Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2022-08-30
14:15:38 gibi stephenfin: sean-k-mooney made review progress in the PCI series so if you have free cyles then we could merge some patches there. I also pushed a FUP on top with doc fixes based on your comments
14:16:16 stephenfin gibi: Also on my list
14:16:30 gibi stephenfin: thanks
14:29:32 bauzas I haven't yet had time to look at open reviews, but if people want me to look at some, \o
14:50:51 whoami-rajat dansmith, sorry was away, I'm currently busy with the PTL nomination, after that can address
14:51:08 dansmith whoami-rajat: I'll do it
14:51:16 whoami-rajat dansmith, ack, thanks
14:51:18 dansmith just didn't want to step on toes if you were in the middle already
14:51:40 sean-k-mooney i have a few nits ill be adding shortly
14:51:46 sean-k-mooney reviewing teh sersie now
14:51:55 sean-k-mooney nothing worhth holding it however
14:53:56 whoami-rajat ack, yeah I've been busy with cinder deadlines as well this week
14:54:04 dansmith sean-k-mooney: get them in so I can address
14:56:24 sean-k-mooney the nits on the first patch are up ill review the last two again shortly
14:57:46 sean-k-mooney no issue with the secon patch reviewing last one now
15:01:03 dansmith oh I thought you mean the last one
15:01:19 dansmith if they're just nits, I think we can/should do a FUP for the nits on the lower ones
15:01:29 dansmith I was going to revise the top one because it won't impact much
15:01:47 sean-k-mooney ack
15:02:12 sean-k-mooney my main grip is _detach_device being used asd the name of the function that detaches the root volume
15:02:19 sean-k-mooney since its really really ambigious
15:02:26 sean-k-mooney but its private/internal
15:02:29 sean-k-mooney and we can change that later
15:02:45 sean-k-mooney its not going ot affect the rpc or anything outside the compute manager and the tests for it
15:03:12 sean-k-mooney there were a couple of typos in the commens too but again nothing requireing a respin
15:04:45 sean-k-mooney dansmith: do you hae a way forward for https://review.opendev.org/c/openstack/nova/+/830883/27/nova/tests/functional/test_boot_from_volume.py
15:05:00 sean-k-mooney i can try and run that locally shortly and take a look
15:05:02 dansmith sean-k-mooney: I fixed it
15:05:06 sean-k-mooney ack
15:05:09 dansmith in the patchset I pushed after that
15:05:19 dansmith hence the zuul +1
15:05:34 sean-k-mooney oh thats an old comment
15:05:38 dansmith yeah
15:06:04 sean-k-mooney ok marked it done
15:07:10 sean-k-mooney ok done
15:08:51 dansmith ack
15:09:01 opendevreview Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883
15:09:37 sean-k-mooney dansmith: i +2'd the userdata patch but left the +w to you or melwitt by the way since i respun it
15:09:51 dansmith sean-k-mooney: I haven't reviewed that one really yet
15:10:06 dansmith but I think melwitt did, so hopefully she can hit it
15:11:33 sean-k-mooney she had one pending comment from PS7 https://review.opendev.org/c/openstack/nova/+/816157/15/nova/objects/instance.py but i also dont think she considered it a blocker
15:12:51 sean-k-mooney its a property on the ovo so technially we could change that later without causing any object change the one thing we cant change is the key in the system metadata table with our a data migration
15:13:06 sean-k-mooney so im hoping she is ok with is as is
15:23:10 jhartkopf sean-k-mooney, gibi: Hey, just saw that the user data change already received two +2s from you. I have some adjustments (in response to nits) ready locally. Should I wait for a follow up with this?
15:23:29 sean-k-mooney yes
15:23:41 sean-k-mooney please adress them in a followup patch
15:24:21 gibi jhartkopf: o/ . as sean-k-mooney suggests lets address those nits in a separate patch. We intend to land the user_data patch as is today to allow the next feature behind it to land too
15:24:41 opendevreview Merged openstack/nova master: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/853379
15:26:56 opendevreview Balazs Gibizer proposed openstack/nova-specs master: Update the PCI in placement spec https://review.opendev.org/c/openstack/nova-specs/+/855218
15:27:20 gibi sean-k-mooney, stephenfin: updated the PCI spec to reflect the implementation reality ^^
15:27:49 sean-k-mooney ack
15:28:18 jhartkopf sean-k-mooney, gibi: Alright, just wanted to make sure :)
15:32:31 bauzas gibi: thanks (or someone else) for having created https://etherpad.opendev.org/p/nova-zed-blueprint-status this helps my work
15:33:40 gibi bauzas: I think I noted somewhere that you owe me a beer for that :)
15:34:04 bauzas gibi: if we were traveling to a PTG, I could have made it
15:34:15 gibi yeah I know :)
15:34:20 bauzas but, I can only give you a e-beer
15:34:49 gibi bauzas: we can take that beer in Vancouver then
15:35:14 bauzas we need to progress then on sustainability efforts as I would like to present those :)
15:35:22 bauzas need then*
15:46:04 bauzas reminder : nova meeting in 15 mins here
15:52:22 gibi stephenfin, sean-k-mooney: I prepared a respin of the PCI series to fix two issues sean-k-mooney spotted in the Create RequestGroups from InstancePCIRequests and in Support resource_class and traits in PCI alias. Should I push it now or hold on while you are reviewing?
15:53:17 dansmith anybody seen this yet? https://zuul.opendev.org/t/openstack/build/5088531548e2497f8a59ddd8c8b89de8
15:53:23 dansmith requirements blocking job setup
15:54:15 dansmith I don't see a lot of other fails, so either it's unstable or just happened
15:54:58 dansmith but found it in a manilla job 7 mins ago
15:57:49 sean-k-mooney no neither have had a releas erecnetly and both are 3.7+
15:58:06 gibi yeah I haven't see such failure yet
15:58:41 sean-k-mooney i wonder is it stable
15:59:24 sean-k-mooney ususlaly you see a failure and a rety of the same package multiple times when this happens
15:59:42 sean-k-mooney im not seeign that
16:00:15 opendevmeet The meeting name has been set to 'nova'
16:00:15 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:15 bauzas #startmeeting nova
16:00:15 opendevmeet Meeting started Tue Aug 30 16:00:15 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:23 bauzas hey folks, happy to see all you again
16:00:31 gmann o/
16:00:55 elodilles o/
16:01:51 bauzas ok, let's start, people will arrive
16:02:16 bauzas #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
16:02:25 bauzas #topic Bugs (stuck/critical)
16:02:34 bauzas #info One Critical bug
16:02:37 bauzas but,
16:02:45 bauzas #link https://bugs.launchpad.net/nova/+bug/1986545 Just sent to the gate
16:03:01 bauzas so the fix should be merged soon
16:03:06 bauzas thanks melwitt for having worked on it
16:03:21 bauzas #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 7 new untriaged bugs (-1 since the last meeting)
16:03:27 bauzas #link https://storyboard.openstack.org/#!/project/openstack/placement 26 open stories (-1 since the last meeting) in Storyboard for Placement
16:03:33 bauzas #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster
16:03:35 gibi o/
16:03:53 bauzas Uggla wasn't able to attend this meeting, but...
16:04:04 bauzas #info bug baton is being passed to Uggla
16:04:32 bauzas mwahaha even
16:04:48 gibi :)
16:05:17 bauzas thanks all who looked at bugs while I was off, the progress is impressive
16:05:50 bauzas any bug to raise before we move on ?
16:06:32 bauzas guess not
16:06:42 bauzas #topic Gate status
16:06:45 bauzas #topic Gate status
16:06:51 bauzas #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs

Earlier   Later