Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2022-08-30
11:19:40 opendevreview Balazs Gibizer proposed openstack/nova master: Doc follow up for PCI in placement https://review.opendev.org/c/openstack/nova/+/855186
11:19:40 opendevreview Balazs Gibizer proposed openstack/nova master: Follow up for the PCI in placement series https://review.opendev.org/c/openstack/nova/+/855185
12:23:56 bauzas reminder : nova meeting will happen today at 1600UTC here in this channel
12:24:10 bauzas gibi: sean-k-mooney: I can run the meeting back
12:29:25 gibi bauzas: you can have the meeting back :)
12:29:56 bauzas not sure if I should say \o/ or /.o\
12:30:40 Uggla Hi bauzas, I hope you enjoy your vacation.
12:30:47 bauzas I did
12:31:10 Uggla Just to let you know that unfortunately I could not attend today's meeting. :(
12:31:17 bauzas np
12:31:23 kashyap Uggla: s/enjoy/enjoyed/? I thought he's going to have another vacation :-P
12:31:36 kashyap (Which is also fine, if he's up for it.)
12:31:49 Uggla *enjoyed thx kashyap
12:31:53 bauzas haha, can't wait for someone saying I'm on "perpetual PTO"
12:32:35 bauzas you know what was fun ? I was in a camp site for two weeks
12:32:45 bauzas first week, the site was telling in French
12:33:01 bauzas eventually, last week, we got like 70% of people that were German
12:33:30 bauzas as it was the last children vacations week in France, while some German lander still have 3 weeks
12:33:48 bauzas so, the campsite folks were telling in German
12:34:04 bauzas *in Corsica
12:34:43 Uggla I hope you had no pb with the storm in Corsica ?
12:36:25 bauzas none
12:36:37 bauzas I was on the East
12:38:06 bauzas when the storm arrived around Ajaccio, we just got a small storm, like just winding and a few raining for 10 mins
12:39:27 bauzas but the campsite asked us on the afternoon to make sure we could quickly move to a gym if needed on the next evening as a new storm was arriving
12:39:34 bauzas eventually, we didn't move
12:45:25 Uggla bauzas, good to know. I saw some impressive storm videos and thought about you hoping you were safe.
12:45:41 bauzas thanks
12:45:50 bauzas indeed this was impressive
12:45:58 Uggla clearly
12:46:15 bauzas I visited some small village in the mountains on the day the storm arrived
12:46:27 bauzas and yeah, they got problems with just the wind
12:46:31 bauzas 200km/h
12:46:45 bauzas fortunately, the mountain protected us
12:54:44 kashyap Yikes!
13:38:53 ricolin sean-k-mooney gibi stephenfin hey, can you give another review on https://review.opendev.org/c/openstack/nova/+/830646/ thanks
13:40:55 sean-k-mooney sure have you started reworking https://review.opendev.org/c/openstack/nova/+/844507/
13:41:04 sean-k-mooney we likely will want ot merge both togehter
13:41:41 sean-k-mooney they proably shoudl be in the other order too
13:55:18 stephenfin ricolin: sure
14:05:12 dansmith whoami-rajat: are you working on gibi's comments? if not, I'll do it
14:09:48 ricolin sean-k-mooney: yes, see if I can push something out today
14:15:38 gibi stephenfin: sean-k-mooney made review progress in the PCI series so if you have free cyles then we could merge some patches there. I also pushed a FUP on top with doc fixes based on your comments
14:16:16 stephenfin gibi: Also on my list
14:16:30 gibi stephenfin: thanks
14:29:32 bauzas I haven't yet had time to look at open reviews, but if people want me to look at some, \o
14:50:51 whoami-rajat dansmith, sorry was away, I'm currently busy with the PTL nomination, after that can address
14:51:08 dansmith whoami-rajat: I'll do it
14:51:16 whoami-rajat dansmith, ack, thanks
14:51:18 dansmith just didn't want to step on toes if you were in the middle already
14:51:40 sean-k-mooney i have a few nits ill be adding shortly
14:51:46 sean-k-mooney reviewing teh sersie now
14:51:55 sean-k-mooney nothing worhth holding it however
14:53:56 whoami-rajat ack, yeah I've been busy with cinder deadlines as well this week
14:54:04 dansmith sean-k-mooney: get them in so I can address
14:56:24 sean-k-mooney the nits on the first patch are up ill review the last two again shortly
14:57:46 sean-k-mooney no issue with the secon patch reviewing last one now
15:01:03 dansmith oh I thought you mean the last one
15:01:19 dansmith if they're just nits, I think we can/should do a FUP for the nits on the lower ones
15:01:29 dansmith I was going to revise the top one because it won't impact much
15:01:47 sean-k-mooney ack
15:02:12 sean-k-mooney my main grip is _detach_device being used asd the name of the function that detaches the root volume
15:02:19 sean-k-mooney since its really really ambigious
15:02:26 sean-k-mooney but its private/internal
15:02:29 sean-k-mooney and we can change that later
15:02:45 sean-k-mooney its not going ot affect the rpc or anything outside the compute manager and the tests for it
15:03:12 sean-k-mooney there were a couple of typos in the commens too but again nothing requireing a respin
15:04:45 sean-k-mooney dansmith: do you hae a way forward for https://review.opendev.org/c/openstack/nova/+/830883/27/nova/tests/functional/test_boot_from_volume.py
15:05:00 sean-k-mooney i can try and run that locally shortly and take a look
15:05:02 dansmith sean-k-mooney: I fixed it
15:05:06 sean-k-mooney ack
15:05:09 dansmith in the patchset I pushed after that
15:05:19 dansmith hence the zuul +1
15:05:34 sean-k-mooney oh thats an old comment
15:05:38 dansmith yeah
15:06:04 sean-k-mooney ok marked it done
15:07:10 sean-k-mooney ok done
15:08:51 dansmith ack
15:09:01 opendevreview Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883
15:09:37 sean-k-mooney dansmith: i +2'd the userdata patch but left the +w to you or melwitt by the way since i respun it
15:09:51 dansmith sean-k-mooney: I haven't reviewed that one really yet
15:10:06 dansmith but I think melwitt did, so hopefully she can hit it
15:11:33 sean-k-mooney she had one pending comment from PS7 https://review.opendev.org/c/openstack/nova/+/816157/15/nova/objects/instance.py but i also dont think she considered it a blocker
15:12:51 sean-k-mooney its a property on the ovo so technially we could change that later without causing any object change the one thing we cant change is the key in the system metadata table with our a data migration
15:13:06 sean-k-mooney so im hoping she is ok with is as is
15:23:10 jhartkopf sean-k-mooney, gibi: Hey, just saw that the user data change already received two +2s from you. I have some adjustments (in response to nits) ready locally. Should I wait for a follow up with this?
15:23:29 sean-k-mooney yes
15:23:41 sean-k-mooney please adress them in a followup patch
15:24:21 gibi jhartkopf: o/ . as sean-k-mooney suggests lets address those nits in a separate patch. We intend to land the user_data patch as is today to allow the next feature behind it to land too
15:24:41 opendevreview Merged openstack/nova master: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/853379
15:26:56 opendevreview Balazs Gibizer proposed openstack/nova-specs master: Update the PCI in placement spec https://review.opendev.org/c/openstack/nova-specs/+/855218
15:27:20 gibi sean-k-mooney, stephenfin: updated the PCI spec to reflect the implementation reality ^^
15:27:49 sean-k-mooney ack
15:28:18 jhartkopf sean-k-mooney, gibi: Alright, just wanted to make sure :)
15:32:31 bauzas gibi: thanks (or someone else) for having created https://etherpad.opendev.org/p/nova-zed-blueprint-status this helps my work
15:33:40 gibi bauzas: I think I noted somewhere that you owe me a beer for that :)
15:34:04 bauzas gibi: if we were traveling to a PTG, I could have made it
15:34:15 gibi yeah I know :)
15:34:20 bauzas but, I can only give you a e-beer
15:34:49 gibi bauzas: we can take that beer in Vancouver then

Earlier   Later