| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-26 | |||
| 19:12:20 | opendevreview | Dan Smith proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 19:12:20 | opendevreview | Dan Smith proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 19:12:21 | opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 19:12:35 | whoami-rajat | yeah 2.94 after 2.92 will break something surely | |
| 19:12:43 | ozzzo_work | Is this the right channel to ask about nova filters? | |
| 19:13:01 | dansmith | ozzzo_work: this is really for nova development not help, and it's friday afternoon | |
| 19:13:15 | dansmith | whoami-rajat: so in the main patch I broke apart that error handler for the issue we noted there, | |
| 19:13:30 | ozzzo_work | ok I'll try emailing the list | |
| 19:13:31 | dansmith | whoami-rajat: and in the last one I made the test less mock-heavy and added some negative cases | |
| 19:13:37 | dansmith | ozzzo_work: that'd be better | |
| 19:15:10 | whoami-rajat | dansmith, great, i was just thinking about how to break those exception blocks, thanks | |
| 19:16:33 | dansmith | whoami-rajat: I don't think we need to be fully covered in the functional tests, but I included several error paths, so I hope that's good enough, assuming I didn't break any unit tests.. more unit tests for covering all the potential exit paths is still good of course | |
| 19:17:40 | whoami-rajat | ack, will take a look | |
| 19:18:58 | dansmith | all the brought-forward comments are referring to the wrong lines in the latest PS instead of being collected up at the top, that's very weird | |
| 19:19:16 | dansmith | IMHO you can resolve those and let people re-comment if they want | |
| 19:19:53 | whoami-rajat | yeah that happens, I'm on the same patchset when the comments were left and it looks fine like that | |
| 19:20:13 | whoami-rajat | left view: old PS with comments, right view: new PS | |
| 19:22:19 | dansmith | right, but if you have base on the left and current on the right, it is supposed to show the comments on unchanged lines, or at the top if they've been changed | |
| 19:22:22 | dansmith | and this is showing them on the wrong lines | |
| 19:23:16 | dansmith | actually hard refresh seems to have fixed it, | |
| 19:23:27 | dansmith | so maybe just a caching bug or something | |
| 19:23:31 | whoami-rajat | yep, I've also been struggling with that recently | |
| 19:23:35 | whoami-rajat | ah really? | |
| 19:24:21 | whoami-rajat | yep that fixed it, nice | |
| 19:24:29 | dansmith | haven't seen that before | |
| 19:27:28 | sean-k-mooney | ozzzo_work: quick glance not sure | |
| 19:29:36 | sean-k-mooney | dansmith: ya i often have to go to the patset the comment was left on to make any use out of that feature | |
| 19:30:51 | sean-k-mooney | ok im starting to get hungery so im going to finish there for today. | |
| 19:31:04 | sean-k-mooney | i will keep an eye on those patches | |
| 19:31:33 | sean-k-mooney | i assume at this point however that it will be monday for the base patch to be ready | |
| 19:54:14 | whoami-rajat | sean-k-mooney, if you're still around, I've a question | |
| 19:54:38 | whoami-rajat | sean-k-mooney, regarding your comment here https://review.opendev.org/c/openstack/nova/+/820368/comments/711f86cd_9c3731a4 | |
| 19:55:05 | whoami-rajat | sean-k-mooney, if we want to support it for the ironic use case, we would have to provide a generic driver implementation and also implemented it for the libvirt driver right? | |
| 19:55:22 | dansmith | whoami-rajat: ironic is the only one that provides its own rebuild implementation, AFAIK | |
| 19:55:39 | whoami-rajat | looking | |
| 19:55:43 | dansmith | whoami-rajat: I think what you need to do is modify ironic's rebuild to check for the flag and fail if it's requested (for now) | |
| 19:55:55 | dansmith | and obviously pass the flag to it as sean mentions | |
| 19:56:09 | dansmith | whoami-rajat: getting it to work with ironic will require work on the ironic side, which obviously isn't going to happen | |
| 19:56:26 | dansmith | ironic is already "weird" about rebuilds, so I think we just have to document that and hope we can get it resolved later | |
| 19:56:27 | whoami-rajat | dansmith, yeah, that's what my concern was, if we just need to fail in that case then it's good | |
| 19:56:42 | dansmith | it's not good, but..yeah :) | |
| 19:56:55 | whoami-rajat | cool, that clears things | |
| 19:57:17 | whoami-rajat | was kind of worried there | |
| 20:59:13 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 20:59:13 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 20:59:14 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 21:16:03 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 21:16:04 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 21:17:00 | ricolin | sean-k-mooney: thanks, just update patches, will try to work on traits asap | |
| #openstack-nova - 2022-08-27 | |||
| 16:44:20 | opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | |
| 16:46:51 | opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | |
| 17:43:18 | frickler | latest prettytable is breaking a nova unit test, if anyone wants to have a look https://zuul.opendev.org/t/openstack/build/2e4535d6aa2d4fd987ddfd0d0bc296d1 | |
| #openstack-nova - 2022-08-28 | |||
| 14:37:10 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 16:17:59 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 17:29:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 17:29:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Create RequestGroups from InstancePCIRequests https://review.opendev.org/c/openstack/nova/+/852771 | |
| 17:29:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Generate request_id for Flavor based InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/853835 | |
| 17:29:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Split PCI pools per PF https://review.opendev.org/c/openstack/nova/+/854440 | |
| 17:29:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | |
| 17:29:35 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119 | |
| 17:29:35 | opendevreview | Balazs Gibizer proposed openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | |
| 17:29:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | |
| 17:29:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | |
| 17:29:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | |
| 17:29:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | |
| 17:29:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | |
| 17:29:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | |
| 17:29:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | |
| 17:29:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | |
| 17:29:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | |
| 17:29:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | |
| 17:29:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Enable pci in placement feature https://review.opendev.org/c/openstack/nova/+/854925 | |
| 17:32:02 | gibi | if somebody is up early on Monday, the PCI series now ready up until https://review.opendev.org/c/openstack/nova/+/854119 , the patches above that has missing unit test coverage and doc, but the whole feature is covered in functional tests already | |
| 18:52:31 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 20:34:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Split PCI pools per PF https://review.opendev.org/c/openstack/nova/+/854440 | |
| 20:34:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | |
| 20:34:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119 | |
| 20:34:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | |
| 20:34:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | |
| 20:34:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | |
| 20:34:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | |
| 20:34:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | |
| 20:34:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | |
| 20:34:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | |
| 20:34:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | |
| 20:34:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | |
| 20:34:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | |
| 20:34:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Enable pci in placement feature https://review.opendev.org/c/openstack/nova/+/854925 | |
| 20:34:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | |
| 20:34:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out base class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | |
| 21:15:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119 | |
| 21:15:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out base class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | |
| 21:15:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | |
| 21:15:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | |
| 21:15:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | |
| 21:15:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | |
| 21:15:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | |
| 21:15:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | |
| 21:15:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | |
| 21:15:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | |