| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-11 | |||
| 04:24:53 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | |
| 08:34:40 | opendevreview | Bence Romsics proposed openstack/nova master: Add limitation to docs about bug 1983570 https://review.opendev.org/c/openstack/nova/+/852168 | |
| 11:20:33 | opendevreview | Merged openstack/nova stable/wallaby: Adapt to SQLAlchemy 1.4 https://review.opendev.org/c/openstack/nova/+/852099 | |
| 17:05:44 | dansmith | melwitt: do we really have no test class for ConductorTaskManager ? | |
| 17:05:58 | dansmith | I see various mocks of it, but... | |
| 17:07:16 | dansmith | sorry, conductor.ComputeTaskManager I mean | |
| 17:16:50 | melwitt | uh dunno. I will look | |
| 17:19:06 | melwitt | this says it's for ComputeTaskManager https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L2238 | |
| 17:20:06 | melwitt | dansmith: ^ | |
| 17:23:07 | dansmith | ah, yeah, okay, I found that in the greps but it seemed like that was more for tasks/* but yeah I guess maybe that's it | |
| 17:35:21 | opendevreview | Dan Smith proposed openstack/nova master: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/852900 | |
| 17:35:22 | opendevreview | Dan Smith proposed openstack/nova master: Avoid startup failure for keystone failures https://review.opendev.org/c/openstack/nova/+/852901 | |
| 17:35:33 | dansmith | melwitt: gibi_pto looks to be gone already, but I think this is a reasonable compromise ^ | |
| 17:40:45 | melwitt | ack, will look | |
| 17:46:42 | dansmith | I haven't run functional tests on that, but it works for me in my devstack if I stop keystone and restart conductor | |
| 18:12:20 | melwitt | ack | |
| 18:40:17 | opendevreview | Dan Smith proposed openstack/nova master: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/852900 | |
| 18:40:18 | opendevreview | Dan Smith proposed openstack/nova master: Avoid n-cond startup abort for keystone failures https://review.opendev.org/c/openstack/nova/+/852901 | |
| 18:49:29 | opendevreview | Dan Smith proposed openstack/nova master: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/852900 | |
| 18:49:30 | opendevreview | Dan Smith proposed openstack/nova master: Avoid n-cond startup abort for keystone failures https://review.opendev.org/c/openstack/nova/+/852901 | |
| 18:49:35 | dansmith | melwitt: that second set is for you ^ :) | |
| 18:50:23 | dansmith | good call on the other exceptions, and the unified handling helps make sure we log the right exception (not responding) for those too | |
| 18:55:57 | dansmith | log the right *message* I mean | |
| 18:56:59 | melwitt | :) | |
| #openstack-nova - 2022-08-12 | |||
| 11:22:47 | opendevreview | Takashi Natsume proposed openstack/nova master: Fix a deprecation warning about distutils https://review.opendev.org/c/openstack/nova/+/852947 | |
| 11:55:49 | opendevreview | Takashi Natsume proposed openstack/python-novaclient master: Remove unnecessary testing code https://review.opendev.org/c/openstack/python-novaclient/+/852949 | |
| 12:07:39 | opendevreview | Takashi Natsume proposed openstack/nova master: Fix a deprecation warning about distutils https://review.opendev.org/c/openstack/nova/+/852947 | |
| 13:19:50 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 20:08:33 | ricolin | sean-k-mooney[m]: I though it's okay to set property in flavor and override property in image? So if they're both set, we can consider flavor property is there to override image property. Or they not suppose to set at the same time? | |
| 20:11:09 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 20:11:09 | opendevreview | Rico Lin proposed openstack/nova master: Add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | |
| 20:11:10 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| #openstack-nova - 2022-08-13 | |||
| 14:39:21 | opendevreview | Takashi Natsume proposed openstack/nova master: Add missing descriptions in HACKING.rst https://review.opendev.org/c/openstack/nova/+/853054 | |
| #openstack-nova - 2022-08-14 | |||
| 20:33:16 | opendevreview | Rico Lin proposed openstack/nova master: Add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | |
| 20:33:17 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 20:33:17 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| #openstack-nova - 2022-08-15 | |||
| 04:11:47 | opendevreview | Ke Niu proposed openstack/nova master: remove unicode prefix from code https://review.opendev.org/c/openstack/nova/+/853112 | |
| 04:12:59 | opendevreview | Ke Niu proposed openstack/nova master: remove unicode prefix from code https://review.opendev.org/c/openstack/nova/+/853112 | |
| 04:14:39 | opendevreview | Ke Niu proposed openstack/nova master: Cleanup py27 support https://review.opendev.org/c/openstack/nova/+/853113 | |
| 13:57:41 | zigo | https://bugs.debian.org/1017217 | |
| 13:57:41 | zigo | I'm getting failed unit tests in Nova (which is RC bug in Debian since that's failed to build...): | |
| 13:57:44 | zigo | Can anyone help? | |
| 14:00:59 | zigo | ricolin: I'm not sure, when reading the specs, but what is vIOMMU for? (note: I know what a PMMU is...) | |
| 14:35:54 | artom | zigo, only thing I can think of is the recently merged double-mocking patch | |
| 14:36:29 | zigo | artom: That's Stable / Yoga that I'm talking about, does this match? | |
| 14:36:39 | zigo | Was it backported? | |
| 14:37:06 | zigo | The thing is, it built fine 10 days ago in Debian Unstable. I'm currently trying to use snapshot.debian.org to see what package changed since ... | |
| 14:38:28 | artom | zigo, hrmm, no, it's https://review.opendev.org/c/openstack/nova/+/852464 and https://review.opendev.org/c/openstack/nova/+/851445 that I'm thinking of | |
| 14:39:28 | zigo | None of these seem to have been backported to Yoga, so it's unlikely the issue here. | |
| 14:39:59 | zigo | In a minute, I'll see what package has changed... | |
| 14:44:07 | artom | zigo, super bizarre... something is causing the unit test to apprently redirect | |
| 14:45:22 | zigo | Yeah, looks scary too ... | |
| 14:46:07 | artom | Which makes no sense, because it's a unit test, literally nothing is running except Python code | |
| 14:56:04 | artom | zigo, so the redirect appears to be coming from websockify itself... | |
| 14:56:29 | artom | I guess I'd look into its changelog for the version you're packaging? | |
| 14:56:55 | zigo | artom: I haven't uploaded websockify since 2021 ... | |
| 14:57:13 | zigo | I'm currently trying to use snapshot.debian.org to see what package has changed. | |
| 14:58:27 | zigo | Result: python3 python3-all python3-attr python3-distutils python3-keyring python3-lib2to3 python3-minimal python3-psycopg2 python3-typing-extensions python3.10 python3.10-minimal | |
| 14:58:39 | zigo | I'll try them one by one... | |
| 15:07:33 | zigo | Gosh ... upgrding the Python 3.10 interpreter triggered the bug !!! :( | |
| 15:08:24 | zigo | python3.10 (3.10.6-1) over (3.10.5-1) | |
| 15:12:06 | artom | o_O | |
| 15:15:50 | zigo | Maybe related to this? https://github.com/python/cpython/issues/87389 | |
| 15:18:08 | zigo | self.path = '/' + self.path.lstrip('/') # Reduce to a single / | |
| 15:18:08 | zigo | if self.path.startswith('//'): | |
| 15:18:08 | zigo | The patch has: | |
| 15:18:29 | zigo | So, Python itself would strip the added /, rendering the unit test and protection useless ... | |
| 15:18:42 | artom | Or rather, trying with py39 for some reason | |
| 15:19:33 | artom | zigo, yep, fails as well | |
| 15:19:44 | artom | OK, you've just found a gate failure :) | |
| 15:19:52 | zigo | :D | |
| 15:20:14 | zigo | I'm trying to add the patch to the 3.10.5 standard library, to see if I reproduce it ... | |
| 15:20:21 | zigo | I'll then file a bug against nova. | |
| 15:21:11 | artom | Well... I say gate failure, and yet: https://zuul.opendev.org/t/openstack/build/e2ae266c798c411784f449f6f5e3d35a | |
| 15:21:19 | artom | I guess we're not running a new enough py10? | |
| 15:21:53 | artom | Yeah, 10.3.4 | |
| 15:22:01 | artom | 3.10.4, sorry | |
| 15:22:08 | artom | It's still coming though | |
| 15:22:25 | artom | And I hit it locally because Fedora does have the affected Python version | |
| 15:24:17 | zigo | Ok, now I'm sure about what I'm saying ! :) | |
| 15:25:02 | zigo | Running Python 3.10.5 interpreter, if I ran the unit test without any additional change, it passes. Now, if I just add the 2 lines of the hunk here: https://github.com/python/cpython/commit/defaa2b19a9a01c79c1d5641a8aa179bb10ead3f (which is part of Python 3.10.6), then I get the failure ... | |
| 15:25:44 | zigo | What's nice, is that I now know there's no security issue... it's just the python interpreter standard lib having additional protections. | |
| 15:32:28 | zigo | https://bugs.launchpad.net/nova/+bug/1986545 | |
| #openstack-nova - 2022-08-16 | |||
| 03:01:50 | opendevreview | liuhuajie proposed openstack/nova master: Cleanup py27 support https://review.opendev.org/c/openstack/nova/+/853216 | |
| 04:21:27 | opendevreview | Brett Milford proposed openstack/nova master: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/852002 | |
| 04:57:32 | opendevreview | Amit Uniyal proposed openstack/nova stable/xena: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/853218 | |
| 04:57:33 | opendevreview | Amit Uniyal proposed openstack/nova stable/xena: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/853219 | |
| 07:28:00 | gibi | o/ | |
| 08:15:59 | opendevreview | huanhongda proposed openstack/nova master: WIP:Drop unreliable host_aggregate_map https://review.opendev.org/c/openstack/nova/+/696851 | |
| 08:25:39 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 08:26:11 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 08:58:36 | opendevreview | melanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | |
| 08:58:36 | opendevreview | melanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | |
| 08:58:37 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | |
| 08:58:37 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | |
| 08:58:38 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | |
| 08:58:38 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | |
| 08:58:39 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 08:58:39 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 08:58:40 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted https://review.opendev.org/c/openstack/nova/+/826756 | |