| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-08 | |||
| 11:37:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 11:37:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations https://review.opendev.org/c/openstack/nova/+/852397 | |
| 11:41:16 | opendevreview | Merged openstack/nova master: Adds img_config_drive in nova users docs https://review.opendev.org/c/openstack/nova/+/852265 | |
| 13:31:05 | gibi | stephenfin: we have another set of double mocking in tree. before https://review.opendev.org/c/openstack/nova/+/850346 we could mock a function twice once via unittest.mock and once via fixtures.MockPatch. The latter internally used the mock lib. But that patch mock lib was removed from test-requirements so it become unimportable and therefore fixtures.MockPatch switched to unittest.mock | |
| 13:31:11 | gibi | automatically and exposed a new set of double mocking. | |
| 13:33:12 | gibi | I will have to start switching some of our generic default mocking to fixture.MonkeyPatch to still allow both posion / default behavior and the test specific mocking to coexits without blowing up a lot of test casesa | |
| 15:16:26 | stephenfin | gibi: Ah, I missed the py310 failure there :-( | |
| 15:16:33 | gibi | I missed it too | |
| 15:16:40 | gibi | but fixing it now... | |
| 17:50:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/852464 | |
| 17:51:14 | gibi | stephenfin: ^^ this was sizeable PITA | |
| 17:59:41 | artom | With falafels? | |
| 18:02:39 | gibi | :D | |
| 18:03:00 | gibi | dont mock me :D | |
| 18:04:38 | artom | That's just me sense of hummus | |
| 19:18:44 | opendevreview | Elod Illes proposed openstack/nova stable/ussuri: [stable-only] Allow Train compute hosts to register with Ussuri https://review.opendev.org/c/openstack/nova/+/851732 | |
| 21:39:13 | opendevreview | Tyler Stachecki proposed openstack/nova master: libvirt: Retain MTU during live-migration https://review.opendev.org/c/openstack/nova/+/852365 | |
| #openstack-nova - 2022-08-09 | |||
| 03:07:00 | opendevreview | Tyler Stachecki proposed openstack/nova master: libvirt: Check VIF MTU matches network MTU https://review.opendev.org/c/openstack/nova/+/852367 | |
| 03:26:11 | opendevreview | Tyler Stachecki proposed openstack/nova master: libvirt: Check if VIF MTU matches network MTU https://review.opendev.org/c/openstack/nova/+/852367 | |
| 04:01:56 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | |
| 07:33:21 | gibi | good morning | |
| 08:43:47 | gibi | folks I've created the Zed bp tracking etherpad https://etherpad.opendev.org/p/nova-zed-blueprint-status please check it out, sign up for review, update status, note if I missed someting. We will look at it again on the todays meeting | |
| 08:44:08 | gibi | bauzas: you own me a beer for that ^^ ;) | |
| 08:44:51 | gibi | elodilles: I've updated the today's agenda on the wiki, feel free to add your stuff there | |
| 09:05:11 | elodilles | gibi: ack, thanks! | |
| 09:19:40 | stephenfin | gibi: Looking | |
| 09:19:42 | stephenfin | artom: Boo | |
| 09:46:45 | noonedeadpunk | hey there! Does anybody know any reason why https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/detach-boot-volume.html has not been implemented? As from what I see the only thing left is kind of changing condition here https://opendev.org/openstack/nova/blame/branch/master/nova/api/openstack/compute/volumes.py#L560 | |
| 09:47:13 | noonedeadpunk | by adding `instance.vm_state not in (vm_states.SHELVED, vm_states.SHELVED_OFFLOADED)` ? | |
| 09:48:33 | noonedeadpunk | As detaching from shelved instance should never hurt from my understanding? | |
| 10:32:39 | opendevreview | Merged openstack/nova stable/ussuri: [stable-only] Allow Train compute hosts to register with Ussuri https://review.opendev.org/c/openstack/nova/+/851732 | |
| 10:33:40 | sean-k-mooney[m] | i think it kind of stalled out because the person working on it stopped | |
| 10:34:01 | sean-k-mooney[m] | im not sure if there was any technical reason that blocked it | |
| 10:34:54 | sean-k-mooney[m] | noonedeadpunk: dansmith might remember more or gibi i think they might have been invovled with that at some point | |
| 10:35:07 | opendevreview | chenwei proposed openstack/nova master: Remove unicode literal from code https://review.opendev.org/c/openstack/nova/+/852538 | |
| 10:36:24 | sean-k-mooney[m] | ^ is such a waste fo ci and review bandwidth | |
| 10:36:46 | sean-k-mooney[m] | also there is someone else arready changing that | |
| 10:38:46 | noonedeadpunk | for some reason I was quite sure it's implemented :( | |
| 10:39:29 | noonedeadpunk | the only tricky thing I see on how to re-attach volume to be same device name and how to disallow unshelve when root device is detached | |
| 10:39:32 | sean-k-mooney[m] | one thing that would have to be done in addtion to the detach is likely clearing the delete on terminate info form teh volume too | |
| 10:39:57 | sean-k-mooney[m] | well the name is a hint | |
| 10:40:01 | sean-k-mooney[m] | so you cant rely on that | |
| 10:40:22 | sean-k-mooney[m] | what you really need to be able to do is atach it and set the boot order on the volume | |
| 10:40:28 | sean-k-mooney[m] | so that it will have precidence | |
| 10:40:58 | noonedeadpunk | so basically preserve the order somehow | |
| 10:41:06 | sean-k-mooney[m] | not really | |
| 10:41:22 | sean-k-mooney[m] | the main usecause for detach was you detach the volmue and then delete the vm | |
| 10:41:27 | sean-k-mooney[m] | and use the volume for a differnt vm | |
| 10:41:53 | sean-k-mooney[m] | but if we wanted ot supprot reattaching it we would need a way to specify the boot order on attach as part of the bdms | |
| 10:42:12 | noonedeadpunk | well that doesn't make much sense then? As for me main usecase would be to workaround not working `openstack server recover` for bfv | |
| 10:42:15 | sean-k-mooney[m] | you can do that when you create a vm but currently you cant update it after the vm is created | |
| 10:42:35 | sean-k-mooney[m] | that is being worked on currently | |
| 10:42:48 | sean-k-mooney[m] | rescue now works | |
| 10:42:54 | sean-k-mooney[m] | and rebuild is in flight | |
| 10:43:29 | noonedeadpunk | as right now if you made a mistake in networking, and was not clever enough to set a password for the user - you need to delete VM, attach volume to another VM, then create third VM that will have same set of ports and volumes in correct order | |
| 10:43:41 | sean-k-mooney[m] | rescuse for volume backed instances is aviable in wallaby maybe before | |
| 10:43:52 | noonedeadpunk | oh, rly? as in Xena rescue is not working | |
| 10:44:18 | sean-k-mooney[m] | rescue shoudl work in xena | |
| 10:45:05 | noonedeadpunk | well, I just got `Instance 19d5f71e-3dde-474f-9802-7e3d2f512f3b cannot be rescued: Cannot rescue a volume-backed instance (HTTP 400)` | |
| 10:45:24 | sean-k-mooney[m] | https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/virt-bfv-instance-rescue.html | |
| 10:45:27 | noonedeadpunk | maybe it's client that does not provide api version... | |
| 10:45:31 | sean-k-mooney[m] | it was implemted in ussuri | |
| 10:45:46 | sean-k-mooney[m] | did you use osc or nova | |
| 10:45:53 | noonedeadpunk | osc ofc | |
| 10:46:28 | sean-k-mooney[m] | i dont think there was a micor version for this | |
| 10:46:33 | noonedeadpunk | shouldn't python-novaclient be deprecated now :p | |
| 10:46:58 | sean-k-mooney[m] | oh there is | |
| 10:47:12 | sean-k-mooney[m] | https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-ussuri-and-victoria | |
| 10:47:13 | sean-k-mooney[m] | 2.87 | |
| 10:47:48 | sean-k-mooney[m] | noonedeadpunk: the shell is the python bindings currently are not | |
| 10:47:51 | noonedeadpunk | ok, let me check on traits then | |
| 10:52:05 | noonedeadpunk | well, there's a typo at very list in trait name in microversion history | |
| 10:53:19 | sean-k-mooney[m] | https://github.com/openstack/os-traits/blob/master/os_traits/compute/__init__.py#L32 | |
| 10:53:51 | sean-k-mooney[m] | ya its RESCUE_BFV not BFV_RESCUE | |
| 10:54:58 | sean-k-mooney[m] | https://github.com/openstack/nova/commit/5b6f44efff5ad721779fd9a7e80d6a5330fad7d4 | |
| 10:55:07 | sean-k-mooney[m] | the code uses the correct value | |
| 10:55:25 | sean-k-mooney[m] | and its correct in the spec | |
| 10:55:29 | sean-k-mooney[m] | just reversed in the docs | |
| 10:55:39 | sean-k-mooney[m] | https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/virt-bfv-instance-rescue.html#proposed-change | |
| 10:56:48 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: [doc] Fix BFV Rescue trait name in microversion https://review.opendev.org/c/openstack/nova/+/852543 | |
| 10:56:51 | noonedeadpunk | Yeah and computes does have this trait | |
| 11:03:37 | gibi | I dont remember much about detach root volume feature but what you discussed above make sense | |
| 11:03:51 | noonedeadpunk | yeah, setting --os-compute-api-version 2.87 works | |
| 11:04:58 | noonedeadpunk | funny/sad thing though is that `python-openstackclient 5.8.0` throws `osc_lib.exceptions.CommandError: versions supported by client: 2.1 - 2.87` | |
| 11:09:17 | noonedeadpunk | oh, well, it didn't work at the end as instance moved to the error state with `Driver Error: internal error: qemu unexpectedly closed the monitor: 2022-08-09T11:04:55.719928Z qemu-system-x86_64: -blockdev {"driver":"rbd","pool":"vms","image":"c76df07c-02b6-4a28-964c-d7'}` | |
| 11:10:01 | gibi | please file a bug report on these issues | |
| 11:10:34 | sean-k-mooney[m] | that sound like a qemu crash | |
| 11:13:06 | opendevreview | Merged openstack/nova stable/yoga: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/852238 | |
| 11:15:55 | noonedeadpunk | ok, so real issue was qemu crash because of `error reading header from c76df07c-02b6-4a28-964c-d703555152b8_disk: No such file or directory` | |
| 11:16:58 | noonedeadpunk | soundsl ike it tried to rescue but clean forgot to create ephemeral first | |
| 11:18:04 | noonedeadpunk | because it called `c76df07c-02b6-4a28-964c-d703555152b8_disk.rescue` :D | |
| 11:19:48 | noonedeadpunk | or well, both was provided. So seems that logic just ignores that it should not have ephemeral | |
| 11:20:50 | sean-k-mooney[m] | maybe ya | |
| 11:21:20 | sean-k-mooney[m] | are you also using rbd as the normal backend? | |
| 11:21:26 | noonedeadpunk | yup | |
| 11:21:46 | sean-k-mooney[m] | perhaps it does not like ceph images_backend adn ceph cinder | |
| 11:21:53 | sean-k-mooney[m] | is it the same ceph cluster | |
| 11:22:21 | noonedeadpunk | but different pools anyway | |
| 11:22:30 | noonedeadpunk | and different image names at very least... | |
| 11:22:30 | sean-k-mooney[m] | ack | |