| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-04 | |||
| 13:00:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 13:01:17 | gibi | this should resolve all the mocking issues from ^^ | |
| 13:06:37 | Uggla | gibi, notify_about_instance_usage is a "legacy call" to notification and should not be used anymore ? | |
| 13:07:19 | gibi | Uggla: if you add a new notification for attaching a share then yes you should not use the legacy one | |
| 13:08:37 | Uggla | ok | |
| 13:11:20 | gibi | we even have a test case that would prevent you to introduce a new legacy notification :) | |
| 13:32:29 | opendevreview | Bence Romsics proposed openstack/nova master: Add limitation to docs about bug 1983570 https://review.opendev.org/c/openstack/nova/+/852168 | |
| 13:45:03 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check for VM snapshot fail while quiesce https://review.opendev.org/c/openstack/nova/+/852171 | |
| 13:56:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extra tests for remote managed dev spec https://review.opendev.org/c/openstack/nova/+/844626 | |
| 13:56:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec https://review.opendev.org/c/openstack/nova/+/844625 | |
| 13:56:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565 | |
| 13:56:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491 | |
| 13:56:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Clean up mapping input to address spec types https://review.opendev.org/c/openstack/nova/+/845765 | |
| 13:56:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress https://review.opendev.org/c/openstack/nova/+/844628 | |
| 13:57:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix type annotation of pci.Whitelist class https://review.opendev.org/c/openstack/nova/+/845780 | |
| 13:57:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unused PF checking from get_function_by_ifname https://review.opendev.org/c/openstack/nova/+/845775 | |
| 13:57:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move __str__ to the PciAddressSpec base class https://review.opendev.org/c/openstack/nova/+/845781 | |
| 14:02:40 | opendevreview | Merged openstack/nova master: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/848886 | |
| 14:02:48 | opendevreview | Merged openstack/nova master: Make test_wait_for_instance_event_* test time independent https://review.opendev.org/c/openstack/nova/+/845922 | |
| 15:31:54 | opendevreview | Dan Smith proposed openstack/nova master: Keep legacy admin behaviour in new RBAC https://review.opendev.org/c/openstack/nova/+/849209 | |
| 15:31:54 | opendevreview | Dan Smith proposed openstack/nova master: Remove system scope from all APIs https://review.opendev.org/c/openstack/nova/+/848021 | |
| 15:31:58 | dansmith | gmann: ^ | |
| 15:32:22 | gmann | #topic Open Reviews | |
| 15:32:29 | gmann | #link https://review.opendev.org/q/projects:openstack/governance+is:open | |
| 15:34:40 | gmann | #endmeeting | |
| 15:34:45 | gmann | ohh :) | |
| 15:35:38 | gmann | sorry, I used wrong channel. it was meant for TC channel | |
| 17:00:39 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 17:41:17 | melwitt | kashyap, stephenfin, sean-k-mooney[m]: I saw that someone else has proposed a patch for the live migration "no ram info was set" issue https://review.opendev.org/c/openstack/nova/+/852002 fyi if you might prefer that approach | |
| 18:36:07 | sean-k-mooney[m] | did i review that before. | |
| 18:36:16 | sean-k-mooney[m] | it sound vaguly familar | |
| 18:37:15 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/842687 is your version right | |
| 18:38:03 | sean-k-mooney[m] | i was previously +2 on your version and stephen currently is so i would prefer ot proceed with yours unless there is a reason not too | |
| 18:40:31 | sean-k-mooney[m] | they are both simialr and your patch has a release note so ill approve that now | |
| 18:44:03 | sean-k-mooney[m] | ok with that im calling it a day o/ catch ye all tomrrow | |
| 19:03:36 | melwitt | sean-k-mooney[m]: cool, thanks. just wanted to show yall in case there was a preference. seeya tomorrow o/ | |
| 19:56:47 | opendevreview | melanie witt proposed openstack/nova master: Workaround qemu query-migrate issue during live migration https://review.opendev.org/c/openstack/nova/+/842687 | |
| #openstack-nova - 2022-08-05 | |||
| 02:15:20 | opendevreview | anguoming proposed openstack/placement master: Remove unicode literal strings https://review.opendev.org/c/openstack/placement/+/845531 | |
| 03:38:42 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | |
| 06:05:19 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/852235 | |
| 07:12:45 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/852235 | |
| 07:12:46 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/852238 | |
| 08:27:49 | opendevreview | Alfredo Moralejo proposed openstack/nova stable/wallaby: Adapt to SQLAlchemy 1.4 https://review.opendev.org/c/openstack/nova/+/852099 | |
| 08:32:27 | kashyap | melwitt: Hi, looking | |
| 11:19:32 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove workaround for SQLAlchemy < 1.4 https://review.opendev.org/c/openstack/nova/+/852255 | |
| 13:05:01 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds img_config_drive in nova users docs https://review.opendev.org/c/openstack/nova/+/852265 | |
| 14:36:10 | opendevreview | Merged openstack/placement master: Remove unicode literal strings https://review.opendev.org/c/openstack/placement/+/845531 | |
| 14:59:37 | opendevreview | Takashi Natsume proposed openstack/python-novaclient master: Fix a fixture for keypairs tests https://review.opendev.org/c/openstack/python-novaclient/+/852274 | |
| 15:33:30 | opendevreview | Takashi Natsume proposed openstack/nova master: doc: Update a PTL guide https://review.opendev.org/c/openstack/nova/+/852275 | |
| 16:29:26 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 16:29:26 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 16:29:27 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 16:29:27 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 16:29:28 | opendevreview | ribaudr proposed openstack/nova master: Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 16:29:28 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 16:29:29 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 16:29:29 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 16:29:30 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 16:29:31 | opendevreview | ribaudr proposed openstack/nova master: Add instance.power_on_error notification https://review.opendev.org/c/openstack/nova/+/852084 | |
| 16:29:31 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 16:29:33 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 16:29:33 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 16:29:35 | opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.93 https://review.opendev.org/c/openstack/nova/+/852088 | |
| 16:29:35 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 16:29:37 | opendevreview | ribaudr proposed openstack/nova master: Add instance.power_off_error notification https://review.opendev.org/c/openstack/nova/+/852278 | |
| 19:12:32 | opendevreview | Merged openstack/python-novaclient master: Fix a fixture for keypairs tests https://review.opendev.org/c/openstack/python-novaclient/+/852274 | |
| #openstack-nova - 2022-08-06 | |||
| 14:47:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/852295 | |
| 15:20:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/852296 | |
| #openstack-nova - 2022-08-08 | |||
| 07:27:48 | gibi | o/ | |
| 08:05:44 | auniyal__ | Hi | |
| 08:05:50 | auniyal__ | please review these - | |
| 08:05:51 | auniyal__ | https://review.opendev.org/q/status:open+AND+owner:auniyal%2540redhat.com | |
| 08:32:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 08:32:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 09:06:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 09:06:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 09:06:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 09:06:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 09:06:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 09:06:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 09:06:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 09:06:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 09:06:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 09:06:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 09:06:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 09:06:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 09:06:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 09:06:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | |
| 09:06:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 09:07:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 09:07:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 09:47:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 09:47:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 11:37:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing simple PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 11:37:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal PCI allocation during resize https://review.opendev.org/c/openstack/nova/+/852396 | |
| 11:37:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 11:37:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations https://review.opendev.org/c/openstack/nova/+/852397 | |
| 11:41:16 | opendevreview | Merged openstack/nova master: Adds img_config_drive in nova users docs https://review.opendev.org/c/openstack/nova/+/852265 | |
| 13:31:05 | gibi | stephenfin: we have another set of double mocking in tree. before https://review.opendev.org/c/openstack/nova/+/850346 we could mock a function twice once via unittest.mock and once via fixtures.MockPatch. The latter internally used the mock lib. But that patch mock lib was removed from test-requirements so it become unimportable and therefore fixtures.MockPatch switched to unittest.mock | |
| 13:31:11 | gibi | automatically and exposed a new set of double mocking. | |