| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-02 | |||
| 16:54:27 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.log.html | |
| 16:54:27 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.txt | |
| 16:54:27 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.html | |
| 16:54:27 | opendevmeet | Meeting ended Tue Aug 2 16:54:27 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:54:27 | bauzas | #endmeeting | |
| 16:54:44 | elodilles | bauzas: have a nice time off o/ | |
| 16:54:48 | gibi | sean-k-mooney[m], bauzas: could you push through https://review.opendev.org/q/topic:os-traits-2.8.0 ? welcome back tonyb! | |
| 16:54:53 | Uggla | bauzas, have a nice PTO. | |
| 16:55:17 | sean-k-mooney[m] | oh right placment | |
| 16:55:18 | sean-k-mooney[m] | ya | |
| 16:55:25 | sean-k-mooney[m] | ill review tose now | |
| 16:55:28 | gibi | thanks | |
| 16:57:17 | sean-k-mooney[m] | do we want to reenabel the test or jsut leave it disabled | |
| 16:57:32 | sean-k-mooney[m] | i +w'd the frist patch | |
| 16:57:50 | sean-k-mooney[m] | so the requreiment patch should be unblocked | |
| 17:00:59 | auniyal | https://review.opendev.org/c/openstack/nova/+/848886 | |
| 17:00:59 | auniyal | https://review.opendev.org/c/openstack/nova/+/851511 | |
| 17:00:59 | auniyal | Please review this- | |
| 17:02:34 | gibi | sean-k-mooney[m]: lets reenable it. I think we need to move that test to python from gabbi | |
| 17:03:10 | sean-k-mooney[m] | ok we can do that as a followup | |
| 17:03:17 | sean-k-mooney[m] | ill approve renableing it so | |
| 17:03:41 | gibi | thanks I will try to do the move tomorrow | |
| 17:04:18 | sean-k-mooney[m] | before you drop | |
| 17:04:20 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/832330 | |
| 17:04:27 | sean-k-mooney[m] | can you add that to your review list | |
| 17:04:39 | sean-k-mooney[m] | stephenfin: ^ i added the doc you asked for by the way | |
| 17:04:52 | stephenfin | gibi: Done (the double mocking patch) | |
| 17:04:52 | sean-k-mooney[m] | ill try and work on the rest of the chain later this week | |
| 17:05:00 | stephenfin | sean-k-mooney[m]: thanks | |
| 17:05:17 | sean-k-mooney[m] | oh the doble mocking patch is up for review | |
| 17:30:33 | bauzas | gibi: I'm about to give it up for the FUP but I found https://launchpad.net/~billy-olsen | |
| 17:42:44 | opendevreview | Stanislav Dmitriev proposed openstack/nova master: Add support for sync writes with block migration https://review.opendev.org/c/openstack/nova/+/851892 | |
| 18:15:20 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: Stop using mdev_name2uuid and fix mdev recreation https://review.opendev.org/c/openstack/nova/+/851924 | |
| 18:15:39 | bauzas | gibi: https://review.opendev.org/c/openstack/nova/+/851924 is the FUP I started to write | |
| 20:07:32 | opendevreview | Artom Lifshitz proposed openstack/nova master: Update libvirt enlightenments for Windows https://review.opendev.org/c/openstack/nova/+/847641 | |
| 20:24:43 | opendevreview | Merged openstack/placement master: disable traits count check to allow os-traits 2.8.0 https://review.opendev.org/c/openstack/placement/+/851792 | |
| 20:24:49 | opendevreview | Merged openstack/nova master: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/849104 | |
| 20:24:56 | opendevreview | Merged openstack/nova master: Remove double mocking https://review.opendev.org/c/openstack/nova/+/851445 | |
| 20:25:04 | opendevreview | Merged openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/c/openstack/nova/+/708768 | |
| 20:48:26 | opendevreview | Artom Lifshitz proposed openstack/nova master: Update libvirt enlightenments for Windows https://review.opendev.org/c/openstack/nova/+/847641 | |
| 21:04:49 | opendevreview | Merged openstack/placement master: Update placement for os-traits 2.8.0 release https://review.opendev.org/c/openstack/placement/+/851793 | |
| 21:33:00 | opendevreview | melanie witt proposed openstack/nova master: block_device_info: Add swap to inline https://review.opendev.org/c/openstack/nova/+/826523 | |
| 21:33:01 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Remove defunct comment https://review.opendev.org/c/openstack/nova/+/826525 | |
| 21:33:01 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Improve creating images INFO log https://review.opendev.org/c/openstack/nova/+/826524 | |
| 21:33:02 | opendevreview | melanie witt proposed openstack/nova master: image_meta: Add ephemeral encryption properties https://review.opendev.org/c/openstack/nova/+/760454 | |
| 21:33:02 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: default by_name image_type to config correctly https://review.opendev.org/c/openstack/nova/+/826526 | |
| 21:33:03 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | |
| 21:33:03 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | |
| 21:33:04 | opendevreview | melanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | |
| 21:33:04 | opendevreview | melanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | |
| 21:33:06 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info https://review.opendev.org/c/openstack/nova/+/826527 | |
| 21:33:06 | opendevreview | melanie witt proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter https://review.opendev.org/c/openstack/nova/+/760456 | |
| 21:33:08 | opendevreview | melanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | |
| 21:33:08 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks https://review.opendev.org/c/openstack/nova/+/826528 | |
| 21:33:10 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | |
| 21:33:10 | opendevreview | melanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | |
| 21:33:12 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | |
| 21:33:12 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | |
| 21:33:14 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 21:33:14 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | |
| 21:33:16 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted https://review.opendev.org/c/openstack/nova/+/826756 | |
| 21:33:16 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 21:33:18 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 22:14:37 | tonyb | gibi: it's wonderful to be back. I see that some of the patches have landed. I'll check on the progress after coffee | |
| #openstack-nova - 2022-08-03 | |||
| 04:02:28 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | |
| 04:53:43 | opendevreview | Amit Uniyal proposed openstack/nova master: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/848886 | |
| 07:22:14 | gibi | good morning | |
| 07:33:09 | Uggla | gibi, o/ | |
| 07:33:17 | opendevreview | Merged openstack/nova master: Updated Suspend definition in server concepts doc https://review.opendev.org/c/openstack/nova/+/851511 | |
| 07:35:04 | gibi | \o/ the unittest.mock series landed \o/ | |
| 07:35:30 | gibi | (hope nobody too mad about the merge conflicts we generated with that :D) | |
| 07:47:11 | gibi | sean-k-mooney[m]: left feedback in the vdpa patch https://review.opendev.org/c/openstack/nova/+/832330 | |
| 08:04:51 | gibi | sean-k-mooney[m]: could you look at https://review.opendev.org/c/openstack/nova/+/851909 it is needed for the sdk 0.100 release here https://review.opendev.org/c/openstack/requirements/+/849986 | |
| 08:12:51 | sean-k-mooney[m] | im just about to have a quick call downstream but ill look at it shortly thanks for reviewing the vdpa patch ill adress your feedback when im adressing stephens | |
| 08:13:42 | sean-k-mooney[m] | if i can get the first patch at least to a point where it can merge today that would be ideall then i can focus on just the ones that wont be backported and thos can hopefully merge seperately as a group | |
| 08:15:52 | gibi | sean-k-mooney[m]: sure. ping me and I will re-review the vdpa patch | |
| 08:16:02 | gibi | if stephenfin is also available the we can land that today | |
| 08:36:29 | opendevreview | Balazs Gibizer proposed openstack/placement master: Func test for os-traits and os-resource-classes lib sync https://review.opendev.org/c/openstack/placement/+/851966 | |
| 08:37:22 | gibi | sean-k-mooney[m], melwitt: as we agreed on the Zed PTG I change the how placement tests for the lib sync so that we don't need to do the test disable/enable dance any more at a lib release ^^ | |
| 08:41:55 | sean-k-mooney[m] | ack almost done with internal call | |
| 08:42:02 | sean-k-mooney[m] | ill look at that next | |
| 08:42:17 | sean-k-mooney[m] | +2 on the safeconnect fix | |
| 08:58:46 | gibi | thanks | |
| 09:04:20 | sean-k-mooney[m] | i was going to ask for the placement change to be done slightly differntly | |
| 09:04:48 | sean-k-mooney[m] | but i realise now that you are loading the tratis/resouce classes directly form the lib and assertign the api returns the same content | |
| 09:04:58 | sean-k-mooney[m] | which should always be in sync | |
| 09:05:25 | sean-k-mooney[m] | i was going to ask that you check that the api respocne contains the lib content and the could was greater or equal | |
| 09:05:45 | sean-k-mooney[m] | but the exact comparison should work as ultimately they have the same data source | |
| 09:05:51 | sean-k-mooney[m] | the lib | |
| 09:09:06 | sean-k-mooney[m] | the only test coverage we currntly loose by not doing the >= check is if we acidentally delete a trait | |
| 09:09:47 | sean-k-mooney[m] | but we are aware that that is not allowed so im not really concerned by that | |
| 09:14:32 | gibi | do you mean accidentally deleting a trait from os-traits? yeah that is something we need to cover elsewhere | |
| 09:15:32 | gibi | today we also not checking for that. Also a >= would not cover that as a os-traits lib version bump migh add 10 new traits and remove 2 but the change is net positive so >= would pass | |
| 09:16:18 | sean-k-mooney[m] | we were checking for it indirectly by asserting the exact number | |
| 09:16:30 | sean-k-mooney[m] | but ya | |
| 09:16:37 | sean-k-mooney[m] | we could have added 2 and removed 2 | |
| 09:16:49 | sean-k-mooney[m] | i think core review is enough to catch that honestly | |
| 09:16:56 | gibi | yes, I hope so | |
| 09:16:58 | sean-k-mooney[m] | we all know that we cant ever remove traits | |
| 09:17:08 | gibi | if not then we need a test in os-traits for it | |