Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2022-07-27
12:16:28 gibi me neither
12:50:54 bauzas I just capture the discussion
12:51:10 bauzas is it because unittest.mock is not on par with our mock lib ?
12:52:16 gibi it is that in py310 unittest.mock introduced a breaking change. The mock lib is a rolling backport of the upstream unittest.mock so at some point this change will appera in the standalone mock lib too
12:52:19 kashyap bauzas: Please put the stable/wallaby backport through: https://review.opendev.org/c/openstack/nova/+/851206
12:52:34 kashyap gibi ACKed it too; and you've ACKed the upstream main
12:53:39 gibi kashyap: we need to land the backports in order
12:53:44 gibi so we land the yoga first
12:53:48 gibi then xena
12:53:50 gibi then wallaby
12:54:03 kashyap gibi: Oh, yes. I mean to also implicitly look at 'em. :)
12:54:11 gibi ack
12:54:21 bauzas gibi: which breaking change ?
12:54:53 gibi if you mock a function twice, the second mocking attempt will fail
12:55:05 gibi as autospecing a mock is disallowed now
12:55:48 bauzas then we should wait for our mock lib
12:55:57 gibi what? why?
12:56:19 gibi why it is better to get the same breaking change later?
12:56:20 bauzas we should change the related tests first due to this
12:57:04 bauzas gibi: well, once our mock lib would be modified, then the CI wouldn't work and we would see it so we could not accept the new release
12:57:16 bauzas then we could modify the tests
12:57:23 bauzas for this new release
12:57:32 bauzas and then accepting the new release
12:58:07 gibi this is the same thing. If we want to accept py310 it means we need to accept all the breaking changes there.
12:59:13 gibi so we are only debating when to fix those duplicated mocks
12:59:27 bauzas at least we need to modify the only needed tests
12:59:29 gibi and as the mock switch is ready now I think we should fix it now
12:59:40 bauzas before changing to use unittest.mock
13:00:17 gibi why before? we can switch to unittest.mock and then fix the duplicated mock to get the py310 non voting job gren
13:00:20 gibi green again
13:01:06 gibi switching first make py310 job telling us where are the duplicates
13:01:55 admin1 i have nova using local disk , but glance and cinder uses ceph .. when using snapshots, i get broken pipe from nova compute .. is there any special way ceph needs to be configured for snapshots to work ?
13:12:03 sean-k-mooney admin1: no in that config nova should upload the snapshot via the glace http api
13:12:25 sean-k-mooney so it will create a snapshot using qemu-image then upload that disk
13:19:53 opendevreview Sylvain Bauza proposed openstack/nova master: api: Drop generating a keypair and add special chars to naming https://review.opendev.org/c/openstack/nova/+/849133
13:20:14 bauzas rebased my keypair api microversion due to unshelve_to_host merge ^
13:20:24 bauzas people can review it
13:27:56 opendevreview Kashyap Chamarthy proposed openstack/nova stable/victoria: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851223
13:31:38 gibi bauzas: +2, do you have an python binding patch and or osc patch with the client side change?
13:31:45 bauzas not yet
13:31:53 opendevreview Kashyap Chamarthy proposed openstack/nova stable/victoria: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851223
13:32:04 gibi Uggla: similar question to you too, do you have a client patch for the unshelve to host change?
13:32:08 gibi bauzas: ack
13:32:31 sean-k-mooney technically we dont need thos to merge the nova change but ya woudl be nice to see them sooner rather then later
13:32:38 Uggla gibi, yes give you the ids in one sec
13:32:39 gibi in the past we said we would at least like to see the client patches proposed (not merged) before we approve a microversion
13:32:45 gibi Uggla: awesome
13:32:49 sean-k-mooney ill be dropping soon but ill see if i have time to review before i do
13:33:32 opendevreview Kashyap Chamarthy proposed openstack/nova stable/ussuri: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851224
13:34:22 Uggla gibi: https://review.opendev.org/c/openstack/python-novaclient/+/831651 and https://review.opendev.org/c/openstack/python-openstackclient/+/831902
13:34:33 gibi Uggla: thanks
13:35:03 Uggla gibi, there is also a related tempest test: 841088: Tempest test for checking unshelve to host | https://review.opendev.org/c/openstack/tempest/+/841088
13:35:16 gibi ack
13:38:26 opendevreview Kashyap Chamarthy proposed openstack/nova stable/train: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851226
13:40:21 kashyap bauzas: gibi: If you have the stomach for it today still (other backports): https://review.opendev.org/q/Iec387dcbc49ddb91ebf5cfd188224eaf6021c0e1
13:40:41 bauzas gibi: kashyap: was working on the novaclient change
13:40:49 kashyap No worries
13:46:31 opendevreview Merged openstack/nova master: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851034
14:04:35 gibi Uggla: I left feedback in the python-novaclient patch and +1d the osc patch. nice work!
14:05:14 Uggla gibi, ok I'll have a look ASAP.
14:12:57 opendevreview Sylvain Bauza proposed openstack/python-novaclient master: Add support for 2.92 : keypair import mandatory https://review.opendev.org/c/openstack/python-novaclient/+/851231
14:13:02 bauzas gibi: ^
14:13:09 gibi bauzas: thanks
14:13:13 bauzas now working on the OSC patch
14:14:14 gibi bauzas: you probably want to put your novaclient patch top of Uggla's
14:14:33 bauzas gibi: there is a depends-on my api patch
14:14:39 bauzas gibi: but I can rebase it
14:15:00 gibi yeah, keep the depends on, but rebase your client patch on Uggla's client patch
14:15:08 gibi otherwise you will be in merge conflict
14:16:39 bauzas gibi: cool, yeah I know about the merge conflict but the fix will be simple
14:16:51 gibi yepp
14:16:59 gibi othervise your client patch looks good to me
14:20:00 opendevreview Sylvain Bauza proposed openstack/python-novaclient master: Add support for 2.92 : keypair import mandatory https://review.opendev.org/c/openstack/python-novaclient/+/851231
14:20:19 bauzas gibi: done
14:20:55 gibi bauzas: thanks, reapplied my +@
14:20:56 gibi +2
14:21:11 bauzas thanks
14:21:44 gibi your home has hair? ;)
14:45:49 bauzas gibi: sorry, haircut *at* home :p
14:46:25 bauzas my wife and I have a hairdresser visiting uds
14:46:30 gibi ohh, nice
14:46:39 bauzas cheaper and better
14:46:39 gibi my wife tend to cut mine
14:46:55 gibi that is the cheapest :)
14:47:28 bauzas yeah but if I use a hair mower, then my hair will have issues :)
14:48:19 bauzas I prefer to have a pro using scissors
15:48:14 artom gibi, so rollback_live_migration_at_destination() is the cast that contains the mutated migrated context, right?
15:48:26 artom So what if we just change it to a call instead of cast to make it blocking?
15:48:41 artom That way, we're sure that by the time we drop the claim, we're out of the mutated context?
15:49:16 gibi that is a dirty thing that will mean we will have a short time window where the db contains the wrong info, then then the second call will return the db content to the correct state
15:49:23 gibi so we will have a smaller race window
15:49:26 gibi but we still have the race
15:50:02 artom You're assuming that mutating the context saves to the DB?
15:50:05 artom I don't think that's the case
15:50:16 gibi we mutate the context and then save the instance today
15:50:25 gibi just the mutate is not an issue
15:50:57 gibi the instance.save happens in _cleanup in the driver
15:51:06 gibi and that is run under the mutated context
15:52:55 gibi links to the code are here https://bugs.launchpad.net/nova/+bug/1982497/comments/2
15:53:08 artom gibi, oh, right

Earlier   Later