| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-25 | |||
| 16:03:23 | bauzas | this looks a transient issue | |
| 16:03:32 | bauzas | we already wait for 60s | |
| 16:03:33 | sean-k-mooney | neutron is not ment to send network vif pulgged for the parent | |
| 16:03:33 | gibi | but 60sec is a lot | |
| 16:03:39 | sean-k-mooney | untill all the subports are setup | |
| 16:03:46 | sean-k-mooney | maybe it does nto take that into account | |
| 16:04:00 | sean-k-mooney | and sends it only once the parent is set up | |
| 16:04:06 | sean-k-mooney | meaning we might be racing | |
| 16:04:16 | gibi | yeah that make sense | |
| 16:04:25 | sean-k-mooney | nova only has one port attached to the vm so we only care about the parent | |
| 16:04:28 | gibi | that will depend on how was tempest querying the state | |
| 16:05:01 | sean-k-mooney | i dont think the parent shoudl really be active if the subports are not active | |
| 16:05:03 | melwitt | this is the tempest test https://github.com/openstack/tempest/blob/97be23ea6402649652991983f3f2b85873eba4d8/tempest/api/compute/admin/test_live_migration.py#L285 | |
| 16:05:16 | sean-k-mooney | but honestly that is proably an impmentation detail that noone should depend on | |
| 16:05:26 | sean-k-mooney | i dont think this was defiended in teh specs | |
| 16:05:59 | sean-k-mooney | so the test might just be asserting stuff that is not required/guarenteed by the api | |
| 16:07:28 | sean-k-mooney | im pretty sure this was the relevent spec https://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html | |
| 16:10:00 | sean-k-mooney | gibi: melwitt so ya reading that quickly the status of the subport is not defeined in relation to port binding | |
| 16:10:18 | dansmith | sean-k-mooney: on the event, it should send the event once the thing the port represents can pass traffic, right? so subport or not, we shouldn't get the alert until the traffic will flow | |
| 16:10:32 | dansmith | else we're wiring up to something we can't expect to get dhcp or other critical traffic through | |
| 16:10:36 | sean-k-mooney | correct | |
| 16:10:47 | dansmith | calling the trunk up because one side is active isn't good enough | |
| 16:11:00 | sean-k-mooney | we should not get the network-vif-plugged for the trunk parent untill everything is configured to allow all taffic to flow | |
| 16:11:26 | dansmith | right, so depending on the backend implementation that may come depending on what wiring needs to happen | |
| 16:11:30 | sean-k-mooney | but they may not have implemented that depened status check | |
| 16:11:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec https://review.opendev.org/c/openstack/nova/+/844625 | |
| 16:11:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491 | |
| 16:11:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extra tests for remote managed dev spec https://review.opendev.org/c/openstack/nova/+/844626 | |
| 16:11:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress https://review.opendev.org/c/openstack/nova/+/844628 | |
| 16:11:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565 | |
| 16:11:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unused PF checking from get_function_by_ifname https://review.opendev.org/c/openstack/nova/+/845775 | |
| 16:11:50 | dansmith | right but that would be a neutron issue | |
| 16:11:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Clean up mapping input to address spec types https://review.opendev.org/c/openstack/nova/+/845765 | |
| 16:11:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move __str__ to the PciAddressSpec base class https://review.opendev.org/c/openstack/nova/+/845781 | |
| 16:11:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix type annotation of pci.Whitelist class https://review.opendev.org/c/openstack/nova/+/845780 | |
| 16:11:58 | sean-k-mooney | dansmith: yes it would | |
| 16:12:23 | dansmith | ack, just confirming ;) | |
| 16:12:31 | sean-k-mooney | so your suggesting that marking it confirmed for nova on the bug is wrong and we should likely change it | |
| 16:13:15 | dansmith | I dunno about that I just want to be clear that nova shouldn't be trying to interpret vif-plugged differently for trunks | |
| 16:13:23 | sean-k-mooney | bauzas: gibi by the way with the escalation and everything that happened in the last few days i have not been doing upstream bug triage this week sorry | |
| 16:13:34 | gibi | sean-k-mooney: no worries | |
| 16:13:38 | sean-k-mooney | dansmith: agreeed | |
| 16:13:48 | bauzas | sean-k-mooney: no worries at all, again, bug triage is just down any prio | |
| 16:13:57 | sean-k-mooney | dansmith: nova should jsut care about thte one port that is attached to the vm (the trunk) | |
| 16:14:03 | sean-k-mooney | the rest is up to neutron to care about | |
| 16:14:07 | dansmith | yes | |
| 16:14:23 | sean-k-mooney | dansmith: if tempest should check this at all is proably TBD | |
| 16:14:27 | gibi | maybe the tempest test verify the system from neutron perspective hence the assert on the subport too | |
| 16:14:57 | dansmith | sean-k-mooney: also true | |
| 16:15:06 | sean-k-mooney | gibi: yes but in that casae it is indicating that neutron is not correctly seting up the trunk | |
| 16:15:11 | gibi | yes | |
| 16:15:14 | gibi | I agree | |
| 16:15:44 | sean-k-mooney | i would suggest seting the nova part to incomplete for now | |
| 16:15:55 | sean-k-mooney | as its not clear that nova shoudl be doing anything it is not already doing | |
| 16:20:19 | gibi | works for me | |
| 16:20:32 | gibi | later we can set it to invalid if turn out only neutron needs a fix | |
| 16:24:12 | opendevreview | Billy Olsen proposed openstack/nova master: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/838976 | |
| 19:30:40 | opendevreview | Amit Uniyal proposed openstack/nova master: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/848886 | |
| #openstack-nova - 2022-07-26 | |||
| 05:31:15 | auniyal | logs from nova/db/main/api should come in devstack@n-cond-cell1, super-cond or cpu ? | |
| 05:41:22 | auniyal | it should come under devstack@n-super-cond, but exceptions are not coming | |
| 07:48:43 | bauzas | good morning Nova | |
| 07:49:05 | gibi | o/ | |
| 07:55:30 | bauzas | I just sent an email | |
| 07:55:44 | bauzas | tl;dr: HOLD YOUR RECHECKS | |
| 08:07:39 | gibi | I see a nice buzz around the issue in the bug report | |
| 08:08:48 | bauzas | like I said in -neutron, I'm looking at gerrit now based on mlavalle's comment | |
| 08:09:52 | gibi | I did that already and commented on the bug, but feel free to double check | |
| 08:17:36 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM: Avoid os-vif 3.0.0 https://review.opendev.org/c/openstack/nova/+/850998 | |
| 08:17:39 | bauzas | gibi: ^ | |
| 08:18:23 | gibi | bauzas: thanks | |
| 08:53:04 | sean-k-mooney[m] | why? | |
| 08:53:41 | sean-k-mooney[m] | what change in os-vif do you think is related | |
| 08:55:13 | sean-k-mooney[m] | the trunk bridge patch? | |
| 08:56:40 | sean-k-mooney[m] | https://github.com/openstack/os-vif/commit/75b290fb2a8f706583e0c12c5c5a4c0fc80e6481 ? | |
| 08:58:07 | sean-k-mooney[m] | if its related to that then the but is in neutron | |
| 09:03:30 | bauzas | sean-k-mooney: we're discussing it alot in the -neutron room | |
| 09:04:06 | bauzas | basically, neutron wanted to defer the trunk creation logic to os-vif but since we have rolling upgrades, looks like we now fail | |
| 09:04:36 | bauzas | it looks to me the upgrade approach was invalid and we should have waited nova to be fully upgraded | |
| 09:07:43 | opendevreview | Sylvain Bauza proposed openstack/nova master: Block os-vif 3.0.0 https://review.opendev.org/c/openstack/nova/+/850998 | |
| 09:07:45 | sean-k-mooney[m] | ill hop over | |
| 09:07:57 | sean-k-mooney[m] | but the nova and os-vif code is right i think | |
| 09:08:22 | sean-k-mooney[m] | but they may have dropped the bridge cleanup code to soon in neutron | |
| 09:08:28 | bauzas | sean-k-mooney: it seems so yeah | |
| 09:09:05 | bauzas | some logic was possibly modified in Neutron | |
| 09:09:24 | bauzas | this would explain why nova-next and grenade were failing | |
| 09:09:45 | bauzas | for the ovs-hybrid-plug job, I don't k | |
| 09:41:24 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM for testing drop of os-vif to 2.8.0 https://review.opendev.org/c/openstack/nova/+/851006 | |
| 09:48:04 | opendevreview | Takashi Natsume proposed openstack/nova-specs master: Create specs directory for Antelope https://review.opendev.org/c/openstack/nova-specs/+/851007 | |
| 10:26:51 | opendevreview | sean mooney proposed openstack/os-vif master: [WIP] make os-vif jobs multinode and enable trunk testing https://review.opendev.org/c/openstack/os-vif/+/851011 | |
| 10:30:59 | whoami-rajat | dansmith, sean-k-mooney[m] hey, just a reminder to request to review the series of rebuilding volume backed instance, would like to get it in Zed release https://review.opendev.org/c/openstack/nova/+/820368/ | |
| 12:16:55 | bauzas | so, https://review.opendev.org/c/openstack/nova/+/851006 has a -1 but not because of the os-vif issue | |
| 12:17:49 | ratailor | bauzas, could you please provide your feedback on https://review.opendev.org/c/openstack/nova/+/844418 ? | |
| 12:18:19 | bauzas | ratailor: for the moment, I'm working on another CI issue | |
| 12:18:22 | bauzas | but ok | |
| 12:18:51 | ratailor | bauzas, no problem. whenever you have time. Thanks! | |
| 13:02:46 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 13:02:47 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (drivers) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 13:02:47 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 13:02:48 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 13:02:48 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |