| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-18 | |||
| 14:37:06 | bauzas | within also a cells v2 DB | |
| 14:37:33 | bauzas | so we need to make sure the upgrade will work for large operators having a lot of instances and cells | |
| 14:37:35 | sean-k-mooney | we had the option to not do a db migration and store it in the instance_system_metadtaa | |
| 14:38:40 | sean-k-mooney | stephenfin: at least seam to prefer treating it like a first class porperty on the instance object and therefor storing it in the instance table | |
| 14:39:20 | sean-k-mooney | so we can revsit that but we should be abel to make additive changes to the db | |
| 14:40:19 | sean-k-mooney | bauzas: stephenfin was suggesting this si a good way to test the new alembic migration flow as its relitivly low risk | |
| 14:40:25 | bauzas | fortunately, we don't need to modify the data | |
| 14:40:38 | sean-k-mooney | right it just a new nullable column | |
| 14:41:31 | bauzas | but yeah, we need to explain the operators that it would be an ALTER for the instances table | |
| 14:41:50 | bauzas | also, making sure we also add it to the shadow table | |
| 14:41:54 | sean-k-mooney | is the release note not sufficent for that | |
| 14:42:00 | bauzas | it will I guess | |
| 14:43:25 | bauzas | sean-k-mooney: I don't see the default policy for seeing the domain attribute value and putting it | |
| 14:43:33 | bauzas | sean-k-mooney: I guess this is enduser ? | |
| 14:45:10 | bauzas | also, we'll change the notification, as you said, so we need to modify the spec to no longer say "none" to notifications impact | |
| 14:45:12 | sean-k-mooney | it woudl admin_or_opwner | |
| 14:45:18 | sean-k-mooney | the same as hostname | |
| 14:46:29 | sean-k-mooney | or project_member in the new RBAC schem for update and project_reader for viewing | |
| 14:46:52 | sean-k-mooney | we can capture this extra detail in a follow up patch | |
| 14:47:06 | sean-k-mooney | can you leave that feedback for atrom on the patch | |
| 14:48:11 | dansmith | oh are we talking about the domain spec? | |
| 14:48:17 | sean-k-mooney | yes | |
| 14:48:49 | dansmith | submitted and merged in less than 24 hours.. that was not cool, IMHO | |
| 14:49:07 | gibi | I take the blame | |
| 14:49:25 | gibi | I was under the impression that it is verry similar to what we already did | |
| 14:49:31 | gibi | about the hostname | |
| 14:49:54 | sean-k-mooney | it is but the question i really have are there outstanding questions that needed to be adressed | |
| 14:49:59 | dansmith | yeah, but that's not a good (enough) excuse :) | |
| 14:50:05 | sean-k-mooney | i did not think there were | |
| 14:50:20 | gibi | dansmith: I see now | |
| 14:50:22 | sean-k-mooney | but if there are as i mentioned above we can revert or adress in a followup | |
| 14:50:39 | dansmith | I've put some general and specific concerns in there | |
| 14:50:40 | sean-k-mooney | do we dissagre directionally on the change | |
| 14:50:53 | dansmith | technically the process is to fast revert when there wasn't time for feedback | |
| 14:51:06 | dansmith | I know there's a deadline at hand, but still... | |
| 14:51:23 | sean-k-mooney | ack well we can follow the spec freeze excpetion process | |
| 14:51:54 | sean-k-mooney | which is ask for exception in team meeting and then basicaly have till end of week or next meeting to agree or punt | |
| 14:54:49 | sean-k-mooney | hum artom does not apper to be on upstream or downstream irc but ill ping them when they are about to readback and review the spec | |
| 14:55:00 | sean-k-mooney | bauzas: dansmith do either of ye want to propose the revert patch | |
| 14:55:00 | gibi | artom is on PTO this week | |
| 14:55:07 | sean-k-mooney | oh | |
| 14:55:09 | sean-k-mooney | ok | |
| 14:55:17 | dansmith | >:( | |
| 14:55:44 | sean-k-mooney | well in that case i can proably recuse myself form the spec review and take it over and adress the feedback | |
| 14:55:52 | sean-k-mooney | if the rest of ye feel ok with reviewing it | |
| 14:56:10 | gibi | sean-k-mooney: works for me | |
| 14:56:16 | sean-k-mooney | or we punt it to next cycle | |
| 14:58:22 | bauzas | I don't know what to say | |
| 14:58:32 | bauzas | the blueprint isn't created yet | |
| 14:58:50 | bauzas | so technically even if the spec is merged, we don't track its progress | |
| 14:59:02 | bauzas | now, about the spec | |
| 14:59:12 | bauzas | I have a few left comments | |
| 14:59:42 | sean-k-mooney | ya sorry i tought we had a check in the ci that the url existied but i guess not i didnt think to check that manually | |
| 14:59:54 | bauzas | my concern being the discrepancy between neutron's dns_domain and nova's domain and how we reconcile them | |
| 15:00:16 | sean-k-mooney | well there isnnt a depency here | |
| 15:00:42 | sean-k-mooney | we optionally can set the port dns_domain if the extension extis for port that are create by nova | |
| 15:00:43 | bauzas | anyway, we have to join some internal meeting | |
| 15:00:47 | gibi | I fixed the missing bp for you :) https://blueprints.launchpad.net/nova/+spec/configurable-instance-domains | |
| 15:01:09 | sean-k-mooney | but nova had no dep no neutron to consime that value in teh current version | |
| 15:01:59 | sean-k-mooney | if that is not clear then we should capture that in the spec | |
| 15:18:07 | bauzas | can anyone tell me why https://review.opendev.org/c/openstack/nova/+/828675/ shows tempest-integrated-compute-centos-9-stream job being run on check pipeline while https://review.opendev.org/c/openstack/nova/+/849463/1/.zuul.yaml was merged ? | |
| 15:18:18 | bauzas | I suspect because of default project config in zuul ? | |
| 15:20:00 | sean-k-mooney | it might be due to needing a rebase | |
| 15:20:09 | sean-k-mooney | ill take a look after our downstream call | |
| 15:20:44 | kashyap | Is anyone else seeing these RETRY_LIMIT failures on stable/wallaby? - https://zuul.opendev.org/t/openstack/build/8f8a3dab99fa41c9ac30efaf6f3a21e0 | |
| 15:21:18 | kashyap | It looks like it's failing due to failing access to some of the Ubuntu repos | |
| 15:45:35 | melwitt | bauzas: gentle reminder about this patch that is proposing to change a piece of logic in the 'nova-manage placement audit' command https://review.opendev.org/c/openstack/nova/+/844418 | |
| 15:46:37 | bauzas | sean-k-mooney: c9s job runs b/c of tempest https://opendev.org/openstack/tempest/src/branch/master/zuul.d/integrated-gate.yaml#L387 | |
| 15:47:14 | bauzas | so we need to keep the non-voting flag | |
| 15:47:29 | sean-k-mooney | or we remove that template | |
| 15:47:31 | bauzas | explicitely in our .zuul | |
| 15:47:36 | sean-k-mooney | and add the jobs manually | |
| 15:48:02 | sean-k-mooney | well better lets update that template | |
| 15:48:34 | sean-k-mooney | we can move it to the periodic-weekly pipelien in that template | |
| 15:48:58 | bauzas | sean-k-mooney: do you feel brave enough to propose a patch against it ? | |
| 15:49:06 | bauzas | I feel my time is short those weeks | |
| 15:49:08 | sean-k-mooney | sure i can do it | |
| 15:50:35 | bauzas | :) | |
| 16:06:47 | sean-k-mooney | bauzas: https://review.opendev.org/c/openstack/tempest/+/850242 | |
| 16:07:12 | bauzas | + | |
| 16:07:14 | bauzas | +1d | |
| 16:45:58 | stephenfin | melwitt: Care to +2 this? https://review.opendev.org/c/openstack/nova/+/850006/ Hopefully I've addressed you query | |
| 16:46:02 | stephenfin | *your | |
| 17:08:05 | sean-k-mooney | bauzas: dansmith https://review.opendev.org/c/openstack/nova-specs/+/849765/comments/83b8b648_d0242918 | |
| 17:09:07 | sean-k-mooney | does that ^ work for ye if so bauzas ping me when the revert is proposed and ill ack it and draft a updated version of the spec | |
| 17:10:35 | sean-k-mooney | with that said it 31C and 45% humitity outside and my office is warmer so im going to call it a day | |
| 17:11:47 | opendevreview | Sylvain Bauza proposed openstack/nova master: api: Drop generating a keypair and add special chars to naming https://review.opendev.org/c/openstack/nova/+/849133 | |
| 17:12:15 | bauzas | sean-k-mooney: gibi: Uggla: fwiw, I just uploaded a v2.92 API change without rebasing from Uggla so please hold your +W | |
| 17:12:25 | bauzas | but it looks like we easily accept it | |
| 17:12:31 | bauzas | without having a 2.91 | |
| 17:13:04 | bauzas | I'll create another branch locally from Uggla's series and I'll see whether I get a merge conflict | |
| 17:19:00 | sean-k-mooney | ack care to put a -w on it until then | |
| 17:19:20 | sean-k-mooney | i likely wont have time to review it again until tommorw anyway | |
| 17:19:27 | sean-k-mooney | just going to go get dinner shortly | |
| 17:19:37 | melwitt | stephenfin: oh, yup, thanks for explaining that | |
| 17:21:44 | bauzas | I resolved the conflicts easily | |
| 17:47:42 | melwitt | bah, no Aardvark >:( https://lists.openstack.org/pipermail/openstack-discuss/2022-July/029608.html | |
| 17:48:00 | dansmith | yeah :( | |
| 17:48:45 | sean-k-mooney | Anteater is closeest | |
| 17:50:00 | dansmith | did I miss them looking for suggestions or did they just decide on a few options to vote on? | |