| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-18 | |||
| 09:55:40 | Uggla | sean-k-mooney, code is here: https://github.com/uggla/nova/tree/bp/manila_shares_attachments | |
| 09:57:01 | Uggla | It seems something is wrong with the placement API. | |
| 10:07:23 | sean-k-mooney | those dont sound like they shoudl be related to your patches | |
| 10:07:36 | sean-k-mooney | you might want to rebase your patches to the tip of master and see if they go away | |
| 10:08:35 | gibi | yepp the schema validation error might be related to the recent bump on jsonschema | |
| 10:08:39 | gibi | and that is fixed on master | |
| 10:09:45 | sean-k-mooney | recent as in merged on friday i think | |
| 10:16:58 | Uggla | sean-k-mooney, I think about it and rebase. But it is still present. | |
| 10:18:55 | sean-k-mooney | try add -r | |
| 10:19:04 | sean-k-mooney | to have tox recreate teh venv | |
| 10:19:19 | sean-k-mooney | ill try running it myself with master shortly | |
| 10:19:25 | sean-k-mooney | just getting something to drink | |
| 10:43:04 | gibi | Uggla: I pulled your branch but the unit tests, you see failing, are passing for me locally | |
| 10:45:37 | gibi | (I added the os_trats change manually to the venv) | |
| 10:49:40 | sean-k-mooney | doing the same currently | |
| 10:51:07 | sean-k-mooney | ====== | |
| 10:51:10 | sean-k-mooney | Totals | |
| 10:51:12 | sean-k-mooney | ====== | |
| 10:51:14 | sean-k-mooney | Ran: 16546 tests in 76.0306 sec. | |
| 10:51:16 | sean-k-mooney | - Passed: 16487 | |
| 10:51:18 | sean-k-mooney | - Skipped: 58 | |
| 10:51:20 | sean-k-mooney | - Expected Fail: 1 | |
| 10:51:22 | sean-k-mooney | - Unexpected Success: 0 | |
| 10:51:24 | sean-k-mooney | - Failed: 0 | |
| 10:51:26 | sean-k-mooney | Sum of execute time for each test: 3190.1976 sec. | |
| 10:51:45 | sean-k-mooney | so ya with clean envs if i install the os-traits repo into the env | |
| 10:51:50 | sean-k-mooney | then it seams to work fine | |
| 10:52:00 | sean-k-mooney | at least on ubuntu 22.04 | |
| 10:52:37 | sean-k-mooney | Uggla: if that is the only issue you have and you have fixed up any other patch comments i would push it and see if the ci complains | |
| 11:27:03 | sean-k-mooney | sfinucan: can you swap the order of the first two patches https://review.opendev.org/c/openstack/nova/+/850006/1 | |
| 11:27:25 | sean-k-mooney | the dataclasses dep seams to be causing issues on the first patch | |
| 11:29:39 | sfinucan | sure | |
| 11:30:35 | opendevreview | Stephen Finucane proposed openstack/nova master: Fix compatibility with jsonschema 4.x https://review.opendev.org/c/openstack/nova/+/849867 | |
| 11:30:35 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove unused requirement https://review.opendev.org/c/openstack/nova/+/850006 | |
| 11:30:36 | opendevreview | Stephen Finucane proposed openstack/nova master: Bump jsonschema minimum to 4.0.0 https://review.opendev.org/c/openstack/nova/+/850021 | |
| 11:30:43 | sfinucan | sean-k-mooney: done | |
| 11:30:47 | sean-k-mooney | thanks | |
| 11:30:53 | sean-k-mooney | ill read my +2 to those | |
| 11:31:02 | sean-k-mooney | *readd | |
| 11:32:17 | sean-k-mooney | stephenfin: can you weigh in on https://review.opendev.org/c/openstack/os-traits/+/844336/1/os_traits/compute/viommu.py#24 by the way | |
| 11:32:33 | sean-k-mooney | do we need an auto trait? it might be nice but im not sure we do | |
| 11:33:12 | sean-k-mooney | it would simplfy the prefileter so im inclined ot leave it but drop none | |
| 11:38:47 | opendevreview | Merged openstack/os-traits master: Add 'COMPUTE_STORAGE_VIRTIO_FS', 'COMPUTE_MEM_BACKING_FILE' https://review.opendev.org/c/openstack/os-traits/+/832769 | |
| 11:40:30 | sean-k-mooney | Uggla: ill propose a release of os-traits later this week there is one other patch i want to land | |
| 11:41:08 | sean-k-mooney | but that will allow you to use it form pypi once we have done the release and unblock the nova series form merging. | |
| 11:43:09 | sean-k-mooney | well its still WIP but more it will unblock the unit/functional tests form passign in the gate | |
| 11:43:28 | Uggla | sean-k-mooney, cool thx | |
| 11:46:55 | opendevreview | sean mooney proposed openstack/nova master: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/832330 | |
| 11:51:39 | opendevreview | sean mooney proposed openstack/nova master: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/832330 | |
| 11:56:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/850003 | |
| 11:58:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/850003 | |
| 12:01:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move uwsgi-gmr reno to the proper place https://review.opendev.org/c/openstack/nova/+/850152 | |
| 12:22:31 | Uggla | gibi, just get a new fresh repo from my code and still having the unit tests failing.... becoming crazy... | |
| 12:23:00 | sean-k-mooney | what version of python are you using and what os | |
| 12:23:43 | Uggla | 3.10.5 | |
| 12:23:52 | Uggla | Fedora 36 | |
| 12:23:59 | sean-k-mooney | i see well that could be the issue | |
| 12:24:06 | sean-k-mooney | 3.10 support is experimental | |
| 12:24:18 | sean-k-mooney | ill see if i get the same issue with 3.10 | |
| 12:24:38 | sean-k-mooney | oh hum | |
| 12:24:43 | sean-k-mooney | i was using 3.10.4 | |
| 12:24:52 | Uggla | but within tox 3.9 is used no ? | |
| 12:25:13 | sean-k-mooney | only if you run tox -e py39 | |
| 12:25:52 | sean-k-mooney | i ran with 3.10.4 so its not 3.10 | |
| 12:26:07 | Uggla | yep this is what I run. | |
| 12:26:44 | sean-k-mooney | well this seams to work on ubuntu so it might be a fedora dep issue | |
| 12:26:56 | sean-k-mooney | although im not sure what would cause that to fail | |
| 12:30:21 | Uggla | sean-k-mooney, it seems it happened to me on Friday after a rebase to split patches... I thought I did something wrong... | |
| 13:07:27 | fungi | sean-k-mooney: did you see my question on https://launchpad.net/bugs/1981813 (just trying to confirm the bug type change was intentional before i add an ossa bugtask)? | |
| 13:10:29 | opendevreview | Manuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 13:12:05 | opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | |
| 14:28:02 | bauzas | dang. | |
| 14:28:26 | bauzas | https://blueprints.launchpad.net/nova/+spec/configurable-instance-domains from https://specs.openstack.org/openstack/nova-specs/specs/zed/approved/configurable-instance-domains.html is giving me HTTP404 | |
| 14:28:55 | bauzas | looks like artom forgot to create it | |
| 14:29:26 | bauzas | also, I'm a bit surprised we merged a spec within one day for an instance modification, but OK | |
| 14:29:27 | sean-k-mooney | oh well thats an easy fix at least | |
| 14:30:21 | sean-k-mooney | it was basically the same change we did for hostname 2 cyles ago | |
| 14:30:32 | sean-k-mooney | so that is not really contovial at least in my view | |
| 14:30:48 | sean-k-mooney | we proably should have added both orginally | |
| 14:31:38 | bauzas | mmmm | |
| 14:31:57 | bauzas | we'll see whether it would be a problem later | |
| 14:33:29 | sean-k-mooney | if you think there is a design issue we can revert the spec. | |
| 14:33:49 | sean-k-mooney | are you worried we missed something specific | |
| 14:36:38 | bauzas | well | |
| 14:36:52 | bauzas | I'm afraid it's about a large table | |
| 14:37:06 | bauzas | within also a cells v2 DB | |
| 14:37:33 | bauzas | so we need to make sure the upgrade will work for large operators having a lot of instances and cells | |
| 14:37:35 | sean-k-mooney | we had the option to not do a db migration and store it in the instance_system_metadtaa | |
| 14:38:40 | sean-k-mooney | stephenfin: at least seam to prefer treating it like a first class porperty on the instance object and therefor storing it in the instance table | |
| 14:39:20 | sean-k-mooney | so we can revsit that but we should be abel to make additive changes to the db | |
| 14:40:19 | sean-k-mooney | bauzas: stephenfin was suggesting this si a good way to test the new alembic migration flow as its relitivly low risk | |
| 14:40:25 | bauzas | fortunately, we don't need to modify the data | |
| 14:40:38 | sean-k-mooney | right it just a new nullable column | |
| 14:41:31 | bauzas | but yeah, we need to explain the operators that it would be an ALTER for the instances table | |
| 14:41:50 | bauzas | also, making sure we also add it to the shadow table | |
| 14:41:54 | sean-k-mooney | is the release note not sufficent for that | |
| 14:42:00 | bauzas | it will I guess | |
| 14:43:25 | bauzas | sean-k-mooney: I don't see the default policy for seeing the domain attribute value and putting it | |
| 14:43:33 | bauzas | sean-k-mooney: I guess this is enduser ? | |
| 14:45:10 | bauzas | also, we'll change the notification, as you said, so we need to modify the spec to no longer say "none" to notifications impact | |