| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-15 | |||
| 16:07:16 | artom | If it finds _IntegratedTestCase in the regressions folder, pep8 -1 | |
| 16:07:27 | artom | If we're *actually* going to be strict about it | |
| 16:07:34 | sean-k-mooney | artom: the other thing to keep in mind is that stephen had been trying to remvoe _IntegratedTestCase at one point | |
| 16:07:48 | artom | stephenfin's been trying to remove *everything* at one point ;) | |
| 16:07:49 | sean-k-mooney | so we should not be directlly adding new tests that use it as a base | |
| 16:08:02 | sean-k-mooney | right but _IntegratedTestCase is considerd private | |
| 16:08:12 | sean-k-mooney | and new code should not inherit form it directly | |
| 16:08:17 | artom | I feel like facts on the ground contradict that :) | |
| 16:08:20 | sean-k-mooney | its subclasses are fine but not that | |
| 16:09:25 | sean-k-mooney | i think lee used it for conveicne not because it was the most correct way to repoduce | |
| 16:11:06 | sean-k-mooney | we generally try to be pragmatic about this but i disagree that amit shoudl rewrite the test they created | |
| 16:13:01 | sean-k-mooney | ProviderUsageBaseTestCase would be prefible if you require someing other then the mixins for new tests | |
| 16:14:28 | sean-k-mooney | or LibvirtProviderUsageBaseTestCase if you need libvirt | |
| 17:03:21 | opendevreview | Artom Lifshitz proposed openstack/nova master: hacking: forbid _IntegratedTestBase in regression tests https://review.opendev.org/c/openstack/nova/+/850053 | |
| 17:03:34 | artom | sean-k-mooney ^^ Yes, I'm part-trolling :) | |
| 17:03:46 | artom | Also, it doens't actually work, which... is surprisingly annoying? | |
| 17:03:56 | artom | Like, I thought I'd be able to hack it up quicker, so the ego takes a hit | |
| 17:04:26 | sean-k-mooney | its kind fo hard to do sicne its not about _IntegratedTestBase sepcificaly | |
| 17:04:37 | sean-k-mooney | we are alowed to use the mixins | |
| 17:06:00 | artom | Oh, like those will never get refactored :P | |
| 17:06:34 | sean-k-mooney | well they should not the can have methods added but they idaaly would be addditive changes only or mainly | |
| 17:12:49 | sean-k-mooney | im going to call it a day chat to you monday o/ | |
| 17:26:27 | artom | Oh crap that remind me, I'm off next week | |
| #openstack-nova - 2022-07-18 | |||
| 04:28:00 | opendevreview | Merged openstack/nova stable/wallaby: Add missing condition https://review.opendev.org/c/openstack/nova/+/847011 | |
| 05:00:37 | opendevreview | Merged openstack/nova master: Update the file for IPv4-only or IPv6-only network https://review.opendev.org/c/openstack/nova/+/465891 | |
| 05:12:10 | opendevreview | Merged openstack/nova master: etc: Highlight absence of packages from config gen https://review.opendev.org/c/openstack/nova/+/849796 | |
| 07:02:52 | opendevreview | Merged openstack/nova stable/victoria: libvirt: make mdev types name attribute be optional https://review.opendev.org/c/openstack/nova/+/754401 | |
| 07:16:50 | bauzas | good Monday everyone | |
| 07:18:43 | sean-k-mooney | bauzas: o/ | |
| 07:19:25 | sean-k-mooney | im up too early for me to say if its good yet but i should proably go have coffee and then form an opipion | |
| 07:20:07 | bauzas | :) | |
| 07:22:44 | sean-k-mooney | bauzas: we have one that we like the general idea of but wanted more info from the autuhor and were considering giving a freeze exception if they provide that info by the team meeting | |
| 07:23:06 | bauzas | sean-k-mooney: I haven't looked yet at the open specs | |
| 07:23:17 | sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 07:23:48 | bauzas | oh I remember having seen it | |
| 07:23:56 | bauzas | it was created by July 11... | |
| 07:24:27 | sean-k-mooney | the rest can all get procedual -2 or abandoned | |
| 07:24:53 | sean-k-mooney | bauzas: its small stephen was even wondering if it shoudl be a specless blueprint before i pointed out they had a spec | |
| 07:25:46 | sean-k-mooney | bauzas: did you enjoy you time in th emountains | |
| 07:27:04 | bauzas | sean-k-mooney: oh yes :) https://twitter.com/matthewdbooth/status/1547252109179080705 | |
| 07:27:56 | sean-k-mooney | :) | |
| 08:04:04 | gibi | good morning | |
| 08:11:26 | sean-k-mooney | o/ | |
| 08:12:17 | sean-k-mooney | bauzas: i reviewed https://review.opendev.org/c/openstack/nova/+/849133 while you were away id allowing space intentional? over all i think this looks good as is | |
| 08:13:21 | bauzas | sean-k-mooney: excellent catch | |
| 08:13:37 | bauzas | this part was just rebased from the previous effort | |
| 08:13:43 | bauzas | I need to reconsider this | |
| 08:13:58 | sean-k-mooney | it proably ok to allow space | |
| 08:14:00 | bauzas | either way, I also need to rebase my work on Uggla's unshelve-to-host API part | |
| 08:14:05 | sean-k-mooney | i jsut would not personally use it | |
| 08:14:19 | bauzas | sean-k-mooney: honestly, I need to consider the RFC | |
| 08:14:38 | sean-k-mooney | ok no rush | |
| 08:15:06 | sean-k-mooney | so are we agreeing on merging the unshelve-to-host change first | |
| 08:15:10 | bauzas | in theory, keynames are quite well defined as being the user@machine | |
| 08:15:12 | sean-k-mooney | to not have a microverion conflict | |
| 08:15:29 | bauzas | sean-k-mooney: yeah, I was about to propose an etherpad tomorrow at the nova meeting | |
| 08:15:37 | sean-k-mooney | ok cool | |
| 08:15:43 | bauzas | to identify quite a sequence of API changes | |
| 08:19:01 | Uggla | bauzas, fyi I'm trying to fix what I have broken in my local virtiofs patches, then I will review the unshelve comments from gibi and yours. | |
| 08:19:27 | gibi | Uggla: ack | |
| 08:22:54 | bauzas | Uggla: np, I'd like to test some crazy thing, being to use the 2.92 microversion *without* rebasing on your series | |
| 08:37:52 | sean-k-mooney | gibi: quick question you have a rather nice doc on ports with resocue request in the admin section | |
| 08:37:53 | sean-k-mooney | https://github.com/openstack/nova/blob/master/doc/source/admin/ports-with-resource-requests.rst | |
| 08:38:42 | sean-k-mooney | i was goign to add a similar doc to the reference section orgianlly for vdpa but now im reconsidering | |
| 08:38:52 | sean-k-mooney | do you think the admin section would be better | |
| 08:39:48 | sean-k-mooney | i think it proably is since admin sepam sotb be where we have vgpu and sev ectra | |
| 08:40:22 | sean-k-mooney | i should proably cross link it form https://github.com/openstack/nova/blob/master/doc/source/admin/networking.rst too | |
| 08:40:41 | gibi | it feels more like an adminy thing | |
| 08:41:12 | gibi | +1 on crosslinking | |
| 08:41:53 | sean-k-mooney | ok ill go work on that so. i think the first vdpa patch is basically ready to merge but stephen raise a good point about docs so im goign to work on that now and then push a new version | |
| 08:50:31 | gibi | ack | |
| 09:37:56 | bauzas | ok, yoga open specs abandoned | |
| 09:38:42 | bauzas | as I said in my email, I won't -2 yet https://review.opendev.org/c/openstack/nova-specs/+/849488 until next meeting | |
| 09:39:01 | bauzas | and I appreciate reviews of https://review.opendev.org/c/openstack/nova-specs/+/842015 | |
| 09:48:44 | Uggla | Could someone help me in the beginning of the afternoon. I have issues with 3 unit tests but can not figure out why. | |
| 09:49:51 | sean-k-mooney | proably have you posted the failing patch for review or the output of the tox results somewhere | |
| 09:53:13 | Uggla | sean-k-mooney, not yet | |
| 09:53:49 | Uggla | sean-k-mooney, doing it right now | |
| 09:54:55 | Uggla | sean-k-mooney, this is the tests issues: https://paste.openstack.org/show/bkFrl9uor71V8QBjPcF1/ | |
| 09:55:40 | Uggla | sean-k-mooney, code is here: https://github.com/uggla/nova/tree/bp/manila_shares_attachments | |
| 09:57:01 | Uggla | It seems something is wrong with the placement API. | |
| 10:07:23 | sean-k-mooney | those dont sound like they shoudl be related to your patches | |
| 10:07:36 | sean-k-mooney | you might want to rebase your patches to the tip of master and see if they go away | |
| 10:08:35 | gibi | yepp the schema validation error might be related to the recent bump on jsonschema | |
| 10:08:39 | gibi | and that is fixed on master | |
| 10:09:45 | sean-k-mooney | recent as in merged on friday i think | |
| 10:16:58 | Uggla | sean-k-mooney, I think about it and rebase. But it is still present. | |
| 10:18:55 | sean-k-mooney | try add -r | |
| 10:19:04 | sean-k-mooney | to have tox recreate teh venv | |
| 10:19:19 | sean-k-mooney | ill try running it myself with master shortly | |
| 10:19:25 | sean-k-mooney | just getting something to drink | |
| 10:43:04 | gibi | Uggla: I pulled your branch but the unit tests, you see failing, are passing for me locally | |
| 10:45:37 | gibi | (I added the os_trats change manually to the venv) | |
| 10:49:40 | sean-k-mooney | doing the same currently | |
| 10:51:07 | sean-k-mooney | ====== | |
| 10:51:10 | sean-k-mooney | Totals | |
| 10:51:12 | sean-k-mooney | ====== | |
| 10:51:14 | sean-k-mooney | Ran: 16546 tests in 76.0306 sec. | |
| 10:51:16 | sean-k-mooney | - Passed: 16487 | |
| 10:51:18 | sean-k-mooney | - Skipped: 58 | |