| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-14 | |||
| 12:23:47 | stephenfin | s/hates/dislikes/ | |
| 12:24:07 | sean-k-mooney | stephenfin: they have a spec proposed and it looked good to me so specless or approve the one they have | |
| 12:24:48 | sean-k-mooney | stephenfin: apprently the compression algortiom depends on teh buidl of spice used | |
| 12:25:01 | sean-k-mooney | them mentioned that in the spec comment | |
| 12:25:06 | stephenfin | Oh, nice. I hadn't seen that | |
| 12:25:58 | sean-k-mooney | if there are default that work for most/everyone im also ok to implemnt those and review that in the code patch | |
| 12:26:26 | sean-k-mooney | ah they have auto for most of them as a default | |
| 12:26:28 | sean-k-mooney | cool | |
| 12:31:01 | stephenfin | agreed :( | |
| 12:31:05 | stephenfin | oh well | |
| 12:31:09 | stephenfin | left comments on the spec | |
| 12:31:11 | stephenfin | ...too | |
| 12:32:11 | sean-k-mooney | when you say enable by default | |
| 12:32:25 | sean-k-mooney | its really only enabled by "default" if there is a way to enable something else | |
| 12:32:44 | sean-k-mooney | are you suggesting we hardcode something | |
| 12:33:03 | sean-k-mooney | since i think they had a sane default for basially all the config optiosn | |
| 12:35:22 | stephenfin | sean-k-mooney: Yeah, basically hardcode the defaults they've proposed and don't bother with the knobs | |
| 12:35:54 | stephenfin | unless we have a good reason to add them (e.g. someone would have a good reason to disable that compression) | |
| 12:36:04 | sean-k-mooney | im not really that pushed eitehr way. i assume there is a tradeoff between bandwith and cpu | |
| 12:36:14 | sean-k-mooney | as there almost always is for compression | |
| 12:36:54 | sean-k-mooney | so it might be somthign that an operator wants to optimise for differently depenidn on there usecase | |
| 12:38:17 | sean-k-mooney | stephenfin: https://review.opendev.org/c/openstack/nova-specs/+/849488/3/specs/zed/approved/spice-compression-support.rst#114 | |
| 12:38:27 | sean-k-mooney | libvirt apprently has default for this too and that is what they are using | |
| 12:38:42 | sean-k-mooney | as the defalt so hardcoding what they propsoed would be the same as doing nothing | |
| 12:39:22 | stephenfin | hmm, it looks like libvirt's defaults are pretty sane, no? | |
| 12:39:28 | stephenfin | I wonder why they're not good enough | |
| 12:40:02 | sean-k-mooney | again i would guess this comes done to wanting to optimise for wan vs lan vs edge vdi deployments | |
| 12:40:32 | sean-k-mooney | in some cases bandwith might be the costly case in other cpu | |
| 12:41:17 | sean-k-mooney | im really not stongly opionated on this but that is what i was assuming when reviewing | |
| 12:41:22 | stephenfin | Okay, makes sense. I suspect adding these knobs is the correct decision in that case. I'll just wait for Manuel to pipe up and defend themselves :) | |
| 12:41:33 | sean-k-mooney | ack | |
| 12:41:52 | stephenfin | If nothing else, we'll get better docs on the advantages/disadvantages of configuring these things | |
| 12:42:25 | sean-k-mooney | stephenfin: by the way artom copy pasted your --hostname spec to add --domain and im mostly ok with it but care to have a look at https://review.opendev.org/c/openstack/nova-specs/+/849765 | |
| 12:43:30 | sean-k-mooney | this is related to the whole fqdn in displayname mess | |
| 12:53:07 | stephenfin | reviewed | |
| 12:53:22 | stephenfin | actually, let me have a look through some of the other specs. I missed the spec review day | |
| 13:01:56 | gibi | I have no hard opinion about spice compression. I agree with you to see if we really need this. But if there is a solid use case then I'm OK with having this. | |
| 13:02:19 | gibi | for a spec we are a bit late but I think if this is close then bauzas will not be against landing it next week | |
| 13:03:21 | sean-k-mooney | so we just want to defer the details fo the config options to the code review | |
| 13:04:09 | sean-k-mooney | *do we | |
| 13:09:58 | gibi | If I understand correctly the current default is sane and if we decide not to add knobs then there is nothing to implement. So I think this needs to be decided before the codereview | |
| 13:10:19 | sean-k-mooney | ack that is my understanidng too | |
| 13:10:52 | gibi | so hope Manuel can come back this week or early next week | |
| 13:10:53 | sean-k-mooney | i assuem they wanted to make this change because they had limitation with the current defaults but those are not captured in teh spec | |
| 13:11:12 | gibi | yeah, and if they have then I think we will not block them to add the knob | |
| 13:11:22 | gibi | we just need to know those limitations :) | |
| 13:11:36 | sean-k-mooney | for something this small i would be supportive of a spec freeze excption | |
| 13:11:50 | sean-k-mooney | if they can document why they need this feature next week | |
| 13:12:27 | gibi | I will be supporting for the exception too | |
| 13:20:27 | opendevreview | Stephen Finucane proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | |
| 13:20:27 | opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | |
| 13:20:28 | opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | |
| 13:20:28 | opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | |
| 13:20:29 | opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | |
| 13:20:29 | opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | |
| 13:20:30 | opendevreview | Stephen Finucane proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | |
| 13:30:52 | artom | stephenfin, your proposed changes section as just *so* well written ;) | |
| 13:31:04 | artom | Thanks for the reviews, I'll push a new rev soon | |
| 14:00:27 | opendevreview | Artom Lifshitz proposed openstack/nova-specs master: Configurable instance domains https://review.opendev.org/c/openstack/nova-specs/+/849765 | |
| 14:09:18 | opendevreview | Stephen Finucane proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862 | |
| 14:09:18 | opendevreview | Stephen Finucane proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851 | |
| 14:09:19 | opendevreview | Stephen Finucane proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | |
| 14:09:19 | opendevreview | Stephen Finucane proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | |
| 14:45:30 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove use of pkg_resources https://review.opendev.org/c/openstack/nova/+/740661 | |
| 14:45:31 | opendevreview | Stephen Finucane proposed openstack/nova master: Fix compatibility with jsonschema 4.x https://review.opendev.org/c/openstack/nova/+/849867 | |
| 14:48:29 | stephenfin | gibi: sean-k-mooney: trivial changes there to fix jsonschema 4.x compat and make nova _slightly_ faster by avoiding use of pkg_resources (which is slooooow) ^ | |
| 14:49:20 | gibi | stephenfin: I will check it | |
| 15:55:50 | opendevreview | Artom Lifshitz proposed openstack/nova master: libvirt: remove default cputune shares value https://review.opendev.org/c/openstack/nova/+/824048 | |
| 16:00:22 | opendevreview | Dmitry Tantsur proposed openstack/nova master: Add a proper schema version to network_data.json https://review.opendev.org/c/openstack/nova/+/849881 | |
| 17:09:07 | artom | sean-k-mooney, stephenfin, any chance we can finalize the domain spec before EOD? | |
| 17:40:14 | sean-k-mooney | ill take a look at it again shortly so yes? | |
| 17:40:32 | artom | \o/ | |
| 18:07:40 | opendevreview | Artom Lifshitz proposed openstack/nova-specs master: Configurable instance domains https://review.opendev.org/c/openstack/nova-specs/+/849765 | |
| 18:15:12 | sean-k-mooney | artom: +2 on ^ stephenfin melwitt gibi incase ye are still about | |
| 18:15:55 | sean-k-mooney | artom: on other commit is something we add examples of the updatead api payload or psudo api requests | |
| 18:16:05 | sean-k-mooney | in this case i dont think you need to do that | |
| 18:16:15 | artom | Which other commit? | |
| 18:16:25 | artom | Oh, if I respin this spec? | |
| 18:16:34 | sean-k-mooney | sorry other specs | |
| 18:16:45 | artom | stephenfin didn't do it, and this is just plagiarizing his domain spec ;) | |
| 18:16:47 | sean-k-mooney | so somethinmes we add example post/put payloads | |
| 18:17:05 | sean-k-mooney | but i think thats overkill for a this | |
| 18:17:17 | sean-k-mooney | /domin/hostname | |
| 18:17:42 | sean-k-mooney | i.e his spec was hostname yours is domain | |
| 18:18:08 | sean-k-mooney | anyway i didnt see anything worth another respin but im happy to rereview if others do | |
| 18:22:17 | opendevreview | Merged openstack/nova master: Remove use of pkg_resources https://review.opendev.org/c/openstack/nova/+/740661 | |
| 18:22:19 | gibi | sean-k-mooney, artom: I'm +2+Ad the domain spec | |
| 18:22:42 | artom | That was fast | |
| 18:22:47 | gibi | I read fast :) | |
| 18:23:00 | sean-k-mooney | and the content was familar :P | |
| 18:23:03 | gibi | yeah | |
| 18:23:21 | artom | Yeah, it's not like we kept rehashing it every second tech call for the past 4 months | |
| 18:23:22 | artom | Oh wiat | |
| 18:23:26 | gibi | I could swear I read this before somewher | |
| 18:23:27 | gibi | e | |
| 18:24:20 | sean-k-mooney | artom: implementaiton wil be ready by tueseday yes | |
| 18:24:44 | artom | https://i.imgflip.com/6ms8wt.jpg | |
| 18:25:02 | gibi | artom: so will you abandon https://review.opendev.org/c/openstack/nova-specs/+/840974 ? | |
| 18:25:22 | sean-k-mooney | its not mutually exclucive but i would at least punt it to AA | |
| 18:25:29 | artom | Done | |