| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-27 | |||
| 11:54:58 | bauzas | you mean, the caller or the called method ? | |
| 11:55:07 | sean-k-mooney | the use in the called method | |
| 11:55:14 | bauzas | the if conditional ? | |
| 11:55:18 | sean-k-mooney | yes | |
| 11:55:21 | bauzas | hah | |
| 11:55:31 | sean-k-mooney | the fact you have to check the sential with an is check explictly | |
| 11:55:39 | bauzas | well, then we could have one single conditional that would set a value or not | |
| 11:55:55 | sean-k-mooney | right which is what i actully was askign for | |
| 11:56:09 | bauzas | would you then prefer something like | |
| 11:56:13 | sean-k-mooney | i didnt leave review feedback yet because i was in the midel of other thngs | |
| 11:56:48 | sean-k-mooney | bauzas: also https://peps.python.org/pep-0661/ is basically the same as cpp's std:optional | |
| 11:57:00 | sean-k-mooney | at least in inteded usage | |
| 11:57:05 | sean-k-mooney | so yes i would prefer that | |
| 11:57:36 | sean-k-mooney | that said i dont se how its used | |
| 11:58:13 | bauzas | sean-k-mooney: https://paste.opendev.org/show/bLmJ5uKGsufcYjXAIda3/ | |
| 11:58:34 | bauzas | would you prefer this pattern ? | |
| 11:59:03 | bauzas | we only set an internal value if the parameter was provided | |
| 11:59:21 | bauzas | so we only check the sentinel value once at the top of the method | |
| 11:59:31 | sean-k-mooney | not quite | |
| 11:59:41 | sean-k-mooney | the problem with that is we can refernce undeined varbles | |
| 12:00:08 | sean-k-mooney | that actully a error in any path where new_az is not _sentinel | |
| 12:00:36 | bauzas | well, the reference to _sentinel is unique | |
| 12:00:49 | bauzas | you can check its id | |
| 12:01:21 | bauzas | that's why this pattern exists in Python to verify whether this parameter was called | |
| 12:01:33 | sean-k-mooney | https://paste.opendev.org/show/bqHsJAFVEGmRncJcERMd/ | |
| 12:01:41 | bauzas | as, if the id of the value explicitly matches the unpassed | |
| 12:02:05 | sean-k-mooney | if _new_az or host: in your version is a runtime error | |
| 12:02:23 | bauzas | sean-k-mooney: true | |
| 12:02:30 | bauzas | I like your counterproposal | |
| 12:03:01 | sean-k-mooney | i just like have a name for the concept that we are modeling | |
| 12:03:11 | sean-k-mooney | and abstracting how it implemtned via the name | |
| 12:03:14 | bauzas | of course, "az_passed == new_az is not _sentinel" without the trailing double-dot :) | |
| 12:03:29 | bauzas | and with a single equal | |
| 12:03:36 | bauzas | but I got your idea | |
| 12:04:03 | bauzas | you create an always-set internal reference for knowing whether this field was set or not | |
| 12:04:15 | bauzas | this is a good pattern | |
| 12:04:23 | bauzas | and only at the top of the method | |
| 12:04:31 | sean-k-mooney | yep | |
| 12:04:51 | sean-k-mooney | you check once and define a varible at the top of the method with a meaningful name | |
| 12:05:02 | bauzas | wfm | |
| 12:05:02 | sean-k-mooney | and then use that later so you dont need to keep the context loaded | |
| 12:05:12 | bauzas | Uggla: ^ | |
| 12:05:29 | bauzas | Uggla: tl;dr follow the pattern proposed by https://paste.opendev.org/show/bqHsJAFVEGmRncJcERMd/ | |
| 12:05:51 | bauzas | but modify the first line by "az_passed = new_az is not _sentinel | |
| 12:27:52 | Uggla | bauzas, ok | |
| 12:44:22 | gibi | Uggla: fyi I'm in the middle of reviewing your patches so you will get feedback from me soon too | |
| 12:45:05 | Uggla | gibi, a lot of new ones ? | |
| 12:46:15 | gibi | Uggla: couple of nits in the code and a list of suggestions in the functional tests | |
| 12:46:45 | Uggla | gibi, ok I'm gonna wait for your comments. | |
| 13:00:28 | gibi | Uggla: posted my comments | |
| 13:00:39 | Uggla | gibi, ok thx | |
| 14:01:23 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 14:03:03 | opendevreview | Jan Hartkopf proposed openstack/python-novaclient master: add support for microversion 2.91 https://review.opendev.org/c/openstack/python-novaclient/+/816158 | |
| 16:29:41 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 19:55:11 | colby__ | gibi: bauzas: sean-k-mooney: Thanks for the info. If the mdevs are not removed to be reused why would nova see them as being used then? Is that the bug mentioned? We have dynamic mdevs made from the sriov-manage on the pgpus that all work on initial spin up of instances, but once you delete the instances you can no longer use the vgpu device. Its still seen as busy. | |
| #openstack-nova - 2022-06-28 | |||
| 04:58:08 | manuvakery1 | Hi .. if i take an instance snapshot after resizing to a higher flavor the min_disk property it set to the older flavor disk size. Is this a known issue in train? | |
| 05:31:44 | sean-k-mooney | ade_lee: so first bit of feedback is the jobs is not captureing logs form comptue-0 only compute-1 | |
| 05:31:59 | sean-k-mooney | ade_lee: second bit of feedback is this is a know issue | |
| 05:32:10 | sean-k-mooney | 2022-06-27 10:32:42.103 2 ERROR nova.virt.libvirt.driver [-] [instance: 1fb29abc-c443-4404-81df-312b233d05ca] Live Migration failure: End of file while reading data: | |
| 05:32:12 | sean-k-mooney | We trust you have received the usual lecture from the local System | |
| 05:32:14 | sean-k-mooney | Administrator. It usually boils down to these three things: | |
| 05:32:16 | sean-k-mooney | #1) Respect the privacy of others. | |
| 05:32:18 | sean-k-mooney | #2) Think before you type. | |
| 05:32:20 | sean-k-mooney | #3) With great power comes great responsibility. | |
| 05:32:22 | sean-k-mooney | sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper | |
| 05:33:00 | sean-k-mooney | https://bugzilla.redhat.com/show_bug.cgi?id=2089520 | |
| 05:33:53 | sean-k-mooney | and its the same root cause | |
| 05:33:55 | sean-k-mooney | live_migration_uri=qemu+ssh://nova_migration@%s:2022/system?keyfile=/etc/nova/migration/identity&proxy=netcat | |
| 05:34:02 | sean-k-mooney | you are definign ^ | |
| 05:34:32 | sean-k-mooney | the live_migration_uri is depercated and we should not be using it downstream | |
| 05:35:02 | sean-k-mooney | but the actual issus is that that netcat at the ned if forceing netcat to be used in the live migration wrapper | |
| 05:35:52 | sean-k-mooney | so we are taking this if branch instead of the previous one https://github.com/rdo-packages/nova-distgit/blob/rpm-master/nova-migration-wrapper#L73-L75= | |
| 05:36:26 | sean-k-mooney | there are two issues with that first nc is not install and second the sudoers file only allow it to be used if you use the fully qualifed path | |
| 05:37:10 | sean-k-mooney | https://github.com/rdo-packages/nova-distgit/blob/rpm-master/nova_migration-sudoers#L3= | |
| 05:37:44 | sean-k-mooney | if nc was actully installed it might work as the command not found helper might eb trigering the sudo prompt so the patch might not be the problem | |
| 05:37:59 | sean-k-mooney | but the issue is its takign the netcat path | |
| 05:43:40 | sean-k-mooney | https://gitlab.com/libvirt/libvirt/-/blob/65312001bd972df8b7d4f11ea4662aff4889bee5/src/rpc/virnetclient.c#L446-448 | |
| 05:43:45 | sean-k-mooney | this is the relevent libvit code | |
| 05:49:35 | sean-k-mooney | proxy=netcat will not work on 17 we shoudl etierh use auto or force the virt-ssh-helper via the native proxy | |
| 05:49:35 | sean-k-mooney | change the migration uri to proxy=native | |
| 05:56:01 | sean-k-mooney | ade_lee: based on jame's comments and looking at the code this is a puppet-nova bug https://bugzilla.redhat.com/show_bug.cgi?id=2089520#c3 they obviouly never got the memo that using the uri directly has been deprecated since like osp 13 and that netcat was going away in 17 and they needed to stop forcing netcat and use either auto or native or stop generating the uri to let | |
| 05:56:03 | sean-k-mooney | libvirt use the virt-ssh-helper. | |
| 06:00:41 | sean-k-mooney | actully looking at puppet-nova this look liek its a ooo issue | |
| 06:01:43 | kashyap | sean-k-mooney: At least there seems to be upstream bug that says "fix released", but no patch there: https://bugs.launchpad.net/tripleo/+bug/1918250 | |
| 06:02:30 | sean-k-mooney | nice find | |
| 06:02:31 | kashyap | Yep, here it is (it's in Mar 2021): https://review.opendev.org/c/openstack/puppet-tripleo/+/779784/ | |
| 06:02:43 | kashyap | sean-k-mooney: Unrelated: You seem to be quite early up today | |
| 06:02:44 | sean-k-mooney | well | |
| 06:02:59 | sean-k-mooney | that might have been regressed | |
| 06:03:15 | sean-k-mooney | ya i woke up at 5:30 and didnt feel like going back to sleep | |
| 06:03:17 | sean-k-mooney | so i got up | |
| 06:03:18 | kashyap | Is there a new issue? | |
| 06:03:22 | kashyap | (I see) | |
| 06:03:30 | sean-k-mooney | live migration does not work on 17 period | |
| 06:03:42 | sean-k-mooney | well at least not with tls-e config | |
| 06:03:45 | kashyap | Is there a bz link? | |
| 06:03:46 | sean-k-mooney | not sure about with it disabled | |
| 06:04:07 | sean-k-mooney | kashyap: yes ill get it in a sec but the issue is that proxy=netcat is gettign generated in the migration uri | |
| 06:04:23 | frickler | are you sure you are in the right channel? this sounds like rdo talk | |
| 06:04:25 | sean-k-mooney | and netcat is not installed in the container since we should be using the virt-ssh-helper in 17 | |