| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-21 | |||
| 12:13:58 | sean-k-mooney | :) i see it in my inbox ill try and take a look at them this week | |
| 12:14:59 | sean-k-mooney | """This covers the first 4 sub chapters of Proposed Change""" | |
| 12:15:35 | sean-k-mooney | have i said how happy i am that you volenterred to work on this :) | |
| 12:17:19 | gibi | yes you have :) | |
| 12:17:48 | gibi | actually after the initial shock, this batch of patches was a nice coding excersize | |
| 12:24:48 | opendevreview | Rajesh Tailor proposed openstack/nova master: Remove unnecessary if condition https://review.opendev.org/c/openstack/nova/+/844418 | |
| 12:42:18 | bauzas | gibi: sean-k-mooney: sorry, was doing other things, will look above | |
| 12:42:29 | gibi | bauzas: no worries | |
| 12:59:47 | bauzas | sean-k-mooney: thanks for having worked on it, it was an easy peasy | |
| 13:01:08 | sean-k-mooney | yep simple fix | |
| 13:02:35 | bauzas | sean-k-mooney: just -1 because of the try clause https://review.opendev.org/c/openstack/nova/+/847001 | |
| 13:03:14 | sean-k-mooney | i will have to duplicate the try | |
| 13:03:39 | sean-k-mooney | the only place that its not needed for is the schdueler_hints.get | |
| 13:04:26 | sean-k-mooney | i can duplicate it but i think this is cleaner but whatever ye prefer | |
| 13:14:27 | opendevreview | sean mooney proposed openstack/nova master: ignore deleted server groups in validation https://review.opendev.org/c/openstack/nova/+/847001 | |
| 13:14:51 | sean-k-mooney | bauzas: ^ | |
| 13:31:36 | bauzas | sean-k-mooney: +2d with a comment on the relnote (sorry missed it at first look) | |
| 14:04:14 | bauzas | gibi: updated the agenda for today's meeting | |
| 14:04:18 | gibi | bauzas: thanks | |
| 14:04:25 | bauzas | gibi: thanks for chairing it until I arrive | |
| 14:04:46 | bauzas | Uggla: missed to review your patches, yet another day with other prios | |
| 14:19:24 | bauzas | but I'll back around the meeting time | |
| 14:36:20 | opendevreview | Rajesh Tailor proposed openstack/nova master: Remove unnecessary if condition https://review.opendev.org/c/openstack/nova/+/844418 | |
| 14:59:50 | Uggla | bauzas, no pb. | |
| 15:00:19 | Uggla | bauzas, sean-k-mooney, please have a quick look at https://review.opendev.org/c/openstack/nova/+/845581/1/nova/compute/api.py and just tell me what you prefer. Longer code with logs (current version) vs shorter one with less logs (proposed by Gibi). If you prefer Gibi's proposal, I will refactor and you will be able to do the review with an updated version. | |
| 15:02:23 | Uggla | bauzas, sean-k-mooney, gibi can we have a look at https://review.opendev.org/c/openstack/nova-specs/+/833669/7..9/specs/zed/approved/libvirt-virtiofs-attach-manila-shares.rst#b94 to get rid of this point tomorrow morning ? | |
| 15:03:44 | sean-k-mooney | Uggla: i think shorter | |
| 15:03:53 | sean-k-mooney | just looking at https://review.opendev.org/c/openstack/nova/+/845581/1/nova/compute/api.py quickly | |
| 15:04:24 | sean-k-mooney | the orginal code had a lot of repaded logs for the differnt pbrances that i dont think will be helpful | |
| 15:04:40 | Uggla | sean-k-mooney, ok thank you. | |
| 15:05:09 | sean-k-mooney | im not against logs but that seams pretyy verbouse with a lot of repetition | |
| 15:12:20 | sean-k-mooney | bauzas: gibi i think https://review.opendev.org/c/openstack/nova/+/847001/2 might be incomplete | |
| 15:13:06 | sean-k-mooney | i think this happens because while we null out the server_group in teh request_spec | |
| 15:13:18 | sean-k-mooney | we dont remove the group form the hint | |
| 15:13:46 | gibi | Uggla: sure, ping me tomorrow morning to talk that through | |
| 15:14:10 | gibi | sean-k-mooney: ahh, so anther way to solve it would be to remove the hint from the request spec if the group is not found | |
| 15:14:40 | sean-k-mooney | gibi: we proably shoudl do both | |
| 15:14:48 | sean-k-mooney | so catch the instance not found | |
| 15:15:00 | sean-k-mooney | but make sure when the group is deleted we remove it form the schdluer hinits | |
| 15:15:37 | sean-k-mooney | gibi: you found where the group was deleted previously yes you dont happen to have the link to that still? | |
| 15:16:31 | gibi | sean-k-mooney: this is where we detect that that the group is gone https://github.com/openstack/nova/commit/94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1 | |
| 15:17:22 | gibi | sean-k-mooney: this is where the group is deleted in the API https://github.com/openstack/nova/blob/ebe08834f311e8e22bfd9685d7e6e91dab967382/nova/api/openstack/compute/server_groups.py#L145 | |
| 15:17:36 | sean-k-mooney | ya so that sets spec.instace_group to none but does not remvoe the group from the hint | |
| 15:18:06 | sean-k-mooney | so https://github.com/openstack/nova/commit/94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1#diff-8e61e9d80a8e925e5b0a9209a495ba0e4888e9fd81903ed0ab79edcbdb05901dR458 | |
| 15:18:15 | sean-k-mooney | is incomplete | |
| 15:18:36 | gibi | yeah we should extend that | |
| 15:18:44 | gibi | nuke the group hint | |
| 15:18:59 | gibi | as if the group does not exists it will never exesits in the future | |
| 15:19:11 | sean-k-mooney | yep so ill do both and then adress bauzas nit in the reno | |
| 15:19:15 | gibi | ack | |
| 15:20:16 | sean-k-mooney | do you think this need a func test by the way or are you ok with just unit test to repoduce | |
| 15:20:30 | sean-k-mooney | i could create one i guess | |
| 15:20:54 | sean-k-mooney | i was trying to keep it minimal but it proably does not hurt to add one | |
| 15:21:37 | gibi | I dont think it is hard to add an evact func test for this case. So I suggest to have one | |
| 15:24:22 | sean-k-mooney | ya its not cool ill do that so | |
| 15:47:19 | gibi | FYI nova weekly meeting will start in 12 minutes here in the channel | |
| 15:59:36 | opendevmeet | The meeting name has been set to 'nova' | |
| 15:59:36 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 15:59:36 | opendevmeet | Meeting started Tue Jun 21 15:59:36 2022 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 15:59:36 | gibi | #startmeeting nova | |
| 15:59:41 | gibi | chair gibi bauzas | |
| 15:59:44 | opendevmeet | Current chairs: bauzas gibi | |
| 15:59:44 | gibi | #chair gibi bauzas | |
| 16:00:01 | gibi | lets wait a bit before we start | |
| 16:02:06 | elodilles | o/ | |
| 16:02:37 | gibi | OK, lets get started | |
| 16:02:48 | gibi | bauzas asked me to run this as he might be late a bit | |
| 16:02:51 | gibi | #topic Bugs (stuck/critical) | |
| 16:03:02 | gibi | #info One critical bug | |
| 16:03:07 | gibi | #link https://bugs.launchpad.net/nova/+bug/1979047 Centos 9 Stream bug failure | |
| 16:03:22 | gibi | the centos 9 steam job is made non-voting on Friday to unblock the gate | |
| 16:04:52 | gibi | there is some info from tripleooo about the same issue, they pinned libvirt version | |
| 16:04:59 | gibi | should we try to do the same? | |
| 16:06:48 | elodilles | good question o:) is there any other option? :-o | |
| 16:06:57 | gibi | keep it non voting forever? | |
| 16:07:04 | elodilles | :S | |
| 16:07:04 | gibi | :) | |
| 16:07:40 | gibi | we would need somebody who care about this job to propose a fix | |
| 16:08:00 | gibi | I don't see a long line of volunteers | |
| 16:08:01 | gibi | so moving on | |
| 16:08:12 | gibi | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 12 new untriaged bugs (-2 since the last meeting) | |
| 16:08:13 | elodilles | i mean, does it make any difference to pin libvirt compared to keep the job non-voting ? | |
| 16:08:33 | artom | Looks like a libvirt fix is being released, based on https://bugzilla.redhat.com/show_bug.cgi?id=2092856 | |
| 16:08:39 | gibi | elodilles: if we keep non-voting and the libvirt issue is fixed the job will start being green again | |
| 16:08:47 | artom | So maybe just wait for that to land in CS9, and make the job voting again? | |
| 16:08:56 | gibi | artom: yepp, we can do that | |
| 16:09:09 | Uggla | o/ | |
| 16:09:20 | elodilles | ack, then that is the best option for now | |
| 16:09:28 | gibi | ack, seems like we do that as that is easy | |
| 16:09:50 | gibi | so untriaged bug backlog looks healthy thanks melwitt for the triages | |
| 16:10:14 | gibi | #info If you are interested add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:10:22 | gibi | next the baton goes to bauzas | |
| 16:10:29 | gibi | I will ping him when he is back | |
| 16:10:34 | gibi | let's assume he took it :) | |
| 16:10:41 | gibi | #info Next bug baton is passed to bauzas | |
| 16:10:50 | gibi | any other bug you would like to discuss? | |
| 16:11:16 | artom | Not me? Cool then | |
| 16:11:42 | gibi | I think bauzas rescheduled himself as he missed having the baton during the summit | |
| 16:12:00 | gibi | (I'm following bauzas agend from the wiki :) | |
| 16:12:07 | artom | For once it's not my job to figure out the "overwatch" rotation :P | |