| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-16 | |||
| 17:00:12 | gibi | sean-k-mooney: btw, I added the pci inventory reporting to the resource tracker level https://review.opendev.org/c/openstack/nova/+/846187 it does not need to be in the virt layer so I did not force to it | |
| 17:00:14 | artom | Nice | |
| 17:00:27 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843950 | |
| 17:00:28 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843951 | |
| 17:00:29 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843952 | |
| 17:00:30 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844606 | |
| 17:00:31 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844607 | |
| 17:00:33 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: functional: Use tempdir for CONF.instances_path https://review.opendev.org/c/openstack/nova/+/846204 | |
| 17:03:09 | sean-k-mooney | gibi: cool just triaged it as medium since you have repoduced it and there is a workaround | |
| 17:03:18 | gibi | sean-k-mooney: thanks | |
| 17:03:58 | sean-k-mooney | by the way by doing it at the compute manager level that shoudl work for all virt drivers which is nice | |
| 17:04:32 | gibi | yepp that also a + | |
| 17:04:44 | sean-k-mooney | we will likely only test with libvirt but if someone was to test with powervm and it worked they could update the docs | |
| 17:04:56 | gibi | yes | |
| 17:11:40 | opendevreview | Gorka Eguileor proposed openstack/nova master: DNM: Testing memory usage of n-cpu (2/3) https://review.opendev.org/c/openstack/nova/+/846208 | |
| 17:11:40 | opendevreview | Gorka Eguileor proposed openstack/nova master: DNM: Testing memory usage of n-cpu (1/3) https://review.opendev.org/c/openstack/nova/+/846207 | |
| 17:11:41 | opendevreview | Gorka Eguileor proposed openstack/nova master: DNM: Testing memory usage of n-cpu (3/3) https://review.opendev.org/c/openstack/nova/+/846209 | |
| 17:12:03 | geguileo | dansmith: sean-k-mooney ^ Those are the test patches to see if we can figure something out... | |
| 17:12:31 | geguileo | fist is doing nothing, next is trimming malloc memory, last is trimming and setting malloc arenas | |
| 17:14:55 | opendevreview | Gorka Eguileor proposed openstack/nova master: DNM: Testing memory usage of n-cpu (1/3) https://review.opendev.org/c/openstack/nova/+/846207 | |
| 17:14:56 | opendevreview | Gorka Eguileor proposed openstack/nova master: DNM: Testing memory usage of n-cpu (3/3) https://review.opendev.org/c/openstack/nova/+/846209 | |
| 17:14:56 | opendevreview | Gorka Eguileor proposed openstack/nova master: DNM: Testing memory usage of n-cpu (2/3) https://review.opendev.org/c/openstack/nova/+/846208 | |
| 17:16:17 | dansmith | geguileo: I believe no human has ever gotten a zuul config change correct on the first try | |
| 17:20:34 | sean-k-mooney | so you are directly calling into mallac to free memory | |
| 17:20:41 | sean-k-mooney | thats interesting | |
| 17:20:51 | sean-k-mooney | sory forgot the ... | |
| 17:56:26 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: functional: Use tempdir for CONF.instances_path https://review.opendev.org/c/openstack/nova/+/846204 | |
| 17:56:27 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843951 | |
| 17:56:28 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843952 | |
| 17:56:29 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844606 | |
| 17:56:31 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844607 | |
| 18:29:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Report PCI inventory to placement basics https://review.opendev.org/c/openstack/nova/+/846187 | |
| 18:29:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 18:29:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| #openstack-nova - 2022-06-17 | |||
| 03:27:03 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | |
| 03:27:04 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | |
| 04:35:55 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | |
| 04:35:55 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | |
| 07:44:11 | gibi | bauzas, sean-k-mooney: can we get a second opinion on https://review.opendev.org/c/openstack/nova/+/831507/comment/b9fbbb2c_8e65c98e/ about the possible refactor? | |
| 07:47:55 | gibi | Uggla: I don't want to be a heavy handed core but I really don't like the 14 conditionals in the unshelve code | |
| 08:01:25 | Uggla | gibi, hi | |
| 08:02:39 | gibi | o/ | |
| 08:06:07 | Uggla | gibi, ok i'm gonna change in that way. | |
| 08:06:31 | gibi | Uggla: don't rush, I just asked bauzas and sean-k-mooney oppinion about it above | |
| 08:07:14 | Uggla | gibi, I agree that usually having so many conditions is not great. | |
| 08:18:15 | gibi | cores: easy win for a +A (doc patch) https://review.opendev.org/c/openstack/placement/+/845730 | |
| 08:22:45 | gibi | cores: also an easy +A (unit test stabilization) https://review.opendev.org/c/openstack/nova/+/845922 | |
| 08:35:08 | bauzas | gibi: sorry was afk due to some appointment | |
| 08:35:49 | bauzas | Uggla: will try to do the review today | |
| 08:40:15 | Uggla | bauzas, ok | |
| 08:40:30 | bauzas | finishing up my GPU patch | |
| 08:47:29 | bauzas | gibi: do you think we could workaround https://bugs.launchpad.net/nova/+bug/1874664 with some flavor extraspec ? | |
| 08:48:08 | bauzas | it's a placement issue | |
| 08:48:56 | bauzas | if you look at the issue, we try to use the same RP https://paste.opendev.org/show/b9A9TdUl1dzTJaNtbrCd/ | |
| 08:49:53 | bauzas | for both allocations | |
| 09:01:20 | gibi | bauzas: I will check in a minute | |
| 09:05:39 | gibi | bauzas: have you checked that multicreate without vgpu can boot two instance on the same host? (I'm wondering if we do that) | |
| 09:08:38 | bauzas | gibi: good question, I dunno | |
| 09:09:15 | bauzas | gibi: so, my fix I created was using this bug number but I'll then create a separate other | |
| 09:20:36 | gibi | bauzas: I see the limitation | |
| 09:20:39 | gibi | bauzas: it is not placement | |
| 09:20:47 | gibi | bauzas: in that test placement returns 2 allocation candidate | |
| 09:20:55 | gibi | one for each pGPU | |
| 09:21:12 | gibi | but nova only able to consume the first allocation candidate per host | |
| 09:21:55 | gibi | bauzas: https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/scheduler/manager.py#L382-L388 | |
| 09:22:12 | gibi | nova only tries to first a_c, for both instance | |
| 09:22:23 | gibi | *tries to claim the first | |
| 09:22:38 | gibi | it succeeds for the first instance but obviously fails for the second | |
| 09:22:48 | gibi | the TODO from jaypipes is valid | |
| 09:23:24 | gibi | if you resolve that TODO then the test_multiple_instance_create_filling_up_capacity test case will be able to boot both instances on the same host | |
| 09:24:24 | bauzas | gibi: looking | |
| 09:33:09 | bauzas | gibi: thanks for finding the RCA | |
| 09:33:18 | gibi | I think we can implement that TODO | |
| 09:33:34 | gibi | without adding to much complexity with sorting | |
| 09:33:51 | gibi | it would not be optimal but would be better than what we have today | |
| 09:39:14 | gibi | I'm affraid the gate is broken on master | |
| 09:39:16 | gibi | https://zuul.opendev.org/t/openstack/builds?job_name=tempest-integrated-compute-centos-9-stream&skip=0 | |
| 09:40:18 | gibi | libvirt.libvirtError: internal error: unable to execute QEMU command 'netdev_add': File descriptor named '(null)' has not been found | |
| 09:49:07 | bauzas | gibi: what a Friday | |
| 09:49:23 | bauzas | Centos 9 Stream /o\ | |
| 09:49:27 | gibi | bauzas: reported a bug https://bugs.launchpad.net/nova/+bug/1979047 please triage it and set it critical I will drop a mail to the ML | |
| 09:50:49 | bauzas | gibi: we need to make this job non-voting | |
| 09:51:14 | gibi | are we give up on this job? :) | |
| 09:51:49 | bauzas | gibi: the priority is to unblock the gate | |
| 09:52:12 | bauzas | want me to write it ? | |
| 09:53:48 | gibi | I sent a mail to the ML | |
| 09:54:06 | bauzas | I'll propose the patch at least | |
| 09:54:31 | bauzas | we're on a Friday | |
| 09:55:01 | gibi | bauzas: my philosophy: sure unblock the gate in 2-3 days if nobody found a quick solution. but keep the pain a bit around to motivate people to try and find a solution first :) | |
| 09:55:42 | bauzas | gibi: my philosophy: remove support from something which breaks and you'll suddently find people who care | |
| 09:56:31 | bauzas | either way, patch is being forged, we need two cores for approving it, so there is no direct impact *yet* | |
| 09:56:37 | gibi | OK, lets go with yours this time :) | |
| 09:56:50 | gibi | I will +2 the non-voting patch | |
| 10:03:12 | opendevreview | Sylvain Bauza proposed openstack/nova master: zuul: Temporarly put Centos9 Stream job non-voting https://review.opendev.org/c/openstack/nova/+/846292 | |
| 10:03:30 | bauzas | gibi: feel free to add a reply to your email with this patch number | |
| 10:04:57 | opendevreview | Sylvain Bauza proposed openstack/nova master: zuul: Temporarly put Centos9 Stream job non-voting https://review.opendev.org/c/openstack/nova/+/846292 | |
| 10:07:14 | gibi | bauzas: thanks +2. done the ML update | |
| 10:17:53 | gibi | bauzas: the grenade job on master also look baaaad https://zuul.opendev.org/t/openstack/builds?job_name=nova-grenade-multinode&project=openstack%2Fnova&branch=master&skip=0 | |
| 10:18:31 | gibi | that seem to be a different error | |
| 10:18:32 | gibi | Details: {'type': 'SecurityGroupInUse', 'message': 'Security Group 40f249d7-9c4e-432c-91d7-d68ef7ac05b0 in use.', 'detail': ''} | |