| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-16 | |||
| 11:33:03 | sean-k-mooney | openstack and nova in this case genreal requried all contoler process to agre on the db schema | |
| 11:33:47 | jkulik | hm ... yeah, didn't think about those. fair point, that there are definitely commmands that can't go via API | |
| 11:34:01 | sean-k-mooney | the cell info is generaly in the db yes but if you are using templated db/rabbit urls in the db the passwords come form the nova.config | |
| 11:34:32 | jkulik | oh. I didn't know about that possibility | |
| 11:35:12 | sean-k-mooney | https://docs.openstack.org/nova/latest/admin/cells.html#template-urls-in-cell-mappings | |
| 11:35:33 | sean-k-mooney | jkulik: they are optional | |
| 11:35:57 | sean-k-mooney | but they were created to make doing password rotation simplere with config tools like ansible | |
| 11:36:13 | sean-k-mooney | since you just need to update the configs and the passward on the db | |
| 11:36:34 | sean-k-mooney | that and to not store passwords in plain text in the db | |
| 11:36:44 | jkulik | yeah, immediately wondering if we want that, too | |
| 11:36:53 | jkulik | downstream I mean | |
| 11:37:12 | sean-k-mooney | in which downstream | |
| 11:37:35 | jkulik | I mean in our installations of Nova. sorry for the confusing wording | |
| 11:37:39 | sean-k-mooney | tripleo uses it by defualt i think | |
| 11:37:50 | jkulik | we have a helm-chart to deploy Nova | |
| 11:37:56 | sean-k-mooney | ah ok | |
| 11:38:09 | sean-k-mooney | i dont know if openstack ansible or kolla ever addopted it | |
| 11:38:22 | sean-k-mooney | but ya its up to each installer | |
| 11:47:44 | sean-k-mooney | gibi: just because i happen to be looking at the code do you knwo why we dont allwo you to plug in image_types backends using stevador extention points like we do for filteres? | |
| 11:47:57 | sean-k-mooney | i just noticed it was a dict https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/virt/libvirt/imagebackend.py#L1286-L1294= | |
| 11:48:20 | gibi | I think nobody asked for it | |
| 11:48:42 | gibi | also we removed a bunch of extension points in the past | |
| 11:48:47 | gibi | so we might not want to add more | |
| 11:49:07 | gibi | but technically we could add one | |
| 11:49:29 | sean-k-mooney | ya i know proably more then we should have but that would be one way to allow people to play with a bfv backend and protype it. | |
| 11:50:06 | sean-k-mooney | the image ABC is intneded to define the api https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/virt/libvirt/imagebackend.py#L81= | |
| 11:51:08 | sean-k-mooney | gibi: or for example add the ablity to use libvirt sotorage pools. | |
| 11:51:47 | sean-k-mooney | although im relaly not sure how solid that interface actully is | |
| 11:52:09 | gibi | but why this needs to be an extension why cannot be just proposed to nova as a backend? | |
| 11:53:03 | sean-k-mooney | because if its an exstion we can easilly move backend we dont like out of tree | |
| 11:53:41 | sean-k-mooney | but also because it seams liek a nice extion point ot have | |
| 11:53:47 | sean-k-mooney | i was just wondering | |
| 11:56:11 | jrosser_ | sean-k-mooney: OSA uses templated db url but there is a bug we hit https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/nova_db_setup.yml#L58-L87 | |
| 11:56:49 | gibi | extension point has a cost though, we cannot change the API freely | |
| 11:57:15 | gibi | as that might break out of tree extensions | |
| 11:59:53 | sean-k-mooney | yep | |
| 12:47:46 | sean-k-mooney | gibi: by the way its a supper low priortiy right now but if i every get around to updating my black patch to the currnent 79 charater line lenght are you still interested in reviewing it | |
| 12:48:09 | sean-k-mooney | i was just cleaning up some terminals and closed the one i was working on that in | |
| 12:48:25 | sean-k-mooney | well one of them | |
| 12:48:30 | sean-k-mooney | i still have it open in emacs | |
| 12:49:08 | gibi | yes I stil think we should merge it on master with 79 lines | |
| 12:51:05 | sean-k-mooney | oh thats where i put the default chagne stuff | |
| 12:51:25 | sean-k-mooney | i started that in vscode since i was using that to debug the repoducer | |
| 12:51:46 | sean-k-mooney | i spent like 30 mins looking for it in differnt emacs and terminal windows | |
| 12:52:06 | gibi | :D | |
| 12:53:30 | sean-k-mooney | it also does not help that i have 4 copies of nova and i started workign on it in the one i reseve for quickly pulling down patches and testing them locally | |
| 12:53:48 | sean-k-mooney | aka ~/repos/openstack/nova-3 | |
| 12:53:51 | gibi | I started using git worktree so I can track where I my nova checkouts :D | |
| 12:54:01 | gibi | s/I/are/ | |
| 12:54:20 | sean-k-mooney | what is git worktree | |
| 12:54:33 | gibi | you can have multiple working direktory for a single git repo | |
| 12:54:42 | gibi | each directory can have a different version checked out | |
| 12:54:50 | gibi | but all tight to the same local git repo | |
| 12:54:58 | jkulik | loving git worktree for working on multiple things in parallel :) | |
| 12:55:02 | sean-k-mooney | i normally do must of my dev on vms or my server so the local checkouts on my laptop are usually only for pep8/unit tests fixing | |
| 12:55:33 | sean-k-mooney | gibi: oh ok i shoudl look into that | |
| 12:55:43 | sean-k-mooney | similar concept but differnt approch to git-nit | |
| 12:56:49 | sean-k-mooney | commit-ish | |
| 12:56:53 | sean-k-mooney | hehe i like that | |
| 12:57:52 | sean-k-mooney | so i coudl tie my nova-1 nova-2 and nova-3 repos togenter into one nova repo and use those folders as work dirs instead of full repos | |
| 12:58:46 | sean-k-mooney | if im in a git work tree folder and i do git checkout or rebase ectra does it work like a normal repo? | |
| 12:58:55 | sean-k-mooney | but only affecting that workign tree | |
| 12:59:11 | gibi | yes | |
| 12:59:24 | gibi | and you can aways say git worktree list to see where are your workdirs :D | |
| 12:59:26 | sean-k-mooney | ok so i coudl have 2 rebases going on in differnt workign trees | |
| 12:59:33 | gibi | I think so yes | |
| 12:59:39 | sean-k-mooney | cool | |
| 13:00:01 | sean-k-mooney | i dont do that often but sometimes if im pinged to respine X while working on y i will | |
| 13:33:05 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 13:33:05 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 13:33:06 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 13:33:06 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (drivers) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 13:40:58 | opendevreview | sean mooney proposed openstack/nova master: update default numa allocation strategy https://review.opendev.org/c/openstack/nova/+/846169 | |
| 14:28:25 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843678 | |
| 14:28:26 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843702 | |
| 14:28:27 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | |
| 14:28:28 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844594 | |
| 14:28:29 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844595 | |
| 14:53:39 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 14:53:39 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 14:53:40 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 14:53:40 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (drivers) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 15:27:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Report PCI inventory to placement basics https://review.opendev.org/c/openstack/nova/+/846187 | |
| 15:30:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Report PCI inventory to placement basics https://review.opendev.org/c/openstack/nova/+/846187 | |
| 15:51:31 | dansmith | does anyone know of a recentish change to nova that might have inflated n-cpu memory footprint? | |
| 16:00:50 | sean-k-mooney | not that im aware of that has merged | |
| 16:01:43 | sean-k-mooney | dansmith: gibi has a change that adds a trivial cache for speeding up numa toplogy computation | |
| 16:01:48 | sean-k-mooney | but i dont think that has merged | |
| 16:02:08 | sean-k-mooney | dansmith: are you trying to track down a memory increase | |
| 16:02:36 | dansmith | maybe yeah | |
| 16:03:29 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/845896 but its not merged so its not that | |
| 16:04:55 | dansmith | okay, so it's not a regression, or at least, not a recent one | |
| 16:05:13 | dansmith | n-cpu memory usage after a single-node run is ~500m, but after a multinode one, it's 1.5G to 2.5G | |
| 16:05:23 | dansmith | so I wonder if we're buffering something in memory due to live migration or something | |
| 16:05:34 | sean-k-mooney | do you have swap awailable | |
| 16:05:55 | dansmith | what does it matter? it' | |
| 16:06:06 | dansmith | it's not OOMing, we're just noticing it's much larger | |
| 16:07:02 | sean-k-mooney | just tha ti saw high memory usage in the past when swap was disabled | |
| 16:07:11 | sean-k-mooney | that did not happen when it was available | |
| 16:07:23 | sean-k-mooney | but i guess you have the saem config in singel vs multinode | |