| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-15 | |||
| 09:55:16 | sean-k-mooney | but sure | |
| 09:55:30 | sean-k-mooney | lets get the op to test and provide feedback | |
| 10:07:36 | gibi | ack | |
| 10:40:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Optimize numa_fit_instance_to_host https://review.opendev.org/c/openstack/nova/+/845896 | |
| 10:40:11 | gibi | now with reno ^^ | |
| 10:43:31 | opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Fix eventlet.tpool import https://review.opendev.org/c/openstack/nova/+/845838 | |
| 11:02:11 | gibi | bauzas: fyi, reported a new gate failure https://bugs.launchpad.net/nova/+bug/1978817 I will push a fix soo | |
| 11:02:16 | gibi | it is not a blocker | |
| 11:02:26 | gibi | it only fails on slooow nodes | |
| 11:13:11 | sean-k-mooney | gibi other then formating it does not look like much changed in https://review.opendev.org/c/openstack/nova/+/845896/2/nova/tests/unit/virt/test_hardware.py | |
| 11:13:28 | gibi | sean-k-mooney: I needed to add id field for instance cells | |
| 11:13:36 | gibi | (and yes I reformatted it :D) | |
| 11:13:36 | sean-k-mooney | oh just saw that | |
| 11:13:56 | sean-k-mooney | ok ide make sense i guess | |
| 11:14:12 | sean-k-mooney | we need to modle the guest numa node that the object represents | |
| 11:14:26 | sean-k-mooney | and in real code it woudl always be set | |
| 11:14:32 | sean-k-mooney | so you are just fixing the test data | |
| 11:16:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make test_wait_for_instance_event_* test time independent https://review.opendev.org/c/openstack/nova/+/845922 | |
| 11:16:39 | gibi | sean-k-mooney: yepp it is just adding a more realistic test data | |
| 11:17:21 | sean-k-mooney | ok im +2 on that patch assuming zuul is happy this time | |
| 11:17:55 | sean-k-mooney | stephenfin: you proably know that code the best out of the remaining cores would you mind looking at that if you have time | |
| 11:18:18 | sean-k-mooney | if not artom your +1 and bauzas review would be nice | |
| 11:18:55 | gibi | yepp. I also asked for feedback from the bug reporter | |
| 11:47:06 | artom | sean-k-mooney, which one? | |
| 11:52:43 | bauzas | gibi: ack for the gate failure | |
| 11:52:56 | gibi | bauzas: since then I pushed the fix https://review.opendev.org/c/openstack/nova/+/845922 | |
| 11:53:06 | bauzas | just saw it | |
| 11:53:26 | gibi | artom: I think sean-k-mooney refered to the numa scheduling perf optimization fix https://review.opendev.org/c/openstack/nova/+/845896 | |
| 11:53:50 | bauzas | gibi: 1.23 secs, heh | |
| 11:53:59 | bauzas | any reason why this value ? | |
| 11:54:04 | gibi | 123 :) | |
| 11:54:09 | gibi | just a sequence of ints | |
| 12:00:32 | bauzas | could be 0.123 :p | |
| 12:02:37 | gibi | lost opportunity | |
| 12:37:25 | gibi | bauzas: finally I understood your comment. see the response in https://review.opendev.org/c/openstack/nova/+/845922/1#message-84ed99281b79342e03258fde3778208610868563 | |
| 12:38:32 | bauzas | gibi: sorry yeah, I understood this was a returned value of a mock | |
| 12:38:52 | gibi | so there is no delay in the test | |
| 12:39:07 | bauzas | yeah I was wrong when commenting | |
| 12:40:59 | gibi | no worries | |
| 13:06:53 | opendevreview | Merged openstack/nova stable/yoga: Simulate bug 1969496 https://review.opendev.org/c/openstack/nova/+/840832 | |
| 14:07:45 | opendevreview | norman shen proposed openstack/nova master: Clear connection info if vol disconnected https://review.opendev.org/c/openstack/nova/+/845995 | |
| 14:07:46 | sean-k-mooney | artom: yes i was refering to https://review.opendev.org/c/openstack/nova/+/845896 | |
| 14:10:07 | opendevreview | Merged openstack/nova stable/train: Only allow one scheduler service in tests https://review.opendev.org/c/openstack/nova/+/751362 | |
| 14:10:14 | opendevreview | Merged openstack/nova stable/train: func tests: move _run_periodics() into base class https://review.opendev.org/c/openstack/nova/+/751363 | |
| 14:10:22 | opendevreview | Merged openstack/nova stable/train: Helper to start computes with different HostInfos https://review.opendev.org/c/openstack/nova/+/751364 | |
| 14:10:30 | opendevreview | Merged openstack/nova stable/train: tests: Add reproducer for bug #1879878 https://review.opendev.org/c/openstack/nova/+/751365 | |
| 14:10:36 | opendevreview | Merged openstack/nova stable/train: Add generic reproducer for bug #1879878 https://review.opendev.org/c/openstack/nova/+/751366 | |
| 14:19:00 | gibi | sean-k-mooney: one hickup in the pci-tracking work: update_provider_tree is the place to report resources BUT [pci]device_spec and the whole pci tracking lives outside of the virt driver. So either we need to report PCI devs to placement ouside of update_provider_tree along with the pci tracker OR do the reporting in update_provider tree and duplicate [pci]device_spec handling in the libvirt driver | |
| 14:20:20 | gibi | I can start building up things in the libvirt driver and see if the disconnect with the pci manager causes any issues | |
| 14:20:28 | sean-k-mooney | not realy | |
| 14:20:42 | sean-k-mooney | we already hae access tot he pci tracker form in that fuction | |
| 14:20:49 | sean-k-mooney | we just neede to read the info form it | |
| 14:21:02 | gibi | we see the pci tracker in update_provider_tree? | |
| 14:21:14 | sean-k-mooney | its aviable via the resouce tracker | |
| 14:22:24 | gibi | do we have access to the resource tracker from the libvirt driver? | |
| 14:22:28 | gibi | I dont see it | |
| 14:22:40 | sean-k-mooney | we should | |
| 14:23:20 | gibi | so the tracker calls the virt driver to update the resource inventories but the tracker is not passed down to the driver | |
| 14:24:17 | gibi | as far as I see | |
| 14:25:22 | sean-k-mooney | hum | |
| 14:25:31 | sean-k-mooney | can we just pass it in | |
| 14:25:56 | sean-k-mooney | i dont like the idea of duplicating the logic in the driver | |
| 14:27:14 | sean-k-mooney | these are the two main places we care about correct https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L9244= | |
| 14:28:27 | gibi | https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/virt/libvirt/driver.py#L8530 | |
| 14:28:44 | gibi | we need to report the inventories in update_provider_tree | |
| 14:29:30 | sean-k-mooney | sorry wrong link https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/compute/resource_tracker.py#L1221-L1232= | |
| 14:32:37 | gibi | sean-k-mooney: so you suggest to pass down the pci_tracker to the update_provider_tree? | |
| 14:35:00 | sean-k-mooney | yep | |
| 14:35:19 | sean-k-mooney | can catch the not implemted error and invoke without it if the driver does nto support it for one release | |
| 14:35:21 | sean-k-mooney | with a fixme | |
| 14:35:28 | sean-k-mooney | so that we dont rbeak out of tree drivers | |
| 14:35:52 | sean-k-mooney | for pci in placment we only are adding supprot for libvirt for now | |
| 14:36:00 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/845748 | |
| 14:36:13 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/845753 | |
| 14:36:31 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/845754 | |
| 14:38:46 | sean-k-mooney | gibi: do you think that passing it down or a subset of data form it woudl be problematic | |
| 14:39:24 | gibi | it is different than the other resources like CPU of VGPU | |
| 14:39:29 | sean-k-mooney | gibi: the stat pools woudl be all we need | |
| 14:39:59 | sean-k-mooney | well the other way to do it si to import the code form the pci module | |
| 14:40:04 | sean-k-mooney | and filter the list of pci device with it | |
| 14:40:15 | sean-k-mooney | and thel look at all the instnace and there pci usage | |
| 14:40:23 | gibi | we are moving logic around a virt driver boundary so I'm affraid | |
| 14:40:43 | sean-k-mooney | actully for placment | |
| 14:41:08 | sean-k-mooney | we only need to know the set of pci devices and the whitelist | |
| 14:41:35 | sean-k-mooney | but i would be unfortable with using the current set form libvirt as if its passed into a guest i dont know if that will still be in the data form libvirt | |
| 14:42:08 | sean-k-mooney | its also more work to recompute it so i would be much more comfortabel geting the data form the pci tracker | |
| 14:42:16 | frickler | nova is running nova-live-migration-ceph and tempest-integrated-compute-centos-8-stream as non-voting jobs in gate, can someone have a look and clean that up? https://review.opendev.org/840833 | |
| 14:42:58 | frickler | (just noticed because both are failing and I was worried about "my" patch queued behind it) | |
| 14:42:59 | gibi | sean-k-mooney: I will look into passing the pci tracker down to the virt driver but I feel bad about it architecturally | |
| 14:43:17 | sean-k-mooney | well you have anohter option | |
| 14:43:28 | sean-k-mooney | wich is to implemnt this part of the update in the compute manager | |
| 14:44:22 | gibi | that would duplicate the reshape logic :/ | |
| 14:44:40 | gibi | ideally I would like to have all the similar thing is the same place | |
| 14:44:50 | gibi | so if GPU is handled in the virt driver level then PCI should be too | |
| 14:45:13 | gibi | but I'm not sure why we have a pci tracker in the manager level instead of in the virt level | |
| 14:45:32 | gibi | I mean I know a lot of reasons but I probably don't know all of them | |
| 14:45:45 | gibi | so moving the pci tracker down to the virt level is scary | |
| 14:45:57 | gibi | just passing it down will create coupling that is scary too | |
| 14:46:10 | gibi | <can I rewrite nova, please?> | |
| 14:47:12 | sean-k-mooney | well vGPU shoudl not be where it si now | |