| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-13 | |||
| 13:45:33 | fungi | if you want to propose that addition, you can push a change for our image builds here: https://opendev.org/opendev/system-config/src/branch/master/docker/etherpad/Dockerfile#L33 | |
| 13:45:43 | fungi | looks like it's already in the commented-out example even? | |
| 13:46:55 | sean-k-mooney | im not sure if that plugin disables it outright or just the keybind or if its configurable | |
| 13:47:00 | sean-k-mooney | just llook at the source now | |
| 13:47:50 | sean-k-mooney | https://github.com/ether/ep_disable_reset_authorship_colours/blob/main/static/js/disable_reset_authorship_colours.js looks like its just hiding the button | |
| 13:47:55 | sean-k-mooney | so that wont actully help | |
| 13:48:45 | sean-k-mooney | but ya good to know we can look into it sometime | |
| 15:14:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 15:19:26 | bauzas | gibi: sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/829248 got a second +2 with comments | |
| 15:19:33 | bauzas | nothing urgent to read, just left some notes | |
| 15:19:49 | bauzas | honestly, this was hard to review in terms of testing modifications | |
| 15:20:01 | bauzas | the patch in question is simple, but the impact is larged | |
| 15:20:03 | bauzas | large | |
| 15:20:11 | bauzas | but I trust you both | |
| 15:21:40 | sean-k-mooney | ack ill read over them after our downstream call | |
| 15:21:54 | bauzas | those are mostly bikeshed comments | |
| 15:22:07 | bauzas | not requiring a rebased | |
| 15:52:04 | gibi | bauzas: I read through your comments. I replied to them. I don't think anything needs to be changed with the patch per se. If you insist on some of the comments the please do and I will push a follow up patch | |
| 15:52:31 | bauzas | gibi: cool, wasn't an ask | |
| 15:52:41 | gibi | coolio | |
| 15:52:44 | gibi | thanks for the review | |
| 15:52:58 | bauzas | I'll click the submit button | |
| 15:53:50 | gibi | thanks | |
| 16:06:35 | bauzas | sent to the gate | |
| 16:09:25 | gibi | \o/ | |
| 16:12:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 17:04:02 | opendevreview | Artom Lifshitz proposed openstack/nova master: libvirt: remove default cputune shares value https://review.opendev.org/c/openstack/nova/+/824048 | |
| 17:04:08 | artom | sean-k-mooney, ^^ | |
| 17:25:16 | opendevreview | Merged openstack/nova master: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/829248 | |
| 17:37:01 | sean-k-mooney | artom: comments inline | |
| 17:37:57 | artom | sean-k-mooney, fair point on the partial | |
| 17:50:49 | sean-k-mooney | i think im ok with the patch over all but i want to see the ci result to see if libvirt is ok with the empty cputune element | |
| 17:51:35 | sean-k-mooney | i woudl prefer if we did not set it if it had not atributes or child elements but if libvirt does not care then we proably could proceed as you currently have it | |
| 17:51:57 | sean-k-mooney | i would like to look at the other quotas however and see if there are other we set by defualt like this | |
| 17:52:04 | sean-k-mooney | i dont think we do but we shoudl check | |
| 17:52:43 | artom | Yeah, I didn't check with a real libvirt for an empty cputune | |
| 17:53:51 | sean-k-mooney | ok ill check back on the zuul resulst tomorrow o/ | |
| 18:06:18 | elodilles | erlon bauzas : we can discuss on tomorrow's nova meeting if we want to wait for any patch or can release these >>> https://review.opendev.org/q/project:openstack/releases+is:open+intopic:nova | |
| 18:07:41 | erlon | hey elodilles, sure. thanks for creating the release patches | |
| 18:08:18 | elodilles | np | |
| 18:08:56 | elodilles | sean-k-mooney: fyi, too ^^^ | |
| 20:36:04 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 22:53:53 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| #openstack-nova - 2022-06-14 | |||
| 02:41:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to require mulitpathd for volume attachment https://review.opendev.org/c/openstack/nova/+/845660 | |
| 02:43:18 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to require mulitpathd for volume attachment https://review.opendev.org/c/openstack/nova/+/845660 | |
| 02:46:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to require mulitpathd for volume attachment https://review.opendev.org/c/openstack/nova/+/845660 | |
| 03:26:29 | opendevreview | Merged openstack/nova stable/xena: Fix eventlet.tpool import https://review.opendev.org/c/openstack/nova/+/840733 | |
| 03:26:35 | opendevreview | Merged openstack/nova stable/xena: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/829433 | |
| 04:07:49 | opendevreview | Merged openstack/nova stable/yoga: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/840732 | |
| 04:07:55 | opendevreview | Merged openstack/nova stable/yoga: Isolate PCI tracker unit tests https://review.opendev.org/c/openstack/nova/+/840830 | |
| 04:22:43 | opendevreview | Merged openstack/nova stable/yoga: Remove unavailable but not reported PCI devices at startup https://review.opendev.org/c/openstack/nova/+/840831 | |
| 04:24:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to require mulitpathd for volume attachment https://review.opendev.org/c/openstack/nova/+/845660 | |
| 04:26:24 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to require mulitpathd for volume attachment https://review.opendev.org/c/openstack/nova/+/845660 | |
| 04:35:13 | opendevreview | Merged openstack/nova stable/wallaby: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811809 | |
| 06:45:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to require mulitpathd for volume attachment https://review.opendev.org/c/openstack/nova/+/845660 | |
| 07:32:55 | gibi | good morning | |
| 07:47:35 | bauzas | good morning | |
| 07:54:18 | gibi | sean-k-mooney, artom: I have concerns in https://review.opendev.org/c/openstack/nova/+/824048 | |
| 08:34:36 | bauzas | gibi: following the discussion we had last week about VGPU allocations https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8203-L8206 | |
| 08:37:18 | bauzas | https://images.squarespace-cdn.com/content/518f5d62e4b075248d6a3f90/1385326046909-827X09Z2RML6LYHWQBVI/git-blame2.jpg?format=1500w&content-type=image%2Fjpeg | |
| 08:42:50 | gibi | bauzas: ahh, it was wishfull thingkin | |
| 08:42:55 | gibi | thinking | |
| 08:43:13 | bauzas | gibi: I just wrote a quick functest and this is weird | |
| 08:43:23 | bauzas | I asked for VGPU=2 and I got only one allocation | |
| 08:43:31 | bauzas | so I need to dig into the code | |
| 08:43:50 | gibi | one allocation of two vgpus from the same pgpu? | |
| 08:44:13 | bauzas | just a plain simple flavor with resources:VGPU=µ2 | |
| 08:44:13 | bauzas | just a plain simple flavor with resources:VGPU=µ2 | |
| 08:44:45 | bauzas | which should have created a single allocation of VGPU=2 | |
| 08:44:56 | bauzas | when arriving before the above code | |
| 08:45:04 | bauzas | against one single RP | |
| 08:45:09 | gibi | yepp placement does not split allocation against a single RC between RPs | |
| 08:45:26 | bauzas | but I don't know why when I introspect, I see : | |
| 08:45:34 | bauzas | {'1df35fc7-41f4-4ef4-b995-7fd561c6a391': {'resources': {'VGPU': 1}}} | |
| 08:45:34 | bauzas | (Pdb) vgpu_allocations | |
| 08:45:39 | gibi | ohh, that is strange | |
| 08:45:46 | bauzas | yeah | |
| 08:45:46 | gibi | you should have 2 in the allocation | |
| 08:45:49 | bauzas | correct | |
| 08:46:01 | gibi | but then you have a nice problem to debug :) | |
| 08:46:14 | bauzas | I'm checking the max limit of the inventory | |
| 08:46:27 | bauzas | that could be the reason | |
| 08:46:47 | bauzas | if we cap to 1, then there are no ways to create an allocation of 2 | |
| 08:46:58 | bauzas | but... the scheduler should have failed, right? | |
| 08:47:01 | gibi | but then you should get no allocation candidates | |
| 08:47:05 | bauzas | yeah that | |
| 08:47:40 | bauzas | something got messed somewhere and I still need to investigate whether this is just a fixture issue | |
| 08:48:00 | gibi | do you have the placement log from the a_c query? | |
| 08:48:26 | gibi | does nova requested 1 VGPU in the a_c query? | |
| 08:49:31 | bauzas | I'll set the DEBUG level | |
| 08:50:55 | bauzas | shit OS_DEBUG=1 doesn't seem to work with functional tests | |
| 08:51:37 | gibi | bauzas: yep it does not, I was not able to track that down last time | |
| 08:52:00 | bauzas | pdb'ing a bit further down then | |
| 08:52:16 | bauzas | anyway, looks like a nice bone to snag | |
| 08:53:01 | bauzas | oh f*** | |
| 08:53:03 | bauzas | forget | |
| 08:53:08 | bauzas | it's PEBKAC | |
| 08:53:44 | bauzas | I wrote stupid code | |
| 08:54:07 | bauzas | https://paste.opendev.org/show/bgjrdJhdinSqXXIY6EWm/ | |
| 08:55:20 | bauzas | way better now this is fixed | |