| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-03 | |||
| 16:33:02 | sean-k-mooney | melwitt: by the way on later branches there are zuul rules to do this | |
| 16:33:49 | melwitt | sean-k-mooney: oh nice | |
| 16:33:52 | sean-k-mooney | https://github.com/SeanMooney/ansible_role_devstack/blob/master/ansible/deploy_multinode_devstack.yaml#L133-L136= | |
| 16:33:59 | sean-k-mooney | sync-controller-ceph-conf-and-keys, | |
| 16:34:57 | sean-k-mooney | https://github.com/openstack/devstack/tree/master/roles/sync-controller-ceph-conf-and-keys | |
| 16:35:01 | sean-k-mooney | actully its in devstack | |
| 16:35:57 | sean-k-mooney | im kind of confused why we are donign this in hte gate hook | |
| 16:36:02 | gibi | sean-k-mooney: I promised to reject the devname case in the new codepath, for that I need to spearate out the devname handling codepath from the current parsing | |
| 16:36:49 | sean-k-mooney | am not really you jus need to check if the whitelist containds devname | |
| 16:37:19 | sean-k-mooney | gibi: if you realy wanted too you could also punt on that for this cycle | |
| 16:37:20 | gibi | yepp that does not allows removing that devname codepath from the complexity picture | |
| 16:37:46 | sean-k-mooney | well devname does not realy change anything for the rest of the spec or code | |
| 16:37:48 | gibi | I just add the guard condition, but the code below will still depend on devname | |
| 16:38:06 | gibi | so the code below will as today, complex, uggly, :/ | |
| 16:38:08 | sean-k-mooney | yep but that wont affect tracking the dvices in placment | |
| 16:38:15 | gibi | and I just pile on that with the guard | |
| 16:38:29 | gibi | I don't like piling on hard to comprehend code | |
| 16:38:41 | sean-k-mooney | what im saying is if you dont feel like you will have time to adress the devname part | |
| 16:38:51 | sean-k-mooney | we could put that out os scope fo the spec an come back to it | |
| 16:38:54 | sean-k-mooney | after | |
| 16:39:16 | sean-k-mooney | i.e. we can deprecate and remove it later | |
| 16:40:07 | gibi | yeah I got you. But I feel that this is a good change to clean it up. I don't know when will be the next time we come back to this | |
| 16:41:34 | sean-k-mooney | yep it certenly is | |
| 16:42:28 | sean-k-mooney | next time would proably be either when we make this on by default or add support for neutron prots | |
| 16:42:56 | sean-k-mooney | you are right that we likely wont just go clean tthis up if its not in aide of something else | |
| 16:43:29 | gibi | yepp | |
| 16:46:05 | sean-k-mooney | melwitt: by the way im really confused why the hook works the way it does | |
| 16:47:05 | sean-k-mooney | like we are runnign devstack on all the noes anyway so im not sure why se need the gate hook to reach out to all the other subnodes and execute command on them to deploy ceph | |
| 16:47:24 | sean-k-mooney | you know instead of just runign the ceph plugin as part of the devstack run on thsoe nodes | |
| 16:48:22 | sean-k-mooney | melwitt: we are using the shell module elsewhere in the file by the way | |
| 16:48:24 | sean-k-mooney | https://github.com/openstack/nova/blob/stable/train/gate/live_migration/hooks/ceph.sh#L62 | |
| 16:49:12 | sean-k-mooney | melwitt: just in case your wondering the fist thing after $ansible is the inventory group | |
| 16:49:14 | sean-k-mooney | $ANSIBLE subnodes --become -f 5 -i "$WORKSPACE/inventory" -m raw -a "executable=/bin/bash | |
| 16:49:36 | sean-k-mooney | so this is runnign the scrip on all the hosts in the subnodes group wich is jut the compute node | |
| 16:50:13 | sean-k-mooney | so ANSIBLE subnodes --become -f 5 -i "$WORKSPACE/inventory" -m shell -a "... would be the same | |
| 16:51:58 | sean-k-mooney | because this is using "" not '' $BASE is evaulatedin the context fo prepare_ceph too | |
| 16:52:00 | sean-k-mooney | https://github.com/openstack/nova/blob/stable/train/gate/live_migration/hooks/ceph.sh#L10-L17= | |
| 16:52:14 | sean-k-mooney | which i dont know if that was inteded or not | |
| 16:52:32 | sean-k-mooney | i guess so as it woud not otherwise be defiend | |
| 16:53:00 | sean-k-mooney | anyway i think im going to call it a day if you want me to take a look at this on monday then i can | |
| 16:54:26 | melwitt | sean-k-mooney: thank you for all the hints | |
| 17:21:19 | opendevreview | melanie witt proposed openstack/nova stable/train: DNM Testing for ceph setup gate fail https://review.opendev.org/c/openstack/nova/+/844530 | |
| 17:33:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565 | |
| 17:33:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491 | |
| 17:33:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: test remote managed dev spec with wildcard address https://review.opendev.org/c/openstack/nova/+/844626 | |
| 17:33:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec https://review.opendev.org/c/openstack/nova/+/844625 | |
| 17:33:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: More comment in the code https://review.opendev.org/c/openstack/nova/+/844628 | |
| 17:33:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 19:14:47 | opendevreview | Merged openstack/nova stable/yoga: Add missing condition https://review.opendev.org/c/openstack/nova/+/843820 | |
| #openstack-nova - 2022-06-04 | |||
| 05:55:30 | opendevreview | melanie witt proposed openstack/nova stable/train: [stable-only] Use 'shell' ansible module to setup ceph https://review.opendev.org/c/openstack/nova/+/844530 | |
| 05:56:35 | opendevreview | melanie witt proposed openstack/nova stable/train: [stable-only] Use 'shell' ansible module to setup ceph https://review.opendev.org/c/openstack/nova/+/844530 | |
| 05:58:42 | opendevreview | melanie witt proposed openstack/nova stable/train: [stable-only] Use 'shell' ansible module to setup ceph https://review.opendev.org/c/openstack/nova/+/844530 | |
| 07:04:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec https://review.opendev.org/c/openstack/nova/+/844625 | |
| 07:04:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491 | |
| 07:04:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: test remote managed dev spec with wildcard address https://review.opendev.org/c/openstack/nova/+/844626 | |
| 07:04:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress https://review.opendev.org/c/openstack/nova/+/844628 | |
| 07:04:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565 | |
| 07:04:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 07:47:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extra tests for remote managed dev spec https://review.opendev.org/c/openstack/nova/+/844626 | |
| 07:47:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565 | |
| 07:47:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491 | |
| 07:47:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via os.path.isdir in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 07:47:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress https://review.opendev.org/c/openstack/nova/+/844628 | |
| 07:52:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via os.path.isdir in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 08:19:59 | opendevreview | Merged openstack/nova stable/wallaby: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/811808 | |
| 17:48:50 | opendevreview | Ade Lee proposed openstack/nova master: Test setting the nova job to centos-9-stream https://review.opendev.org/c/openstack/nova/+/831844 | |
| 23:36:32 | opendevreview | Wenping Song proposed openstack/nova master: filter host by switch https://review.opendev.org/c/openstack/nova/+/844706 | |
| #openstack-nova - 2022-06-05 | |||
| 01:05:22 | opendevreview | Jorhson Deng proposed openstack/nova master: Reset the instance's task_state to None when the status is error https://review.opendev.org/c/openstack/nova/+/838991 | |
| 01:37:01 | opendevreview | Wenping Song proposed openstack/nova master: Fix the exception message for duplicate pgpu addresses https://review.opendev.org/c/openstack/nova/+/844716 | |
| 07:35:56 | opendevreview | Wenping Song proposed openstack/nova master: Remove mdev when delete vm https://review.opendev.org/c/openstack/nova/+/844739 | |
| 16:59:56 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843958 | |
| 16:59:57 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843959 | |
| 16:59:58 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843960 | |
| 16:59:59 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: tests: work around malformed serial XML https://review.opendev.org/c/openstack/nova/+/844743 | |
| 17:00:01 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844744 | |
| 17:00:03 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests https://review.opendev.org/c/openstack/nova/+/844745 | |
| 17:00:05 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844746 | |
| 19:58:14 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843959 | |
| 19:58:15 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843960 | |
| 19:58:16 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844744 | |
| 19:58:17 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests https://review.opendev.org/c/openstack/nova/+/844745 | |
| 19:58:19 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844746 | |
| 19:58:21 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: functional: Use tempdir for CONF.instances_path https://review.opendev.org/c/openstack/nova/+/844750 | |
| 21:13:12 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests https://review.opendev.org/c/openstack/nova/+/844745 | |
| 21:13:13 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844746 | |
| 23:36:10 | opendevreview | Takashi Kajinami proposed openstack/nova stable/wallaby: Clean up allocations left by evacuation when deleting service https://review.opendev.org/c/openstack/nova/+/844753 | |
| #openstack-nova - 2022-06-06 | |||
| 01:45:29 | opendevreview | Merged openstack/osc-placement master: Change minversion of tox to 3.18.0 https://review.opendev.org/c/openstack/osc-placement/+/791972 | |
| 14:38:51 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843959 | |
| 14:38:52 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843960 | |
| 14:38:53 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844744 | |
| 14:38:54 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests https://review.opendev.org/c/openstack/nova/+/844745 | |
| 14:38:55 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844746 | |
| 15:12:40 | kashyap | dansmith: I wonder if that QEMU SIGSEGV was triggerred again w/ your coredump patch in place now | |
| 15:13:00 | dansmith | kashyap: it hasn't landed yet due to other gate fails, | |
| 15:13:15 | dansmith | but so far we haven't seen it occur again on patches that depend on it | |
| 15:13:18 | kashyap | Ah, yeah; saw that this morning. I naively assumed by now it must've merged | |
| 15:13:26 | dansmith | which is weird because it was 100% fail for a few days | |
| 15:13:41 | kashyap | Heh, as you said, Heisenbug from hell | |
| 15:15:49 | dansmith | yeah :/ | |
| 15:33:59 | opendevreview | Takashi Kajinami proposed openstack/placement master: doc: Comment out language option https://review.opendev.org/c/openstack/placement/+/844855 | |