| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-30 | |||
| 18:20:19 | elodilles | sean-k-mooney: probably because in the past only stable-maint group audited everyone before adding them to a <project>-stable-maint group | |
| 18:20:24 | sean-k-mooney | elodilles: i can add and remove member to nova-core | |
| 18:20:42 | sean-k-mooney | so there is defintly a delta in the config | |
| 18:20:49 | elodilles | sean-k-mooney: but anyway, now it is said to be managed by the teams themselves | |
| 18:21:25 | sean-k-mooney | elodilles: ya the audit log setction is there for me in nova-core | |
| 18:21:27 | sean-k-mooney | https://review.opendev.org/admin/groups/54f6a1ec13b7453596635e8708f1b60bfd281ebd,audit-log | |
| 18:21:49 | sean-k-mooney | but not in nova-stable-maint | |
| 18:21:51 | elodilles | gibi: dooooooooon't :-o be careful :) and read the policy (or ask) if something is not clear :D | |
| 18:21:55 | sean-k-mooney | so that might be the differnce | |
| 18:22:42 | gibi | elodilles: sure ;) | |
| 18:23:08 | sean-k-mooney | elodilles: im sure we will still lean hevaly on your guidance in these matters | |
| 18:23:54 | sean-k-mooney | although as i siad downstream a few minutes ago, a doc review i was doing used all of my free brain power so im goign to call it a day | |
| 18:23:55 | sean-k-mooney | o/ | |
| 18:24:11 | elodilles | sean-k-mooney: o:) thanks :) i'll try to help :) | |
| 18:24:27 | elodilles | sean-k-mooney: have a nice evening! o/ | |
| 18:25:50 | elodilles | bauzas: i've also removed Matt and Lee as you wanted | |
| 18:33:51 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843947 | |
| 18:33:52 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843948 | |
| 18:33:53 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843949 | |
| 18:36:57 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843947 | |
| 18:36:58 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843948 | |
| 18:36:59 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843949 | |
| 18:38:23 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843950 | |
| 18:38:24 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843951 | |
| 18:38:25 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843952 | |
| 20:25:39 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843958 | |
| 20:25:40 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843959 | |
| 20:25:41 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843960 | |
| 20:49:40 | mloza1 | hello, how can I tell if a VM created in to a specific AZ? | |
| 21:24:30 | opendevreview | Merged openstack/os-vif master: Change minversion of tox to 3.18.0 https://review.opendev.org/c/openstack/os-vif/+/791970 | |
| #openstack-nova - 2022-05-31 | |||
| 07:37:30 | gibi | bauzas: o/ There is a good chance that I have to be away from the keyboard during the team meeting today | |
| 08:07:07 | gibi | stephenfin, sean-k-mooney[m]: your view would me much appreciated here https://review.opendev.org/c/openstack/nova/+/843443/1#message-ac73126bbaa46cbbccdccb15c4c6d28358a328fc | |
| 08:16:26 | bauzas | elodilles: thanks for the nova-stable-maint additions ;) | |
| 08:16:59 | bauzas | gibi: ack, no worries | |
| 08:28:16 | elodilles | bauzas: np :) | |
| 09:48:50 | sean-k-mooney2 | gibi: ah the autopep8 change. i intentionally did not put it in test-reqirements since others experessed that they wanted ti to be optional and not require autopep8 | |
| 09:49:11 | sean-k-mooney | am | |
| 09:49:18 | sean-k-mooney | so we could do as you suggest | |
| 09:49:23 | sean-k-mooney | and move it there and pin | |
| 09:49:30 | gibi | I affraid that we start listing deps in different palces | |
| 09:49:31 | gibi | places | |
| 09:49:37 | sean-k-mooney | or we could add it to global requirements and pin in upper-constraits | |
| 09:49:58 | sean-k-mooney | gibi: now that devestack does not install test-requiremetns | |
| 09:50:00 | gibi | I don't know if we track test only requirements in global | |
| 09:50:10 | sean-k-mooney | its less of an issue with me to do that | |
| 09:50:19 | sean-k-mooney | gibi: we have flake8 i think | |
| 09:50:43 | sean-k-mooney | and pytest | |
| 09:50:57 | gibi | noe flake is not in global but pytest is in global | |
| 09:50:59 | sean-k-mooney | gibi: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L396= | |
| 09:51:23 | gibi | ohh cool | |
| 09:51:25 | sean-k-mooney | so ya we have a section for test tools | |
| 09:51:30 | gibi | then I would like to track autopep8 in global | |
| 09:51:47 | sean-k-mooney | would you like me to add it with a patch | |
| 09:51:52 | gibi | I can do it | |
| 09:52:02 | gibi | I just wanted to make an agreement first | |
| 09:52:16 | sean-k-mooney | ok i think that will be better longterm | |
| 09:52:26 | gibi | yepp | |
| 09:52:48 | sean-k-mooney | by the way on a related not stephenfin made an intersting point on the mailing list | |
| 09:53:08 | sean-k-mooney | apprently we can now tell git blame to ignore commits | |
| 09:53:31 | sean-k-mooney | so if i was to push a ptach to pre-commit normalis all the quotes for example | |
| 09:53:35 | gibi | yepp I saw. I still think it will be a big debate to blackify nova | |
| 09:53:39 | sean-k-mooney | we can tell git blame to ignore that | |
| 09:53:51 | sean-k-mooney | oh i was not plannign to add black | |
| 09:54:03 | sean-k-mooney | jus ta few more pre-comit hooks | |
| 09:54:32 | sean-k-mooney | using black is an option i guess but i wanteed to avoid the linelenth debate | |
| 09:54:44 | gibi | I'm a bit of all or nothing. as any normalization gives us the backport conflict so why not then do all the normalization at once | |
| 09:54:53 | sean-k-mooney | and just make some small imporvements | |
| 09:54:58 | gibi | black handles linelegth | |
| 09:55:07 | gibi | you can ask it to restrict to 79 | |
| 09:55:08 | sean-k-mooney | i would like to do all | |
| 09:55:24 | sean-k-mooney | i really really wish we had auto code formating | |
| 09:55:33 | gibi | [default: 88] | |
| 09:55:33 | gibi | -l, --line-length INTEGER How many characters per line to allow. | |
| 09:55:45 | gibi | what an insteresting default :) | |
| 09:55:48 | sean-k-mooney | but i dont want to break people's workflow just for my comfort | |
| 09:56:04 | sean-k-mooney | gibi: there was an articl on why that was chosen i think | |
| 09:56:22 | sean-k-mooney | gibi: the issue is i dont think there is currently a way to set that in a file | |
| 09:56:23 | gibi | yeah now that you said it | |
| 09:57:18 | sean-k-mooney | oh the other hand i think have autoformating using any tool woudl improve new contibutor experince | |
| 09:57:23 | sean-k-mooney | and all our live in the long run | |
| 09:57:27 | gibi | I totally agree | |
| 09:57:44 | gibi | I just want a single commit to reformat everything with a tool and then forget about it | |
| 09:58:02 | gibi | gradual change will mean a lot of commit to ignore later | |
| 09:58:57 | sean-k-mooney | yep same | |
| 09:59:03 | sean-k-mooney | also https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length | |
| 09:59:20 | sean-k-mooney | apprently it now follow the flak8 max-line-lenth | |
| 09:59:25 | sean-k-mooney | which was missing for so long | |
| 09:59:53 | gibi | I still use https://github.com/gibizer/zuul-log-search/blob/main/tox.ini#L30 | |
| 10:00:20 | sean-k-mooney | yep we coudl do that but the disadvantage is | |
| 10:00:24 | sean-k-mooney | it wont work for ides | |
| 10:00:28 | sean-k-mooney | like vscode | |
| 10:00:58 | sean-k-mooney | im using nano/emacs so not an issue for me personally i would be runnign black with precommit | |
| 10:01:25 | sean-k-mooney | but ya go eat. i can wip up a patch if we want to consider it | |
| 10:01:38 | sean-k-mooney | im not really show how it would look | |
| 10:01:56 | gibi | ack | |
| 11:43:08 | stephenfin | gibi: sean-k-mooney: If you do normalization, I see no reason not to apply that normalization to stable branches also | |
| 11:43:29 | sean-k-mooney | hum we coudl i guess | |
| 11:43:37 | gibi | including downstream? :) | |
| 11:43:40 | sean-k-mooney | im just fixign a few long lines on a black patch | |
| 11:43:54 | sean-k-mooney | gibi: it woudl get imported downstream if we did it upstream | |