| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-26 | |||
| 15:39:14 | kashyap | Also have to address your own good comments on this patch: https://review.opendev.org/c/openstack/nova/+/762330 | |
| 15:40:40 | kashyap | gibi: Ah, forgot that I already have the patch here for: https://review.opendev.org/c/openstack/nova/+/838191 (libvirt/config: Parse the 'cpu' element in domainCapabilities) | |
| 15:40:45 | kashyap | (Modulo test) | |
| 15:41:27 | gibi | yeah only test needed | |
| 15:41:44 | kashyap | Actually, no that's not it...it's not adding a separate config class there | |
| 15:42:34 | kashyap | gibi: From IRC log | |
| 15:42:46 | kashyap | (Of this channel): | |
| 15:42:47 | kashyap | 17:13 < kashyap> gibi: To tie up the lose end on caps vs domCaps -- the guidance from the libvirt folks is (a) no, we can't treat the caps == domCaps w/ 'host-model' mode; and (b) we should use domCaps wherever possible. | |
| 15:42:51 | kashyap | 17:13 < kashyap> gibi: So that means, we should introduce a new config object | |
| 15:42:54 | kashyap | 17:13 < gibi> kashyap: ack, make sense | |
| 15:43:19 | gibi | hehh, I'm just following you guid here :) | |
| 15:43:30 | kashyap | So, to sum up: | |
| 15:44:14 | kashyap | (1) address your + Stephen's comments; (2) add the separate config object class to parse "cpu" element from domCaps, and work that in "properly" | |
| 15:44:45 | kashyap | I could definitely use some help, if you have some time for this! I keep duking around this and never quite managing it fully | |
| 15:45:57 | gibi | I cannot promise I can jump on this right away but I keep it in mind | |
| 15:46:15 | gibi | but thanks for summing it up it helps keeping the context | |
| 17:44:21 | opendevreview | Merged openstack/os-vif master: update job template to zed https://review.opendev.org/c/openstack/os-vif/+/843432 | |
| 18:41:43 | opendevreview | Rajat Dhasmana proposed openstack/nova-specs master: Repropose volume backed server rebuild spec https://review.opendev.org/c/openstack/nova-specs/+/840155 | |
| 19:28:14 | opendevreview | Miguel Lavalle proposed openstack/os-vif master: Delete trunk bridges to avoid race with Neutron https://review.opendev.org/c/openstack/os-vif/+/841499 | |
| #openstack-nova - 2022-05-27 | |||
| 00:05:09 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: WIP: Persist connection_info during live migration https://review.opendev.org/c/openstack/nova/+/843554 | |
| 00:31:46 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: WIP: Persist connection_info during live migration https://review.opendev.org/c/openstack/nova/+/843554 | |
| 00:31:47 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: DNM: Testing live migration with local attach https://review.opendev.org/c/openstack/nova/+/843146 | |
| 00:38:33 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: DNM: Testing live migration with local attach https://review.opendev.org/c/openstack/nova/+/843146 | |
| 00:38:34 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: WIP: Persist connection_info during live migration https://review.opendev.org/c/openstack/nova/+/843554 | |
| 02:04:53 | opendevreview | Ghanshyam proposed openstack/nova stable/victoria: DNM: testing Tempest pin in stable/victoria https://review.opendev.org/c/openstack/nova/+/843301 | |
| 04:25:57 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add missing condition https://review.opendev.org/c/openstack/nova/+/843565 | |
| 04:27:49 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos https://review.opendev.org/c/openstack/nova/+/843127 | |
| 10:32:38 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos https://review.opendev.org/c/openstack/nova/+/843127 | |
| 10:50:09 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos https://review.opendev.org/c/openstack/nova/+/843127 | |
| 11:54:28 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix duplicates keys https://review.opendev.org/c/openstack/nova/+/843605 | |
| 12:10:09 | opendevreview | Merged openstack/nova master: Fix extending non LUKSv1 encrypted volumes https://review.opendev.org/c/openstack/nova/+/836064 | |
| 14:02:58 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Run encrypted volume tests in nova-live-migration-ceph https://review.opendev.org/c/openstack/nova/+/843621 | |
| 14:03:12 | artom | sean-k-mooney, if I've done this correct, ^^ should reproduce on master | |
| 14:03:17 | artom | Without any workarounds | |
| 15:57:53 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Run encrypted volume tests in nova-live-migration https://review.opendev.org/c/openstack/nova/+/843621 | |
| 18:54:19 | opendevreview | Ghanshyam proposed openstack/os-vif master: Drop lower-constraints.txt and its testing https://review.opendev.org/c/openstack/os-vif/+/840020 | |
| 19:07:18 | artom | sean-k-mooney, so, I can't reproduce it on master, and I think that's because https://review.opendev.org/c/openstack/nova/+/804230/3/nova/compute/manager.py fixed it | |
| 19:07:26 | artom | And I even reviewed it, too | |
| 19:07:43 | artom | You may be done for the day, feel free to ignore this | |
| 19:08:01 | artom | I'm using (potentially absent) you as a rubber duck (again) | |
| 19:09:42 | artom | Lemme try backporting that to stable/wallaby instead of my WIP thing | |
| 19:19:25 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843678 | |
| 19:19:26 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843679 | |
| 19:19:27 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | |
| 19:19:42 | sean-k-mooney | artom: o/ | |
| 19:19:51 | sean-k-mooney | artom: im not around for long | |
| 19:20:04 | sean-k-mooney | but ill look quickly | |
| 19:20:36 | sean-k-mooney | artom: ah yes cool | |
| 19:21:10 | sean-k-mooney | and there is a functional repoducer https://review.opendev.org/c/openstack/nova/+/804229/3 | |
| 19:21:45 | sean-k-mooney | artom: ya so i think that is a better approch vs stable only | |
| 19:22:15 | artom | For sure | |
| 19:22:18 | sean-k-mooney | artom: nice find | |
| 19:22:48 | artom | :) I tried on master with iscsi + cryptsetup, which should have hit the same problem | |
| 19:22:50 | artom | It didn't | |
| 19:22:56 | artom | So I went git log diving | |
| 19:23:08 | artom | Luckily, Lee's commit message was well written and was easy to find. | |
| 19:23:15 | sean-k-mooney | so thats in xena so ya wallby to trait i guess | |
| 19:23:35 | sean-k-mooney | *to train | |
| 19:23:43 | sean-k-mooney | for the backports | |
| 19:24:29 | artom | We're going to burn out the SRT team (well, our 1 Nova dude Amit) in a matter of days | |
| 19:24:42 | artom | Like, he'll need therapy | |
| 19:24:44 | artom | I almost do | |
| 19:25:15 | sean-k-mooney | it hopefuly wont be too bad of a backpor but the fact we ned py27 suport for trian is a pain | |
| 19:25:49 | sean-k-mooney | even wallaby seam kind of old to me honestly | |
| 19:26:02 | artom | The code itself is mostly OK | |
| 19:26:13 | sean-k-mooney | anyway im going ot finish up for the weekend but ill check it on monday | |
| 19:26:24 | artom | But the price to pay for all the func tests improvements since train is backports being a PITA | |
| 19:26:53 | sean-k-mooney | ya | |
| 19:59:25 | opendevreview | melanie witt proposed openstack/nova master: Update [scheduler] limit_tenants_to_placement_aggregate config help https://review.opendev.org/c/openstack/nova/+/843684 | |
| 20:48:33 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843678 | |
| 20:48:34 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843679 | |
| 20:48:35 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | |
| 21:09:10 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843679 | |
| 21:09:11 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | |
| #openstack-nova - 2022-05-28 | |||
| 03:25:25 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843679 | |
| 03:25:26 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | |
| 03:28:44 | opendevreview | melanie witt proposed openstack/nova master: WIP Test volume extend actions in the nova-next job https://review.opendev.org/c/openstack/nova/+/843700 | |
| 04:23:30 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843679 | |
| 04:23:31 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | |
| 04:59:44 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | |
| 04:59:45 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843702 | |
| 06:39:17 | opendevreview | melanie witt proposed openstack/nova master: WIP Test volume extend actions in the nova-next job https://review.opendev.org/c/openstack/nova/+/843700 | |
| #openstack-nova - 2022-05-29 | |||
| 00:14:15 | opendevreview | Ghanshyam proposed openstack/nova stable/victoria: DNM: Testing https://review.opendev.org/c/openstack/tempest/+/843182 https://review.opendev.org/c/openstack/nova/+/843188 | |
| 00:43:55 | opendevreview | melanie witt proposed openstack/nova master: Test attached volume extend actions in the nova-next job https://review.opendev.org/c/openstack/nova/+/843700 | |
| #openstack-nova - 2022-05-30 | |||
| 08:09:44 | bauzas | good morning Nova | |
| 08:13:00 | gibi | bauzas: o/ | |
| 08:29:09 | Uggla | bauzas, lucky guy. ;) | |
| 08:59:37 | jhartkopf | Hey, I am currently working on the client-side implementation for an approved spec for Zed. Is it correct that the CLI parser changes should be implemented in python-openstackclient while the API changes are implemented in python-novaclient? Is openstacksdk involved in this at all? | |
| 09:01:31 | Uggla | jhartkopf, yes for python-openstackclient and python-novaclient. | |
| 09:03:30 | Uggla | I think openstacksdk is not involved. But it is good to update it if required, for people who needs it. | |
| 09:10:23 | jhartkopf | Uggla: Alright, so I will focus on openstackclient and novaclient first, thanks! | |
| 09:13:22 | Uggla | jhartkopf, you can have a look at https://review.opendev.org/c/openstack/python-novaclient/+/831651 and https://review.opendev.org/c/openstack/python-openstackclient/+/831902, this is what I'm currently doing. Maybe not the best example, but it gives an idea. | |
| 09:21:05 | opendevreview | Rico Lin proposed openstack/nova-specs master: Add vIOMMU device support for libvirt driver https://review.opendev.org/c/openstack/nova-specs/+/840310 | |
| 09:22:00 | ricolin | ^^^ stephenfin: sean-k-mooney just update viommu spec, please kindly review again. Thanks ;) | |
| 09:40:28 | jhartkopf | Uggla: Yeah that looks similar to what I had in mind, thank you :) | |
| 09:41:51 | sean-k-mooney | ricolin: you have one error that should be fixed regarding the default for the viommu value but im +2 otherwise | |
| 10:15:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 10:15:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: WIP: skeleton for asserting PCI resources in Placement https://review.opendev.org/c/openstack/nova/+/843291 | |
| 10:57:08 | opendevreview | Rico Lin proposed openstack/nova-specs master: Add vIOMMU device support for libvirt driver https://review.opendev.org/c/openstack/nova-specs/+/840310 | |
| 10:57:37 | ricolin | sean-k-mooney: right, it makes no sense to default to enable with performance overhead | |