| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-23 | |||
| 16:12:02 | sean-k-mooney | gibi: stephenfin if ye want to s/device_list/devices/ im fine with that | |
| 16:12:14 | sean-k-mooney | and or do it as a followup | |
| 16:12:42 | gibi | as I see stephenfin has things against the pluralness as well | |
| 16:13:04 | gibi | anyhow I will reply in the spec and we can discuss it tomorrow over IRC | |
| 16:13:32 | sean-k-mooney | well from my point of view it is plural as it generally refers to multiple devices via the vendor/product id or the regex support | |
| 16:13:39 | sean-k-mooney | sure | |
| 16:14:02 | sean-k-mooney | elodilles: by the way i propsoed https://review.opendev.org/c/openstack/requirements/+/842991 to test if that will help with stable/ussuri | |
| 16:14:39 | sean-k-mooney | elodilles: i think that woudl pull in most of the wait for sshabel changes but certenly not all | |
| 16:15:23 | sean-k-mooney | there are some other idea we had of how to impove the stabel branch situation but that was the lowest effort quick change we cam up with | |
| 16:16:38 | sean-k-mooney | ah actully i might need older | |
| 16:16:51 | sean-k-mooney | we might be hitting py36 issues witht hat | |
| 16:17:24 | sean-k-mooney | although we should supprot 36 on yoga so proably somethign else | |
| 16:18:08 | sean-k-mooney | ah oslo_log dependices | |
| 16:19:30 | sean-k-mooney | hum why is that using upper constratis form master | |
| 16:19:57 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/1f08c1134a1540bb8e9ae836c5ba60a9/log/job-output.txt#20845 ERROR: Could not find a version that satisfies the requirement oslo.log===5.0.0 (from -c https://releases.openstack.org/constraints/upper/master | |
| 16:20:21 | bauzas | gmann: ack no worries | |
| 16:21:06 | sean-k-mooney | ok i need to also change devstack to work aroudn that | |
| 16:26:04 | gibi | dansmith: could you check the unshelve to host spec https://review.opendev.org/c/openstack/nova-specs/+/831506/ I think now it is also aligned to you comments too | |
| 16:27:02 | dansmith | oh yeah I saw this ack | |
| 16:27:05 | dansmith | oops | |
| 16:27:33 | dansmith | that was intended to be two statements to two different people, but it worked out this time :) | |
| 16:28:19 | sean-k-mooney | oh i have debated if that was useful in the past | |
| 16:28:39 | sean-k-mooney | i sometimes start replyint in the wrong tab if misclick | |
| 16:28:49 | sean-k-mooney | but more often then not i assuem that causes issues | |
| 16:29:18 | gibi | :) | |
| 16:29:37 | dansmith | I'm not a fan.. end up with too many "that guy is an ass okay sure buddy" things where you don't remember to hit send in a /query and then switch | |
| 16:33:01 | sean-k-mooney | https://review.opendev.org/c/openstack/requirements/+/842991 is going to fail but even using an old upper-constriats i think wont work | |
| 16:33:13 | sean-k-mooney | its been resolving for ~5 mins locally | |
| 16:34:13 | sean-k-mooney | realistically if i want to bump the tempest version i think i would need to either do this differently via devstack or bump other constraits | |
| 16:41:22 | sean-k-mooney | actully the best apptoch might be to just not use an upper-constratits file for the venv | |
| 16:44:03 | dansmith | gibi: I have one typo gripe plus bauzas | |
| 16:44:12 | dansmith | can we fix and re-ack real quick? | |
| 16:44:23 | dansmith | I can edit inline and then +2 if you'll be around to +W | |
| 16:44:47 | bauzas | dansmith: sure | |
| 16:45:14 | opendevreview | Dan Smith proposed openstack/nova-specs master: Allow unshelve to a specific host https://review.opendev.org/c/openstack/nova-specs/+/831506 | |
| 16:45:22 | sean-k-mooney | ok i think the best way to make this work is just to remove using upper-constraits from the venv in devstack ill try that and see if that work | |
| 16:45:22 | bauzas | gibi: I'll have comments on the PCI spec, mostly on the config options | |
| 16:45:30 | dansmith | bauzas: gibi done | |
| 16:45:35 | bauzas | dansmith: saw | |
| 16:46:30 | bauzas | Uggla: typey typey now | |
| 16:46:44 | Uggla | ? | |
| 16:53:01 | bauzas | Uggla: your spec got approved | |
| 16:53:08 | bauzas | which means "hands on deck now" | |
| 16:53:15 | Uggla | oh cool | |
| 16:59:18 | gibi | dansmith, bauzas: thanks | |
| 17:04:23 | sean-k-mooney | gmann: o/ hi looks like you are also tryinng to use a newer version of tempest on ussuri | |
| 17:04:25 | sean-k-mooney | https://review.opendev.org/c/openstack/devstack/+/838051 | |
| 17:04:55 | sean-k-mooney | im trying to do the same with https://review.opendev.org/c/openstack/requirements/+/842991 andhttps://review.opendev.org/c/openstack/devstack/+/843006 | |
| 17:07:06 | sean-k-mooney | ok im going to call it a day but ill take a look at those again tomorrow | |
| 17:14:03 | opendevreview | Merged openstack/nova-specs master: Allow unshelve to a specific host https://review.opendev.org/c/openstack/nova-specs/+/831506 | |
| 17:16:15 | melwitt | sean-k-mooney: have you seen this re: upper-constraints? https://review.opendev.org/c/openstack/nova/+/842813 | |
| 17:16:46 | melwitt | oh, nvm, I guess that's what you just talking about the last few messages | |
| 17:18:02 | sean-k-mooney | no i had not | |
| 17:18:16 | sean-k-mooney | but i dont think we want to do that | |
| 17:18:52 | sean-k-mooney | i dont really agree with pinnint tempest but if we do im not conviced we shoudl do it via devstack | |
| 17:19:37 | sean-k-mooney | we could but i think we need to contol that form the project side unless the QA team want to support all the brances we care about including the EM ones | |
| 17:20:32 | melwitt | it's a nova patch | |
| 17:20:44 | sean-k-mooney | i know but devstack does nto seam to use the right version | |
| 17:20:47 | sean-k-mooney | either | |
| 17:20:58 | sean-k-mooney | at least on the stable branch of the requirement repo it uses master | |
| 17:21:06 | sean-k-mooney | not the patch under test | |
| 17:22:00 | sean-k-mooney | it looks like on stable its using the checked out version of the requiremetns repo | |
| 17:22:05 | sean-k-mooney | well on train https://github.com/openstack/devstack/blob/stable/train/stackrc#L320 | |
| 17:22:28 | sean-k-mooney | that would be fine i guess if tha tis the correct branch | |
| 17:23:15 | sean-k-mooney | melwitt: https://github.com/openstack/devstack/blob/stable/ussuri/stackrc#L315= | |
| 17:23:23 | sean-k-mooney | on ussui it woudl end up using master | |
| 17:23:44 | sean-k-mooney | melwitt: so i guess that patch is fine for train | |
| 17:23:54 | sean-k-mooney | but not for ussuri | |
| 17:24:17 | melwitt | hm ok | |
| 17:25:41 | sean-k-mooney | look like gmann pinned train with https://github.com/openstack/devstack/commit/8a22f7380c7029e931fe9103320f24a223b619d1 | |
| 17:26:03 | sean-k-mooney | so i guess the train patch is fine to merge | |
| 17:26:15 | sean-k-mooney | but that would not help with ussuri | |
| 17:26:19 | gibi | bauzas: thanks for the review, replied in https://review.opendev.org/c/openstack/nova-specs/+/791047 | |
| 17:26:49 | sean-k-mooney | melwitt: i kind of would have epected the newer stable branches to be fix before train | |
| 17:27:00 | sean-k-mooney | but maybe its because train is EM already | |
| 17:27:15 | opendevreview | ribaudr proposed openstack/nova-specs master: libvirt: Allow Manila shares to be directly attached to instances https://review.opendev.org/c/openstack/nova-specs/+/833669 | |
| 17:27:31 | sean-k-mooney | melwitt: mind if we pick this up tomorrow the train nova patch is likely ok to proceed with | |
| 17:27:36 | melwitt | sean-k-mooney: it might be an oversight? gmann ^ | |
| 17:27:47 | melwitt | sean-k-mooney: sure | |
| 17:28:18 | sean-k-mooney | i would think using the locally checked out requiremetn repo would always be valid | |
| 17:28:31 | sean-k-mooney | and that instead of a stable only change we coudl have done this on master and backported | |
| 17:28:48 | sean-k-mooney | at least on the nova side | |
| 17:29:24 | melwitt | yeah, that does make sense | |
| 17:29:24 | sean-k-mooney | anyway got to run and pick up food for dinner | |
| 17:30:01 | melwitt | o/ | |
| 17:59:36 | elodilles | melwitt: about the TEMPEST_VENV thing: afaik that is intentional: tempest should run always against master in 'maintained' stable branches (that's why it is in venv) | |
| 18:00:23 | melwitt | elodilles: I replied on the review, I see what you mean, it was my misunderstanding. I see now that tempest is pinned on train but not elsewhere | |
| 18:00:40 | melwitt | thanks for the quick reply :) | |
| 18:01:21 | elodilles | melwitt: oh, sorry :) haven't seen your answer yet o:) | |
| 18:01:36 | melwitt | no worry, I posted it only a minute ago :) | |
| 18:02:08 | elodilles | :) | |
| 18:02:25 | melwitt | I should have said "I also replied on the review" | |
| 18:08:12 | elodilles | no problem :) i really wonder how these new problems crept into ussuri and train... i mean, the SSHABLE thing was not needed before, so why now? did we merge something to nova? or did it come with some other dependencies? :/ | |
| 18:12:38 | melwitt | elodilles: same. looking at a CI run from today on stable/ussuri, one thing it's failing on the same oslo.log dep issue as on stable/train https://zuul.opendev.org/t/openstack/build/571459b47ccb4ed1854f61ce99597eca | |
| 18:14:20 | melwitt | ERROR: full: could not install deps [-chttps://releases.openstack.org/constraints/upper/master, -r/opt/stack/tempest/requirements.txt]; v = InvocationError('/opt/stack/tempest/.tox/tempest/bin/pip install -chttps://releases.openstack.org/constraints/upper/master -r/opt/stack/tempest/requirements.txt', 1) | |
| 18:29:41 | elodilles | melwitt: oslo.log 5.0.0 dropped py36 & py37 | |
| 18:30:31 | elodilles | so yes it seems it is used from master's upper-constraints.txt :S | |
| 18:33:05 | elodilles | but on ussuri we have zuulv3. so you are right, we need a fix for ussuri then, too :S (though it will be probably a different fix, because the hook does not exist there anymore) | |
| 18:35:23 | melwitt | yeah :/ | |
| 18:35:25 | melwitt | sean-k-mooney has been looking at it | |