| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-16 | |||
| 09:58:59 | sean-k-mooney | not always but its rare i will touch the api and compute node in one patch | |
| 09:59:03 | sean-k-mooney | or db and api | |
| 09:59:19 | Uggla | sean-k-mooney, yep but here it is only api. | |
| 09:59:44 | sean-k-mooney | ya for that patch the api microverison bump shoudl be the last patch | |
| 09:59:54 | sean-k-mooney | the valdiation code can be a sperat patch | |
| 09:59:59 | sean-k-mooney | not sure about the rest | |
| 10:00:34 | sean-k-mooney | i would not expect that chagne to be more the 2-5 patches honestly | |
| 10:00:51 | sean-k-mooney | its not partacalarly large, you could put all the docs changes in one | |
| 10:01:29 | sean-k-mooney | the unit and fucntional test shoudl be in the patch that changes the behavior not groupted into one patch | |
| 10:02:42 | Uggla | sean-k-mooney, yes I was thinking about moving the doc in another patch. | |
| 10:04:02 | sean-k-mooney | i often do the docs changes inlien but have also split them in the past. docs patche can land after feature freeze | |
| 10:04:28 | sean-k-mooney | not that i hope it will take that long to land your code but just somethign to keep in mind if we are getting close to m3 | |
| 18:34:43 | opendevreview | Rico Lin proposed openstack/nova-specs master: Add vIOMMU device support for libvirt driver https://review.opendev.org/c/openstack/nova-specs/+/840310 | |
| 18:38:22 | ricolin | sean-k-mooney: stephenfin just update https://review.opendev.org/c/openstack/nova-specs/+/840310 mnaser also leave some comment in patch to targeting your why question, please kindly take another review on it. Thanks! :) | |
| 19:13:49 | mnaser | ricolin: might wanna fix pep8 :) | |
| #openstack-nova - 2022-05-17 | |||
| 00:01:43 | opendevreview | Merged openstack/nova master: Drop lower-constraints.txt and its testing https://review.opendev.org/c/openstack/nova/+/840021 | |
| 01:14:38 | opendevreview | Julia Kreger proposed openstack/nova-specs master: Discussion: Options to address ironic driver rebalance https://review.opendev.org/c/openstack/nova-specs/+/842015 | |
| 03:14:54 | melwitt | elodilles: would like to have your opinion about one-off func test change vs backporting func test refactor https://review.opendev.org/c/openstack/nova/+/841483/2#message-295349b50b8233180cd5015ab8b977bab074765b at your convenience | |
| 07:35:57 | opendevreview | Rico Lin proposed openstack/nova-specs master: Add vIOMMU device support for libvirt driver https://review.opendev.org/c/openstack/nova-specs/+/840310 | |
| 08:37:51 | elodilles | melwitt: i've commented on the patch. (in general one-off maybe better, but if this would be needed multiple times and considering this smaller functional test refactor, maybe it is acceptable to backport it) | |
| 10:10:57 | gibi | sean-k-mooney: hi! I'm about to start fixing nits in the PCI tracking spec, but if you already in the middle of reviewing it then I can hold until your comments | |
| 10:18:21 | sean-k-mooney | im in the middel of reviewing but sofar i have no comments to add :) | |
| 10:18:29 | sean-k-mooney | so if you want to fix them go ahead | |
| 10:22:59 | gibi | OK thans. I will fix the nits then soon | |
| 10:38:23 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: PCI device tracking in Placement https://review.opendev.org/c/openstack/nova-specs/+/791047 | |
| 10:38:46 | gibi | sean-k-mooney, stephenfin, melwitt: thanks for the reviews so far I fixed up the last batch of nits in the spec ^^ | |
| 11:48:10 | erlon | https://review.opendev.org/c/openstack/nova/+/836014 | |
| 11:48:10 | erlon | sean-k-mooney: melwitt: hey guys, good morning, can I get some eyes on the pre-livemigration rollback patch? | |
| 11:54:03 | sean-k-mooney | yep ill take a look although i currently dont have stable rights but ill confrim it hte patch looks sane | |
| 11:54:13 | sean-k-mooney | just finsihing a spec review but ill be doen shortly | |
| 12:25:16 | sean-k-mooney | gibi: +1 some nits and one question inline but im more or less +2 | |
| 12:30:43 | gibi | sean-k-mooney: thanks. I can trim down the required / forbidden traits tag to just having ``traits`` and implement required traits now similar in the first round. We can see if we need forbidden traits later ever | |
| 12:32:30 | sean-k-mooney | im not pushed really either way i was just thinkign about it as one filed wiht forbiden triat modedl with a - or ! if supproted | |
| 12:33:01 | sean-k-mooney | i dont think its much work to supprot forbidien traits so i dont really see any harm in including it | |
| 12:33:08 | sean-k-mooney | it wont expand scope that much | |
| 12:33:35 | sean-k-mooney | if other are ok with what you ahve propsoed im fine to upgrade to +2 | |
| 12:33:53 | sean-k-mooney | but i want to wait of melwitt and stephenfin to comment | |
| 12:34:06 | gibi | sure, lets see what the others think | |
| 12:34:13 | gibi | and thanks again for the review | |
| 12:34:38 | sean-k-mooney | no worreis. thanks for volenterring to take this on :) | |
| 12:34:47 | gibi | :) | |
| 12:44:35 | opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | |
| 13:01:31 | sean-k-mooney | bauzas: i assume you are respining the keypair spec | |
| 13:07:57 | bauzas | sean-k-mooney: yes, I was about to ping you and gmann | |
| 13:08:08 | bauzas | about the x508 type | |
| 13:08:26 | bauzas | I think we should continue to accept this parameter | |
| 13:09:29 | sean-k-mooney | for listing | |
| 13:09:36 | sean-k-mooney | not for generation right | |
| 13:10:28 | sean-k-mooney | so we will keep type for show and import | |
| 13:10:42 | sean-k-mooney | but remove generation for all types in the microversion | |
| 13:11:36 | bauzas | sean-k-mooney: you can import a x508 public key https://github.com/openstack/nova/blob/972c06c608f0b00e9066d7f581fd81197065cf49/nova/api/openstack/compute/keypairs.py#L105 | |
| 13:11:43 | sean-k-mooney | yes i know | |
| 13:11:56 | sean-k-mooney | that was never in doubt at least in my mind | |
| 13:12:16 | bauzas | if so, we create a fingerprint | |
| 13:12:25 | sean-k-mooney | i was not sure if we could generate them but we can | |
| 13:12:37 | bauzas | sean-k-mooney: you can generate them too | |
| 13:12:43 | sean-k-mooney | yes i know i found the code | |
| 13:12:50 | sean-k-mooney | so i dont want the capablities to differ per type | |
| 13:12:56 | bauzas | yes | |
| 13:13:08 | bauzas | so I'll remove this in the spec | |
| 13:13:08 | sean-k-mooney | so i dont want to kep generateion for x509 but drop it for ssh in teh new microverion | |
| 13:13:13 | sean-k-mooney | ack | |
| 13:13:22 | sean-k-mooney | so we will remvoe generation for all types | |
| 13:13:31 | sean-k-mooney | but keep type in the api for import and list | |
| 13:13:37 | sean-k-mooney | correct? | |
| 13:13:50 | sean-k-mooney | and keep the generation code for older microverions | |
| 13:14:58 | bauzas | sean-k-mooney: yes, just stoping to accept no public key | |
| 13:15:11 | bauzas | by the new microversion, yes | |
| 13:15:28 | sean-k-mooney | that works for me | |
| 13:29:50 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes to remove keypair generation https://review.opendev.org/c/openstack/nova-specs/+/840217 | |
| 13:54:23 | kashyap | gibi: FFS, now CentOS9S seem to fail this - https://review.opendev.org/c/openstack/nova/+/838926 | |
| 13:54:41 | kashyap | I just can't seem to get rid off my back | |
| 13:55:17 | kashyap | It's another unrelated random timeout: https://zuul.opendev.org/t/openstack/build/bcaf2154eeb545cdb7907d0c807513e9 | |
| 14:23:19 | gibi | kashyap: that was another disk detach issue | |
| 14:31:00 | sean-k-mooney | should we make the c9s job non-voting | |
| 14:31:12 | sean-k-mooney | i have seen that fail quite offen with the detach issue | |
| 14:34:33 | kashyap | gibi: Oh, damn; is that a real one? | |
| 14:35:03 | kashyap | sean-k-mooney: Yeah, we should until that known issue is resolved. I wonder if others disagree | |
| 14:35:04 | sean-k-mooney | kashyap: i dont think its realated to your patch if that is what you are asking | |
| 14:35:17 | gibi | I think we are still in the progress of landing the tempest patches that adds the waiter unit the guest boots up | |
| 14:35:26 | sean-k-mooney | kashyap: but device detach is really really falky on centos 9 | |
| 14:35:31 | kashyap | sean-k-mooney: No; I was asking if it's an unrelated new issue :) | |
| 14:35:40 | gibi | it is not new | |
| 14:35:47 | sean-k-mooney | kashyap: its unrelated to your patch | |
| 14:35:47 | gibi | and it is not related to your patch | |
| 14:36:01 | kashyap | (Yep, noted) | |
| 14:38:00 | sean-k-mooney | gibi: i tought the tempest chagnes were landed on master | |
| 14:39:36 | sean-k-mooney | https://review.opendev.org/q/topic:wait_until_sshable_pingable | |
| 14:39:57 | sean-k-mooney | so https://review.opendev.org/c/openstack/tempest/+/817772? | |
| 14:41:07 | sean-k-mooney | hum tempest.api.compute.volumes.test_attach_volume.AttachVolumeMultiAttachTest | |
| 14:41:09 | sean-k-mooney | is what failed | |
| 14:41:14 | sean-k-mooney | so maybe that is not useing that yet | |
| 14:42:02 | sean-k-mooney | apprently it is https://github.com/openstack/tempest/blob/master/tempest/api/compute/volumes/test_attach_volume.py | |
| 14:42:55 | sean-k-mooney | perhaps test_resize_server_with_multiattached_volume is not | |
| 14:43:00 | gibi | I noted this particular failure in https://bugs.launchpad.net/nova/+bug/1960346/comments/29 | |
| 14:43:25 | sean-k-mooney | ah | |
| 14:43:27 | sean-k-mooney | https://github.com/openstack/tempest/blob/master/tempest/api/compute/volumes/test_attach_volume.py#L495= | |
| 14:43:46 | sean-k-mooney | so we need to wait after that resize | |
| 14:43:55 | gibi | after resize we only wait for ACTIVE state then go and detach | |
| 14:43:58 | sean-k-mooney | or in teh resize call we need to wait for it to be sshable again | |