| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-13 | |||
| 15:15:48 | opendevreview | Merged openstack/nova master: Add Python 3.10 functional jobs https://review.opendev.org/c/openstack/nova/+/839029 | |
| 15:33:35 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: PCI device tracking in Placement https://review.opendev.org/c/openstack/nova-specs/+/791047 | |
| 15:34:46 | gibi | sean-k-mooney, stephenfin, melwitt: fresh and simplified ^^ | |
| 15:37:33 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/wallaby: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/841760 | |
| 15:37:51 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/wallaby: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/841736 | |
| 16:04:25 | sean-k-mooney | gibi: thanks im not sure i have the brain power left to read it fully at 5 pm on a friday | |
| 16:04:41 | sean-k-mooney | but ill defintly take a look on monday | |
| 16:04:54 | gibi | I totally understand :) | |
| 16:05:04 | gibi | have a nice weekend | |
| 16:05:28 | sean-k-mooney | you too o/ | |
| 16:09:15 | opendevreview | sean mooney proposed openstack/os-vif stable/xena: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841771 | |
| 16:09:16 | opendevreview | sean mooney proposed openstack/os-vif stable/xena: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841772 | |
| 16:10:32 | opendevreview | sean mooney proposed openstack/os-vif stable/wallaby: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841773 | |
| 16:10:33 | opendevreview | sean mooney proposed openstack/os-vif stable/wallaby: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841774 | |
| 16:13:09 | opendevreview | sean mooney proposed openstack/os-vif stable/victoria: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841775 | |
| 16:13:10 | opendevreview | sean mooney proposed openstack/os-vif stable/victoria: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841776 | |
| 16:13:47 | opendevreview | sean mooney proposed openstack/os-vif stable/ussuri: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841777 | |
| 16:13:48 | opendevreview | sean mooney proposed openstack/os-vif stable/ussuri: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841778 | |
| 16:14:21 | opendevreview | sean mooney proposed openstack/os-vif stable/train: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841779 | |
| 16:14:22 | opendevreview | sean mooney proposed openstack/os-vif stable/train: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841780 | |
| 16:45:29 | opendevreview | Merged openstack/nova master: trivial: fix deprecation warning in notification fixture https://review.opendev.org/c/openstack/nova/+/841756 | |
| 18:53:57 | mnaser | happy friday -- https://review.opendev.org/c/openstack/nova/+/840985 + https://review.opendev.org/c/openstack/nova/+/840993 are trivial nice to have fixes that could use reviews =) | |
| 20:04:00 | opendevreview | melanie witt proposed openstack/placement stable/victoria: placement-status: check only consumers in allocation table https://review.opendev.org/c/openstack/placement/+/840702 | |
| 20:05:38 | opendevreview | melanie witt proposed openstack/placement stable/ussuri: placement-status: check only consumers in allocation table https://review.opendev.org/c/openstack/placement/+/840703 | |
| #openstack-nova - 2022-05-16 | |||
| 08:00:43 | bauzas | good morning Nova | |
| 08:11:01 | Uggla | bauzas, o/ | |
| 09:36:10 | opendevreview | Merged openstack/nova master: Switch libvirt event timeout message to warning https://review.opendev.org/c/openstack/nova/+/840985 | |
| 09:37:35 | opendevreview | ribaudr proposed openstack/nova master: Allow unshelve to a specific host https://review.opendev.org/c/openstack/nova/+/831507 | |
| 09:47:01 | opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | |
| 09:49:45 | kashyap | Uggla: Hey, from a quick skim, you might want to split that "unshelve to a specific host" into a few patches. As it seems to be touching a lot of files in ine go. | |
| 09:52:32 | Uggla | kashyap, I'm gonna have a look. I need to think what could be the best split. | |
| 09:54:09 | kashyap | Uggla: One idea could be to split based on "one logical change per commit". It ensures that in case something needs to be reverted, it can be easily done | |
| 09:54:36 | kashyap | (And also many other reasons: https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes) | |
| 09:58:23 | sean-k-mooney | Uggla: i tend to split by subsystem | |
| 09:58:30 | sean-k-mooney | or binary that im touching | |
| 09:58:59 | sean-k-mooney | not always but its rare i will touch the api and compute node in one patch | |
| 09:59:03 | sean-k-mooney | or db and api | |
| 09:59:19 | Uggla | sean-k-mooney, yep but here it is only api. | |
| 09:59:44 | sean-k-mooney | ya for that patch the api microverison bump shoudl be the last patch | |
| 09:59:54 | sean-k-mooney | the valdiation code can be a sperat patch | |
| 09:59:59 | sean-k-mooney | not sure about the rest | |
| 10:00:34 | sean-k-mooney | i would not expect that chagne to be more the 2-5 patches honestly | |
| 10:00:51 | sean-k-mooney | its not partacalarly large, you could put all the docs changes in one | |
| 10:01:29 | sean-k-mooney | the unit and fucntional test shoudl be in the patch that changes the behavior not groupted into one patch | |
| 10:02:42 | Uggla | sean-k-mooney, yes I was thinking about moving the doc in another patch. | |
| 10:04:02 | sean-k-mooney | i often do the docs changes inlien but have also split them in the past. docs patche can land after feature freeze | |
| 10:04:28 | sean-k-mooney | not that i hope it will take that long to land your code but just somethign to keep in mind if we are getting close to m3 | |
| 18:34:43 | opendevreview | Rico Lin proposed openstack/nova-specs master: Add vIOMMU device support for libvirt driver https://review.opendev.org/c/openstack/nova-specs/+/840310 | |
| 18:38:22 | ricolin | sean-k-mooney: stephenfin just update https://review.opendev.org/c/openstack/nova-specs/+/840310 mnaser also leave some comment in patch to targeting your why question, please kindly take another review on it. Thanks! :) | |
| 19:13:49 | mnaser | ricolin: might wanna fix pep8 :) | |
| #openstack-nova - 2022-05-17 | |||
| 00:01:43 | opendevreview | Merged openstack/nova master: Drop lower-constraints.txt and its testing https://review.opendev.org/c/openstack/nova/+/840021 | |
| 01:14:38 | opendevreview | Julia Kreger proposed openstack/nova-specs master: Discussion: Options to address ironic driver rebalance https://review.opendev.org/c/openstack/nova-specs/+/842015 | |
| 03:14:54 | melwitt | elodilles: would like to have your opinion about one-off func test change vs backporting func test refactor https://review.opendev.org/c/openstack/nova/+/841483/2#message-295349b50b8233180cd5015ab8b977bab074765b at your convenience | |
| 07:35:57 | opendevreview | Rico Lin proposed openstack/nova-specs master: Add vIOMMU device support for libvirt driver https://review.opendev.org/c/openstack/nova-specs/+/840310 | |
| 08:37:51 | elodilles | melwitt: i've commented on the patch. (in general one-off maybe better, but if this would be needed multiple times and considering this smaller functional test refactor, maybe it is acceptable to backport it) | |
| 10:10:57 | gibi | sean-k-mooney: hi! I'm about to start fixing nits in the PCI tracking spec, but if you already in the middle of reviewing it then I can hold until your comments | |
| 10:18:21 | sean-k-mooney | im in the middel of reviewing but sofar i have no comments to add :) | |
| 10:18:29 | sean-k-mooney | so if you want to fix them go ahead | |
| 10:22:59 | gibi | OK thans. I will fix the nits then soon | |
| 10:38:23 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: PCI device tracking in Placement https://review.opendev.org/c/openstack/nova-specs/+/791047 | |
| 10:38:46 | gibi | sean-k-mooney, stephenfin, melwitt: thanks for the reviews so far I fixed up the last batch of nits in the spec ^^ | |
| 11:48:10 | erlon | https://review.opendev.org/c/openstack/nova/+/836014 | |
| 11:48:10 | erlon | sean-k-mooney: melwitt: hey guys, good morning, can I get some eyes on the pre-livemigration rollback patch? | |
| 11:54:03 | sean-k-mooney | yep ill take a look although i currently dont have stable rights but ill confrim it hte patch looks sane | |
| 11:54:13 | sean-k-mooney | just finsihing a spec review but ill be doen shortly | |
| 12:25:16 | sean-k-mooney | gibi: +1 some nits and one question inline but im more or less +2 | |
| 12:30:43 | gibi | sean-k-mooney: thanks. I can trim down the required / forbidden traits tag to just having ``traits`` and implement required traits now similar in the first round. We can see if we need forbidden traits later ever | |
| 12:32:30 | sean-k-mooney | im not pushed really either way i was just thinkign about it as one filed wiht forbiden triat modedl with a - or ! if supproted | |
| 12:33:01 | sean-k-mooney | i dont think its much work to supprot forbidien traits so i dont really see any harm in including it | |
| 12:33:08 | sean-k-mooney | it wont expand scope that much | |
| 12:33:35 | sean-k-mooney | if other are ok with what you ahve propsoed im fine to upgrade to +2 | |
| 12:33:53 | sean-k-mooney | but i want to wait of melwitt and stephenfin to comment | |
| 12:34:06 | gibi | sure, lets see what the others think | |
| 12:34:13 | gibi | and thanks again for the review | |
| 12:34:38 | sean-k-mooney | no worreis. thanks for volenterring to take this on :) | |
| 12:34:47 | gibi | :) | |
| 12:44:35 | opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | |
| 13:01:31 | sean-k-mooney | bauzas: i assume you are respining the keypair spec | |
| 13:07:57 | bauzas | sean-k-mooney: yes, I was about to ping you and gmann | |
| 13:08:08 | bauzas | about the x508 type | |
| 13:08:26 | bauzas | I think we should continue to accept this parameter | |
| 13:09:29 | sean-k-mooney | for listing | |
| 13:09:36 | sean-k-mooney | not for generation right | |
| 13:10:28 | sean-k-mooney | so we will keep type for show and import | |
| 13:10:42 | sean-k-mooney | but remove generation for all types in the microversion | |
| 13:11:36 | bauzas | sean-k-mooney: you can import a x508 public key https://github.com/openstack/nova/blob/972c06c608f0b00e9066d7f581fd81197065cf49/nova/api/openstack/compute/keypairs.py#L105 | |
| 13:11:43 | sean-k-mooney | yes i know | |
| 13:11:56 | sean-k-mooney | that was never in doubt at least in my mind | |
| 13:12:16 | bauzas | if so, we create a fingerprint | |
| 13:12:25 | sean-k-mooney | i was not sure if we could generate them but we can | |
| 13:12:37 | bauzas | sean-k-mooney: you can generate them too | |
| 13:12:43 | sean-k-mooney | yes i know i found the code | |
| 13:12:50 | sean-k-mooney | so i dont want the capablities to differ per type | |
| 13:12:56 | bauzas | yes | |
| 13:13:08 | bauzas | so I'll remove this in the spec | |
| 13:13:08 | sean-k-mooney | so i dont want to kep generateion for x509 but drop it for ssh in teh new microverion | |
| 13:13:13 | sean-k-mooney | ack | |
| 13:13:22 | sean-k-mooney | so we will remvoe generation for all types | |
| 13:13:31 | sean-k-mooney | but keep type in the api for import and list | |
| 13:13:37 | sean-k-mooney | correct? | |