| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-04-27 | |||
| 11:43:25 | sean-k-mooney | but not writabel by project_member | |
| 11:45:51 | gibi | I'm OK to pursue this with the neutron team but I think we can merge the above fix as changing API behavior like that might no be backportable | |
| 11:50:00 | sean-k-mooney | its currently project_admin by policy https://github.com/openstack/neutron/blob/master/neutron/conf/policies/subnet.py#L54-L67= its a correct fix i guess | |
| 11:51:02 | gibi | hm, that is subnet creation | |
| 11:51:22 | gibi | but yes the GET is project admin too segment_id | |
| 11:51:27 | gibi | https://github.com/openstack/neutron/blob/6db61d070483df60ffbf992d57cef2c1903fe355/neutron/conf/policies/subnet.py#L98-L108 | |
| 11:52:22 | sean-k-mooney | ya its there in both | |
| 11:52:45 | opendevreview | Wenping Song proposed openstack/os-traits master: Add nova and cyborg owner traits for resources https://review.opendev.org/c/openstack/os-traits/+/839128 | |
| 11:52:54 | sean-k-mooney | what troubling is actully https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/subnet_segmentid_writable.py | |
| 11:53:27 | sean-k-mooney | apparently you can update the segment id of a subnet | |
| 11:54:04 | sean-k-mooney | i dont know if the vm/schdilign implciations fo that were considered | |
| 11:54:12 | gibi | I don't want to know what happens with the IP pool during such update | |
| 11:54:32 | gibi | and yes, you are right that can go against the currently scheduled host of the VMs | |
| 11:54:34 | sean-k-mooney | or if it went form not a routed netowk to a routed one | |
| 11:54:52 | gibi | yeah that too | |
| 11:55:24 | sean-k-mooney | i hope they only allow this before ports are added to the subnet | |
| 11:58:43 | sean-k-mooney | gibi: added +2 but now +w to see if bauzas wants to review. we can kick it into the gate if bauzas is busy and does not review by tomorrow | |
| 11:59:04 | gibi | sure. thanks | |
| 11:59:16 | gibi | btw the author is a first time nova contributor :) | |
| 12:01:20 | sean-k-mooney | i guess https://bugzilla.redhat.com/show_bug.cgi?id=1761903 woudl fail qe without thsi so once that lands we should backport it for them i guess | |
| 12:06:22 | gibi | yeah this fix needs to be backport | |
| 12:08:59 | gibi | up until wallaby upstream | |
| 12:20:51 | opendevreview | Wenping Song proposed openstack/os-traits master: Add nova and cyborg owner traits for resources https://review.opendev.org/c/openstack/os-traits/+/839128 | |
| 12:57:19 | gibi | sean-k-mooney: the OWNER os-traits patch now looks good to me https://review.opendev.org/c/openstack/os-traits/+/839128 let's land it and propose a os-traits release | |
| 12:58:44 | sean-k-mooney | yep i see the added a release not. i guess that does not hurt but im not sure how many people actully consume that | |
| 12:58:52 | sean-k-mooney | ill take a look again shortly | |
| 12:59:09 | sean-k-mooney | i need to finsih reviewing your pci patches again too | |
| 12:59:09 | gibi | yeah reno does not hurt | |
| 12:59:20 | gibi | thanks for that! | |
| 12:59:59 | sean-k-mooney | the code looks fine on the first patch but i have not found a block of uninterupted time in the last few days to trace through the unit tests and line them up | |
| 13:00:23 | sean-k-mooney | im sure they are fine but that all i have left to do on the first patch | |
| 13:07:07 | gibi | no worries | |
| 13:26:36 | opendevreview | Merged openstack/os-traits master: Add nova and cyborg owner traits for resources https://review.opendev.org/c/openstack/os-traits/+/839128 | |
| 13:28:33 | bauzas | gibi: sean-k-mooney: eventually accepted https://review.opendev.org/c/openstack/nova/+/839361 | |
| 13:29:09 | bauzas | gibi: sean-k-mooney: that said, I'm sad we need to be an admin for knowing the API extensiion | |
| 13:31:43 | sean-k-mooney | well we can know if the extension is aviabel without being an admin but we cant consume the data form the extention without being an admin | |
| 13:32:02 | sean-k-mooney | i guess the assumetion here is that routed networks are provider networks and requies an admin to create | |
| 13:32:16 | sean-k-mooney | but you then dont need to be an admin to create ports on that network | |
| 13:32:26 | sean-k-mooney | so i really think it shoudl be readonly | |
| 13:32:34 | sean-k-mooney | for project_memeber | |
| 13:32:57 | sean-k-mooney | and project_admin to create the subnet and affinitese it to a segment | |
| 13:33:29 | sean-k-mooney | so we likely shoudl add neutron to the bug and ask them to change the default policy for get but not create to project_reader | |
| 14:19:39 | bauzas | sean-k-mooney: yeah, we should ask the neutron team to change the policy | |
| 14:27:38 | sean-k-mooney | should we just tag them in the bug and ask them to update and or propsoe a patch to do that? | |
| 14:27:47 | sean-k-mooney | we dont consider policy change to be api changes | |
| 14:27:53 | sean-k-mooney | so presumable that would be backportable | |
| 14:47:27 | gibi | I'm not sure neutron will think this is backportable, but let see | |
| 14:59:31 | melwitt | bauzas: thanks ^_^ | |
| 15:45:43 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Run against performance.json patch https://review.opendev.org/c/openstack/nova/+/838934 | |
| 17:00:13 | gibi | bauzas: I reported a gate-failure https://bugs.launchpad.net/nova/+bug/1970642 it is not super frequent but I saw it multiple times | |
| 18:53:15 | opendevreview | Artom Lifshitz proposed openstack/nova master: Fix LM rollback w/o multi port bindings extension https://review.opendev.org/c/openstack/nova/+/839227 | |
| 18:53:15 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce live migration rollback w/o multi port bindings error https://review.opendev.org/c/openstack/nova/+/839091 | |
| 22:53:54 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839648 | |
| 22:56:21 | opendevreview | Ghanshyam proposed openstack/nova stable/yoga: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839653 | |
| 22:56:31 | opendevreview | Ghanshyam proposed openstack/nova stable/xena: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839654 | |
| 23:02:38 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839648 | |
| 23:02:51 | opendevreview | Ghanshyam proposed openstack/nova stable/yoga: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839653 | |
| 23:03:05 | opendevreview | Ghanshyam proposed openstack/nova stable/xena: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839654 | |
| #openstack-nova - 2022-04-28 | |||
| 06:42:41 | elodilles | good morning o/ fyi, i see lot of tox-docs job failure in zuul (nova + in several other projects) which seems to be a result of the latest oslo.policy release from yesterday. I'll try to look into it, but first I've pinged the oslo team on #openstack-oslo | |
| 09:51:39 | gibi | ^^ fix is up and I checked locally it works for the nova jobs https://review.opendev.org/c/openstack/oslo.policy/+/839711 | |
| 10:02:48 | bauzas | thanks gibi | |
| 10:03:03 | bauzas | (sorry was on and off) | |
| 10:08:42 | sean-k-mooney | gibi: when you get a chance can you look at the comments i left on https://review.opendev.org/c/openstack/nova/+/838555 | |
| 10:41:38 | gibi | sean-k-mooney: looking... | |
| 10:46:38 | gibi | and pulling the patch down... | |
| 10:50:01 | gibi | sean-k-mooney: hm, the test passing locally for me even after a rebase | |
| 10:50:59 | opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Remove unavailable but not reported PCI devices at startup https://review.opendev.org/c/openstack/nova/+/839717 | |
| 10:51:00 | opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Simulate bug 1969496 https://review.opendev.org/c/openstack/nova/+/839718 | |
| 10:51:01 | opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Allow claiming PCI PF if child VF is unavailable https://review.opendev.org/c/openstack/nova/+/839719 | |
| 10:51:15 | gibi | let see if after the rebase it will be clean | |
| 10:51:28 | gibi | if not then something is interfeering between test cases | |
| 10:56:32 | gibi | hm | |
| 10:56:46 | gibi | now gerrit says it is in merge conflict | |
| 10:57:47 | gibi | bah I pushed it against stein :D | |
| 10:57:57 | gibi | *train | |
| 10:57:59 | sean-k-mooney | hehe | |
| 10:58:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unavailable but not reported PCI devices at startup https://review.opendev.org/c/openstack/nova/+/838553 | |
| 10:58:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow claiming PCI PF if child VF is unavailable https://review.opendev.org/c/openstack/nova/+/838555 | |
| 10:58:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Simulate bug 1969496 https://review.opendev.org/c/openstack/nova/+/838554 | |
| 10:58:59 | gibi | I blame it for the lack of coffein | |
| 11:39:52 | sean-k-mooney | gibi: sorry was pinned for something else runing it locally but ill readd my +2 and review the final patch when it completes | |
| 11:40:45 | gibi | no worries, we have a block in the docs job until https://review.opendev.org/c/openstack/oslo.policy/+/839711 merged and released | |
| 11:41:30 | sean-k-mooney | i breifly looked at that but did not get the full context | |
| 11:42:22 | sean-k-mooney | so oslo-config-generator chagne the kw paramater to a flag? | |
| 11:42:30 | sean-k-mooney | removing the boolean paramater | |
| 11:42:54 | sean-k-mooney | and this is adapting to that backwards incompatible change correct | |
| 11:44:07 | sean-k-mooney | that shoudl have been a major version bump | |
| 11:44:28 | sean-k-mooney | as in oslo.policy=4.0.0 not 3.12.0 | |
| 11:45:02 | sean-k-mooney | gibi: nova.tests.unit.pci.test_manager.PciDevTrackerTestCase.test_set_hvdevs_unavailable_vf_removed is failing for me locally | |
| 11:45:29 | sean-k-mooney | File "/home/sean/repos/openstack/nova-3/nova/objects/pci_device.py", line 238, in _from_db_object | |
| 11:45:30 | sean-k-mooney | setattr(pci_device, key, db_dev[key]) | |
| 11:45:32 | sean-k-mooney | KeyError: 'id' | |
| 11:46:50 | sean-k-mooney | its form the create call | |
| 11:46:53 | sean-k-mooney | File "/home/sean/repos/openstack/nova-3/nova/tests/unit/pci/test_manager.py", line 413, in test_set_hvdevs_unavailable_vf_removed | |
| 11:46:55 | sean-k-mooney | self._create_tracker([fake_db_dev_3, fake_db_dev_4, fake_db_dev_5]) | |
| 11:47:54 | gibi | looking | |
| 11:49:16 | gibi | strange, it is passing for me | |
| 11:49:41 | gibi | do you have commit hash f395e71168 ? | |
| 11:58:36 | sean-k-mooney | f395e71168d843f06c8de7b04874c29f1e10e5a8 | |
| 11:58:55 | sean-k-mooney | ill run it again | |