| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-04-21 | |||
| 18:35:47 | sean-k-mooney | this https://github.com/openstack/openstack-zuul-jobs/blob/master/roles/configure-swap/tasks/main.yaml#L3-L29= i think is really the only non generic part | |
| 18:36:01 | sean-k-mooney | but ya no worries | |
| 18:36:29 | clarkb | specifically swapfile on ext4 created with fallocate worked until very recently on linux. But recent changes broke that and made ext4 much more like xfs and others | |
| 18:36:56 | sean-k-mooney | hum ok | |
| 18:37:08 | sean-k-mooney | we use fallocate in nova to preallocate | |
| 18:37:12 | sean-k-mooney | what exactly changed | |
| 18:37:28 | clarkb | I'd have to go find the commit that removed fallocate to remember | |
| 18:37:33 | sean-k-mooney | i think we check for odirect | |
| 18:37:37 | clarkb | note docuemntation specifically says fallocate is fine but it isn't anymore | |
| 18:37:50 | clarkb | but it is specifically for how swapfiles are managed by the kernel | |
| 18:38:50 | sean-k-mooney | ok | |
| 18:38:53 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/imagebackend.py#L283-L301= | |
| 18:38:59 | sean-k-mooney | we do this but perhaps that is still ok | |
| 18:39:38 | clarkb | https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/750941 is the change there is a red hat bz link that I can't open | |
| 18:40:56 | sean-k-mooney | thats bad form we are ment to make them public if we are using them in commit or upstream bugs i wonder if there is a reason that lee did not in this case | |
| 18:41:15 | sean-k-mooney | oh because it was rhel9 proably in this cases | |
| 18:41:50 | sean-k-mooney | ya that was commit before cenots 9 or rhel 9 were a thing publicly | |
| 18:53:04 | sean-k-mooney | clarkb: not much in it but you shoudl be able to see it now https://bugzilla.redhat.com/show_bug.cgi?id=1827115 | |
| 18:53:40 | sean-k-mooney | tldr fallocate -z shoud be the same as dd and result in no holes | |
| 18:54:59 | clarkb | I wonder if it is any faster at that point | |
| 18:55:07 | clarkb | might be worth testing that as creating the file can be slow at time | |
| 18:55:52 | sean-k-mooney | ya not really sure to be honest | |
| 18:58:57 | clarkb | sean-k-mooney: https://lkml.org/lkml/2020/9/24/810 | |
| 18:59:21 | clarkb | maybe it is all happy now again | |
| 19:00:51 | sean-k-mooney | i cant view the last message but the previous ones in that thread look promising at least | |
| 19:07:41 | sean-k-mooney | clarkb: if there was a performace hit we could just revert lees change. shall i open a revert and see if it works? | |
| 19:08:32 | sean-k-mooney | i guess we would need a DNM test patch agaisnt devstack to test all the distros that depending on the revert | |
| 19:09:23 | sean-k-mooney | actully we proably should talk about this in #openstack-qa isntead | |
| 19:16:33 | opendevreview | sean mooney proposed openstack/nova master: enable locking test fixture https://review.opendev.org/c/openstack/nova/+/838942 | |
| 19:16:44 | sean-k-mooney | artom: gibi ^ that shoudl fix it | |
| 19:19:32 | lyarwood | sean-k-mooney: FWIW the bug was public when I linked it, it was made private by someone else a few months later. | |
| 19:19:54 | lyarwood | sean-k-mooney: also looks like that switch for fallocate landed after my original change | |
| 19:20:37 | opendevreview | Ghanshyam proposed openstack/nova master: Update python classifier as per testing runtime https://review.opendev.org/c/openstack/nova/+/838943 | |
| 19:20:47 | sean-k-mooney | lyarwood: ack not blaming you by the way i assumed you had a good reason to keep it private ot that it was public when you filed it but didnt check who made it private | |
| 19:21:00 | lyarwood | Yeah no issues | |
| 19:22:21 | sean-k-mooney | i was going to submit a revirt but i see were are not actully passing -z | |
| 19:22:36 | artom | sean-k-mooney, that make sense, but why did we not hit more often upstream> | |
| 19:22:37 | artom | ? | |
| 19:22:39 | sean-k-mooney | i might try updating it to use -z and regert the size ot 8192 | |
| 19:22:42 | artom | In downstream CI it's 100% | |
| 19:23:00 | sean-k-mooney | artom: the upper constrait bump only happend 2 months ago | |
| 19:23:16 | sean-k-mooney | so i guess we only started seeing it recently | |
| 19:23:24 | sean-k-mooney | it could be realted to mirrors having old versions | |
| 19:23:29 | sean-k-mooney | but not really sure | |
| 19:24:02 | opendevreview | Ghanshyam proposed openstack/python-novaclient master: Update python classifier as per testing runtime https://review.opendev.org/c/openstack/python-novaclient/+/838944 | |
| 19:27:08 | artom | sean-k-mooney, ah, so actually, lemme test that with my downstream DNM patch | |
| 19:31:32 | sean-k-mooney | that shoudl be a clean cherry pick to wallby since i actuly did it on wallayb first and then stashed it checkout masters and applied it | |
| 19:31:52 | sean-k-mooney | so i can chery pick it upstream and then do it downstream if you like | |
| 19:52:10 | opendevreview | sean mooney proposed openstack/nova stable/yoga: enable locking test fixture https://review.opendev.org/c/openstack/nova/+/838877 | |
| 19:52:36 | sean-k-mooney | ... damit | |
| 19:52:47 | sean-k-mooney | gerrit nolonger addes the cherry-picked form lines by default | |
| 19:53:07 | sean-k-mooney | oh i bet its because its not merged. | |
| 19:54:36 | opendevreview | sean mooney proposed openstack/nova stable/yoga: enable locking test fixture https://review.opendev.org/c/openstack/nova/+/838877 | |
| 19:55:11 | opendevreview | sean mooney proposed openstack/nova stable/xena: enable locking test fixture https://review.opendev.org/c/openstack/nova/+/838945 | |
| 19:55:49 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: enable locking test fixture https://review.opendev.org/c/openstack/nova/+/838946 | |
| 20:02:37 | melwitt | sean-k-mooney: correct, it will add the lines only if merged | |
| 20:11:48 | clarkb | sean-k-mooney: ya probably worth a revert to check it | |
| 21:59:34 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Run against performance.json patch https://review.opendev.org/c/openstack/nova/+/838934 | |
| 22:04:52 | opendevreview | Ghanshyam proposed openstack/nova master: Update python testing as per zed cycle teting runtime https://review.opendev.org/c/openstack/nova/+/838943 | |
| 22:06:24 | opendevreview | Ghanshyam proposed openstack/nova master: Update python testing as per zed cycle teting runtime https://review.opendev.org/c/openstack/nova/+/838943 | |
| #openstack-nova - 2022-04-22 | |||
| 01:26:00 | songwenping_ | sean-k-mooney: yeah, i will. | |
| 02:54:27 | opendevreview | Billy Olsen proposed openstack/nova master: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/838976 | |
| 06:32:31 | opendevreview | Wenping Song proposed openstack/nova-specs master: Usage of new trait of OWNER_NOVA https://review.opendev.org/c/openstack/nova-specs/+/819510 | |
| 07:04:58 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add workaround to skip compareCPU() check on the destination https://review.opendev.org/c/openstack/nova/+/838926 | |
| 07:21:04 | gibi | bauzas: that is sort of un unblocking change https://review.opendev.org/c/openstack/nova/+/838942 | |
| 07:21:11 | gibi | and a simple fix | |
| 07:21:13 | gibi | sean-k-mooney: thanks! | |
| 07:24:37 | bauzas | gibi: do you know which specific change in os-brick added fs locks ? | |
| 07:26:02 | gibi | bauzas: here https://review.opendev.org/q/ecaf7f8962e12b43f9759ddc1b608f30eb9f5ebb | |
| 07:27:53 | bauzas | oh this was very old | |
| 07:28:29 | bauzas | gibi: I'm about to respin https://review.opendev.org/c/openstack/nova/+/838942 because we miss the osbrick version that creates our problem | |
| 07:28:46 | bauzas | at least in the commit msg | |
| 07:29:11 | bauzas | AFAICS, this was delivered in 5.1.0, right? | |
| 07:30:22 | gibi | sure, feel free to respin. I'm not sure about the version | |
| 07:31:04 | bauzas | comes from https://review.opendev.org/c/openstack/os-brick/+/814139 | |
| 07:31:15 | bauzas | which was released by 5.1.0 | |
| 07:31:24 | gibi | ahh I see now | |
| 07:31:27 | gibi | yes | |
| 07:31:29 | gibi | it is 5.1 then | |
| 07:32:48 | opendevreview | Jorhson Deng proposed openstack/nova master: Reset the instance's task_state to None when the status is error https://review.opendev.org/c/openstack/nova/+/838991 | |
| 07:36:07 | opendevreview | Sylvain Bauza proposed openstack/nova master: enable locking test fixture https://review.opendev.org/c/openstack/nova/+/838942 | |
| 07:36:18 | bauzas | gibi : ^ | |
| 07:41:09 | gibi | thanks, +A | |
| 07:50:27 | bauzas | gibi: I'm still confused by the urgency | |
| 07:50:31 | bauzas | gibi: https://github.com/openstack/nova/blame/master/requirements.txt#L50 | |
| 07:50:45 | bauzas | gibi: we use os-brick 5.2 for 4 months now | |
| 07:52:23 | bauzas | gibi: and that's only then we upgraded from 4.3.1 https://github.com/openstack/nova/commit/b5e2128f3847d444a808a2b0f89e6f1e4ffb77fc | |
| 08:06:10 | gibi | bauzas: there is a common confusion why it is not happening all the time for us upstream | |
| 08:06:21 | gibi | but there was reports back from january that it happens locally | |
| 08:06:40 | gibi | and I think now it happens downstream 100% | |
| 08:06:47 | gibi | hence the urgency :) | |
| 08:07:16 | gibi | honestly when it was first reported I was not able to reproduce it locally on my previous laptop | |
| 08:07:23 | gibi | but with my new laptop I saw it once | |
| 08:07:35 | gibi | so I guess it depends on some version caches | |
| 08:13:28 | bauzas | gibi: ack thanks | |
| 08:14:34 | kashyap | gibi: Getting out of the venv and recreating the 'tox' env resolved it. (I thought I tried this last night) | |
| 08:14:58 | gibi | kashyap: great, then mistery resolved :) | |
| 08:15:03 | kashyap | Yep | |
| 08:57:55 | opendevreview | Merged openstack/nova master: Update python testing as per zed cycle teting runtime https://review.opendev.org/c/openstack/nova/+/838943 | |
| 08:58:00 | opendevreview | Merged openstack/placement master: Make perfload jobs fail if write allocation fails https://review.opendev.org/c/openstack/placement/+/828438 | |