| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-24 | |||
| 12:42:23 | yuval | "supports_remote_managed_ports": os_traits.COMPUTE_REMOTE_MANAGED_PORTS, | |
| 12:42:23 | yuval | File "/home/yuval/workspace/opendev/nova/nova/virt/driver.py", line 129, in <module> | |
| 12:42:31 | yuval | I get this while running unittests | |
| 12:42:40 | yuval | what I am doing wrong? | |
| 12:43:09 | opendevreview | Merged openstack/nova master: Lightbits LightOS driver https://review.opendev.org/c/openstack/nova/+/821606 | |
| 12:43:10 | gibi | yuval: you need to rebuild you tox env | |
| 12:43:22 | gibi | yuval: it probably has an old os-traits lib | |
| 12:43:30 | yuval | tox -e ? | |
| 12:43:35 | gibi | yuval: try tox -r -e <env> | |
| 12:43:37 | yuval | or remove it | |
| 12:43:39 | gibi | the -r is the rebuild | |
| 12:43:43 | yuval | ok | |
| 12:43:44 | gibi | or you can remove .tox dir | |
| 12:43:46 | yuval | thanks | |
| 12:43:55 | yuval | yes I will try it if it wont work | |
| 12:44:06 | sean-k-mooney | yuval: ya this is likely just an old os-traits version | |
| 12:44:16 | sean-k-mooney | the other way to fix it is to manually install it | |
| 12:44:42 | sean-k-mooney | .tox/<env>/bin/python3 -m pip install -U os-traits | |
| 12:45:19 | sean-k-mooney | that is also how you can locally test with os-triats changes that are not released | |
| 12:45:51 | gibi | bauzas, gmann: I'v started re-reading the policy series and I have concerns about assisted volume snapshot https://review.opendev.org/c/openstack/nova/+/828994/7/nova/api/openstack/compute/assisted_volume_snapshots.py#42 | |
| 12:45:52 | sean-k-mooney | just replace os-triats with the path to the git repo on disk | |
| 13:00:45 | opendevreview | Merged openstack/nova master: libvirt: Register defaults for undefined hw image properties https://review.opendev.org/c/openstack/nova/+/800708 | |
| 13:00:54 | opendevreview | Merged openstack/nova master: manage: Add image_property commands https://review.opendev.org/c/openstack/nova/+/824392 | |
| 13:02:55 | yuval | hey added release note | |
| 13:05:44 | yuval | I got a little mixed up with git issues | |
| 13:06:00 | yuval | I edited the changes without pulling latest version | |
| 13:06:09 | yuval | then had to rebase | |
| 13:06:47 | yuval | ahhh | |
| 13:06:59 | yuval | its merged before I added the release note | |
| 13:07:11 | yuval | ok, I am uploading a followup | |
| 13:10:05 | gibi | yuval: release not as a follow up is OK | |
| 13:11:19 | sean-k-mooney | yuval: since you have not pushed yet can you reference the gerrit change id for the lightos feature patch in the commit | |
| 13:11:55 | yuval | its a special syntax or just followup for: <changeid> | |
| 13:12:19 | sean-k-mooney | no special syntax so followup for: ... is fine | |
| 13:12:31 | sean-k-mooney | just makes it simpler to corralate them in the future | |
| 13:12:40 | sean-k-mooney | you will still need the normal change id | |
| 13:13:23 | sean-k-mooney | in the normal way but if you reference the other one in the commit message body we can copy paste and find the relevent review if we ever need too in the future | |
| 13:14:24 | opendevreview | yuval proposed openstack/nova master: Lightos driver release note https://review.opendev.org/c/openstack/nova/+/830817 | |
| 13:15:15 | sean-k-mooney | cool commit message looks fine ill review the rest later | |
| 13:16:18 | opendevreview | yuval proposed openstack/nova master: Lightos driver release note https://review.opendev.org/c/openstack/nova/+/830817 | |
| 13:16:59 | yuval | thank you | |
| 13:33:43 | sean-k-mooney | gibi: chateaulav im also +2 on the emulation patches. i think the testign coudl be imporved in the futrue but just wanted to point out that https://review.opendev.org/c/openstack/nova/+/822053/63 is in merge conflict | |
| 13:34:04 | sean-k-mooney | so likely we will need to rebase the series before it can proceed | |
| 13:34:10 | chateaulav | ok | |
| 13:35:41 | sean-k-mooney | chateaulav: if you rebase it im ok with fast approving or im sure gibi woudl be happy to reapove too | |
| 13:41:58 | chateaulav | ok, and just to make sure i dont screw this up i should follow: https://docs.opendev.org/opendev/infra-manual/latest/developers.html#rebasing-a-commit ? | |
| 13:42:18 | sean-k-mooney | chateaulav: just do the following | |
| 13:42:22 | sean-k-mooney | git fetch --all | |
| 13:42:31 | sean-k-mooney | git rebase origin/master | |
| 13:42:33 | sean-k-mooney | git review | |
| 13:42:53 | sean-k-mooney | from the top patch in the series | |
| 13:43:11 | chateaulav | ok, | |
| 13:43:14 | sean-k-mooney | although you have a syntax error in the zuul patch where you defien the regex | |
| 13:43:15 | chateaulav | sounds good | |
| 13:43:23 | sean-k-mooney | so you might want to fix that before you do the git review | |
| 13:43:37 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/fdf39c2132e844799465d04c6200429c/log/job-output.txt#30091 | |
| 13:45:46 | sean-k-mooney | chateaulav: actully i think that issue is coming form the parent job | |
| 13:51:04 | sean-k-mooney | chateaulav: can you add tox_envlist: 'all' https://review.opendev.org/c/openstack/nova/+/828372/28/.zuul.yaml | |
| 13:51:17 | sean-k-mooney | chateaulav: that should fix the job issue | |
| 13:51:24 | chateaulav | ok | |
| 13:52:29 | gibi | chateaulav, sean-k-mooney: I can reapprove sure | |
| 13:53:14 | sean-k-mooney | chateaulav: i think the job is defaulting to the smoke env https://github.com/openstack/tempest/blob/master/tox.ini#L227-L235 | |
| 13:53:42 | sean-k-mooney | all https://github.com/openstack/tempest/blob/master/tox.ini#L58-L68 will allow you to fully contol what tests run via the zuul job | |
| 14:14:46 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 14:14:47 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 14:14:47 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 14:17:49 | chateaulav | most stressfull rebase ever... everything is updated, waiting on checks to run | |
| 14:18:48 | sean-k-mooney | :) im sure it will be fine | |
| 14:20:03 | sean-k-mooney | ah it was the image property regesistration patch it conflicted with | |
| 14:20:10 | chateaulav | yeah | |
| 14:21:20 | sean-k-mooney | ok well im +2 on the rebase it looks correct to me | |
| 14:21:37 | chateaulav | thanks sean-k-mooney and gibi | |
| 14:22:37 | sean-k-mooney | ill check back on the ci results later for the zuul patch | |
| 14:46:09 | opendevreview | sean mooney proposed openstack/nova master: update default overcommit https://review.opendev.org/c/openstack/nova/+/830829 | |
| 14:53:08 | dmitriis | do the move to extra_info first or after this change is in. | |
| 14:53:08 | dmitriis | sean-k-mooney: RE https://review.opendev.org/c/openstack/nova/+/829974 I have a fix for the migration & unshelve scenarios here (binding:profile updates) along with func tests. I could work on making vf_num and pf_mac_address to be stored in extra_info but need to clarify the ordering. It's close to freeze time so I just wanted to know whether to | |
| 14:53:09 | gmann | gibi: thanks for catching that, I missed that it is called from cinder. | |
| 14:53:14 | gmann | gibi: I will update | |
| 14:58:55 | sean-k-mooney | dmitriis: im not sure of the status of gibis change to store the mac in extra info | |
| 14:59:34 | gibi | sean-k-mooney: it is in the works | |
| 14:59:36 | sean-k-mooney | i woudl proably defer moving it to extra_info until after this change | |
| 14:59:55 | gibi | sean-k-mooney: I can publish the code today the funct testing will take more time | |
| 15:00:16 | dmitriis | sean-k-mooney, gibi: ack | |
| 15:00:30 | gibi | I'm OK moving forward with dmitriis fix that is up and refactor it later | |
| 15:00:43 | sean-k-mooney | ack that is what i was going to ask | |
| 15:01:04 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/829974 is addin more call to the pci utils but that can be refactored later | |
| 15:01:25 | sean-k-mooney | and i think having move operation work is proably more imporant then purity in this case | |
| 15:01:49 | sean-k-mooney | given we should be able to backport the refactor after FF i think | |
| 15:02:47 | sean-k-mooney | dmitriis: ill try and review that fully later today | |
| 15:03:09 | dmitriis | sean-k-mooney: ack, ty | |
| 15:15:20 | gibi | ack I will review too | |
| 15:55:45 | sean-k-mooney | dmitriis: +1 on https://review.opendev.org/c/openstack/nova/+/829974 comments inline | |
| 15:56:11 | gibi | dmitriis: I also left comments inline https://review.opendev.org/c/openstack/nova/+/829974 just now | |
| 15:58:56 | melwitt | gibi: answered. I also see the series is in merge conflict so I have to rebase it 😩 | |
| 15:59:14 | sean-k-mooney | chateaulav: looking at the realtime status of https://review.opendev.org/c/openstack/nova/+/822053/64 in zuul the tox jobs are going to fail | |
| 16:00:03 | chateaulav | tracking, taking a look now | |
| 16:00:10 | dmitriis | sean-k-mooney, gibi: looking | |
| 16:00:14 | sean-k-mooney | melwitt: do we need to start stacking series and or wait for unified limists to merge before mergeing others | |
| 16:00:24 | gibi | melwitt: thanks for the answer I missed the fact that it ius differnt coverage. Then I think it make sense to keep both coverage in place | |
| 16:01:40 | bauzas | melwitt: don't be afraid, we can merge your series tomorrow if needed | |