| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-14 | |||
| 14:08:38 | tobias-urdin | stable backport | |
| 14:09:01 | opendevreview | Tobias Urdin proposed openstack/nova stable/xena: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/828407 | |
| 15:04:32 | dmitriis | https://review.opendev.org/c/openstack/nova-specs/+/828177 lost a WF+1 during a rebase to fix a doc test failure - if anybody has time | |
| 15:11:32 | gibi | dmitriis: fixed | |
| 15:11:38 | dmitriis | gibi: tyvm | |
| 15:31:21 | chateaulav | dansmith: i imagine id want to just do a 'del primitive' if it meets thats case, correct? | |
| 15:31:48 | opendevreview | Merged openstack/nova-specs master: Late Amendments to the Off-path Backends Spec https://review.opendev.org/c/openstack/nova-specs/+/828177 | |
| 15:43:17 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 15:43:24 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 15:43:24 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 15:43:25 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 15:50:49 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 15:51:57 | dansmith | chateaulav: you didn't add the field, you just added an enum value, so no, I don't think deleting the primitive entirely is really the right approach | |
| 15:52:22 | dansmith | chateaulav: I haven't looked, but did you determine why the field is being set to riscv32 if we're not running guests configured thusly? | |
| 15:53:43 | gibi | dansmith: I think the compute node has all the supported arch listed in supported_hv_specs field. And in grenade, during the live migration the old compute loads the new compute from the DB and sees a HVSpec with the new value | |
| 15:54:17 | dansmith | gibi: oh is this a list of all the possible supported specs? | |
| 15:54:35 | gibi | dansmith: I think so | |
| 15:54:37 | chateaulav | dansmith: yes. | |
| 15:54:59 | dansmith | ah, I see. So the thing that needs to happen is remove that object from the list, which you can't do in the backport of the offending object of course | |
| 15:55:15 | dansmith | this is one reason we have list objects, but no such container is used here I think | |
| 15:55:39 | dansmith | so if the list is on the compute node, you'll need to do it in the compute node's backport routine, which I assume is what gibi was originally suggesting | |
| 15:56:01 | gibi | dansmith: yeah, something like that | |
| 15:56:17 | dansmith | I thought this was representing a single guest, not expecting one to be set to riscv32, but now the tie to the compute node makes more sense :) | |
| 15:56:20 | chateaulav | dansmith: ok, that makes more sense. | |
| 15:58:45 | chateaulav | so then ill need to bump the version there in order to do a proper backport | |
| 15:58:46 | gibi | dansmith: yeah, that casuse my inital confusion too | |
| 15:59:11 | gibi | chateaulav: yes, I think so. bump the compute ovo version and in the backport code drop the HVSpec from the list that has new value | |
| 16:00:29 | dansmith | chateaulav: yes | |
| 16:18:09 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 16:44:04 | gmann | bauzas: sure, that series is in my list for today. | |
| 16:47:44 | melwitt | bauzas: if you get a chance, would appreciate your review on this backport that is two patches squashed together https://review.opendev.org/c/openstack/nova/+/825064 I did the squash so it would be best if someone else can review that | |
| 17:21:46 | bauzas | melwitt: easy peasy, done | |
| 17:21:58 | bauzas | gmann: I had a question about the approach for merging stuff | |
| 17:22:27 | bauzas | gmann: given the first patch has a microversion, we would hold this one until we review the whole series ? | |
| 17:29:02 | bauzas | ok, /me needs to leave | |
| 17:29:04 | bauzas | \o | |
| 17:33:44 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 17:34:01 | melwitt | bauzas: thanks :) | |
| 17:35:56 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 17:40:29 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 17:42:28 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 17:46:02 | gmann | bauzas: yes, you are right. I am +2 on first patch but -W until we get the whole series ready to go. | |
| 17:53:44 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 18:01:59 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 18:01:59 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 18:02:00 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 20:26:30 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 20:26:31 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 20:26:31 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 21:14:50 | opendevreview | yuval proposed openstack/nova master: Lightbits LightOS driver https://review.opendev.org/c/openstack/nova/+/821606 | |
| 21:23:25 | opendevreview | Ade Lee proposed openstack/nova master: DNM - patch paramiko to get around ed25519 problem https://review.opendev.org/c/openstack/nova/+/829135 | |
| 23:55:19 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| #openstack-nova - 2022-02-15 | |||
| 00:00:02 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 00:14:09 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 00:34:02 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 00:35:13 | opendevreview | David Hill proposed openstack/nova master: Fail on parse_dom if vif quota sizes > 32 bit unsigned int https://review.opendev.org/c/openstack/nova/+/829064 | |
| 00:40:07 | opendevreview | David Hill proposed openstack/nova master: Validate burst value is equal or smaller than 4194303 https://review.opendev.org/c/openstack/nova/+/829064 | |
| 07:00:29 | opendevreview | Takashi Kajinami proposed openstack/nova stable/xena: Fix the wrong exception used to retry detach API calls https://review.opendev.org/c/openstack/nova/+/829049 | |
| 08:27:23 | gibi | sean-k-mooney: hi! when you are up, regarding https://bugs.launchpad.net/neutron/+bug/1942329 I made some progress and added a proposal to the today's neutron meeting https://wiki.openstack.org/wiki/Network/Meetings#On_Demand_Agenda you might be interested | |
| 09:44:51 | opendevreview | alecorps proposed openstack/nova master: VMware: Support volumes backed by VStorageObject https://review.opendev.org/c/openstack/nova/+/808791 | |
| 11:14:54 | sean-k-mooney | gibi: oh ok cool so that is something we can fix entirly on the neutron side | |
| 11:15:03 | sean-k-mooney | * entirly on the nova side | |
| 11:15:14 | gibi | sean-k-mooney: nope we need both nova and neutron change | |
| 11:15:18 | sean-k-mooney | we just need to update the mac addres in the neutron port when we migrate | |
| 11:15:36 | sean-k-mooney | well you are thinking of extending the port bindings? | |
| 11:15:45 | sean-k-mooney | to avoid just doing the mac update? | |
| 11:16:01 | gibi | 1) in single binding case we need to update the mac on a bound port that is rejected today by neutron | |
| 11:16:13 | sean-k-mooney | ah ok | |
| 11:16:21 | gibi | 2) in multi binding case we might want to keep the MAC per binding to be able to switch | |
| 11:16:21 | sean-k-mooney | i didnt know that would be rejected | |
| 11:16:38 | sean-k-mooney | yep | |
| 11:17:05 | sean-k-mooney | the thing is the mac is not part of the port binding | |
| 11:17:19 | sean-k-mooney | which i guess is why we need neutron changes | |
| 11:17:24 | gibi | but then we need neturon to use the MAC from the active binding when returning a port | |
| 11:17:45 | gibi | yes, and that is a neutron change too | |
| 11:17:46 | sean-k-mooney | right but the mac is an atribute or the port extention | |
| 11:17:52 | gibi | yes, | |
| 11:18:26 | sean-k-mooney | rather then port binding extentions so ya if we do that we obviously need to handel this slight differently | |
| 11:18:27 | gibi | so we need to be carefully overlay the mac from the active binding top of the port.mac_address field | |
| 11:18:44 | gibi | if there is a binding | |
| 11:19:01 | sean-k-mooney | what i was orginaily thinking is we would not update the mac until after we had activated teh dest binding | |
| 11:19:10 | sean-k-mooney | but if we cant update the port while its bound | |
| 11:19:13 | sean-k-mooney | then that is not an option | |
| 11:20:21 | gibi | we could relax the check in neutron to allow mac update if the same request updates the binding:host_id but it becomes messy when we have multiple binding or if nova needs to update the mac separately from the binding activation | |
| 11:20:21 | sean-k-mooney | by the way technically when we update binding:host_id we are unbinding and rebinding the port so we really should be able to update the mac in that case | |
| 11:20:33 | sean-k-mooney | ya | |
| 11:20:51 | sean-k-mooney | i can see why you would want to extend the port bidnign extention | |
| 11:21:00 | sean-k-mooney | that seams reasonable to me | |
| 11:21:13 | sean-k-mooney | and just have neutron do the mac update when we do the activation | |
| 11:21:21 | gibi | the API request that activates the binding cannot carry a mac update today so that path is a lot harder to take | |
| 11:21:37 | gibi | so I would put the mac to the binding instead | |
| 11:21:37 | sean-k-mooney | in the cold migrate case we will still need to be able to update the mac when setting the host id however | |
| 11:22:04 | gibi | sean-k-mooney: you are right we have two cases | |
| 11:22:29 | sean-k-mooney | we are not allow to write to the port binding:details but you can put the "migrate_mac" in the binding:profile | |
| 11:22:40 | gibi | sean-k-mooney: I'm wondering if we can add the mac to the binding in case of cold migrate and let neutron multiple binding logic see that as the single active binding | |
| 11:23:04 | sean-k-mooney | gibi: we could also finally start using multiple port binding for cold migration | |
| 11:23:12 | sean-k-mooney | we already do for cross cell | |
| 11:23:14 | gibi | that is a biiig change | |
| 11:23:26 | gibi | afaik | |
| 11:23:29 | gibi | but yes | |