| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-08 | |||
| 19:46:04 | chateaulav | https://www.irccloud.com/pastebin/XwYHRJuH/ | |
| 19:46:19 | chateaulav | any advice is appreciated | |
| 19:51:32 | artom | chateaulav, you don't need Depends-on if it's in the same project (nova) | |
| 19:51:39 | artom | Just stack them on top of each other | |
| 19:52:03 | artom | IOW, locally `git commit` as many patches as makes sense, then `git review` them in one shot | |
| 19:53:33 | chateaulav | ok, so then to make sure i understand. remove the depends on, make all my commits and then when all the commits are staged do review and it will run all of them. | |
| 19:55:00 | artom | Yep | |
| 19:55:16 | artom | So if you have A depends on B depends on C | |
| 19:55:28 | artom | Commit C first, then B, then A, then submit for review | |
| 19:56:32 | artom | And if you have A depends on B depends on C but also D depends on C | |
| 19:56:50 | artom | Commit C first, then C and D in either order, then A | |
| 19:56:57 | artom | "linearize" it, so to speak | |
| 19:57:17 | artom | Sorry, then B and D in any order, then A | |
| 20:12:02 | chateaulav | artom: ok, makes sense | |
| 20:18:06 | opendevreview | Pedro Monteiro Azevedo de Moura Almeida proposed openstack/nova master: Update live_migration_downtime definition https://review.opendev.org/c/openstack/nova/+/828387 | |
| 20:25:37 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 20:26:08 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 20:26:19 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 20:54:08 | opendevreview | Pedro Monteiro Azevedo de Moura Almeida proposed openstack/nova master: Update live_migration_downtime definition https://review.opendev.org/c/openstack/nova/+/828387 | |
| 22:23:49 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Bump os-traits to 2.7.0 https://review.opendev.org/c/openstack/nova/+/826675 | |
| 22:23:49 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Introduce remote_managed tag for PCI devs https://review.opendev.org/c/openstack/nova/+/824834 | |
| 22:23:50 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Filter computes without remote-managed ports early https://review.opendev.org/c/openstack/nova/+/812111 | |
| 22:23:50 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Add supports_remote_managed_ports capability https://review.opendev.org/c/openstack/nova/+/827839 | |
| 22:23:51 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Document remote-managed port usage considerations https://review.opendev.org/c/openstack/nova/+/827513 | |
| 22:23:51 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Add support for VNIC_REMOTE_MANAGED https://review.opendev.org/c/openstack/nova/+/824835 | |
| 22:56:49 | opendevreview | Merged openstack/nova master: neutron: Rework how we check for extensions https://review.opendev.org/c/openstack/nova/+/705792 | |
| 23:32:56 | opendevreview | melanie witt proposed openstack/placement master: Make perfload jobs fail if write allocation fails https://review.opendev.org/c/openstack/placement/+/828438 | |
| 23:58:31 | opendevreview | melanie witt proposed openstack/placement master: Make perfload jobs fail if write allocation fails https://review.opendev.org/c/openstack/placement/+/828438 | |
| #openstack-nova - 2022-02-09 | |||
| 06:38:10 | opendevreview | melanie witt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | |
| 06:38:10 | opendevreview | melanie witt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | |
| 06:38:11 | opendevreview | melanie witt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | |
| 06:38:11 | opendevreview | melanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | |
| 06:38:12 | opendevreview | melanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | |
| 06:38:12 | opendevreview | melanie witt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | |
| 06:38:13 | opendevreview | melanie witt proposed openstack/nova master: Add legacy limits and usage to placement unified limits https://review.opendev.org/c/openstack/nova/+/713498 | |
| 06:38:13 | opendevreview | melanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | |
| 06:38:14 | opendevreview | melanie witt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | |
| 06:38:14 | opendevreview | melanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | |
| 06:38:16 | opendevreview | melanie witt proposed openstack/nova master: Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | |
| 08:31:59 | gibi | melwitt: thanks a lot for the quick re-review on the any-traits series | |
| 10:50:52 | tobias-urdin | gibi: sorry for the delay but i've updated the bugfix as requested https://review.opendev.org/c/openstack/nova/+/827865 | |
| 10:58:29 | gibi | tobias-urdin: thanks. I'm +2 on the fix | |
| 11:01:39 | sean-k-mooney | looks good to me too | |
| 11:07:55 | opendevreview | Felix Huettner proposed openstack/nova master: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/828516 | |
| 11:22:06 | tobias-urdin | thx, you guys ok with backporting with the rename of the internal function in libvirt driver? | |
| 11:22:36 | sean-k-mooney | its not part of the driver api so it should be fine | |
| 11:22:58 | tobias-urdin | ack | |
| 11:24:05 | gibi | yepp, feel free to propose the backports | |
| 11:24:54 | opendevreview | Tobias Urdin proposed openstack/nova stable/wallaby: libvirt: Add announce-self post live-migration workaround https://review.opendev.org/c/openstack/nova/+/825178 | |
| 11:56:38 | sean-k-mooney | gibi: dmitriis im +2 on all the off-path backend series bar the docs patch at the end | |
| 11:57:29 | dmitriis | sean-k-mooney: ack, I am finishing up some changes to the doc patch | |
| 11:57:56 | dmitriis | interestingly, the mlx5 driver doesn't allow "trusted" to be set on a VF so I'll document that as a limitation | |
| 11:58:37 | dmitriis | i.e. some drivers may not allow you to do that which will limit the use of the promisc mode presumably - I'll explore more | |
| 11:59:13 | dmitriis | RTNETLINK answers: Operation not permitted | |
| 11:59:13 | dmitriis | $ sudo ip link set enp130s0f0 vf 0 trust off ; echo $? | |
| 11:59:13 | dmitriis | 2 | |
| 11:59:13 | dmitriis | $ sudo ip link set enp130s0f0 vf 0 trust on ; echo $? | |
| 11:59:15 | dmitriis | 2 | |
| 11:59:30 | sean-k-mooney | dmitriis: ya it depend on the driver | |
| 11:59:40 | sean-k-mooney | but honestly i hate that feature so meh | |
| 12:00:14 | dmitriis | sean-k-mooney: yeah, just trying to go through various combinations that may break | |
| 12:00:14 | sean-k-mooney | promisc mode is a security threat and it degrades performance | |
| 12:00:19 | dmitriis | agreed | |
| 12:00:56 | sean-k-mooney | at some point i woudl liek to stop using the binding_profile to enabel that too and actully have a api extension instead | |
| 12:01:37 | sean-k-mooney | this is currently the only value that can be set in the binding_profile that is not set by nova | |
| 12:01:51 | sean-k-mooney | and as a result we have to filter what we store in it | |
| 12:01:59 | sean-k-mooney | when clearing it as you saw | |
| 12:02:08 | dmitriis | yes, it feels very unnatural | |
| 12:04:21 | sean-k-mooney | ok i have an apointment in 40 mins so i better go. ill be back in a few hours | |
| 12:04:27 | dmitriis | sean-k-mooney: thanks a lot for all the support on this patch series - it's been quite a challenge to get it to this point | |
| 12:04:42 | sean-k-mooney | ack your almost there | |
| 12:29:10 | gibi | sean-k-mooney: I will check it a bit later | |
| 12:57:32 | opendevreview | Felix Huettner proposed openstack/nova master: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/828516 | |
| 13:03:30 | artom | gdi test_tagged_attachment is failing in nova-next on xena as well | |
| 13:03:43 | opendevreview | Felix Huettner proposed openstack/nova master: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/828516 | |
| 13:10:38 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add nova-ovs-hybrid-plug job https://review.opendev.org/c/openstack/nova/+/828418 | |
| 13:10:39 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/828419 | |
| 13:16:34 | opendevreview | Merged openstack/nova master: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/827865 | |
| 13:17:00 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Document remote-managed port usage considerations https://review.opendev.org/c/openstack/nova/+/827513 | |
| 13:30:17 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Fix clean-up process for aborted queued live migrations https://review.opendev.org/c/openstack/nova/+/828374 | |
| 13:33:21 | opendevreview | Tobias Urdin proposed openstack/nova stable/xena: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/828407 | |
| 14:26:54 | gibi | gmann: can I fix this bug outside of an api microversion? or this also needs an api microversion to be fixed? https://review.opendev.org/c/openstack/placement/+/826491/7#message-af8324d5631836fe3ec8052192994f9a42e00492 | |
| 14:27:31 | gibi | sean-k-mooney, bauzas, melwitt ^^ | |
| 14:28:51 | sean-k-mooney | we have not done a release yet with any traits so if its a bug in the any traits impl i dont think we need a microversion | |
| 14:28:56 | sean-k-mooney | just reading now | |
| 14:29:41 | opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: Add nova-ovs-hybrid-plug job https://review.opendev.org/c/openstack/nova/+/828413 | |
| 14:29:42 | opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/828414 | |
| 14:29:43 | opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: skip test_tagged_attachment in nova-next https://review.opendev.org/c/openstack/nova/+/828542 | |
| 14:30:14 | gibi | sean-k-mooney: this is a bug without any traits | |
| 14:30:42 | sean-k-mooney | oh sorry i was ment to read the comment not the commit message | |
| 14:30:45 | gibi | sean-k-mooney: today placement accepts !!!!!!FOO as a forbidden trait as it strips all the ! | |
| 14:30:53 | sean-k-mooney | i didnt scorll down | |
| 14:31:09 | sean-k-mooney | ah | |
| 14:31:30 | sean-k-mooney | well i thinkn that shoudl be fixable if you make it a 400 | |
| 14:31:46 | sean-k-mooney | given ! is not allowed in a trait other then to mark it forbiden | |
| 14:32:10 | sean-k-mooney | gibi: is there an error in our regex for validation or do we only validate that in nova | |
| 14:32:29 | gibi | placement does not validate that with a schema | |
| 14:32:43 | sean-k-mooney | ah ok https://github.com/openstack/nova/blob/master/nova/api/validation/extra_specs/traits.py | |
| 14:32:52 | sean-k-mooney | so we do if you enable the extra spec validation | |
| 14:33:12 | sean-k-mooney | but i guess images and direct request could still contian the invalid traits | |