| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-07 | |||
| 12:30:02 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove use of non-integer/slice indices https://review.opendev.org/c/openstack/placement/+/801104 | |
| 12:30:03 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove unnecessary use of '_mapping' https://review.opendev.org/c/openstack/placement/+/801107 | |
| 12:30:03 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Use explicit transactions https://review.opendev.org/c/openstack/placement/+/801106 | |
| 12:30:04 | opendevreview | Stephen Finucane proposed openstack/placement master: tests: Restore - don't reset - warning filters https://review.opendev.org/c/openstack/placement/+/828119 | |
| 12:30:04 | opendevreview | Stephen Finucane proposed openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | |
| 12:31:01 | sean-k-mooney | hehe speaking of placement ^ gibi how is you any trait series coming | |
| 12:32:27 | stephenfin | sean-k-mooney: I'd appreciate reviews on that, btw :) It's all very simple stuff but preps us for sqla 2.0 | |
| 12:32:44 | stephenfin | Need to find time to finish the equivalent nova series /o\ | |
| 12:33:23 | sean-k-mooney | stephenfin: ack i can take a look. im going to try an go thorugh the off path seires this morning maybe this afternoon | |
| 13:01:11 | gibi | sean-k-mooney: melwitt gave +2 on the next patch in the any-traits series | |
| 13:01:20 | gibi | sean-k-mooney: you your eyese are appreciated there too :) | |
| 13:05:56 | bauzas | folks, I'm a bit on and off today, I think I'm impacted by the COVID | |
| 13:07:00 | elodilles | ohh, bauzas get well soon :S | |
| 13:08:34 | elodilles | (i just wanted to ask for a stable review, but then i won't disturb you with that :S) | |
| 13:08:56 | gibi | bauzas: take care! | |
| 13:09:16 | gibi | bauzas: if you need I can cover you tomorrow on the weekly meeting | |
| 13:09:59 | bauzas | gibi: no, unfortunately in France if you're impacted but you WFH, they don't give you some offtime | |
| 13:10:26 | gibi | that sounds bad | |
| 13:10:49 | gibi | anyhow I'm not bound by the french law so I can still cover you if you want :) | |
| 13:16:21 | opendevreview | Tobias Urdin proposed openstack/nova master: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/827865 | |
| 13:16:27 | bauzas | for the moment, I don't have a lot of issues, just some cough, a sore throat and nose blowing | |
| 13:18:00 | bauzas | like if it was a small rhinitis | |
| 13:19:34 | bauzas | fwiw, my daughter got the same on Tuesday and we saw the positif test on Wed so I tested myself too on Wed morning with a selftest, then an antigenic test on Wed evening, and then a PCR test on Thursday | |
| 13:19:41 | bauzas | eventually a last selftest on Friday | |
| 13:19:46 | bauzas | all of them were negative | |
| 13:20:27 | bauzas | but yesterday evening, I selftested again (ie. after 5 days of being negative) and eventually it was positive :( | |
| 13:20:38 | bauzas | hence the PCR test today | |
| 13:20:59 | bauzas | so, see, maybe testing yourself up to J+4 doesn't work | |
| 13:21:11 | bauzas | D+4 I mean | |
| 13:22:31 | gibi | yeah | |
| 13:22:39 | gibi | I heard similar stories | |
| 13:25:06 | bauzas | from what I read, this is specific to Omicron | |
| 13:25:20 | bauzas | for Delta, this worked | |
| 13:25:57 | bauzas | but now, symptoms arrive before the viral charge | |
| 13:26:07 | bauzas | or at the same time | |
| 13:26:41 | bauzas | so, previously, testing yourself at D+3 was verifying your viral charge | |
| 13:28:18 | bauzas | while now, your viral charge would only arrive around D+5 | |
| 13:28:31 | bauzas | the more people know, the better it will be | |
| 13:40:06 | sean-k-mooney | dmitriis: -1 for https://review.opendev.org/c/openstack/nova/+/824833/7/nova/network/neutron.py#1527 | |
| 13:40:39 | dmitriis | sean-k-mooney: looking | |
| 13:41:18 | sean-k-mooney | tl;dr we cant assume a PF has a netdev | |
| 13:41:37 | sean-k-mooney | so you cant assume it has a mac | |
| 13:42:06 | sean-k-mooney | your new fucntion will be called for all VFs not just remote managed ones | |
| 13:42:12 | sean-k-mooney | so you need to not raise | |
| 13:42:28 | sean-k-mooney | just dont include the info if it cant be recived | |
| 13:42:36 | sean-k-mooney | *retrived | |
| 13:43:45 | dmitriis | sean-k-mooney: yeah, a PF can be something else, much like a PF with a netdev can have non-netdev VFs | |
| 13:43:47 | dmitriis | good point | |
| 13:44:28 | sean-k-mooney | we broke this in the past | |
| 13:44:59 | sean-k-mooney | by always trying to get the netdev name for bandwith qos and i broke it differently in a different bugfix | |
| 13:45:07 | sean-k-mooney | so we have been bitten by it twice | |
| 13:46:40 | sean-k-mooney | dmitriis: actully just to reinforce that you cant assume all VFs are nics | |
| 13:46:58 | gibi | ohh, I knew that we cannot assume that netdev exists but I did not realized that to get the MAC we need the netdev | |
| 13:47:01 | sean-k-mooney | that is what we broke with the init qos support we broke vf for qat | |
| 13:47:45 | dmitriis | sean-k-mooney: yeah, Bluefield2 devs have a management VF, for example, which is not a netdev | |
| 13:47:48 | sean-k-mooney | i can triple check how we do the lookup but in general the mac wont be in /sys if the netdev is not created | |
| 13:50:07 | sean-k-mooney | gibi: we do the lookup like this https://github.com/openstack/nova/blob/master/nova/pci/utils.py#L173-L191 | |
| 13:50:20 | sean-k-mooney | which i woudl expect to fail sicne we are geting the netdev path | |
| 13:50:32 | gibi | yeah you are correct | |
| 13:51:01 | sean-k-mooney | dmitriis: anyway hopefully that will be a minor change jsut dont populate the filed if the data is not available | |
| 13:51:21 | sean-k-mooney | im going to continue reviewing the rest of the series in the mean time | |
| 13:51:28 | dmitriis | sean-k-mooney: Thinking about it now, I assumed that since we are in the neutron-related code path and got a PCI device allocated which is a netdev VF, I am safe to assume the PF is also a netdev. However, this may not be true all the time. | |
| 13:51:32 | dmitriis | sean-k-mooney: ack | |
| 13:52:07 | sean-k-mooney | dmitriis: ya that was the assumtion that bit us for the calvim thunderx | |
| 13:52:13 | sean-k-mooney | i even hat that in a comment | |
| 13:52:26 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/777679/3/nova/virt/libvirt/host.py | |
| 13:52:47 | sean-k-mooney | so no we cant assume that | |
| 13:53:08 | dmitriis | sean-k-mooney: yes, I recall fixing something for that comment but I definitely missed this part | |
| 13:54:39 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/805649 | |
| 14:05:28 | gibi | melwitt: fyi the placement perfload job (non voting) probably broken since the consumer types feature https://zuul.opendev.org/t/openstack/build/0d0e850ea9de47e8bf30ad1dbd1d3b91/log/job-output.txt#1163 | |
| 14:05:47 | gibi | melwitt: I think we don't really look at that job so I'm not sure we want to fix it | |
| 14:08:01 | chateaulav | gibi: for the hanging comment about the tempest testing, you mean in addition to an additional ci job, correct? | |
| 14:08:21 | chateaulav | for https://review.opendev.org/c/openstack/nova/+/822053, and thanks for the continued reviews! | |
| 14:08:57 | gibi | chateaulav: yeah so I think a separate job that test some emulation (maybe aarch64) with tempest. But I guess some of the existing tempest test will not work with emulation so we need a trimmed down test list | |
| 14:11:21 | chateaulav | ok, makes sense for the most part. first time messing with tempest, but ill get something together | |
| 14:13:27 | gibi | chateaulav: thanks | |
| 14:17:43 | sean-k-mooney | gibi: chateaulav by the way have either of you got a working vm image for this testing. i think the centos9s cloud image will booth properly on arm (it did on my mac nativly) but i could not get cirros to work | |
| 14:17:56 | sean-k-mooney | the centos image is huge in comparison at almost 700mb | |
| 14:18:03 | gibi | sean-k-mooney: I did not tired | |
| 14:18:48 | sean-k-mooney | ok well that might be one of the chanllages with doing the arm testing via emulation but it is likely fine | |
| 14:19:00 | sean-k-mooney | we can have devstack download addtional images | |
| 14:19:24 | sean-k-mooney | but i was having trouble geting cirrus to boot with uefi in genreal and that is required for aarch64 | |
| 14:19:44 | sean-k-mooney | so uefi on x86 and aarch64 did not seam to work with cirros | |
| 14:20:14 | sean-k-mooney | i got an error with the alingment or either the filesystme or uefi firmware in the console and then no output | |
| 14:20:29 | sean-k-mooney | chateaulav: what have you been using to test with qemu directly? | |
| 14:20:48 | chateaulav | sean-k-mooney: yeah havent tried the cirros on aarch hardware, but on x86 works fine. | |
| 14:20:59 | chateaulav | have code running in a deployment ostack env | |
| 14:21:00 | sean-k-mooney | did you do an install form iso or something else | |
| 14:21:37 | sean-k-mooney | chateaulav: ok so you did arch64 via qemu on x86 with the aarch64 cirros image | |
| 14:21:44 | chateaulav | sean-k-mooney: qcow | |
| 14:21:44 | chateaulav | http://download.cirros-cloud.net/0.5.2/cirros-0.5.2-aarch64-disk.img | |
| 14:21:57 | chateaulav | yes | |
| 14:22:19 | sean-k-mooney | ya i tried that and it woudl not boot on may ubuntu aarch64 vm on my macbook air | |
| 14:22:38 | sean-k-mooney | i was trying to see if i could use that as a arm dev env | |
| 14:23:03 | sean-k-mooney | chateaulav: did you put anything special in the glacne metadtaa | |
| 14:23:19 | chateaulav | hw_emulation_architecture='aarch64', hw_firmware_type='uefi', hw_machine_type='virt' | |
| 14:23:35 | sean-k-mooney | ya ok that is what i was expecting | |
| 14:23:43 | sean-k-mooney | thanks | |
| 14:24:03 | sean-k-mooney | i can give it a try again i pulled the image form github so maybe there is a delta | |
| 14:24:31 | sean-k-mooney | from here https://github.com/cirros-dev/cirros/releases/tag/0.5.2 | |