| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-01-28 | |||
| 19:14:43 | sean-k-mooney | it will need test but we can likely just merge and updated version fo that and backport | |
| 19:14:55 | sean-k-mooney | its not a nova bug but we can workaorund it in nova | |
| 19:15:43 | spatel | Sweet!!! i can give it a try to this patch and see how it goes :) | |
| 19:36:27 | sean-k-mooney | spatel: we will proably proceed with https://review.opendev.org/c/openstack/nova/+/825496 instead | |
| 19:39:54 | spatel | that is also sounds good | |
| 19:40:04 | spatel | as far as it get merge | |
| 21:06:25 | opendevreview | Merged openstack/nova master: requirements: Remove os-xenapi https://review.opendev.org/c/openstack/nova/+/822747 | |
| 21:06:32 | opendevreview | Merged openstack/nova master: Remove Python 2-specific imports https://review.opendev.org/c/openstack/nova/+/822748 | |
| 22:10:19 | opendevreview | melanie witt proposed openstack/nova master: Raise InstanceNotFound on fkey constraint fail saving info cache https://review.opendev.org/c/openstack/nova/+/826942 | |
| #openstack-nova - 2022-01-29 | |||
| 08:11:35 | opendevreview | Merged openstack/nova stable/xena: Update centos 8 py36 functional job nodeset to centos stream 8 https://review.opendev.org/c/openstack/nova/+/825930 | |
| 18:41:02 | opendevreview | Imran Hussain proposed openstack/nova master: [nova/libvirt] Support for checking and enabling SMM when needed https://review.opendev.org/c/openstack/nova/+/825496 | |
| #openstack-nova - 2022-01-31 | |||
| 08:54:52 | opendevreview | Pierre Libeau proposed openstack/nova master: Move file system freeze after end of mirroring https://review.opendev.org/c/openstack/nova/+/803713 | |
| 09:21:05 | kashyap | sean-k-mooney: Will look the SMM thing | |
| 09:55:00 | plibeau3 | bauzas: hello when you have time to read https://review.opendev.org/c/openstack/nova/+/803713/ QEMU community give some input | |
| 09:59:27 | bauzas | plibeau3: ack, I can take a look on it this afternoon | |
| 09:59:58 | stephenfin | sean-k-mooney: Can you look at https://review.opendev.org/c/openstack/nova/+/822749/ today? | |
| 10:34:25 | opendevreview | Imran Hussain proposed openstack/nova master: [nova/libvirt] Support for checking and enabling SMM when needed https://review.opendev.org/c/openstack/nova/+/825496 | |
| 11:10:25 | opendevreview | Imran Hussain proposed openstack/nova master: [nova/libvirt] Support for checking and enabling SMM when needed https://review.opendev.org/c/openstack/nova/+/825496 | |
| 11:51:43 | gibi | Uggla: everybody could nominate Z names, but only the TC votes (this will change in A release) | |
| 11:52:15 | Uggla | gibi, oh ok thx gibi. | |
| 11:59:24 | sean-k-mooney | stephenfin: yep ill look now | |
| 12:01:24 | sean-k-mooney | stephenfin: the only feedback i had is do we want to have the extras installed in the ci but you might be doing that in the next patch | |
| 12:01:50 | sean-k-mooney | which you are | |
| 12:01:58 | sean-k-mooney | so no im happy with both patches | |
| 12:02:13 | stephenfin | openstack server create --flavor m1.small --image fedora-iso --port e3caceae-2c74-4114-9f3f-262a37fc1971 --port e3caceae-2c74-4114-9f3f-262a37fc1971 test-server --wait | |
| 12:02:27 | stephenfin | ate entry 'fa:16:3e:62:88:38/e3caceae-2c74-4114-9f3f-262a37fc1971-0' for key 'virtual_interfaces.uniq_virtual_interfaces0address0deleted'") | |
| 12:02:27 | stephenfin | oslo_db.exception.DBDuplicateEntry: (pymysql.err.IntegrityError) (1062, "Duplic | |
| 12:04:48 | sean-k-mooney | stephenfin: yep | |
| 12:04:57 | sean-k-mooney | repating the port fails there | |
| 12:05:04 | sean-k-mooney | this is a known failure mode | |
| 12:05:09 | sean-k-mooney | we could block that in the api | |
| 12:05:15 | stephenfin | We probably should | |
| 12:05:46 | stephenfin | There were a few bugs related to this when I Googled but none had resolutions in them | |
| 12:09:13 | sean-k-mooney | ya i have seen customer hit this with heat templates and i think the shift on stack installer hit this about 4 mounts ago | |
| 12:09:28 | sean-k-mooney | i previously chatted to mdbooth about it. | |
| 12:10:04 | sean-k-mooney | i know its recently come up again downstream. are you looking at that? | |
| 12:16:03 | stephenfin | yup, spotted downstream | |
| 12:17:50 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add microversion 1.39 to support any-trait queries https://review.opendev.org/c/openstack/placement/+/826719 | |
| 12:19:05 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add microversion 1.39 to support any-trait queries https://review.opendev.org/c/openstack/placement/+/826719 | |
| 12:23:50 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add microversion 1.39 to support any-trait queries https://review.opendev.org/c/openstack/placement/+/826719 | |
| 13:01:59 | dmitriis | sean-k-mooney: can't cleanly apply some changes on top of https://review.opendev.org/c/openstack/nova/+/819494/ since I rebased mine to the tip. But I removed the conflicting modifications in bind-time/plug-time event related functions which are getting removed in that change. | |
| 13:02:44 | dmitriis | (wondering if it's OK to rebase Artom's PRs myself) | |
| 13:03:33 | sean-k-mooney | ack am you could artom will be online soon if you want to wait and ask but i dont really see any harm in that. i would move it after the os-traits patch | |
| 13:04:11 | sean-k-mooney | alternitvily i can review those now and see if we can merge it shortly | |
| 13:07:03 | dmitriis | sean-k-mooney: ack, let me rebase both of his changes and I can cherry-pick cleanly then and reorder the VNIC_SMARTNIC patch and the os-traits patch | |
| 13:07:53 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Reject duplicate port IDs in server create https://review.opendev.org/c/openstack/nova/+/827070 | |
| 13:08:05 | stephenfin | sean-k-mooney: ^ (gibi, you might interested also) | |
| 13:08:18 | sean-k-mooney | alreday have it open :) | |
| 13:08:33 | sean-k-mooney | i assume a 400 will be returned | |
| 13:08:36 | stephenfin | yup | |
| 13:08:51 | stephenfin | I'm really hoping to avoid a microversion for that, since it's so obviously wrong as-is | |
| 13:08:51 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Add nova-ovs-hybrid-plug job https://review.opendev.org/c/openstack/nova/+/817303 | |
| 13:09:00 | stephenfin | but I can't make that choice alone, of course :) | |
| 13:09:02 | sean-k-mooney | 400 is already a valid return code | |
| 13:09:07 | sean-k-mooney | so no microversion needed | |
| 13:09:16 | stephenfin | right, but it's currently returning a 201 | |
| 13:09:21 | stephenfin | since server create is async | |
| 13:09:34 | sean-k-mooney | its returning a 201 but the server end in error | |
| 13:09:38 | stephenfin | yeah | |
| 13:09:44 | sean-k-mooney | i think we have an excpetion for that | |
| 13:10:14 | stephenfin | so I'm arguing that since every other subsequent server op would fail, this is an acceptable change. We shouldn't break anyones automation | |
| 13:10:24 | sean-k-mooney | https://docs.openstack.org/nova/latest/contributor/microversions.html#when-do-i-need-a-new-microversion | |
| 13:10:37 | sean-k-mooney | so i would argue that thies is the first yes | |
| 13:10:46 | sean-k-mooney | did we silently fail to do what is asked | |
| 13:11:00 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/819494 | |
| 13:11:20 | sean-k-mooney | we log the error for the duplciate keys in nova-compute but i think the user got a no valid host error in the event log | |
| 13:12:34 | stephenfin | we don't even get as far as scheduling | |
| 13:13:00 | stephenfin | but ultimately we silently fail to do what is asked, yes | |
| 13:13:25 | sean-k-mooney | oh we create teh entry in the virtual interfaces table in the api i gues so we can store any tag infor | |
| 13:13:52 | sean-k-mooney | ok well ya so im pro no microververion for this too and backporting it | |
| 13:14:19 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Reject duplicate port IDs in server create https://review.opendev.org/c/openstack/nova/+/827070 | |
| 13:15:19 | sean-k-mooney | stephenfin: since your about can you quickly look at https://review.opendev.org/c/openstack/nova/+/817303/11 and the followup revert form artom | |
| 13:16:09 | sean-k-mooney | dmitriis: ping me later today when the full series is rebased and up and ill try and do a full pass form start to finish | |
| 13:16:34 | stephenfin | sean-k-mooney: Sure, I won't do it right now but I'll get to it straight after lunch | |
| 13:16:53 | sean-k-mooney | dmitriis: ill be busy for the next hour or so but ill try to get to it later | |
| 13:16:56 | sean-k-mooney | stephenfin: ack | |
| 13:17:08 | chateaulav | sean-k-mooney: what would be the best method for testing my ci job? | |
| 13:18:10 | dmitriis | sean-k-mooney: ack, on it now. I'll add a release note to the latest commit as well. I'm going to work on a doc change as well after I resubmit. | |
| 13:28:09 | sean-k-mooney | chateaulav: typically we submit a DNM patch at the end of a series, in that you can disable most of the intree ci jobs and then test your job by doing <ci>-recheck or whatever the comment is that you use for your ci | |
| 13:28:40 | sean-k-mooney | chateaulav: [DNM] means do not merge and typiclay do not review | |
| 13:29:08 | sean-k-mooney | we use it when ever we are doing things to see if they work or when we are workign on infra like the ci | |
| 13:29:38 | gibi | stephenfin: +2 on your fix. thanks | |
| 13:32:04 | chateaulav | gotcha | |
| 13:32:08 | sean-k-mooney | chateaulav: here is an example of working on a first party job https://review.opendev.org/c/openstack/nova/+/727228/1/.zuul.yaml you would do the same for third party just leave the -check-requiremetns template enabled and comment out the check an gate jobs then you can recheck usign your third party ci comment | |
| 13:32:36 | chateaulav | sean-k-mooney: thanks! | |
| 13:32:57 | sean-k-mooney | chateaulav: no problem | |
| 13:37:34 | plibeau4 | lyarwood: https://review.opendev.org/c/openstack/nova/+/820531 when you have time :) | |
| 13:43:52 | gibi | sean-k-mooney: filed bug about placement silently ignoring repeated required query params https://storyboard.openstack.org/#!/story/2009816 I know that you would like to fix it as a bugfix to return http400 (option a) in the bugreport) | |
| 13:44:02 | gibi | bauzas, gmann, melwitt: ^^ Do you agree? | |
| 13:44:18 | bauzas | sorry folks, I had a problem with my internet | |
| 13:44:39 | sean-k-mooney | gibi: that would be my perfernce yes but lets see how the rest feel | |
| 13:44:43 | bauzas | (not my internet, rather my router) | |
| 13:45:24 | sean-k-mooney | gibi: if we think we cant do that without a microverion im ok with what you have previously propsoed in the patch | |
| 13:46:32 | gibi | sean-k-mooney: ack, I will prepare a bugfix as I also think this should be fixed | |
| 13:47:27 | bauzas | gibi: hah, I finally saw the story | |
| 13:47:45 | bauzas | gibi: when I was calling the link, it wasn't giving me the story | |
| 13:48:19 | bauzas | gibi: looks to me a correct bug | |
| 13:48:45 | bauzas | for the solution, yeah, HTTP400 without needing a microversion I think | |
| 13:49:05 | bauzas | but let's wait for gmann's thoughts | |
| 13:50:23 | sean-k-mooney | gibi: oh thats an interesting edge case this also hides invlaid "standard" traits like that interesting. it makes sense but that is even more broken then just ignoring some of your requirements when selecting resouces | |