| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-01-13 | |||
| 07:50:10 | gibi | chateaulav: no worries. I should have notice that it was at the wrong place | |
| 09:22:27 | sean-k-mooney[m] | admin1 there is a config option to resume guests on host reboot | |
| 09:23:19 | sean-k-mooney[m] | but if the system has been up for a while and the periodic task has run it proably has updated the db to mark them of shutdown by now | |
| 09:53:04 | sean-k-mooney[m] | chateualav im +1 on your spec but i have a few comments if you adress them im +2 | |
| 10:52:31 | sean-k-mooney | bauzas: do you have time to revisit https://review.opendev.org/c/openstack/nova-specs/+/824191 | |
| 10:53:24 | sean-k-mooney | kashyap: i might jsut fix the nits in https://review.opendev.org/c/openstack/nova-specs/+/824053 myself assuming you are not working on them? | |
| 10:53:39 | kashyap | sean-k-mooney: Mornin | |
| 10:53:59 | sean-k-mooney | morning :) | |
| 10:54:04 | kashyap | sean-k-mooney: Sorry, lemme just do it right away | |
| 10:54:28 | sean-k-mooney | cool we can review it quickly when you push and reappove | |
| 10:57:01 | kashyap | sean-k-mooney: Why does Sylvain suggest "Previous-approved : Yoga" in the commit message? Isn't it *for* Yoga? | |
| 10:57:42 | sean-k-mooney | they ment xena | |
| 10:58:11 | sean-k-mooney | if its just a reapproval we typicaly refernece the last release it was apprved for but that is not strictly requried | |
| 10:58:42 | sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/799096 is the most recently approved version | |
| 10:58:49 | kashyap | Ah, nod | |
| 10:59:08 | sean-k-mooney | which had Previous-approved: Train | |
| 11:00:32 | kashyap | Yep, fixin | |
| 11:08:38 | opendevreview | Kashyap Chamarthy proposed openstack/nova-specs master: Repropose "CPU selection with guest hypervisor consideration" https://review.opendev.org/c/openstack/nova-specs/+/824053 | |
| 11:08:45 | kashyap | sean-k-mooney: --^ | |
| 11:21:16 | sean-k-mooney | bauzas: i have a pep8 issue in the spec anyway. i need to wrap the example output in a code block to make sphinx happy | |
| 11:21:28 | sean-k-mooney | bauzas: so ill just adress you comments now | |
| 11:21:36 | sean-k-mooney | ill also drop the log filter stuff for now | |
| 11:53:16 | bauzas | sean-k-mooney: all good, ping me when you're done | |
| 11:53:48 | bauzas | sean-k-mooney: and I was on https://review.opendev.org/c/openstack/nova-specs/+/824191:) | |
| 11:54:21 | sean-k-mooney | im more or less done just tweakign some formating to make it render nicer | |
| 11:57:50 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Add PCI VPD Capability Handling https://review.opendev.org/c/openstack/nova/+/808199 | |
| 12:05:03 | opendevreview | sean mooney proposed openstack/nova-specs master: add per process healthcheck spec https://review.opendev.org/c/openstack/nova-specs/+/821279 | |
| 12:05:15 | sean-k-mooney | bauzas: ^ | |
| 12:06:04 | sean-k-mooney | bauzas: also kashyap spec https://review.opendev.org/c/openstack/nova-specs/+/824053 | |
| 12:20:32 | opendevreview | Merged openstack/nova-specs master: lightos volume driver spec https://review.opendev.org/c/openstack/nova-specs/+/824191 | |
| 12:41:53 | opendevreview | Iago Filipe proposed openstack/nova master: Remove deprecated opts from VNC conf https://review.opendev.org/c/openstack/nova/+/824478 | |
| 13:23:53 | opendevreview | Jonathan Race proposed openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | |
| 13:26:15 | chateaulav | sean-k-mooney: thanks for the feedback, changes have been made. | |
| 13:26:37 | chateaulav | patchset 6 submitted | |
| 13:36:52 | sean-k-mooney | chateaulav: +2 from me gibi when you have time can you revisit | |
| 13:39:00 | gibi | on my list for tofay | |
| 13:42:09 | sean-k-mooney | thanks. i have pushed the latest version fo the health check spec. im going to work on something else for a bit but if anyone has question ping me or leave them inline in the spec an ill try to be reponsive to them | |
| 13:48:47 | bauzas | sean-k-mooney: looking at your last rev for the hc | |
| 13:48:59 | bauzas | should be an easy peasy | |
| 13:49:10 | bauzas | chateaulav: you're my next jab | |
| 14:07:21 | opendevreview | Merged openstack/nova-specs master: Repropose "CPU selection with guest hypervisor consideration" https://review.opendev.org/c/openstack/nova-specs/+/824053 | |
| 14:09:52 | gibi | sean-k-mooney: ack, you are on my list too (just meeeetings) | |
| 14:40:58 | opendevreview | Merged openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | |
| 14:51:24 | gibi | sean-k-mooney: I have couple of comment in the health check spec https://review.opendev.org/c/openstack/nova-specs/+/821279 feel free to ping me if clarification is needed | |
| 14:51:40 | sean-k-mooney | i will take a look now | |
| 14:51:58 | gibi | ok | |
| 14:52:19 | sean-k-mooney | regarding /health | |
| 14:52:30 | sean-k-mooney | those are referign to two differnrt api endpoint | |
| 14:52:47 | sean-k-mooney | the first isntance is saying i will expose /helth for the new tcp endpoint added by this spec | |
| 14:52:59 | sean-k-mooney | the second section in rest api impact | |
| 14:53:13 | gibi | OK, I see | |
| 14:53:14 | sean-k-mooney | is saying i will not expose it in the nova-api endpoint | |
| 14:53:19 | gibi | make sense | |
| 14:54:07 | sean-k-mooney | regardign the versioning | |
| 14:54:24 | sean-k-mooney | if it woudl make you feel better i can just bump the version everytime we add a posible check | |
| 14:54:31 | sean-k-mooney | e.g. the minior version | |
| 14:54:38 | sean-k-mooney | that would make it more consitnet | |
| 14:54:52 | sean-k-mooney | i was jsut goign to have the keys of the checks sub dictionay unversioned | |
| 14:54:52 | gibi | I'm good any ways iff the rules of bumping is clear | |
| 14:55:01 | gibi | that is fine | |
| 14:55:03 | gibi | then lets state taht | |
| 14:55:05 | gibi | that | |
| 14:55:15 | gibi | checks is unversioned the rest is semver | |
| 14:55:39 | sean-k-mooney | well that the thing i want the value of the checks to be versioned | |
| 14:55:42 | sean-k-mooney | just not the keys | |
| 14:55:55 | sean-k-mooney | so you can rely on the format of the checks | |
| 14:56:05 | sean-k-mooney | but the set of names is open | |
| 14:56:39 | gibi | aah | |
| 14:56:47 | sean-k-mooney | if we want to version everything in the responce the only delta form what i have now is the set of check names would be versioned too | |
| 14:56:57 | sean-k-mooney | which i can do but im not sure what all of them are yet | |
| 14:57:03 | gibi | then I would vote for versioning the set of check names too | |
| 14:57:12 | sean-k-mooney | ok | |
| 14:57:27 | sean-k-mooney | ill make that update and fix the typo | |
| 14:57:38 | gibi | OK, thanks | |
| 14:57:42 | gibi | I will +2 it | |
| 15:08:46 | opendevreview | sean mooney proposed openstack/nova-specs master: add per process healthcheck spec https://review.opendev.org/c/openstack/nova-specs/+/821279 | |
| 15:08:55 | sean-k-mooney | gibi: there you go ^ | |
| 15:09:23 | sean-k-mooney | if we are generally aligned on that i might adress any other nits if there are some in a followup | |
| 15:10:00 | gibi | sean-k-mooney: I'm +2 | |
| 15:10:01 | gibi | thank you | |
| 15:10:14 | sean-k-mooney | no worries :) | |
| 15:10:37 | sean-k-mooney | i proably shoudl start implementing that soon likely next week | |
| 15:10:56 | bauzas | ++ | |
| 15:11:09 | bauzas | if nothing controversial, gibi please +2/+W it then | |
| 15:11:21 | bauzas | or I can jab this spec again | |
| 15:11:47 | sean-k-mooney | bauzas: if you can that would be great | |
| 15:12:42 | gibi | I will go back to it before I leave today and +W it if bauzas didn't yet | |
| 15:13:14 | sean-k-mooney | TheJulia: given today is spec freeze are you plannign to rework https://review.opendev.org/c/openstack/nova-specs/+/815789 | |
| 15:13:59 | bauzas | sean-k-mooney: oki doki, hold your brace | |
| 15:14:50 | TheJulia | sean-k-mooney: I didn't create that and I've never seen it before | |
| 15:15:05 | sean-k-mooney | oh its the spec for https://review.opendev.org/c/openstack/nova/+/813897 no? | |
| 15:15:16 | TheJulia | sean-k-mooney: I've been treating the issue as a bug but I've been beyond slammed as of recent | |
| 15:16:20 | sean-k-mooney | ok we might want to put this intout the compute team backlog downstream and take it over to land it next cycle | |
| 15:16:44 | sean-k-mooney | given we are chaign the api behavior and rebalaicne semantic upstream we were considering it a feature | |
| 15:17:27 | TheJulia | well, that is what it calls for | |
| 15:17:31 | TheJulia | at least, a glance at the spec | |
| 15:17:43 | TheJulia | the bug can be solved by just doing the needful and not changing the API | |
| 15:18:08 | sean-k-mooney | its not changing the api syntatically | |
| 15:18:18 | sean-k-mooney | i guess the sidefffect is not nessisaly visable | |
| 15:18:28 | sean-k-mooney | so you could arge it snot changing it semantically too | |