| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-01-12 | |||
| 16:08:39 | opendevreview | Jonathan Race proposed openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | |
| 16:32:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: List auth plugin parameters for [keystone] section https://review.opendev.org/c/openstack/nova/+/824458 | |
| 17:01:45 | opendevreview | yuval proposed openstack/nova-specs master: lightos volume driver spec https://review.opendev.org/c/openstack/nova-specs/+/824191 | |
| 17:46:48 | opendevreview | Merged openstack/nova stable/wallaby: Reproduce bug 1953359 https://review.opendev.org/c/openstack/nova/+/820554 | |
| 17:46:54 | opendevreview | Merged openstack/nova stable/wallaby: Extend the reproducer for 1953359 and 1952915 https://review.opendev.org/c/openstack/nova/+/821943 | |
| 17:56:23 | opendevreview | Ghanshyam proposed openstack/nova master: Move rule_if_system() method to base test class https://review.opendev.org/c/openstack/nova/+/824475 | |
| 17:57:19 | opendevreview | Ghanshyam proposed openstack/nova master: Server actions APIs scoped to project scope https://review.opendev.org/c/openstack/nova/+/824358 | |
| 18:23:14 | chateaulav | just a question, i may have miss read a the process docs. for submitting the spec should it be under nova-specs/specs/yoga/ as i currently have it under the implemented directory? | |
| 18:56:54 | yuval | chateaulav: I think the pep8 fails if you dont put it under approved/implemented | |
| 18:58:32 | chateaulav | ok, just want to make sure im not creating extra work | |
| 19:00:24 | sean-k-mooney | it shoudl be put under approved | |
| 19:00:29 | chateaulav | ok | |
| 19:00:35 | sean-k-mooney | and the name of the file shoudl match the blueprint name | |
| 19:00:44 | chateaulav | sean-k.mooney: thanks, will fix | |
| 19:00:53 | sean-k-mooney | you can run the check locally with "tox -e pep8,docs" | |
| 19:01:41 | sean-k-mooney | we have a script that will move it form approved to implemented if the feature is complted at the end of the cycle | |
| 19:01:59 | sean-k-mooney | i or other will run it and it uses the name of the file to check if the blueptirn is marked as complete | |
| 19:02:54 | opendevreview | Jonathan Race proposed openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | |
| 19:05:28 | chateaulav | sean-k-mooney: ack, placed it in the right area now. my bad... lol. dont know if the +2 needs readded with the new patchset or if that auto adds itself. | |
| 19:07:07 | sean-k-mooney | it will be lost but ill try and review it tomorrow if i agree its ready i can fast approve but if not we will get to it tomorrow | |
| 19:07:40 | opendevreview | Iago Filipe proposed openstack/nova master: Remove deprecated opts from VNC conf https://review.opendev.org/c/openstack/nova/+/824478 | |
| 19:08:01 | chateaulav | gibi had already done so. | |
| 19:08:15 | chateaulav | gibi: sorry for the extra work.. | |
| 19:08:27 | sean-k-mooney | its fine :) dont worry | |
| 19:08:38 | sean-k-mooney | it need 2 +2 and a +w to merge | |
| 19:08:47 | chateaulav | cool | |
| 19:09:18 | sean-k-mooney | so we will review it again tomorow/tonight | |
| 19:09:40 | sean-k-mooney | the cutoff is not untill close of busniess tomrorow anyway but this should be merged by then | |
| 19:09:46 | opendevreview | Iago Filipe proposed openstack/nova master: Remove deprecated opts from VNC conf https://review.opendev.org/c/openstack/nova/+/824478 | |
| 19:11:26 | sean-k-mooney | with that in mind i should go back to updating my own spec | |
| 21:19:04 | opendevreview | Iago Filipe proposed openstack/nova master: Remove deprecated opts from VNC conf https://review.opendev.org/c/openstack/nova/+/824478 | |
| 23:38:56 | opendevreview | sean mooney proposed openstack/nova-specs master: add per process healthcheck spec https://review.opendev.org/c/openstack/nova-specs/+/821279 | |
| #openstack-nova - 2022-01-13 | |||
| 04:12:07 | admin1 | hi all | |
| 04:12:19 | admin1 | my instances are all on shutoff state after a reboot | |
| 04:12:25 | admin1 | and they are not booting up | |
| 04:12:31 | admin1 | any pointers on how to start them | |
| 04:12:39 | admin1 | in the database/gui , they are shown as active | |
| 05:31:57 | opendevreview | Ghanshyam proposed openstack/nova master: Move rule_if_system() method to base test class https://review.opendev.org/c/openstack/nova/+/824475 | |
| 05:47:03 | opendevreview | Ghanshyam proposed openstack/nova master: Server actions APIs scoped to project scope https://review.opendev.org/c/openstack/nova/+/824358 | |
| 07:50:10 | gibi | chateaulav: no worries. I should have notice that it was at the wrong place | |
| 09:22:27 | sean-k-mooney[m] | admin1 there is a config option to resume guests on host reboot | |
| 09:23:19 | sean-k-mooney[m] | but if the system has been up for a while and the periodic task has run it proably has updated the db to mark them of shutdown by now | |
| 09:53:04 | sean-k-mooney[m] | chateualav im +1 on your spec but i have a few comments if you adress them im +2 | |
| 10:52:31 | sean-k-mooney | bauzas: do you have time to revisit https://review.opendev.org/c/openstack/nova-specs/+/824191 | |
| 10:53:24 | sean-k-mooney | kashyap: i might jsut fix the nits in https://review.opendev.org/c/openstack/nova-specs/+/824053 myself assuming you are not working on them? | |
| 10:53:39 | kashyap | sean-k-mooney: Mornin | |
| 10:53:59 | sean-k-mooney | morning :) | |
| 10:54:04 | kashyap | sean-k-mooney: Sorry, lemme just do it right away | |
| 10:54:28 | sean-k-mooney | cool we can review it quickly when you push and reappove | |
| 10:57:01 | kashyap | sean-k-mooney: Why does Sylvain suggest "Previous-approved : Yoga" in the commit message? Isn't it *for* Yoga? | |
| 10:57:42 | sean-k-mooney | they ment xena | |
| 10:58:11 | sean-k-mooney | if its just a reapproval we typicaly refernece the last release it was apprved for but that is not strictly requried | |
| 10:58:42 | sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/799096 is the most recently approved version | |
| 10:58:49 | kashyap | Ah, nod | |
| 10:59:08 | sean-k-mooney | which had Previous-approved: Train | |
| 11:00:32 | kashyap | Yep, fixin | |
| 11:08:38 | opendevreview | Kashyap Chamarthy proposed openstack/nova-specs master: Repropose "CPU selection with guest hypervisor consideration" https://review.opendev.org/c/openstack/nova-specs/+/824053 | |
| 11:08:45 | kashyap | sean-k-mooney: --^ | |
| 11:21:16 | sean-k-mooney | bauzas: i have a pep8 issue in the spec anyway. i need to wrap the example output in a code block to make sphinx happy | |
| 11:21:28 | sean-k-mooney | bauzas: so ill just adress you comments now | |
| 11:21:36 | sean-k-mooney | ill also drop the log filter stuff for now | |
| 11:53:16 | bauzas | sean-k-mooney: all good, ping me when you're done | |
| 11:53:48 | bauzas | sean-k-mooney: and I was on https://review.opendev.org/c/openstack/nova-specs/+/824191:) | |
| 11:54:21 | sean-k-mooney | im more or less done just tweakign some formating to make it render nicer | |
| 11:57:50 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Add PCI VPD Capability Handling https://review.opendev.org/c/openstack/nova/+/808199 | |
| 12:05:03 | opendevreview | sean mooney proposed openstack/nova-specs master: add per process healthcheck spec https://review.opendev.org/c/openstack/nova-specs/+/821279 | |
| 12:05:15 | sean-k-mooney | bauzas: ^ | |
| 12:06:04 | sean-k-mooney | bauzas: also kashyap spec https://review.opendev.org/c/openstack/nova-specs/+/824053 | |
| 12:20:32 | opendevreview | Merged openstack/nova-specs master: lightos volume driver spec https://review.opendev.org/c/openstack/nova-specs/+/824191 | |
| 12:41:53 | opendevreview | Iago Filipe proposed openstack/nova master: Remove deprecated opts from VNC conf https://review.opendev.org/c/openstack/nova/+/824478 | |
| 13:23:53 | opendevreview | Jonathan Race proposed openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | |
| 13:26:15 | chateaulav | sean-k-mooney: thanks for the feedback, changes have been made. | |
| 13:26:37 | chateaulav | patchset 6 submitted | |
| 13:36:52 | sean-k-mooney | chateaulav: +2 from me gibi when you have time can you revisit | |
| 13:39:00 | gibi | on my list for tofay | |
| 13:42:09 | sean-k-mooney | thanks. i have pushed the latest version fo the health check spec. im going to work on something else for a bit but if anyone has question ping me or leave them inline in the spec an ill try to be reponsive to them | |
| 13:48:47 | bauzas | sean-k-mooney: looking at your last rev for the hc | |
| 13:48:59 | bauzas | should be an easy peasy | |
| 13:49:10 | bauzas | chateaulav: you're my next jab | |
| 14:07:21 | opendevreview | Merged openstack/nova-specs master: Repropose "CPU selection with guest hypervisor consideration" https://review.opendev.org/c/openstack/nova-specs/+/824053 | |
| 14:09:52 | gibi | sean-k-mooney: ack, you are on my list too (just meeeetings) | |
| 14:40:58 | opendevreview | Merged openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | |
| 14:51:24 | gibi | sean-k-mooney: I have couple of comment in the health check spec https://review.opendev.org/c/openstack/nova-specs/+/821279 feel free to ping me if clarification is needed | |
| 14:51:40 | sean-k-mooney | i will take a look now | |
| 14:51:58 | gibi | ok | |
| 14:52:19 | sean-k-mooney | regarding /health | |
| 14:52:30 | sean-k-mooney | those are referign to two differnrt api endpoint | |
| 14:52:47 | sean-k-mooney | the first isntance is saying i will expose /helth for the new tcp endpoint added by this spec | |
| 14:52:59 | sean-k-mooney | the second section in rest api impact | |
| 14:53:13 | gibi | OK, I see | |
| 14:53:14 | sean-k-mooney | is saying i will not expose it in the nova-api endpoint | |
| 14:53:19 | gibi | make sense | |
| 14:54:07 | sean-k-mooney | regardign the versioning | |
| 14:54:24 | sean-k-mooney | if it woudl make you feel better i can just bump the version everytime we add a posible check | |
| 14:54:31 | sean-k-mooney | e.g. the minior version | |
| 14:54:38 | sean-k-mooney | that would make it more consitnet | |
| 14:54:52 | sean-k-mooney | i was jsut goign to have the keys of the checks sub dictionay unversioned | |
| 14:54:52 | gibi | I'm good any ways iff the rules of bumping is clear | |
| 14:55:01 | gibi | that is fine | |
| 14:55:03 | gibi | then lets state taht | |