| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-12-03 | |||
| 17:18:12 | rloo | well, one can set/unset via 'openstack server set', 'openstack server unset' | |
| 17:18:40 | sean-k-mooney | yep which would be a valid way to achive your goa | |
| 17:18:47 | sean-k-mooney | rebuidl with current metadata and then update | |
| 17:19:26 | sean-k-mooney | the alterniive is get the meddtata, update it client side and pass the desired state to rebuidl | |
| 17:19:40 | rloo | except that we (downstream) need the values for the rebuild operation itself. and our users don't think they have to set them if they've already set them. they just want to change one of the properties/metadata fields. | |
| 17:20:21 | rloo | i can do a downstream patch for this, just wanted to grok what the upstream/intent was, to figure out if we need to carry this patch downstream forever or not. | |
| 17:20:40 | sean-k-mooney | which downsteam? | |
| 17:21:01 | rloo | or force our users to explicitly specify all the property values in the rebuild command. or have them specify via the 'set' command, then do a rebuild w/o specifying any. | |
| 17:21:02 | sean-k-mooney | this is not something we would backprot in redhat for example in osp as it a breaking api change | |
| 17:21:20 | rloo | yahoo downstream. | |
| 17:21:22 | sean-k-mooney | rloo: to change this we would need a spec and new api microverion | |
| 17:21:57 | sean-k-mooney | in that version we would likel add a second filed to allow specifying if the metadta was replaced or updated | |
| 17:22:29 | sean-k-mooney | in the short term forcing users to speciy all the metadta is the way to work around it | |
| 17:22:39 | sean-k-mooney | or do the metadta update first | |
| 17:22:41 | sean-k-mooney | then rebuild | |
| 17:22:44 | rloo | well, it seems like what you describe is the intent (vs a bug). i have other things i'd like upstreamed that are more important/useful than this I think so going to hack for now :) Thx for explaining! | |
| 17:23:26 | sean-k-mooney | no porblem. this likely would be a simple thing to add in that its only a singel new filed | |
| 17:23:33 | sean-k-mooney | and fairly self contained | |
| 17:23:44 | sean-k-mooney | but sicne its an api change ti requires a spec. | |
| 17:23:48 | opendevreview | Gustavo Santos proposed openstack/nova master: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/815373 | |
| 17:23:55 | sean-k-mooney | if you decied to file one feel freee to ping me and ill review | |
| 17:24:29 | rloo | thx sean-k-mooney! | |
| 17:24:47 | sean-k-mooney | rloo: looking at the api verions history i dont see this refernce https://docs.openstack.org/nova/latest/reference/api-microversion-history.html so i suspect this is from our pre 2.1 api | |
| 17:26:02 | sean-k-mooney | i would proably add "metadata_update_method: replace|merge|clear" if i was to extend the api | |
| 17:29:54 | opendevreview | Gabriel Silva Trevisan proposed openstack/nova master: [WIP] Set resize claim resource when changing host https://review.opendev.org/c/openstack/nova/+/820381 | |
| 17:30:46 | rloo | sean-k-mooney: it seems to me that i'd want to modify/enhance the existing rebuild API: https://docs.openstack.org/api-ref/compute/?expanded=rebuild-server-rebuild-action-detail#rebuild-server-rebuild-action | |
| 17:33:17 | sean-k-mooney | rloo: yes | |
| 17:34:17 | sean-k-mooney | enhance it so you can specify how the metadat is process by addin ga metadata_update_method or some other enhacsement so you can opt into the merge behavior | |
| 17:34:43 | sean-k-mooney | or even make that the default for the new microversion and allow opting in to the replace behavior | |
| 17:35:05 | sean-k-mooney | but we need a microversion to ensure we do not break clients | |
| 17:35:17 | sean-k-mooney | that rely on the current behavior | |
| 17:38:28 | rloo | thx sean-k-mooney, I'll keep that in mind! | |
| 18:22:02 | opendevreview | Lee Yarwood proposed openstack/nova master: conf: Allow cinderclient and os_brick to independently log at DEBUG https://review.opendev.org/c/openstack/nova/+/820399 | |
| 18:33:32 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Ignore exception.CPUUnpinningInvalid when deleting https://review.opendev.org/c/openstack/nova/+/820401 | |
| #openstack-nova - 2021-12-06 | |||
| 08:55:39 | gibi | good morning Nova | |
| 09:05:04 | lyarwood | Morning | |
| 09:21:47 | bauzas | good morning | |
| 10:12:54 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to use NUMA cell with free resources first https://review.opendev.org/c/openstack/nova/+/805649 | |
| 10:17:37 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to use NUMA cell with free resources first https://review.opendev.org/c/openstack/nova/+/805649 | |
| 10:21:24 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/805649 | |
| 13:28:56 | opendevreview | sean mooney proposed openstack/nova master: [DNM] using druable queue in rabit https://review.opendev.org/c/openstack/nova/+/820523 | |
| 14:26:42 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/805649 | |
| 14:31:39 | opendevreview | Jan Hartkopf proposed openstack/nova-specs master: update userdata https://review.opendev.org/c/openstack/nova-specs/+/816542 | |
| 14:53:58 | opendevreview | Pierre Libeau proposed openstack/nova master: Nova resize don't extend disk in one specific case https://review.opendev.org/c/openstack/nova/+/820531 | |
| 14:58:05 | opendevreview | Jan Hartkopf proposed openstack/nova-specs master: update userdata https://review.opendev.org/c/openstack/nova-specs/+/816542 | |
| 15:01:00 | opendevreview | Gustavo Santos proposed openstack/nova master: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/815373 | |
| 15:21:01 | opendevreview | Jan Hartkopf proposed openstack/nova-specs master: update userdata https://review.opendev.org/c/openstack/nova-specs/+/816542 | |
| 15:39:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1953359 https://review.opendev.org/c/openstack/nova/+/820540 | |
| 15:39:34 | gibi | yet another race condition ^^ | |
| 16:15:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: [rt] Apply migration context for incoming migrations https://review.opendev.org/c/openstack/nova/+/820549 | |
| 16:15:57 | gibi | and a fix ^^ | |
| 16:20:08 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Reproduce bug 1953359 https://review.opendev.org/c/openstack/nova/+/820550 | |
| 16:21:21 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: [rt] Apply migration context for incoming migrations https://review.opendev.org/c/openstack/nova/+/820553 | |
| 16:22:33 | opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Reproduce bug 1953359 https://review.opendev.org/c/openstack/nova/+/820554 | |
| 16:23:45 | opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: [rt] Apply migration context for incoming migrations https://review.opendev.org/c/openstack/nova/+/820555 | |
| 16:24:57 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: Reproduce bug 1953359 https://review.opendev.org/c/openstack/nova/+/820558 | |
| 16:26:09 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: [rt] Apply migration context for incoming migrations https://review.opendev.org/c/openstack/nova/+/820559 | |
| 16:39:35 | opendevreview | Jan Hartkopf proposed openstack/nova-specs master: update userdata https://review.opendev.org/c/openstack/nova-specs/+/816542 | |
| 18:59:55 | opendevreview | Gabriel Silva Trevisan proposed openstack/nova master: [WIP] Set resize claim resource when changing host https://review.opendev.org/c/openstack/nova/+/820381 | |
| 21:38:52 | opendevreview | Gabriel Silva Trevisan proposed openstack/nova master: [WIP] Set resize claim resource when changing host https://review.opendev.org/c/openstack/nova/+/820381 | |
| #openstack-nova - 2021-12-07 | |||
| 08:24:46 | gibi | melwitt: thanks for noticing that https://review.opendev.org/c/openstack/nova/+/820381 and https://review.opendev.org/c/openstack/nova/+/820549 are related | |
| 08:24:56 | gibi | I left comments in the former | |
| 08:25:14 | gibi | We need to figure out which direction is better | |
| 08:25:37 | gibi | bauzas: you could also be interested in ^^ | |
| 08:30:45 | bauzas | morning | |
| 08:30:54 | bauzas | gibi:sure, will look a bit later | |
| 08:30:58 | gibi | bauzas: o/ | |
| 10:00:26 | opendevreview | Vlad Gusev proposed openstack/nova stable/stein: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/820682 | |
| 10:27:14 | bauzas | gibi: OK, so I briefly looked at both https://bugs.launchpad.net/nova/+bug/1952915 and https://bugs.launchpad.net/nova/+bug/1953359 | |
| 10:27:30 | bauzas | I see you made a duplicate | |
| 10:27:52 | gibi | I'm pretty sure the root cause of those bugs are the same | |
| 10:27:57 | gibi | hence the duplication | |
| 10:28:04 | gibi | and we can choose from which fix we want | |
| 10:28:05 | bauzas | so I guess for fixing https://bugs.launchpad.net/nova/+bug/1952915 we need to merge https://review.opendev.org/c/openstack/nova/+/820549 ? | |
| 10:28:49 | bauzas | ahah, I see the difference for both patches | |
| 10:28:51 | gibi | I think both proposed fix fixes the same root cause | |
| 10:29:01 | gibi | but in a different way | |
| 10:29:21 | gibi | I tried to summ it up in https://review.opendev.org/c/openstack/nova/+/820381/4#message-122f30f371867edb0992d6260871f4cb65c047aa | |
| 10:32:10 | bauzas | gibi: yeah I'd prefer your own change | |
| 10:32:51 | gibi | it is a trade off really. Mine is less impact, but the other might fixes other currently unreported erros too, but maybe break something else in the process | |
| 10:35:49 | bauzas | gibi: I provided my thoughts | |
| 10:36:54 | gibi | thanks | |
| 10:41:26 | bauzas | gibi: I'll review your own change later today | |
| 10:41:35 | bauzas | I just merged for the moment the functional test | |
| 10:41:43 | bauzas | (with some comments) | |
| 10:42:12 | gibi | bauzas: OK, I try to extend the test a bit later | |
| 10:42:23 | bauzas | gibi: nah, just open thoughts | |
| 10:43:27 | gibi | not due to your thoughts (havent checked them yet) but do to the fact that the other bug reports two visible issue 1) periodic fails 2) revert resize fails. My func test only covers 1) not 2) | |
| 10:43:48 | gibi | as I was only able to reliable reproduce 1) in my local env | |
| 10:44:22 | gibi | but I saw the 2) too | |
| 10:47:53 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/805649 | |
| 10:50:53 | opendevreview | Sylvain Bauza proposed openstack/nova master: [doc] propose Review-Priority label for contribs https://review.opendev.org/c/openstack/nova/+/816861 | |
| 12:10:05 | opendevreview | Merged openstack/nova master: Reproduce bug 1953359 https://review.opendev.org/c/openstack/nova/+/820540 | |
| 12:24:40 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: Extend the reproducer for 1953359 and 1952915 https://review.opendev.org/c/openstack/nova/+/820856 | |
| 12:24:58 | gibi | bauzas, melwitt: ^^ extended my reproducer to cover both bugs | |
| 12:25:51 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: [rt] Apply migration context for incoming migrations https://review.opendev.org/c/openstack/nova/+/820559 | |
| 12:26:19 | gibi | bajj | |
| 12:26:21 | gibi | bahh | |
| 12:26:26 | gibi | the rebase went sideways | |
| 12:29:20 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: Extend the reproducer for 1953359 and 1952915 https://review.opendev.org/c/openstack/nova/+/820856 | |