| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-11-08 | |||
| 09:14:33 | bauzas | if an operator sets the default_az value, then any instance which would be created will have an AZ | |
| 09:14:55 | bauzas | either the default AZ if the user doesn't ask for it, or then the AZ that the user provides with --az | |
| 09:21:25 | EugenMayer | bauzas / gibi thank you. The question is in which group? | |
| 09:27:42 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to use NUMA cell with free resources first https://review.opendev.org/c/openstack/nova/+/805649 | |
| 10:06:41 | bauzas | EugenMayer: sorry, missed your ping | |
| 10:06:51 | bauzas | EugenMayer: you ask about the config group ? | |
| 10:07:58 | EugenMayer | yes since beside one does not know which service, one does not know the group bauzas - kind of heavily lifting expected to look this up in the source code but well, i guess i could just contribute the docs and stop complaining :) | |
| 10:12:09 | opendevreview | Martin Kopec proposed openstack/nova master: Update Interop doc https://review.opendev.org/c/openstack/nova/+/816980 | |
| 10:48:44 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 11:20:11 | opendevreview | wujian proposed openstack/nova master: Fix instance action event result inconsistent https://review.opendev.org/c/openstack/nova/+/816990 | |
| 11:48:10 | opendevreview | David Hill proposed openstack/nova stable/victoria: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/816927 | |
| 12:14:30 | gibi | lyarwood: hi! could please look at the stable/victoria backport of https://review.opendev.org/q/topic:bug/1944759 elodilles already has +2 on it | |
| 12:15:41 | lyarwood | gibi: ACK'd | |
| 12:15:48 | gibi | thanks! | |
| 12:22:13 | gibi | bauzas: replied to your question in https://review.opendev.org/c/openstack/nova/+/815690/comment/764e7a47_1cdc2d2d/ | |
| 12:29:45 | sean-k-mooney | stephenfin: im going to respin this shortly can you remove your -2 on https://review.opendev.org/c/openstack/nova/+/804292 | |
| 12:31:19 | sean-k-mooney | lyarwood: ^ that is what we agreed to do at the ptg by the way so that will allow you to avoid issue with 3.10 | |
| 12:31:53 | lyarwood | ah cool sorry missed that | |
| 12:31:55 | sean-k-mooney | although we proably need to start testing with 3.10 this cycle at least non voting | |
| 12:32:23 | sean-k-mooney | im going to quickly repin my autopep8 patch and then that | |
| 12:37:47 | opendevreview | sean mooney proposed openstack/nova master: Add autopep8 to tox and pre-commit https://review.opendev.org/c/openstack/nova/+/806182 | |
| 12:38:15 | opendevreview | Takashi Kajinami proposed openstack/nova stable/xena: Clean up allocations left by evacuation when deleting service https://review.opendev.org/c/openstack/nova/+/816954 | |
| 12:38:30 | sean-k-mooney | lyarwood: gibi if we can merge ^ relitivily quickly that woudl be great as its enforcing that all patch pass autopep8 without needing file changes | |
| 12:44:34 | opendevreview | sean mooney proposed openstack/nova master: This change replaces all hardcoded tox enve with generative envs https://review.opendev.org/c/openstack/nova/+/804292 | |
| 12:46:22 | lyarwood | sean-k-mooney: is that mostly picking up a rule we skip with flake8? | |
| 12:46:50 | sean-k-mooney | autopep8 actully read the tox file for what we skip | |
| 12:46:52 | sean-k-mooney | but yes | |
| 12:47:07 | sean-k-mooney | i dont know how to ignore that 1 new line for doc stings | |
| 12:47:21 | sean-k-mooney | that basicly the only change it really makes today | |
| 12:47:50 | lyarwood | ah right that's why I was asking, I couldn't tell if it was picking up our skip list or not | |
| 12:48:29 | sean-k-mooney | ya it reads the flake8 section | |
| 12:49:26 | sean-k-mooney | so it should respect ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,W504,E731,H238 | |
| 12:49:48 | sean-k-mooney | if we know what rule was adding the new line we could add it to the list | |
| 12:50:26 | lyarwood | tbh I'd rather do that and avoid the huge diff | |
| 12:50:51 | lyarwood | brb | |
| 12:51:31 | sean-k-mooney | well its much smaller then black ecta but sure | |
| 12:51:55 | sean-k-mooney | looking at https://github.com/hhatto/autopep8#features there are seveeral that are fixing indentaiton or addign missing blank lines | |
| 12:58:14 | sean-k-mooney | it might be comeing form https://www.python.org/dev/peps/pep-0257/ | |
| 13:01:01 | sean-k-mooney | """Insert a blank line after all docstrings (one-line or multi-line) that document a class -- generally speaking, the class's methods are separated from each other by a single blank line, and the docstring needs to be offset from the first method by a blank line.""" | |
| 13:01:14 | sean-k-mooney | https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings | |
| 13:01:23 | sean-k-mooney | lyarwood: ^ that is where that si cominng form | |
| 13:02:38 | sean-k-mooney | ah and its called out in the autopep8 | |
| 13:02:40 | sean-k-mooney | Put a blank line between a class docstring and its first method declaration. (Enabled with E301.) | |
| 13:03:27 | sean-k-mooney | E301 is inconsitent tabs and spaces | |
| 13:03:29 | sean-k-mooney | https://www.flake8rules.com/rules/E101.html | |
| 13:08:12 | lyarwood | and that's enabled so why isn't flake8 picking it up already? | |
| 13:08:29 | sean-k-mooney | its not part of pep8 | |
| 13:08:41 | lyarwood | ah | |
| 13:08:46 | sean-k-mooney | E301 does not specify the docstring behavior | |
| 13:09:00 | sean-k-mooney | auto pep8 impleted as part of the E301 fixing | |
| 13:09:04 | lyarwood | sorry I thought you said it did, I see what you're sayingnow | |
| 13:13:14 | sean-k-mooney | lyarwood: summerised it in the review https://review.opendev.org/c/openstack/nova/+/806182/3#message-f37506ed0411c71d9ce66de251196048da171b34 | |
| 13:15:31 | gibi | sean-k-mooney: I have one question in autopep8 https://review.opendev.org/c/openstack/nova/+/806182/comment/e15200f9_a50f0219/ | |
| 13:16:08 | sean-k-mooney | we can add it to test-requiremetns yes | |
| 13:16:21 | sean-k-mooney | i just did not to avoid installing it in enves that did not need it | |
| 13:16:36 | sean-k-mooney | but if you prefer that i can update it shortly | |
| 13:16:41 | gibi | hm, will we ever need to pin the version of autopep8? | |
| 13:17:07 | sean-k-mooney | this can be done with upperconstraitns | |
| 13:17:11 | sean-k-mooney | or inline | |
| 13:17:36 | sean-k-mooney | i dont think so but its a vaild question | |
| 13:17:50 | gibi | currently it can only be inline afaik. but anyhow we don't pin it now, and we can move it to test-requirements when we need to pin it | |
| 13:17:59 | gibi | so I'm +2 | |
| 13:19:04 | sean-k-mooney | for line 69 yes since that does not include the base test env dep for the pep8 env the upper constratis form the base env still apply | |
| 13:22:56 | lyarwood | okay LGTM | |
| 13:23:27 | lyarwood | oh wait, downstream meeting :| | |
| 13:23:41 | lyarwood | helps if I look at the correct day in my cal | |
| 13:26:13 | opendevreview | Merged openstack/nova master: db: Remove legacy placement models https://review.opendev.org/c/openstack/nova/+/812146 | |
| 13:26:23 | opendevreview | Merged openstack/nova master: objects: Stop querying the main DB for keypairs https://review.opendev.org/c/openstack/nova/+/812147 | |
| 13:50:21 | bauzas | gibi: +w'd your series | |
| 13:50:27 | gibi | bauzas: thanks | |
| 14:13:47 | gibi | melwitt: hi! When you are up, we are waiting for you +A in https://review.opendev.org/c/openstack/nova/+/815689/2 so if you have time please check | |
| 14:23:57 | opendevreview | Merged openstack/nova master: Revert "tox: Encode specific Python versions" https://review.opendev.org/c/openstack/nova/+/804168 | |
| 14:30:31 | EugenMayer | When doing a nova backup, it seems like ephemeral disks are entirely excluded. is this to be expected? | |
| 14:30:51 | sean-k-mooney | EugenMayer: yes | |
| 14:31:06 | sean-k-mooney | EugenMayer: snapshots and backups are only done of the root disk | |
| 14:31:17 | EugenMayer | wow, that is a huge bummer ;/ | |
| 14:31:51 | EugenMayer | Is there any way to workarround that? somehow using glance directly and creating an image per disk? | |
| 14:31:52 | sean-k-mooney | ephemeral is not intended to be used for storing data that cant be recreated or safely lost | |
| 14:32:12 | sean-k-mooney | no it was exluded by design and cant be worked around | |
| 14:32:18 | sean-k-mooney | without code changes | |
| 14:32:28 | EugenMayer | Well, the problem is, there is no way to have multi-disk environment without defining one as ephemeral, right? | |
| 14:32:43 | sean-k-mooney | not without cinder | |
| 14:33:01 | EugenMayer | yes, those are volumes then | |
| 14:33:31 | sean-k-mooney | with openstack and most cloud plathform the expected and recommended usecase is to have only 1 disk with any addtional storage provided via volumes | |
| 14:34:20 | kevko | Hi nova team :) , testing wallaby and when I'm creating heat stack ..from time to time I see this error in nova .. is it known bug ? | |
| 14:34:21 | kevko | https://paste.opendev.org/show/810848/ | |
| 14:34:51 | sean-k-mooney | not in nova that normally means you have an issue with neutron | |
| 14:34:56 | EugenMayer | sean-k-mooney i understand that since one scale that one disk easily, no need to add others. But those VMs are legacy and partially it is part of the application desing to have 2 disks (on premise things). But well, still that now is somewhat a huge showstopper is was not accounting for yet | |
| 14:35:12 | dansmith | kevko: yeah, means neutron failed to send the even to nova to indicate that networking is ready | |
| 14:35:20 | sean-k-mooney | kevko: if you create really large heat stacks and your neutron installation is slow then it can time out wireing up the ports | |
| 14:36:01 | sean-k-mooney | you can workaround it by extending the timeout but the real fix is to tune your neutron deployment to support the workload | |
| 14:37:00 | kevko | well, it's really small heat template | |
| 14:37:44 | sean-k-mooney | is this in the upstream ci or a production issue in your deployment by the way | |
| 14:38:01 | sean-k-mooney | ah you said you were testing it so i guess its in your lab | |
| 14:38:10 | sean-k-mooney | what network backend are you using? | |
| 14:38:11 | EugenMayer | sean-k-mooney thank you for givin the definit answer. Not sure what i make out of it in terms of options/solutions but at least good to know it is intended and road blocked | |
| 14:38:24 | kevko | well, it is production problem also on client's side .. | |
| 14:38:31 | kevko | so i'm trying to replicate issue on lab | |
| 14:38:42 | kevko | i can't see relevant errors in neutron | |
| 14:39:15 | sean-k-mooney | kevko: ack is this ml2/ovn? ml2/ovs? cisco aci perhaps? | |