| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-30 | |||
| 13:52:31 | gibi | lyarwood: I'm hesitant. bauzas? | |
| 13:52:51 | bauzas | holding stable patches ? | |
| 13:53:00 | bauzas | or master ones ? | |
| 13:53:05 | gibi | I think lyarwood is asking for master | |
| 13:53:06 | bauzas | former, yes | |
| 13:53:09 | bauzas | latter, nope | |
| 13:53:26 | gibi | ack, then I'm addin +A | |
| 13:53:33 | bauzas | like, I litterally sent gibi's patch to the gate | |
| 13:53:35 | gibi | to https://review.opendev.org/c/openstack/nova/+/810755 | |
| 13:53:54 | lyarwood | cool yeah I just did for the regression test that landed above | |
| 13:53:56 | bauzas | gibi: we branched Xena on RC1, right? | |
| 13:54:01 | gibi | bauzas: right | |
| 13:54:14 | bauzas | so we're officially working on Yoga with master | |
| 13:54:33 | gibi | in my head RC period is when we want to keep master and stable close for easy backport of last minute issues | |
| 13:54:43 | bauzas | that said, any backported change to stable/xena can't be approved until we deliver GA or it's a regression bugfix | |
| 13:55:11 | bauzas | gibi: today is the last RC day | |
| 13:55:17 | gibi | yepp I know | |
| 13:55:21 | bauzas | I don't think we're taking an absolute risk | |
| 13:55:28 | gibi | OK | |
| 13:55:31 | bauzas | this is tho an interesting thought | |
| 13:56:14 | bauzas | honestly, I think we should make more room for bugfixing during our release cadence | |
| 13:56:51 | bauzas | but let's discuss this at the PTG | |
| 14:02:11 | lyarwood | bug fixing never stops ;) | |
| 14:03:53 | gibi | bauzas: you mean feature freezing at F2? ;) | |
| 14:04:13 | bauzas | I don't know | |
| 14:04:21 | bauzas | I'm not opiniated about the solution | |
| 14:04:59 | bauzas | if we could somehow prioritize bugs over features during a period of time that would be explicitely and properly communicated, this would get my interest | |
| 14:05:42 | bauzas | but that also means that people thinking about new features need to understand in advance our release cadence (ideally drafting before the PTG) | |
| 14:10:11 | opendevreview | Merged openstack/nova master: Add section for 'nova-manage placement audit' tool https://review.opendev.org/c/openstack/nova/+/809479 | |
| 15:19:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Enable min pps tempest testing in nova-next https://review.opendev.org/c/openstack/nova/+/811748 | |
| 15:49:47 | bauzas | gibi: sorry was unclear with my comment on your fix, as I really didn't wanted you to invest time into functesting different compute versions, but this is possible https://github.com/openstack/nova/blob/d64edd3da2336a5c7c8f69cced45272cbaf638a9/nova/tests/functional/test_cold_migrate.py#L74 | |
| 15:50:28 | bauzas | this is just a fyk | |
| 15:51:53 | gibi | bauzas: that probably works if the old behavior is tight to an old service version. In my case there is no service version bump | |
| 15:52:21 | bauzas | then I can't remember where but I'm also sure I wrote some upgrade checks | |
| 15:52:30 | bauzas | anyway | |
| 15:53:05 | bauzas | iirc, the idea is to pin rpc versions to make the compute appear "old" | |
| 15:57:41 | gibi | yepp, if there is such old version | |
| 15:57:58 | gibi | but in my case there is no version difference between the unpatches and the patches compute | |
| 15:58:11 | gibi | unpatched and patched | |
| 15:59:46 | melwitt | elodilles: hi, what is the other patch you think might be better for fixing l-c on stable/train? re: https://review.opendev.org/c/openstack/nova/+/811762/1#message-d28da6263de9241f21a437daf6a0b7273eec47e4 | |
| 16:00:38 | melwitt | I'm not opinionated how to fix it, so if there is another way, I'm happy to rebase the patches onto that | |
| 16:01:58 | opendevreview | Merged openstack/nova master: Update contributor guide for Yoga https://review.opendev.org/c/openstack/nova/+/809936 | |
| 16:12:31 | opendevreview | Merged openstack/nova master: Add regression test for bug #1943431 https://review.opendev.org/c/openstack/nova/+/810755 | |
| 16:40:50 | elodilles | melwitt: I though about this one: https://review.opendev.org/c/openstack/nova/+/810461 | |
| 16:41:25 | elodilles | I missed that it is not yet merged o:) | |
| 16:41:48 | elodilles | so anyway, both ways work for me | |
| 17:01:18 | melwitt | elodilles: ah ok, thanks for the link. does it need an update based on the latest comments about min version? or would that be a separate patch? | |
| 17:14:13 | melwitt | elodilles: also meant to tell you I saw grenade jobs on stable/train also failing with "AttributeError: module 'jsonschema' has no attribute 'compat'" https://zuul.opendev.org/t/openstack/build/08e374906e2844ef865d4c698b3b78e5/log/job-output.txt#28564 is this also related to the setuptools issue? | |
| 17:34:40 | elodilles | melwitt: oh, I haven't seen that yet :( that most probably the very same jsonschema 4.0.0 release from yesterday that we faced in openstack-releases' validator :( | |
| 17:37:56 | elodilles | though jsonschema should be upper constrained in stable O.o | |
| 17:39:18 | melwitt | hm yeah | |
| 17:41:02 | melwitt | elodilles: oh but the error was raised from tempest, which would be coming from master | |
| 17:43:43 | elodilles | actually tempest should be used from train-last tag and still, should be installed with upper constraints. or am I wrong? | |
| 17:44:52 | elodilles | seemingly I am wrong at some point otherwise it wouldn't fail :) | |
| 17:46:34 | melwitt | well.. not sure. because if this fails here it seems like it would fail in the tempest repo itself but it's not | |
| 17:48:22 | melwitt | I see that the job began collecting jsonschema==2.6.0 but ended up installing 4.0.0 | |
| 17:48:54 | melwitt | but why... | |
| 17:49:37 | melwitt | or how. it's pinned to 3.0.2 as you said earlier https://github.com/openstack/requirements/blob/stable/train/upper-constraints.txt#L634 | |
| 17:49:53 | melwitt | collecting: https://zuul.opendev.org/t/openstack/build/08e374906e2844ef865d4c698b3b78e5/log/job-output.txt#38834 | |
| 17:51:41 | melwitt | ok but then it uninstalls 4.0.0 and installs 2.6.0 here https://zuul.opendev.org/t/openstack/build/08e374906e2844ef865d4c698b3b78e5/log/job-output.txt#38886-38895 | |
| 17:52:17 | melwitt | and then tempest installs 4.0.0 https://zuul.opendev.org/t/openstack/build/08e374906e2844ef865d4c698b3b78e5/log/job-output.txt#55512 | |
| 17:52:53 | melwitt | gmann: does tempest running on stable branch not use upper-constraints from stable? ^ | |
| 17:55:23 | elodilles | actually, since this is a grenade job, it should be stein | |
| 17:55:44 | elodilles | where jsonschema is constrained 2.6.0 | |
| 17:56:09 | melwitt | oh right | |
| 17:56:40 | elodilles | but tempest @ stein-last requires: jsonschema>=3.2.0 # MIT | |
| 17:57:08 | elodilles | so it is strange how it works | |
| 18:00:42 | elodilles | (just for the record, currently jsonschema===3.2.0 is in the upper-constraints.txt @ master) | |
| 18:12:47 | melwitt | yeah, I don't understand it | |
| 18:23:18 | opendevreview | Lee Yarwood proposed openstack/nova master: trivial: Rename LibvirtConfigGuestPCIeRootPortController https://review.opendev.org/c/openstack/nova/+/812002 | |
| 20:07:25 | opendevreview | Merged openstack/nova master: Store old_flavor already on source host during resize https://review.opendev.org/c/openstack/nova/+/810909 | |
| 21:32:01 | gmann | melwitt:elodilles: in train, we still using tempest master which I need to move to train-last soon | |
| 21:32:49 | melwitt | gmann: lmk if I can help. stable/train currently broken due to new jsonschema 4.0.0 from master | |
| 21:32:56 | gmann | in stein yes tempest 26.0.0 is used | |
| 21:33:39 | gmann | melwitt: ok. I need to go out to pick up my wife. I will check after coming back | |
| 21:35:20 | melwitt | gmann: np thanks, I can work on it, just I would need a hint where to make a change | |
| 21:39:32 | gmann | melwitt: at first glance, it seems it is using stein branch constraint only https://zuul.opendev.org/t/openstack/build/08e374906e2844ef865d4c698b3b78e5/log/job-output.txt#12290 | |
| 21:41:10 | melwitt | hm ok | |
| 22:16:11 | gmann | melwitt: I think tempest job on stable/stein also should fail on this. | |
| 22:17:15 | melwitt | gmann: yeah.. I've been looking at how it says it's using the stein upper-constraints file, but then after it does "tox -r -notest -efull" the 4.0.0 jsonschema gets installed. I don't understand that | |
| 22:17:56 | gmann | melwitt: it is pinned to used stable/stein u-c in stable/stein with tempest 26.0.0 | |
| 22:18:04 | melwitt | so I was looking at https://github.com/openstack/tempest/blob/5d7e46f5689040ddaff798662f7a44fc71758d2e/tox.ini#L14 and I didn't know what the -c does but it looks like this is supposed to be use the env var upper-constraints file if present else use master? | |
| 22:18:45 | gmann | but it should not install latest jsonschema | |
| 22:19:22 | melwitt | here it says "full installed" ... jsonschema==4.0.0 https://zuul.opendev.org/t/openstack/build/08e374906e2844ef865d4c698b3b78e5/log/job-output.txt#12300 | |
| 22:19:27 | melwitt | I took that to mean the tox -efull env installed 4.0.0 | |
| 22:22:46 | gmann | but later on it uninstall 4.0.0 and install 2.6.0 https://zuul.opendev.org/t/openstack/build/08e374906e2844ef865d4c698b3b78e5/log/job-output.txt#12423-12427 | |
| 22:23:21 | melwitt | oh, again? oh sorry | |
| 22:24:20 | melwitt | ok here's the last time it installs 4.0.0 before the error https://zuul.opendev.org/t/openstack/build/08e374906e2844ef865d4c698b3b78e5/log/job-output.txt#28518 | |
| 22:24:25 | gmann | but in final installed version in venv I always see 4.0.0 so not sure who & when it is installed/upgraded | |
| 22:24:41 | melwitt | I get confused by how it installs and uninstalls 4.0.0 repeatedly | |
| 22:25:31 | melwitt | venv installdeps: -c/opt/stack/old/requirements/upper-constraints.txt, -r/opt/stack/old/tempest/requirements.txt, -r/opt/stack/old/tempest/doc/requirements.txt | |
| 22:32:47 | gmann | as it fallback to latest bcz u-c not matched, we should use the compatible constraint while we cut the tempest 26.0.0 instead of stable/stein by default. | |
| 22:37:15 | gmann | at least that is tested combination tempest we released tempest 26.0.0 | |
| 22:38:28 | melwitt | what does it mean u-c didn't match? | |
| 22:40:00 | gmann | tempest 26.0.0 requirement has jsonschema>=3.2.0 and u-c jsonschema== 2.6.0 - https://github.com/openstack/tempest/blob/26.0.0/requirements.txt#L6 | |
| 22:40:16 | melwitt | ohhh I see. ok | |
| 22:40:17 | gmann | that is why it try to go for latest jsonschema | |
| 22:41:25 | gmann | complex thing here is to make tempest venv work on single (non-master) constraints, we have to take care in many place otherwise tox will recreate the tempest venv. many place I mean in devstack, run-tempest role, tox.ini etc | |
| 22:41:39 | melwitt | I see now. I didn't know it would ignore u-c if the requirement was higher than it ... I thought it would have failed like "can't install the tempest that you want" | |
| 22:42:12 | clarkb | melwitt: it should always use the constraint | |