| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-30 | |||
| 08:16:38 | opendevreview | zhen proposed openstack/nova stable/wallaby: Add missing __init__.py in nova/db/api https://review.opendev.org/c/openstack/nova/+/811786 | |
| 08:18:31 | bauzas | gibi: it's a requirements question | |
| 08:18:40 | lyarwood | gibi: if it was a generic issue then sure but it's a single backend and a single usecase within that backend | |
| 08:19:08 | lyarwood | gibi: otherwise as I said before we would end up documenting all issues in our libs with each release | |
| 08:19:15 | gibi | bauzas: sure, can we ping reqs now for Xena? | |
| 08:19:24 | gibi | lyarwood: OK, so this is not a wide issue | |
| 08:19:33 | gibi | then I'm OK to let this slip | |
| 08:19:52 | bauzas | gibi: not sure, the problem is that for the moment, I don't see any work on os-brick | |
| 08:20:28 | bauzas | lyarwood convinced me it's a small issue, so we can leave it tracked as only a bug | |
| 08:20:56 | bauzas | gibi: if really we see larger problems, we could document something in our relnotes later on | |
| 08:20:58 | lyarwood | yeah lets just let them fix it and release a new version and we can then blacklist the original | |
| 08:21:09 | lyarwood | tbh we don't even need to blacklist it | |
| 08:21:26 | gibi | Ok | |
| 08:21:31 | lyarwood | as again we'd have to blacklist every previous version that contained issues later fixed lol | |
| 08:23:13 | gibi | you are right, I probably overreacted without having the context | |
| 08:57:11 | gibi | elodilles: it seems the release script is broken https://zuul.opendev.org/t/openstack/build/ff6be46d117e4c229b9d45e36addbbae/log/job-output.txt#849 | |
| 09:02:30 | elodilles | gibi: indeed. it seems there was a new jsonschema release yesterday :) | |
| 09:02:48 | gibi | murphy does not like xena | |
| 10:39:12 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Always get BDMs using get_by_volume_and_instance https://review.opendev.org/c/openstack/nova/+/811716 | |
| 10:39:22 | lyarwood | if anyone has time today reviews on ^ and the change below it would be appreiciated | |
| 10:39:47 | lyarwood | https://review.opendev.org/q/topic:bug/1943431 also | |
| 11:04:55 | gibi | lyarwood: I'm +2 on https://review.opendev.org/c/openstack/nova/+/811716 (and the parent). Can I trade this with https://review.opendev.org/c/openstack/nova/+/810911 ? :) | |
| 11:09:03 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses are in lower case https://review.opendev.org/c/openstack/nova/+/811947 | |
| 11:15:53 | lyarwood | gibi: ack will do | |
| 11:15:57 | lyarwood | and thanks! | |
| 11:28:59 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | |
| 11:47:44 | gibi | lyarwood: I finished with https://review.opendev.org/q/topic:bug/1943431 too. If you have still time then I could trade that with https://review.opendev.org/c/openstack/nova/+/811396 :) | |
| 11:50:47 | lyarwood | gibi: ack need to grab lunch and then sit on a call for a while but I'll review both series after that this afternoon | |
| 11:51:03 | gibi | lyarwood: thank you, enjoy your lunch | |
| 12:08:45 | bauzas | gibi: https://review.opendev.org/c/openstack/nova/+/810909/2 gets a -1 | |
| 12:09:04 | bauzas | have you rechecked ? | |
| 12:09:19 | bauzas | hem no | |
| 12:09:25 | gibi | let me check the result | |
| 12:09:32 | gibi | I recheked it in the morning | |
| 12:11:42 | bauzas | again, grenade failing and the likes | |
| 12:12:01 | bauzas | but I'll review anyway | |
| 12:12:12 | bauzas | you're one of my r-p tagged | |
| 12:12:37 | bauzas | oh, strangely, you aren't | |
| 12:12:39 | bauzas | wtf | |
| 12:12:57 | gibi | the multicell job as two build timeout | |
| 12:13:13 | gibi | the grenade failed on a live migration test I need to look deeper | |
| 12:13:29 | gibi | probably unrelated but I don't have a matcher for that failure yet | |
| 12:13:51 | gibi | teh multicell build timeout is due to vif plug timeout | |
| 12:13:59 | gibi | that is unrelated for sure | |
| 12:16:08 | gibi | the grenade live migration failure is due to https://bugs.launchpad.net/nova/+bug/1912310 | |
| 12:16:36 | gibi | I hit recheck | |
| 12:59:36 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | |
| 13:05:42 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | |
| 13:06:51 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | |
| 13:35:06 | bauzas | gibi: https://review.opendev.org/c/openstack/nova/+/810909/2/nova/compute/manager.py#5642 shouldn't we also revert to the original flavor in revert_resize ? | |
| 13:35:42 | gibi | bauzas: is that missing? if yes then that is a separate bug | |
| 13:35:52 | bauzas | I dunno | |
| 13:36:06 | bauzas | I'm afraid you set a field on the instance before confirming | |
| 13:36:19 | bauzas | which means a revert needs to get back | |
| 13:36:34 | gibi | I set it earlier than before, but before it was still set during resize not resize confirm | |
| 13:37:10 | bauzas | gibi: I can't see it in the left side | |
| 13:37:11 | gibi | I'm not moving this field change from resize_confirm to resize. I move it from resize_finish (which is part of resize) to resize | |
| 13:37:20 | bauzas | oh fuck | |
| 13:37:23 | bauzas | you're right | |
| 13:37:25 | bauzas | stupid me | |
| 13:37:39 | bauzas | I confused myself with the resize methods naming | |
| 13:37:40 | gibi | bauzas: sorry, yeah, first I moved, but that breaks upgrade, now I just double set | |
| 13:37:51 | gibi | check the first PS | |
| 13:38:00 | bauzas | resize_confirm != resize_finish | |
| 13:38:00 | gibi | that has the move implemented | |
| 13:38:11 | gibi | bauzas: yepp that naming is hard :D | |
| 13:38:26 | bauzas | yeah you finish a resize before you confirm it :p | |
| 13:38:56 | gibi | you finish the resize_instance RPC call on the destination :D | |
| 13:39:10 | gibi | there can be finsh_confirm_resize too | |
| 13:39:45 | gibi | but I think we dont call it like that | |
| 13:47:20 | opendevreview | Merged openstack/nova master: Reproduce bug 1944759 https://review.opendev.org/c/openstack/nova/+/810763 | |
| 13:47:51 | bauzas | gibi: yeah I know | |
| 13:48:00 | bauzas | it was my brain which fscked | |
| 13:50:59 | opendevreview | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1943431 https://review.opendev.org/c/openstack/nova/+/810755 | |
| 13:51:00 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Move _wait_for_volume_{attach,detach} to os-volume_attachments https://review.opendev.org/c/openstack/nova/+/810775 | |
| 13:51:00 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Update volume_id within connection_info during swap_volume https://review.opendev.org/c/openstack/nova/+/807025 | |
| 13:51:01 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Refactor and simplify Cinder fixture GET volume mock https://review.opendev.org/c/openstack/nova/+/810776 | |
| 13:52:07 | lyarwood | sorry are we holding +Ws until we are out of rc? | |
| 13:52:31 | gibi | lyarwood: I'm hesitant. bauzas? | |
| 13:52:51 | bauzas | holding stable patches ? | |
| 13:53:00 | bauzas | or master ones ? | |
| 13:53:05 | gibi | I think lyarwood is asking for master | |
| 13:53:06 | bauzas | former, yes | |
| 13:53:09 | bauzas | latter, nope | |
| 13:53:26 | gibi | ack, then I'm addin +A | |
| 13:53:33 | bauzas | like, I litterally sent gibi's patch to the gate | |
| 13:53:35 | gibi | to https://review.opendev.org/c/openstack/nova/+/810755 | |
| 13:53:54 | lyarwood | cool yeah I just did for the regression test that landed above | |
| 13:53:56 | bauzas | gibi: we branched Xena on RC1, right? | |
| 13:54:01 | gibi | bauzas: right | |
| 13:54:14 | bauzas | so we're officially working on Yoga with master | |
| 13:54:33 | gibi | in my head RC period is when we want to keep master and stable close for easy backport of last minute issues | |
| 13:54:43 | bauzas | that said, any backported change to stable/xena can't be approved until we deliver GA or it's a regression bugfix | |
| 13:55:11 | bauzas | gibi: today is the last RC day | |
| 13:55:17 | gibi | yepp I know | |
| 13:55:21 | bauzas | I don't think we're taking an absolute risk | |
| 13:55:28 | gibi | OK | |
| 13:55:31 | bauzas | this is tho an interesting thought | |
| 13:56:14 | bauzas | honestly, I think we should make more room for bugfixing during our release cadence | |
| 13:56:51 | bauzas | but let's discuss this at the PTG | |