| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-29 | |||
| 16:56:34 | bauzas | heh | |
| 16:56:43 | bauzas | (18:44:41) bauzas: "ask your orchestration to be smarter ?" | |
| 16:56:43 | dansmith | also, if melwitt is right and they're using heat, then FFS, get heat to wait or something | |
| 16:56:47 | dansmith | lol | |
| 16:56:53 | lyarwood | we keep saying they could wait for the stop to finish but wasn't that part of the issue here? Even if they did wait the libvirt driver would kill the instance prematurely before it had finished shutting down? | |
| 16:57:01 | dansmith | if we're just re-quoting ourselves, are we done here? :P | |
| 16:57:19 | gibi | if currently stop + wait for STOPPED + delete works, then a new delete-with-gracefull-shutdown could also be orchestrated from the conductor but it is obviously an orchestration and adds complexity to the already complext delete codepaths | |
| 16:57:42 | bauzas | gibi: and again, this can't be the straight delete | |
| 16:57:53 | dansmith | gibi: we don't go through conductor directly for stop or delete right now, AFAIK, so it would really get confusing to add another whole path like that, IMHO | |
| 16:57:54 | gibi | bauzas: yepp this is delete++ :D | |
| 16:58:25 | gibi | dansmith: then we either need the make the stop RCP sync or do a polling from the nova-api | |
| 16:58:33 | gibi | RPC | |
| 16:58:35 | melwitt | lyarwood: I didn't think so? | |
| 16:58:53 | bauzas | can't we just have as dansmith suggested a "destroy++" API return some 40x when the task state is not None ? | |
| 16:59:15 | lyarwood | that's fine if they aren't waiting | |
| 16:59:18 | melwitt | if that's the case I missed it | |
| 16:59:21 | dansmith | gibi: we'd need a cast to conductor, a new method there, and a sync stop operation to compute from conductor followed by delete.. waiting from the api is not reasonable because stop can take a *long* time | |
| 16:59:35 | gibi | yeah | |
| 16:59:41 | lyarwood | melwitt: I was sure we had talked about them waiting and libvirt still killing the domain before things had shutdown sorry | |
| 16:59:45 | lyarwood | I'll look at the bug again | |
| 16:59:47 | dansmith | in addition to the other four ways we can delete things :) | |
| 16:59:48 | melwitt | lyarwood: my understanding (and I could be wrong) is that they have never tried waiting to stopped | |
| 17:00:00 | lyarwood | I was sure we suggested that early on | |
| 17:00:01 | dansmith | melwitt: right that seems like it to me | |
| 17:00:03 | melwitt | lyarwood: ok same, maybe I'm way off | |
| 17:00:07 | bauzas | I'd rather prefer this destroy++ API to stop synchronously at the API level if some conditions aren't met | |
| 17:00:36 | bauzas | rather than us pursuing the idea we could achieve some distributed locking mechanism | |
| 17:00:56 | dansmith | gibi: also delete returns "I will eventually do this" to the client, which it would no longer be able to guarantee | |
| 17:01:32 | dansmith | bauzas: fwiw, I don't think that is really going to do what this person wants, so we should make sure they think it would help before we do that work | |
| 17:01:37 | gibi | dansmith: ohh, that is correct and bad :/ | |
| 17:02:05 | gibi | delete++ is just too complex | |
| 17:02:08 | bauzas | dansmith: welp, good point | |
| 17:07:07 | bauzas | either way, I think we need a proper tracking | |
| 17:07:41 | bauzas | artom: I guess you need to fill a blueprint and honestly given the brainstorm efforts we made over last hour, you need to write a bit of a spec | |
| 17:08:16 | bauzas | mostly because the current destroy action can't be used for this and we need to consider a new action parameter (or any change in our API) | |
| 17:08:41 | bauzas | artom: feel also free to write a PTG proposal for this one, we could continue the talk there | |
| 17:57:36 | spatel | Any idea how to do VM nic bonding using two VF with SRIOV ? | |
| 17:58:39 | spatel | i am looking for redundancy with sriov implementation and only solution is to do bonding inside vm | |
| 18:04:32 | opendevreview | Ivan Kolodyazhny proposed openstack/nova master: Add release note which descrube NVMe attach issue https://review.opendev.org/c/openstack/nova/+/811447 | |
| 19:15:02 | opendevreview | melanie witt proposed openstack/nova stable/train: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791807 | |
| 19:15:03 | opendevreview | melanie witt proposed openstack/nova stable/train: address open redirect with 3 forward slashes https://review.opendev.org/c/openstack/nova/+/806629 | |
| 19:15:04 | opendevreview | melanie witt proposed openstack/nova stable/train: [stable-only] Set lower-constraints job as non-voting https://review.opendev.org/c/openstack/nova/+/811762 | |
| 21:59:20 | opendevreview | David Vallee Delisle proposed openstack/nova master: rephrasing config description for num_pcie_ports in libvirt https://review.opendev.org/c/openstack/nova/+/811173 | |
| 22:19:17 | opendevreview | Goutham Pacha Ravi proposed openstack/nova stable/wallaby: DNM: Test wallaby with ceph pacific https://review.opendev.org/c/openstack/nova/+/811802 | |
| 22:33:16 | melwitt | gouthamr: thanks for that! ^ I was going to do it and forgot | |
| 22:34:56 | gouthamr | o/ melwitt - i may have hit a circular dependency of sorts | |
| 22:35:45 | melwitt | oh hm.. (looking at it now) | |
| 22:36:54 | melwitt | gouthamr: I wonder if you need to use the url instead of the change-id? not sure how it would know which of the two (master or stable/wallaby) to use | |
| 22:37:02 | melwitt | for the depends-on | |
| 22:37:05 | gouthamr | +1 can try that | |
| 22:38:04 | opendevreview | Goutham Pacha Ravi proposed openstack/nova stable/wallaby: DNM: Test wallaby with ceph pacific https://review.opendev.org/c/openstack/nova/+/811802 | |
| 22:38:22 | clarkb | the url is prefered now because you can depends on things in other code review systems | |
| 22:38:26 | clarkb | change id is gerrit specific | |
| 22:39:11 | gmann | gouthamr: i do not see circular deps, it should work fine. nova->plugin->devstack | |
| 22:39:19 | melwitt | good to know | |
| 22:40:32 | gouthamr | thanks, but zuul stull tells me "Unable to freeze job graph: 0" | |
| 22:40:54 | clarkb | gouthamr: that implies you have a bug in your zuul config I think | |
| 22:41:15 | clarkb | gouthamr: can you give me links to all the changes involved? | |
| 22:41:24 | gouthamr | clarkb: yep: https://review.opendev.org/c/openstack/nova/+/811802/ | |
| 22:42:16 | gouthamr | https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/810059 and https://review.opendev.org/c/openstack/devstack/+/810202 | |
| 22:42:44 | opendevreview | Ghanshyam proposed openstack/nova stable/wallaby: DNM: Test wallaby with ceph pacific https://review.opendev.org/c/openstack/nova/+/811802 | |
| 22:43:31 | gmann | gouthamr: I think running now ^^ ? | |
| 22:43:37 | gouthamr | oh! | |
| 22:43:48 | gmann | yeah | |
| 22:43:54 | gouthamr | gmann: thanks! i am used to pushing empty changes to trigger the CI elsewhere :) | |
| 22:44:24 | gmann | with right deps too https://zuul.openstack.org/status#nova | |
| 22:44:36 | melwitt | gmann++ | |
| 22:47:34 | clarkb | the issue is you have no files in the commit | |
| 22:47:42 | clarkb | seems like you figured that out | |
| 22:48:07 | clarkb | I don't know that that is a use case we should support. If you aren't changing anything then why bother | |
| 22:48:17 | melwitt | I noticed that but didn't know that it would cause problems | |
| 22:48:24 | gmann | clarkb: yeah, erorr was confusing though | |
| 22:49:11 | clarkb | gmann: yes, https://paste.opendev.org/show/809680/ is the internal handling of it. It is an exceptional case currently | |
| 22:49:23 | clarkb | I've brought it up in the zuul matrix room to see if that is something we can handle better | |
| 22:49:48 | gmann | clarkb: +1 | |
| 22:49:52 | gmann | thanks | |
| 22:51:33 | gouthamr | awesome thanks clarkb! | |
| 22:52:23 | clarkb | the other issue you'll run into with that even if zuul didn't explode on it is so many jobs match on files that are modified. If no files are modified then none of those jobs will run | |
| 23:51:14 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Add functional regression test for bug 1853009 https://review.opendev.org/c/openstack/nova/+/811805 | |
| 23:51:15 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Clear rebalanced compute nodes from resource tracker https://review.opendev.org/c/openstack/nova/+/811806 | |
| 23:51:16 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Invalidate provider tree when compute node disappears https://review.opendev.org/c/openstack/nova/+/811807 | |
| 23:51:17 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/811808 | |
| 23:51:18 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811809 | |
| #openstack-nova - 2021-09-30 | |||
| 00:29:47 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Add functional regression test for bug 1853009 https://review.opendev.org/c/openstack/nova/+/811810 | |
| 00:29:48 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Clear rebalanced compute nodes from resource tracker https://review.opendev.org/c/openstack/nova/+/811811 | |
| 00:29:49 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Invalidate provider tree when compute node disappears https://review.opendev.org/c/openstack/nova/+/811812 | |
| 00:29:50 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/811813 | |
| 00:29:51 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811814 | |
| 00:35:37 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Add functional regression test for bug 1853009 https://review.opendev.org/c/openstack/nova/+/811815 | |
| 00:35:38 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Clear rebalanced compute nodes from resource tracker https://review.opendev.org/c/openstack/nova/+/811816 | |
| 00:35:39 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Invalidate provider tree when compute node disappears https://review.opendev.org/c/openstack/nova/+/811817 | |
| 00:35:40 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/811818 | |
| 00:35:41 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811819 | |
| 01:10:20 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/811808 | |
| 01:10:21 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811809 | |
| 01:38:20 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811809 | |
| 01:44:39 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/811813 | |
| 01:44:40 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811814 | |
| 01:46:45 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/811818 | |
| 01:46:46 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811819 | |