| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-21 | |||
| 10:50:48 | alexe9191 | I do however see a lot of those in the logs "Lock "host_instance" acquired by "nova.scheduler.host_manager.sync_instance_info"" | |
| 10:51:16 | opendevreview | Vlad Gusev proposed openstack/nova stable/stein: Add regression test for bug #1908075 https://review.opendev.org/c/openstack/nova/+/810191 | |
| 11:13:54 | alexe9191 | and now after about 90 minutes it's done | |
| 11:30:37 | gibi | bauzas: could you please triage this vgpu bug https://bugs.launchpad.net/nova/+bug/1943933 ? | |
| 11:33:10 | sean-k-mooney | i think the way our config is ment to work is we list the adress of the parent | |
| 11:33:37 | sean-k-mooney | and then report the quantity of the mdev type that can be created for that device | |
| 11:34:05 | gibi | ohh so the reported wants to partially report the possible mdevs from a physical device | |
| 11:34:20 | sean-k-mooney | i think so | |
| 11:34:33 | sean-k-mooney | which i dont think we support | |
| 11:34:57 | sean-k-mooney | they basically want to treat it like we do for sriov i think where you can enable indiviugual vfs | |
| 11:35:16 | gibi | so this would be a new feature | |
| 11:35:19 | sean-k-mooney | i could be reading into the report too much but i think that is what they were expecting | |
| 11:35:49 | sean-k-mooney | gibi: ya basically a host_reserved_mdev parmater or somehting | |
| 11:36:14 | gibi | OK. I let bauzas respond but I think I see what you see in the report | |
| 11:36:19 | sean-k-mooney | e.g. enable all mdevs of this type form this parent but reserve x for host use | |
| 11:36:27 | gibi | bauzas: also ther is another vgpu bug to triage https://bugs.launchpad.net/nova/+bug/1944031 | |
| 11:37:18 | sean-k-mooney | the second one likely is correct but never personally used vgpu so not sure | |
| 11:37:34 | gibi | yeah bauzas has an environment to reproduce :) | |
| 11:37:37 | gibi | hence my ping | |
| 12:03:59 | bauzas | gibi: sean-k-mooney: ack, will look at both | |
| 12:04:08 | gibi | bauzas: thanks | |
| 12:17:02 | gibi | sean-k-mooney: this feels like a networking / neutron bug but I'm not certain. cloud you check it please https://bugs.launchpad.net/nova/+bug/1944083 ? | |
| 12:27:53 | sean-k-mooney | gibi: the only /32 that i can think of that we install is the one for the metadata service | |
| 12:28:15 | sean-k-mooney | gibi: but ya i think this is all contoled more or less on the neutron side in combindation with cloud-init | |
| 12:28:48 | sean-k-mooney | we might store some to the network info in the metadata which will be used by cloud-init | |
| 12:29:00 | sean-k-mooney | but i think this is more or less out of our contol | |
| 12:30:15 | sean-k-mooney | lets add neutron and see what they think | |
| 12:31:34 | gibi | sean-k-mooney: thanks for the analysis | |
| 12:31:41 | gibi | I agree to involve neutron | |
| 12:32:56 | sean-k-mooney | the closet thing i can tink of is https://github.com/openstack/nova/blob/master/nova/virt/interfaces.template | |
| 12:33:37 | sean-k-mooney | we do list the dhcp server per interface https://github.com/openstack/nova/blob/master/nova/virt/interfaces.template#L21 | |
| 12:33:52 | sean-k-mooney | but we are not adding any routes here | |
| 12:39:40 | sean-k-mooney | we do set the default route via the gateway in the metadata https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/virt/netutils.py#L326-L348 | |
| 12:39:55 | sean-k-mooney | and populate any addtional neutron routes https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/virt/netutils.py#L103-L121 | |
| 12:40:37 | sean-k-mooney | but ya as far as i can see there is noting on the nova side that would install /32 routes to the dns servers | |
| 12:40:45 | opendevreview | norman shen proposed openstack/nova master: Recreate mdev devices according to placement https://review.opendev.org/c/openstack/nova/+/810220 | |
| 12:54:13 | opendevreview | Merged openstack/nova master: Add missing __init__.py in nova/db/api https://review.opendev.org/c/openstack/nova/+/809980 | |
| 12:54:32 | opendevreview | Merged openstack/nova stable/xena: [stable-only]Update .gitreview for stable/xena https://review.opendev.org/c/openstack/nova/+/809759 | |
| 12:54:47 | opendevreview | Merged openstack/nova stable/xena: [stable-only]Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/nova/+/809760 | |
| 13:14:58 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Add missing __init__.py in nova/db/api https://review.opendev.org/c/openstack/nova/+/810192 | |
| 13:15:45 | gibi | elodilles, lyarwood, bauzas: we need this in xena for RC2 ^^ | |
| 13:16:09 | bauzas | done | |
| 13:16:24 | gibi | thanks | |
| 13:16:44 | lyarwood | ACK'd | |
| 13:17:25 | gibi | cool | |
| 13:17:27 | gibi | this was fast :) | |
| 13:17:39 | lyarwood | I'm going to be AFK for the meeting btw, dental checkup for the first time in a long time. | |
| 13:18:24 | gibi | lyarwood: ack, thanks for the headsup | |
| 13:18:35 | gibi | and I hope the dentis will be painless | |
| 13:21:25 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Store and allow libvirt instance device buses and models to be updated https://review.opendev.org/c/openstack/nova-specs/+/810235 | |
| 13:22:19 | lyarwood | I'm British so the normal and in my case correct stereotypes apply, it's not going to be fun. | |
| 13:24:25 | bauzas | lyarwood: we need a release liaison that I'll ask in today's meeting | |
| 13:24:35 | bauzas | lyarwood: if you are interested in this role, tell me | |
| 13:24:47 | gibi | this reminds me to book a dentis checkup too | |
| 13:25:02 | bauzas | gibi: booked since 6 months | |
| 13:25:18 | gibi | I'm not rushing :) | |
| 13:25:29 | kashyap | gibi: Yikes; I've been avoiding it | |
| 13:25:35 | kashyap | I know I should | |
| 13:26:33 | bauzas | "I have a tooth rage", "sure, we have a slot in Feb 2022, works for you ?" | |
| 13:26:47 | bauzas | longer than delivering a car | |
| 13:36:56 | gibi | as far as I see I can book a dentist slot for this thursday morning | |
| 13:37:05 | gibi | that feels too close :/ | |
| 13:40:01 | kashyap | gibi: Don't you prefer your band-aid to be quickly removed? | |
| 13:40:25 | gibi | that one way to look at it | |
| 13:41:07 | artom_ | bauzas, obviously the solution is to drive a new car over your tooth | |
| 13:41:09 | artom_ | No tooth, no pain | |
| 13:41:27 | bauzas | heh | |
| 13:42:17 | gibi | artom: :D | |
| 13:52:22 | bauzas | gibi: agenda is updated https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting feel free to add your points | |
| 13:52:38 | bauzas | gibi: will you propose a backport to stable/xena for the decorator bump ? | |
| 13:52:49 | gibi | bauzas: ack will check the agenda | |
| 13:53:24 | gibi | bauzas: I can propose a backport then we can drop it if we choose other option to go forward | |
| 13:56:11 | opendevreview | Balazs Gibizer proposed openstack/placement stable/xena: Bump min decorator to 4.0.0 https://review.opendev.org/c/openstack/placement/+/810193 | |
| 13:56:16 | gibi | bauzas: done | |
| 13:56:28 | bauzas | thanks | |
| 13:56:40 | bauzas | we could discuss this during the meeting then | |
| 14:02:57 | gibi | added two topic to the end of the agenda | |
| 14:20:04 | opendevreview | Thomas Goirand proposed openstack/nova stable/xena: Add missing __init__.py in nova/db/api https://review.opendev.org/c/openstack/nova/+/810192 | |
| 14:21:28 | zigo | gibi: bauzas: My bad, I shouldn't have pushed an update, now this patch needs another +2W: https://review.opendev.org/c/openstack/nova/+/810192 | |
| 14:21:58 | zigo | I was waiting for the .gitreview, and thought I should be doing it... | |
| 14:33:35 | opendevreview | Elod Illes proposed openstack/nova stable/xena: Add missing __init__.py in nova/db/api https://review.opendev.org/c/openstack/nova/+/810192 | |
| 14:34:47 | elodilles | zigo: i've uploaded the original patch again | |
| 14:35:35 | zigo | elodilles: Thanks. | |
| 14:39:44 | elodilles | zigo: and +2+W'd as the content is now the very same as PS1 had | |
| 14:48:40 | clarkb | gibi: thats kind of my point though updating things like tox.ini or .gitreview or translations or other mechanical infrastructure bits don't need that and aren't really a corner case. The lint rules are just too aggressive and you can trust reviewers more imo | |
| 14:48:59 | clarkb | It is ok to update the branch so that it functions | |
| 14:49:33 | clarkb | but if you insist on having those rules please update the bots so that they don't run afoul of the linter | |
| 14:52:39 | gibi | clarkb: I'm not the right person to convince as I wasnt the one pushed for the stable backport linter. lyarwood, elodilles: what is your view? | |
| 14:53:43 | gibi | clarkb: I do think that having couple of paches needing a manual touch every six months is not a big deal. But I also see the point that we could update the bot to use a specific commit message in nova stable setup patches | |
| 14:53:58 | clarkb | I probably feel more strongly about this than most because 90% of the time if I'm pushing to stable branches it is to fix a stable branch specific issue without a backport and I always run into problems like this and it is frustrating that no one seems to accept it is ok to fix a branch on its own | |
| 14:54:07 | bauzas | gibi: oh shit, I wanted to discuss about the release liaison role but I forgot to add it in the meeting notes :facepalm: | |
| 14:54:24 | gibi | bauzas: I added it :D | |
| 14:54:57 | bauzas | I sqaw | |
| 14:54:59 | clarkb | if the branch is broken and someone pushes a fix reviewers should have the discretion to land the fix | |
| 14:55:12 | gibi | clarkb: thank you for taking case of the stable branches. I hope elodilles and lyarwood can join. | |
| 14:55:21 | gibi | ... and add their views | |
| 14:57:01 | gibi | s/case/care/ | |
| 14:58:07 | gibi | clarkb: most of the linters are to help the reviews not missing things. in this case this linter helps the reviewer to check that the fix is already landed on master and newer stable branches. | |
| 14:58:20 | bauzas | honeslty I tend to prefer trusting reviews rather than using linters | |
| 14:58:26 | gibi | which is the rule, with exceptions | |