| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-01 | |||
| 11:42:31 | bauzas | anyway, the dudes probably have stopped to work at the network room | |
| 11:42:32 | sean-k-mooney | god i havent done that in at least a decade. i did for a short while in collage but never found it a good way to consume info | |
| 11:42:47 | bauzas | looks like my gitches are gone | |
| 11:51:15 | opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Remove disable_native_luksv1 https://review.opendev.org/c/openstack/nova/+/805647 | |
| 11:51:16 | opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Remove rbd_volume_local_attach https://review.opendev.org/c/openstack/nova/+/805648 | |
| 11:52:59 | opendevreview | Stephen Finucane proposed openstack/python-novaclient master: tests: Add missing 'nova update' tests https://review.opendev.org/c/openstack/python-novaclient/+/806916 | |
| 11:52:59 | opendevreview | Stephen Finucane proposed openstack/python-novaclient master: Add pre-commit https://review.opendev.org/c/openstack/python-novaclient/+/806915 | |
| 11:52:59 | lyarwood | bauzas / gibi ; ^ should be ready now, apologies for the mix up with the reno. | |
| 11:53:00 | opendevreview | Stephen Finucane proposed openstack/python-novaclient master: trivial: Remove use of kwargs https://review.opendev.org/c/openstack/python-novaclient/+/806918 | |
| 11:53:00 | opendevreview | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.90 - Configurable hostnames https://review.opendev.org/c/openstack/python-novaclient/+/806917 | |
| 11:53:23 | bauzas | lyarwood: ack, going lunching, but will click to look at it after | |
| 12:05:44 | gibi | lyarwood: +2 on both | |
| 12:20:52 | stephenfin | lyarwood: friendly reminder to ensure you've made any changes necessary to OSC for microversion 2.89 | |
| 12:21:28 | stephenfin | s/patch is/patch/ | |
| 13:02:40 | lyarwood | stephenfin: https://review.opendev.org/c/openstack/python-openstackclient/+/804377 | |
| 13:30:19 | gibi | sean-k-mooney: fyi just got reported from downstream https://bugs.launchpad.net/nova/+bug/1942329 | |
| 13:33:48 | sean-k-mooney | gibi: yep this is a know issue | |
| 13:34:12 | gibi | is it an older bug report open for it I should duplicate to? | |
| 13:34:17 | gibi | is there | |
| 13:34:43 | sean-k-mooney | good question tl;dr when drict physical supprot was added they did not add support for any move operations | |
| 13:35:28 | sean-k-mooney | so cold migration resize and shelve are all broken | |
| 13:35:45 | sean-k-mooney | i cant recall if i blocked it for live migration or if that is also affected | |
| 13:36:36 | sean-k-mooney | we have downstream bugs for this https://bugzilla.redhat.com/show_bug.cgi?id=1745842 | |
| 13:37:49 | sean-k-mooney | i dont see an upstream one linked so im not sure if we have an upstream bug but we have talked about it at the ptg before i think | |
| 13:38:58 | gibi | thanks | |
| 13:41:38 | sean-k-mooney | ah yes line 420 https://etherpad.opendev.org/p/nova-xena-ptg | |
| 13:42:08 | opendevreview | Merged openstack/nova stable/victoria: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802842 | |
| 13:42:15 | sean-k-mooney | no upstream links form ath either altough i did not include the downstreeam one so either but lets use your new one for now | |
| 13:44:58 | gibi | ohh cool, I have a very bad memory | |
| 13:45:54 | sean-k-mooney | this has been on my todo list to fix evenuatlly but it keep getting pushed off. artom started fixing some of the degecases and we have resolved other incidnetally. | |
| 13:46:15 | sean-k-mooney | for example live migration did not wrok because 1 the mac was not updated and 2 detach of PF was not implmented | |
| 13:46:29 | sean-k-mooney | gibi: you fixed detach when you added sriov attach/detach supprot | |
| 13:46:37 | gibi | yepp | |
| 13:46:46 | gibi | and I see artom fixed the unshelve pci_slot case | |
| 13:46:51 | sean-k-mooney | yes | |
| 13:47:18 | sean-k-mooney | so we have been trying to fix the more commens cases first when we get time too work on bugs | |
| 13:47:19 | gibi | I made TODO now on my side to look at the MAC update at some point | |
| 13:48:03 | sean-k-mooney | ack, so it a general problem for all pf move operation including evacuate | |
| 13:48:25 | sean-k-mooney | as you noted we do update the neutron port on vm boot intially its just never done after that | |
| 13:48:35 | gibi | yepp | |
| 13:48:40 | sean-k-mooney | so we need to add the same logic in all the places to update the neutron port mac | |
| 13:48:55 | sean-k-mooney | the problem is that that is not part of multipe port bidnign which makes it annoying | |
| 13:49:46 | gibi | ohh then live migration will be a special case | |
| 13:49:48 | kashyap | gibi: Is it something recent - Zuul requires uBlockOrigin to be disabled? | |
| 13:49:59 | gibi | kashyap: didn't noticed yet | |
| 13:49:59 | kashyap | (And Privacy Badger) | |
| 13:50:16 | sean-k-mooney | yep gibi so if you work on this proably leave live migration till last | |
| 13:50:24 | gibi | sean-k-mooney: ack, good idea | |
| 13:50:42 | sean-k-mooney | we could add a api block noting its not implemented in the interim with a workaround flag to allow operators to renable it | |
| 13:51:01 | sean-k-mooney | its one of the things we disucssed downstream i just never got around to pusshing a patch | |
| 13:51:28 | gibi | it is not utterly broken as we are not leaking resources or breaking the guest, so I would not block the operation | |
| 13:51:49 | sean-k-mooney | well actully it kind of is | |
| 13:52:02 | sean-k-mooney | the vm will migrate but it can cause other vms to fail to boot | |
| 13:52:09 | gibi | why? | |
| 13:52:20 | sean-k-mooney | when we release the PF on the source | |
| 13:52:29 | kashyap | When I opened a Zuul URL to debug, it was asking me to "please try with disabling ad blocker". /me tries. It's iether that, or it's just a stable URL | |
| 13:52:34 | kashyap | s/stable/stale/ | |
| 13:52:51 | sean-k-mooney | if another vm in the same network is shcudled to the source node then it will get a mac conflict in neutron when it trys to update the mac | |
| 13:53:15 | sean-k-mooney | gibi: also the vm that was migrate will not get an adress form dhcp proeprly | |
| 13:53:17 | gibi | Ohh so neutron will reject the AMC update | |
| 13:53:24 | gibi | :/ | |
| 13:53:28 | gibi | OK then it is broken | |
| 13:53:29 | sean-k-mooney | yep | |
| 13:53:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 13:53:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support interface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 13:53:52 | sean-k-mooney | so unless you are using static ips the vm that was migrated will be broken too | |
| 13:53:58 | gibi | kashyap: could paste a link you are strugling with? | |
| 13:54:09 | kashyap | gibi: https://zuul.opendev.org/t/openstack/build/a4b92ce40be841eaaf3e97f00c39b4d4 | |
| 13:54:17 | kashyap | gibi: It's from June, granted | |
| 13:54:21 | gibi | sean-k-mooney: ahh so the dhcp agent uses the port.mac to provide the ip | |
| 13:54:24 | kashyap | Probably it just got garbage-collected | |
| 13:54:37 | gibi | kashyap: it is already gc-d | |
| 13:54:42 | gibi | kashyap: you need to recheck the patch | |
| 13:54:45 | kashyap | Yep | |
| 13:54:53 | sean-k-mooney | gibi: yes and the port will have the mac of the new PF | |
| 13:55:00 | gibi | yep I got it know | |
| 13:55:11 | gibi | then Im OK to block the operation | |
| 13:55:16 | sean-k-mooney | gibi: so either the dhcp server will not respond or it will get the wrong ip if you have moved several vms | |
| 13:56:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: [nova-manage]support extended resource request https://review.opendev.org/c/openstack/nova/+/802060 | |
| 13:57:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reno for qos-minimum-guaranteed-packet-rate https://review.opendev.org/c/openstack/nova/+/805046 | |
| 14:10:11 | opendevreview | Ghanshyam proposed openstack/nova master: Convert features not supported error to HTTPBadRequest https://review.opendev.org/c/openstack/nova/+/806294 | |
| 14:12:28 | gmann | stephenfin: gibi ^^ resolved merge conflict, | |
| 14:13:26 | gibi | gmann: done | |
| 14:13:50 | gmann | gibi: thanks | |
| 14:50:28 | gibi | lyarwood: fyi I found a bug in the libvirt device detach series https://bugs.launchpad.net/nova/+bug/1942345 | |
| 15:04:08 | opendevreview | Merged openstack/nova stable/victoria: Reduce mocking in test_reject_open_redirect for compat https://review.opendev.org/c/openstack/nova/+/803093 | |
| 15:38:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Parse alias from domain hostdev https://review.opendev.org/c/openstack/nova/+/806943 | |
| 15:41:06 | gibi | I marked https://bugs.launchpad.net/nova/+bug/1942345 as xena-rc-potential as we regressed SRIOV PF detach in Xena | |
| 15:42:50 | sean-k-mooney | oh it broke ya that would be rc bug then | |
| 15:43:09 | sean-k-mooney | i might see if we can get this in whitebox ot try and test it eventually | |
| 15:43:21 | sean-k-mooney | unfortunetly we dont have a way to run against upstream with sriov currently | |
| 15:45:18 | gibi | yepp, it would be nice to get automatic coverage of SRIOV ops as I'm lazy to run SRIOV tests manually in my lab env frequently | |
| 15:45:43 | gibi | I discovered this by playing with the SRIOV migration MAC issue | |
| 16:02:56 | gibi | melwitt: if you are up, do you have any opinion about https://storyboard.openstack.org/#!/story/2009159 and the related discussion happened yesterday on the weekly meeting? | |
| 16:04:10 | sean-k-mooney | gibi: i know that there is limited coverage by the melonox ci but they have not added to that as we added new feature like sriov attaach/detach | |
| 16:06:03 | melwitt | gibi: oh sorry I had missed that. need to read it | |
| 16:08:48 | melwitt | gah this traceback formatting on storyboard -_- | |
| 16:11:16 | melwitt | gibi: on the surface it seems like we have to change it back and do something manual up the stack to handle the consumer type update rollback :/ not sure what else can be done about it | |
| 16:11:49 | opendevreview | Merged openstack/nova master: workarounds: Remove disable_native_luksv1 https://review.opendev.org/c/openstack/nova/+/805647 | |
| 16:12:05 | gibi | melwitt: yepp we discussed that on the meeting yesterday that we can do project and user creation outside of the main transaction and only move the consumer type and the allocation update into the last big transaction | |