| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-25 | |||
| 02:25:34 | opendevreview | Merged openstack/nova stable/stein: Prevent archiving of pci_devices records because of 'instance_uuid' https://review.opendev.org/c/openstack/nova/+/760984 | |
| 02:25:43 | opendevreview | Merged openstack/nova master: fup: Remove unused legacy block_device_info format https://review.opendev.org/c/openstack/nova/+/804286 | |
| 02:25:54 | opendevreview | Merged openstack/nova master: fup: Increase service_down_time beyond INITIAL_REPORTING_DELAY in test https://review.opendev.org/c/openstack/nova/+/805667 | |
| 08:56:18 | opendevreview | test proposed openstack/nova master: Add some missing parameters in docs of os-cells https://review.opendev.org/c/openstack/nova/+/805972 | |
| 09:26:57 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 09:51:38 | opendevreview | Balazs Gibizer proposed openstack/placement master: Restrict amqp indirect dep to speed up pip resolution https://review.opendev.org/c/openstack/placement/+/805979 | |
| 09:51:45 | opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | |
| 09:55:59 | lyarwood | gibi: https://review.opendev.org/q/topic:remove_luks_workarounds some simple cleanups here if you have time | |
| 09:56:12 | elodilles | lyarwood: I've commented on the stable/train's CI patch. I'm not completely against it, but it is not necessary in Train so I wouldn't merge it in all cost, plus I see one difference that would reduce coverage if I'm not mistaken: py2 grenade | |
| 09:56:33 | gibi | lyarwood: ack, lookgin | |
| 09:56:37 | lyarwood | elodilles: ack I'll look | |
| 09:56:57 | lyarwood | gibi: thanks, I'm trying to get to your qos series btw, almost there :) | |
| 09:57:04 | gibi | lyarwood: thanks in advance :) | |
| 10:16:24 | opendevreview | Merged openstack/nova master: fup: Fix os-volume_attachments api-ref parameters https://review.opendev.org/c/openstack/nova/+/805876 | |
| 10:24:08 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 10:24:09 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 11:14:15 | opendevreview | Lee Yarwood proposed openstack/placement master: Restrict amqp indirect dep to speed up pip resolution https://review.opendev.org/c/openstack/placement/+/805979 | |
| 11:14:15 | opendevreview | Lee Yarwood proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | |
| 11:14:37 | lyarwood | gibi: ^ just had to reorder these to avoid the 2.6.0 test failure | |
| 11:30:16 | opendevreview | Merged openstack/nova master: Reproduce bug 1941005 https://review.opendev.org/c/openstack/nova/+/805882 | |
| 11:39:56 | kevinz | kashyap: sbauza: Hi, could you help to review this live migration patch? https://review.opendev.org/c/openstack/nova/+/763928, the comments has been addressed. | |
| 11:40:29 | kevinz | kashyap: sbauza: live migration on arm64 patch, really appreciated! | |
| 12:04:15 | sean-k-mooney | kevinz: they are both on vaction this week | |
| 12:04:25 | gibi | lyarwood: right that is the correct order. I knew I wanted to do something with them but I got distracted | |
| 12:04:26 | sean-k-mooney | ill try and take a look at it | |
| 12:04:28 | gibi | thanks | |
| 12:05:53 | gibi | lyarwood: wait, now the 2.6.0 is the first patch, but that will fail due to timeout without the amqp restriciton | |
| 12:06:22 | gibi | do we have a deadlock then | |
| 12:06:25 | gibi | ? | |
| 12:07:30 | gibi | the global req was bumped causing that we need the gabbit update, but that is failing as lower constraints is timing out without the amqp change, but the amqp patch alone will fail due to the gabbit failures | |
| 12:14:45 | opendevreview | Merged openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | |
| 12:17:16 | lyarwood | gibi: yeah sorry I didn't think the amqp change was causing a failure | |
| 12:17:29 | lyarwood | gibi: in that case we should squash both changes into one I guess | |
| 12:17:40 | gibi | yes, I don't see any other way around | |
| 12:17:45 | gibi | I will squash them in a minute | |
| 12:24:05 | opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | |
| 12:24:45 | gibi | lyarwood: this should be green now ^^ | |
| 13:09:19 | opendevreview | Merged openstack/python-novaclient master: Microversion 2.89 - os-volume_attachments https://review.opendev.org/c/openstack/python-novaclient/+/805022 | |
| 13:25:17 | opendevreview | lmercl proposed openstack/nova master: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805995 | |
| 13:29:59 | opendevreview | lmercl proposed openstack/nova stable/wallaby: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805997 | |
| 13:40:50 | opendevreview | lmercl proposed openstack/nova master: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805995 | |
| 14:20:53 | opendevreview | Rodrigo Barbieri proposed openstack/nova stable/victoria: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/806004 | |
| 14:25:50 | gmann | stephenfin: gibi replied on hostname policy chekcs https://review.opendev.org/c/openstack/nova/+/778550/10/nova/api/openstack/compute/views/servers.py#414 | |
| 14:26:04 | gmann | we can chat to conclude it quickly | |
| 14:26:34 | gmann | my point is, this is policy change and should not be controlled with microversion instead just deprecate and remove in next cycle for old microversion also | |
| 14:26:42 | gmann | that is how other policy changes we do | |
| 14:27:56 | gmann | old microversion in this case i mean >2.3 for GET and >2.75 for PUT/Rebuild as this attribute was added for them. | |
| 14:40:44 | gibi | gmann: does this mean we are not implementing the POST /servers change to allow passing hostname in Xena? If we do implement that then delaying the policy change (at least of the new microversion) with deprecation does not make sense from usability perspective | |
| 14:41:15 | gibi | I want see what I passed in | |
| 14:43:58 | gibi | so what if in Xena we deprecate the policy BUT also in xena in the microversion that allows passing hostname in server create we introduce the hostname in the responses. Then in Yoga we remove the policy from the hostname attribute and that results that hostname will be shown in every microversion | |
| 14:44:41 | gibi | this allows that the current POST change be usable in Xena and also follows deprecation policy | |
| 14:52:44 | gmann | gibi: in that case we have to mention that policy is controlled with microversion. for >=2.90 you can see this attribute even previously you have restricted it for non-admin and even non-admin does not pass hostname in POST request. | |
| 14:55:28 | gibi | gmann: purely from policy perspective yes, this would be a microversion that temporarily changes the policy. After Yoga where the policy is removed this microversion controlls policy situation would be resolved | |
| 14:55:59 | gibi | honestly I don't want to delay the possibility to set hostnames | |
| 14:56:18 | gibi | but only allow to set them in 2.90 but not allow to see what you set feels bad | |
| 15:02:36 | gmann | gibi: they can see with policy change, but yes with default policy they would not be able to see | |
| 15:02:44 | gmann | *policy override | |
| 15:03:01 | gibi | gmann: is there a way to only override the policy for the hostname attribute only? | |
| 15:06:09 | gmann | gibi: no, it is with other server extended attributes | |
| 15:06:38 | gibi | but we don't want to show all the exteneded attribute as there are sensitive informations there like the hypervisor_hostname | |
| 15:06:51 | gmann | humm | |
| 15:06:52 | gibi | but the hostname of the VM is harmless | |
| 15:07:02 | gibi | that does not reveal any infra informatiuon | |
| 15:07:11 | gmann | yeah | |
| 15:09:55 | gmann | gibi: I think in this exceptional case when there is related API change, I am getting your point. | |
| 15:10:18 | gmann | let me rethink if any other way it can create inconsistency other seems ok to me | |
| 15:10:23 | gmann | otherwise | |
| 15:11:07 | gibi | gmann: for me it is the case when our strict rules (microversion and policy deprecation) get in our way to provide a meaningful and (for me) safe change for the end user | |
| 15:12:05 | gmann | yeah. | |
| 15:13:09 | gibi | and I support our strict rules in general as it is a safety net to avoid breaking users, but in this specific case I think we can allow an exception for the rules | |
| 15:14:12 | gmann | i agree. especially with the point of using 2.90 changes completely (request and see the hostname by end users) | |
| 15:15:22 | gmann | I think I am convinced now :). thanks | |
| 15:17:15 | opendevreview | Merged openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | |
| 15:24:27 | gibi | gmann: thank you for the discussion | |
| 15:29:33 | melwitt | lyarwood: thanks for noting that I need to rebase the consumer types set, going to do that now and will need +W reapplied after | |
| 15:29:59 | lyarwood | melwitt: I think we can get away without a rebase now | |
| 15:30:09 | lyarwood | melwitt: zuul should do it for us once it's rechecked | |
| 15:30:33 | melwitt | o rly | |
| 15:30:35 | melwitt | ok | |
| 15:30:39 | melwitt | I'm glad I said something. thanks I can do that | |
| 15:30:47 | stephenfin | gmann: gibi: Sorry, I had meetings. It _sounds_ like you've come to a conclusion and are ultimately happy with what I've done? | |
| 15:31:22 | gmann | stephenfin: yeah, it looks good to me, reviewing that patch... | |
| 15:33:14 | gibi | ohh consumer_types are going in \o/ | |
| 15:36:30 | melwitt | yes \o/ | |
| 15:36:54 | lyarwood | assuming it's rebased by zuul ;) | |
| 15:39:26 | lyarwood | cool looks like it did | |
| 15:39:58 | lyarwood | brb | |
| 16:07:09 | gmann | stephenfin: left few comments on test and documentation | |
| 16:36:31 | artom | def _do_old_style_instance_list_for_poor_cellsv1_users() | |
| 16:36:39 | artom | Right, who's the joker responsible for that? | |
| 16:37:25 | artom | Mr Smith. | |
| 16:37:29 | sean-k-mooney | someone who took pitty on the cell v1 users | |
| 16:37:39 | sean-k-mooney | then need all the care we can give them | |
| 16:37:41 | artom | (Yes, this is very old code - looking at a Queens bug report) | |
| 16:39:33 | sean-k-mooney | ********* | |
| 16:39:58 | sean-k-mooney | they are mising url quoting | |
| 16:40:00 | sean-k-mooney | https://github.com/sqlalchemy/sqlalchemy/blob/master/lib/sqlalchemy/engine/url.py#L542 | |
| 16:43:23 | artom | ? | |
| 16:44:27 | sean-k-mooney | the query args secotion fo the url is enccoded using quote_plus | |
| 16:44:40 | sean-k-mooney | where spaces are replaced with + | |