| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-23 | |||
| 14:38:46 | fungi | gerrit will allow you to push with any author on the commit, so long as your account is listed as the committer | |
| 14:38:54 | sean-k-mooney | its just https://launchpadlibrarian.net/554904339/python3.patch | |
| 14:39:03 | sean-k-mooney | no commit headers it just a raw patch file | |
| 14:39:15 | sean-k-mooney | not a git commit | |
| 14:39:25 | fungi | yeah, co-authored-by or whatever then | |
| 14:40:44 | fungi | the patch is trivial enough i doubt we need to worry about icla | |
| 14:41:52 | fungi | hopefully melwitt knows if there was some necessary nuance to the other solution we're not spotting | |
| 14:42:04 | fungi | once she's able to review it | |
| 14:48:13 | opendevreview | sean mooney proposed openstack/nova master: address open redirect with 3 forward slashes https://review.opendev.org/c/openstack/nova/+/805654 | |
| 14:52:03 | opendevreview | sean mooney proposed openstack/nova master: address open redirect with 3 forward slashes https://review.opendev.org/c/openstack/nova/+/805654 | |
| 14:52:53 | lyarwood | gibi: thanks for creating https://bugs.launchpad.net/nova/+bug/1940741 - have you had time to look into the race that's causing it? | |
| 14:53:43 | gibi | lyarwood: I only have the repro with DEBUG and tried to add sleep before the confirm call but that did not increased the chance of repro | |
| 14:53:57 | lyarwood | `2021-08-23 12:47:50,585 DEBUG [nova.servicegroup.drivers.db] Seems service nova-compute on host src is down. Last heartbeat was 2021-08-23 12:47:45.500309. Elapsed time is 5.084755` what the hell | |
| 14:54:13 | gibi | lyarwood: I'm deep in https://bugs.launchpad.net/nova/+bug/1936849 now so you can take https://bugs.launchpad.net/nova/+bug/1940741 forward | |
| 14:54:20 | lyarwood | ack np | |
| 14:54:39 | gibi | lyarwood: yepp I saw that hence my trial with sleeps | |
| 14:55:15 | gibi | lyarwood: maybe the compute service is busy and cannot do an update in every second | |
| 14:56:11 | lyarwood | yeah the dest is likely running through the resize codepaths and blocking the src prior to that | |
| 14:56:19 | lyarwood | good old func tests | |
| 14:56:22 | gibi | :) | |
| 14:56:48 | gibi | lyarwood: but you can prove that if you slow down the resize on the dest with sleep | |
| 14:57:39 | gibi | if that increases the repro rate then we have a proof | |
| 15:01:54 | gibi | lyarwood: you won't belive what causing https://bugs.launchpad.net/nova/+bug/1936849 | |
| 15:02:30 | lyarwood | surprise me :) | |
| 15:02:44 | gibi | lyarwood: https://github.com/openstack/nova/blob/10b1dc84f47a71061340f8e0ae0fe32dca44061a/nova/tests/unit/storage/test_rbd.py#L122-L125 | |
| 15:03:31 | gibi | that is the same shutdown as https://github.com/openstack/nova/blob/10b1dc84f47a71061340f8e0ae0fe32dca44061a/nova/tests/unit/virt/hyperv/test_serialproxy.py#L70 | |
| 15:03:47 | gibi | because the Rbd test sets shutdown on the Mock class level | |
| 15:04:29 | gibi | becuase Rados is an alias for Mock not an instance of Mock | |
| 15:04:31 | gibi | the missing () | |
| 15:05:32 | lyarwood | oofffffff | |
| 15:05:36 | lyarwood | nice catch | |
| 15:06:01 | gibi | I will do some grepping for other missing () after mock.Mock | |
| 15:06:13 | gibi | as this was a long journey :) | |
| 15:06:14 | lyarwood | yeah that sounds like an easy hacking rule | |
| 15:21:43 | gibi | hehh after the fix the rbd unit tests are failing :) The Rados = mock.Mock was intentional in the setup as they wanted to make sure that when the code calls Rados() it actually calls Mock() | |
| 15:23:21 | lyarwood | noice | |
| 15:41:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Avoid modifying the Mock class in test https://review.opendev.org/c/openstack/nova/+/805657 | |
| 15:52:44 | opendevreview | Stephen Finucane proposed openstack/nova master: scheduler: Merge driver into manager https://review.opendev.org/c/openstack/nova/+/773644 | |
| 15:52:44 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Drop references to non-filter scheduler drivers https://review.opendev.org/c/openstack/nova/+/773645 | |
| 15:52:45 | opendevreview | Stephen Finucane proposed openstack/nova master: conf: Remove deprecated aliases https://review.opendev.org/c/openstack/nova/+/773647 | |
| 15:52:45 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Merge 'test_utils', 'test_scheduler_utils' https://review.opendev.org/c/openstack/nova/+/773646 | |
| 16:00:13 | sean-k-mooney | gibi: oh it was using the class defintion not an instance of the class | |
| 16:00:24 | gibi | sean-k-mooney: yepp | |
| 16:00:25 | sean-k-mooney | fun | |
| 16:00:52 | gibi | sean-k-mooney: and as the class definitions are global per interpreter it created a way that two tests interfere | |
| 16:01:25 | sean-k-mooney | yep we have seen that several times before | |
| 16:03:00 | opendevreview | Ade Lee proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | |
| 16:45:55 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | |
| 16:46:19 | stephenfin | lyarwood: sean-k-mooney: Feel free to improve the commit message on that with additional context if you'd like | |
| 16:49:44 | sean-k-mooney | stephenfin: ack thanks | |
| 16:50:36 | sean-k-mooney | ah you are adding a url parse was not sure if it needed a pears or a decode | |
| 16:51:22 | sean-k-mooney | in anycase the test seams good | |
| 16:55:59 | lyarwood | I don't get how it's encoded by the time it gets there however if it's not in the config | |
| 16:58:56 | sean-k-mooney | i think its becasue we were geting it form an object of type sqlalchemy.engine.url.URL | |
| 16:59:01 | sean-k-mooney | and then casting that to a string | |
| 16:59:16 | lyarwood | ah | |
| 16:59:18 | sean-k-mooney | so it was likely being url encoded by the str call | |
| 17:19:20 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | |
| 17:19:21 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Increase service_down_time beyond INITIAL_REPORTING_DELAY in test https://review.opendev.org/c/openstack/nova/+/805667 | |
| 17:20:00 | lyarwood | gibi: ^ there was a silly race in my func test causing https://bugs.launchpad.net/nova/+bug/1940741 that should hopefully fix it now | |
| 17:21:07 | gibi | lyarwood: good catch! | |
| 17:21:24 | gibi | I did not know there is an initial delay | |
| 17:21:29 | lyarwood | ah wait, might need to refine that a little | |
| 17:32:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add two new hacking rules https://review.opendev.org/c/openstack/nova/+/805668 | |
| 17:32:50 | gibi | lyarwood: the hacking rule ^^ | |
| 17:34:22 | gibi | and that marks my end of the day o/ see you tomorrow folks | |
| 17:35:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add two new hacking rules https://review.opendev.org/c/openstack/nova/+/805668 | |
| 17:37:12 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Increase service_down_time beyond INITIAL_REPORTING_DELAY in test https://review.opendev.org/c/openstack/nova/+/805667 | |
| 17:37:13 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | |
| 17:37:14 | lyarwood | Aborting. | |
| 17:37:14 | lyarwood | Type 'yes' to confirm, other to cancel: yes | |
| 17:37:14 | lyarwood | Do you really want to submit the above commits? | |
| 18:18:50 | melwitt | hmm.. why isn't zuul voting on a change when it passes? https://review.opendev.org/c/openstack/nova/+/805654 sorry if I missed the discussion | |
| 18:30:17 | melwitt | maybe a fluke. just rechecked it | |
| 18:34:23 | melwitt | sean-k-mooney: hey, in case you didn't see, I replied to your comments on https://review.opendev.org/c/openstack/placement/+/679441 | |
| 18:34:33 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to use cell with more free memory first https://review.opendev.org/c/openstack/nova/+/805649 | |
| 18:58:33 | opendevreview | Lee Yarwood proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | |
| 19:32:52 | opendevreview | Merged openstack/nova master: VMWare: Use WithRetrieval to get all results https://review.opendev.org/c/openstack/nova/+/804968 | |
| 22:22:02 | opendevreview | Merged openstack/nova master: Avoid modifying the Mock class in test https://review.opendev.org/c/openstack/nova/+/805657 | |
| 23:14:20 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of Engine.scalar(), Engine.execute() https://review.opendev.org/c/openstack/nova/+/804878 | |
| 23:14:20 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Enable SQLAlchemy 2.0 deprecation warnings https://review.opendev.org/c/openstack/nova/+/804709 | |
| 23:14:21 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of legacy select() calling style https://review.opendev.org/c/openstack/nova/+/805735 | |
| 23:14:21 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of 'autoload' parameter https://review.opendev.org/c/openstack/nova/+/805734 | |
| 23:14:22 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Don't pass strings to 'Connection.execute' https://review.opendev.org/c/openstack/nova/+/805737 | |
| 23:14:22 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace 'insert.inline' parameter with 'Insert.inline()' method https://review.opendev.org/c/openstack/nova/+/805736 | |
| 23:15:14 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Add migration to resolve shadow table discrepancies https://review.opendev.org/c/openstack/nova/+/805738 | |
| #openstack-nova - 2021-08-24 | |||
| 06:47:02 | opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Avoid modifying the Mock class in test https://review.opendev.org/c/openstack/nova/+/805759 | |
| 06:57:28 | opendevreview | Johannes Kulik proposed openstack/nova master: api: Log actual number of UUIDs queried https://review.opendev.org/c/openstack/nova/+/805786 | |
| 07:24:37 | gibi | fungi: I re-opened the bug https://bugs.launchpad.net/nova/+bug/1927677 should I reopne the OSA part of it too? | |
| 08:19:50 | admin1 | when i do a rescue, in horizon , it asks for pass .but that pas does not work for root or debian/ubuntu .. | |
| 08:19:54 | admin1 | so how exactly is a rescue done | |
| 08:25:33 | lyarwood | admin1: so we attempt to inject the password during the rescue into the rescue image, either directly or via a configdrive and cloud-init | |
| 08:26:24 | lyarwood | admin1: direct injection into the rescue image depends on the config in your env | |
| 08:26:39 | lyarwood | admin1: and injection by configdrive depends on cloud-init being used by the rescue image | |
| 08:27:52 | lyarwood | https://github.com/openstack/nova/blob/2d2fb2debab9e1705231ebee1bd9305c5b22fa15/nova/virt/libvirt/driver.py#L4635-L4638 controls the direct injection | |
| 08:29:27 | admin1 | is there a good recommended resuce image that works ? | |
| 08:39:32 | opendevreview | Lee Yarwood proposed openstack/nova master: api: Introduce microversion 2.89 adjusting os-volume_attachments https://review.opendev.org/c/openstack/nova/+/804275 | |
| 08:50:46 | opendevreview | Merged openstack/nova master: address open redirect with 3 forward slashes https://review.opendev.org/c/openstack/nova/+/805654 | |
| 08:59:42 | lyarwood | admin1: You can use pretty much anything, I tend to virt-customize the image with a password etc before use | |
| 08:59:59 | lyarwood | admin1: but there are plenty of small rescue images made for this purpose with physical hosts like http://tinycorelinux.net/ | |