| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-19 | |||
| 16:22:04 | gibi | interesting | |
| 16:22:31 | stephenfin | I think you mean annoying :) | |
| 16:22:40 | gibi | :) | |
| 16:22:43 | gibi | interesting design | |
| 16:22:56 | gibi | I would make return_value and side_effect mutually exclusive | |
| 16:23:15 | stephenfin | So would I. Doing it any other way seems like an anti-pattern | |
| 16:23:32 | stephenfin | If you want a different result or the first call from every other, implement that in the side effect | |
| 16:23:48 | stephenfin | I suspect a bug or edge case, tbh | |
| 16:26:11 | gibi | agree | |
| 16:28:19 | sean-k-mooney | dont we normally | |
| 16:28:23 | sean-k-mooney | i have never seen both used | |
| 16:28:36 | sean-k-mooney | at least i have always used only one or the other | |
| 16:28:39 | opendevreview | Lee Yarwood proposed openstack/nova master: api: Introduce microversion 2.89 adjusting os-volume_attachments https://review.opendev.org/c/openstack/nova/+/804275 | |
| 16:28:43 | stephenfin | I was using a mock configured in a setUp way up in the file | |
| 16:28:44 | sean-k-mooney | perhaps we should add a hacking chekc | |
| 16:29:04 | stephenfin | and missed the fact that it was configured with side_effect | |
| 16:29:17 | sean-k-mooney | ah ok | |
| 16:29:23 | sean-k-mooney | that is harder to catch | |
| 16:29:53 | stephenfin | it was particularly annoying since normally when I see the error I was seeing, it's because I've mocked something twice by accident | |
| 16:30:08 | stephenfin | so I was looking exclusively for that, but the ID of the mock objects were the same in multiple places (i.e. it wasn't that) | |
| 16:30:11 | stephenfin | anyway | |
| 16:44:18 | opendevreview | Merged openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 16:52:52 | opendevreview | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.89 - os-volume_attachments https://review.opendev.org/c/openstack/python-novaclient/+/805022 | |
| 16:53:51 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 16:53:51 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 16:56:04 | lyarwood | melwitt: https://review.opendev.org/c/openstack/nova/+/800634 - Would you mind taking a look at this and the stack under it this week if you get time? | |
| 17:33:33 | gmann | lyarwood: as we are renaming 'id' field too can you quickly append the spec also before we merge the code https://review.opendev.org/c/openstack/nova-specs/+/794799 | |
| 17:34:05 | gmann | I am hoping no issue to update the spec now. gibi ? | |
| 17:37:27 | sean-k-mooney | gmann:the spec is already approved and this would be a minor change so i think that is ok | |
| 17:38:04 | gmann | sean-k-mooney: yeah, it is just to update documentation for what we agreed during implementation | |
| 18:02:54 | opendevreview | Merged openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | |
| 18:13:25 | opendevreview | Merged openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 18:13:34 | opendevreview | Merged openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 18:38:55 | opendevreview | Merged openstack/nova master: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/804303 | |
| 19:02:14 | sean-k-mooney | melwitt: i have some nits in https://review.opendev.org/c/openstack/placement/+/679441 | |
| 19:03:21 | sean-k-mooney | the -1 is because of https://review.opendev.org/c/openstack/placement/+/679441/25/api-ref/source/parameters.yaml#210 the regex allows 0-9 also https://review.opendev.org/c/openstack/placement/+/679441/25/placement/schemas/common.py#23 | |
| 19:04:06 | sean-k-mooney | im not sure if that was intentional or not. i dont see why it would cause a problem but wanted to draw your attention to it | |
| 19:08:10 | melwitt | sean-k-mooney: k will look, thx for reviewing | |
| 19:08:20 | melwitt | lyarwood: yes sorry it slipped my mind yesterday 😣 | |
| 20:14:38 | melwitt | sean-k-mooney: replied | |
| 20:57:41 | opendevreview | Rodrigo Barbieri proposed openstack/nova stable/wallaby: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/805304 | |
| 20:58:14 | opendevreview | Merged openstack/nova master: api: Pass request to 'addresses' view builder https://review.opendev.org/c/openstack/nova/+/803753 | |
| 20:58:23 | opendevreview | Merged openstack/nova master: api: Remove unnecessary 'base_' prefix from schemas https://review.opendev.org/c/openstack/nova/+/803754 | |
| 20:58:33 | opendevreview | Merged openstack/nova master: tests: Sanity check some tests https://review.opendev.org/c/openstack/nova/+/803755 | |
| #openstack-nova - 2021-08-20 | |||
| 05:26:11 | opendevreview | Merged openstack/nova master: Accelerator smartnic SRIOV support https://review.opendev.org/c/openstack/nova/+/804320 | |
| 09:27:40 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 09:27:41 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 11:03:53 | opendevreview | Merged openstack/nova master: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/804285 | |
| 11:04:00 | opendevreview | Merged openstack/nova master: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/804229 | |
| 11:04:09 | opendevreview | Merged openstack/nova master: Add functional regression test for bug 1853009 https://review.opendev.org/c/openstack/nova/+/695012 | |
| 11:10:07 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 12:05:19 | opendevreview | Merged openstack/nova master: Clear rebalanced compute nodes from resource tracker https://review.opendev.org/c/openstack/nova/+/695187 | |
| 12:05:26 | opendevreview | Merged openstack/nova master: Invalidate provider tree when compute node disappears https://review.opendev.org/c/openstack/nova/+/695188 | |
| 12:30:26 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Move _migrate_stub into LibvirtMigrationMixin https://review.opendev.org/c/openstack/nova/+/804232 | |
| 12:30:27 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Remove unused legacy block_device_info format https://review.opendev.org/c/openstack/nova/+/804286 | |
| 12:36:09 | opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/766043 | |
| 12:43:34 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Update attachment_id spec to include implementation changes https://review.opendev.org/c/openstack/nova-specs/+/805374 | |
| 13:00:58 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | |
| 13:01:24 | lyarwood | gah gate failure | |
| 13:34:18 | lyarwood | and I have zero idea why things locked up in the failing test, tgif++ | |
| 14:01:22 | opendevreview | Lee Yarwood proposed openstack/nova master: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/695189 | |
| 14:01:22 | opendevreview | Lee Yarwood proposed openstack/nova master: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/694802 | |
| 14:11:33 | grami[m] | Hi all, I'm trying to understand the function of hw:cpu_socket if I set this to 2 will it force the vcpus to split between socket or numa? | |
| 14:14:56 | grami[m] | After doing some tests with pinned CPU I noticed that it defaults to trying to place all pcpus on a single numa and is forced to apply hw:numa_nodes = 2 | |
| 14:16:12 | lyarwood | stephenfin: https://review.opendev.org/c/openstack/nova/+/766043 mind hitting that again if you have bandwidth | |
| 15:23:59 | opendevreview | Merged openstack/nova master: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/804230 | |
| 15:24:06 | opendevreview | Merged openstack/nova master: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/804298 | |
| 15:24:21 | opendevreview | Merged openstack/nova master: fixtures: Add legacy APIs to cinder fixture https://review.opendev.org/c/openstack/nova/+/805195 | |
| 15:24:41 | opendevreview | Merged openstack/nova master: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/804299 | |
| 15:24:56 | opendevreview | Merged openstack/nova master: fup: Move OSBrickFixture into base.ServersTestBase https://review.opendev.org/c/openstack/nova/+/804231 | |
| 15:25:09 | opendevreview | Merged openstack/nova master: fup: Mock all unix connectors in os-brick fixture https://review.opendev.org/c/openstack/nova/+/804233 | |
| 15:25:39 | lyarwood | \o/ | |
| 16:16:56 | opendevreview | Merged openstack/nova master: VmWare: Fix deprecation warning in unit tests https://review.opendev.org/c/openstack/nova/+/805024 | |
| 16:17:12 | opendevreview | Merged openstack/nova master: docs: Explicitly state lack of support for node renaming https://review.opendev.org/c/openstack/nova/+/795607 | |
| 16:17:28 | opendevreview | Merged openstack/nova master: api: Improve extra spec validator help texts https://review.opendev.org/c/openstack/nova/+/782412 | |
| 16:21:58 | lyarwood | gmann: https://review.opendev.org/c/openstack/devstack/+/805219 - would you mind taking a look at this now that the nova part is in the gate | |
| 16:22:06 | lyarwood | https://review.opendev.org/c/openstack/nova/+/766043 for reference | |
| 16:29:19 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 16:36:20 | gmann | lyarwood: sure. checking | |
| 16:45:18 | lyarwood | stephenfin: https://review.opendev.org/c/openstack/nova/+/801607/ - any idea why this isn't +W? | |
| 16:45:25 | lyarwood | and the change above it I think | |
| 17:17:40 | opendevreview | Merged openstack/nova master: scheduler: Merge 'FilterScheduler' into base class https://review.opendev.org/c/openstack/nova/+/773643 | |
| 17:17:47 | opendevreview | Merged openstack/nova master: tests: Remove 'stub_out_trusted_certs' https://review.opendev.org/c/openstack/nova/+/765432 | |
| 17:17:59 | opendevreview | Merged openstack/nova stable/wallaby: Retry lvm volume and volume group query https://review.opendev.org/c/openstack/nova/+/796707 | |
| 17:21:54 | opendevreview | Merged openstack/nova master: Add logs when cannot fit numa https://review.opendev.org/c/openstack/nova/+/798187 | |
| 17:22:03 | opendevreview | Merged openstack/nova master: Improve prep_resize reschedule unit test https://review.opendev.org/c/openstack/nova/+/800297 | |
| 18:58:34 | opendevreview | Merged openstack/nova master: VMWare: Use get_hardware_devices throughout https://review.opendev.org/c/openstack/nova/+/805017 | |
| 19:03:58 | gmann | stephenfin: I replied on hostname change, please check if that make sense (basically we should remove the policy check to show it to non-admin after deprecation phase) - https://review.opendev.org/c/openstack/nova/+/778550/10/nova/api/openstack/compute/views/servers.py#414 | |
| 19:41:39 | gibi | gmann: sure, no problem to amend the spec to reflect the reality | |
| 20:14:11 | NobodyCam | Good Afternoon Nova, Crazy question, is there a way to verify a ironic node is read for scheduling... I am checking ironic node status / placement status, but even if both are available I am still hitting `No valid hosts` | |
| 20:23:34 | gmann | gibi: k. here it is https://review.opendev.org/c/openstack/nova-specs/+/805374 | |
| 20:32:22 | opendevreview | Lance Bragstad proposed openstack/nova master: WIP: Update create server policy for system-admins https://review.opendev.org/c/openstack/nova/+/805456 | |
| 20:35:53 | artom | NobodyCam, your best best is probably to trace the instance create request ID in the scheduler with DEBUG enabled, and see why it failed scheduling | |
| 20:36:31 | artom | NobodyCam, you either got no results from the Placement queries, in which case you'll need to check the Placement log, or one of the filters ended up with 0 hosts, in which case the scheduler logs will tell you | |
| 20:36:35 | NobodyCam | its timing.. | |
| 20:37:05 | NobodyCam | node is deleted but scheduler says no | |
| 20:40:40 | NobodyCam | actual error is `Failed to compute_task_build_instances: No valid host was found. There are not enough hosts available.` | |
| 20:41:08 | NobodyCam | scheduler is not returning the host in filtered hosts | |
| 20:41:25 | NobodyCam | I was looking for a way to check that externally | |
| 20:46:45 | NobodyCam | I should add that we force placement to a particular host in our enviroment | |