| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-19 | |||
| 12:48:56 | sean-k-mooney | lyarwood: feel like doing some os-traits reviews? there are 3 that would be nice to land by client freeze | |
| 12:49:15 | sean-k-mooney | * non-client freeze | |
| 12:49:18 | lyarwood | yeah sure I'll clean this up and take a look | |
| 12:49:42 | sean-k-mooney | https://review.opendev.org/c/openstack/os-traits/+/794807 https://review.opendev.org/c/openstack/os-traits/+/779495 and https://review.opendev.org/c/openstack/os-traits/+/753579 | |
| 12:50:02 | sean-k-mooney | first one is kasyaps and then next two are stephens | |
| 13:02:35 | ganso | gibi, sean-k-mooney, melwitt: Hi! I believe all concerns so far have been addressed, if you have a minute could you please take another look at that 1vcpu patch https://review.opendev.org/c/openstack/nova/+/804303 ? Thanks in advance | |
| 13:05:00 | sean-k-mooney | im ok with this version although you could have used instance.flavor instead of instance.get_flavor() but its fine | |
| 13:05:06 | sean-k-mooney | it will do the same thing | |
| 13:13:32 | opendevreview | sean mooney proposed openstack/os-vif master: extend per-port bridge support to vhost-user https://review.opendev.org/c/openstack/os-vif/+/805214 | |
| 13:15:47 | sean-k-mooney | stephenfin: can you cast your eyes over ^ i think i fixed the nits form the previous patch for tap interfaces too. | |
| 13:17:54 | opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/766043 | |
| 13:18:16 | gibi | lyarwood: left feedback in https://review.opendev.org/c/openstack/nova/+/800634 | |
| 13:22:43 | lyarwood | ack thanks | |
| 13:49:00 | opendevreview | sean mooney proposed openstack/os-vif master: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/805223 | |
| 14:06:56 | opendevreview | Merged openstack/os-traits master: Add a trait for the "bochs" display device https://review.opendev.org/c/openstack/os-traits/+/794807 | |
| 14:18:55 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 14:31:17 | opendevreview | Merged openstack/os-traits master: Add 'COMPUTE_FIRMWARE_UEFI', 'COMPUTE_FIRMWARE_BIOS' https://review.opendev.org/c/openstack/os-traits/+/779495 | |
| 14:32:20 | opendevreview | Merged openstack/os-traits master: List traits in documentation https://review.opendev.org/c/openstack/os-traits/+/753579 | |
| 15:01:59 | opendevreview | sean mooney proposed openstack/os-vif master: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/805223 | |
| 15:03:44 | gibi | sean-k-mooney: I'm out tomorrow (national holiday). Do you think we need to wait with the os-vif last release for Xena? | |
| 15:05:08 | gibi | sean-k-mooney: I can probably check back tomorrow late afternoon and approve the updated release patch if needed | |
| 15:05:59 | opendevreview | Merged openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | |
| 16:01:46 | opendevreview | Merged openstack/nova-specs master: Revert "Amend configurable-instance-hostnames to include response changes" https://review.opendev.org/c/openstack/nova-specs/+/803895 | |
| 16:18:53 | sean-k-mooney | gibi: am honestly i can just backport the things im working on so no we can go ahead | |
| 16:19:14 | gibi | sean-k-mooney: ok, then I approve the release patch | |
| 16:19:41 | sean-k-mooney | cool enjoy your PTO tomorrow | |
| 16:20:39 | gibi | sean-k-mooney: thanks | |
| 16:21:19 | stephenfin | grr, once again bitten by the fact that setting Mock.return_value and Mock.side_effect seems to return the former once and then fall back to the side_effect for all other calls :-( | |
| 16:22:04 | gibi | interesting | |
| 16:22:31 | stephenfin | I think you mean annoying :) | |
| 16:22:40 | gibi | :) | |
| 16:22:43 | gibi | interesting design | |
| 16:22:56 | gibi | I would make return_value and side_effect mutually exclusive | |
| 16:23:15 | stephenfin | So would I. Doing it any other way seems like an anti-pattern | |
| 16:23:32 | stephenfin | If you want a different result or the first call from every other, implement that in the side effect | |
| 16:23:48 | stephenfin | I suspect a bug or edge case, tbh | |
| 16:26:11 | gibi | agree | |
| 16:28:19 | sean-k-mooney | dont we normally | |
| 16:28:23 | sean-k-mooney | i have never seen both used | |
| 16:28:36 | sean-k-mooney | at least i have always used only one or the other | |
| 16:28:39 | opendevreview | Lee Yarwood proposed openstack/nova master: api: Introduce microversion 2.89 adjusting os-volume_attachments https://review.opendev.org/c/openstack/nova/+/804275 | |
| 16:28:43 | stephenfin | I was using a mock configured in a setUp way up in the file | |
| 16:28:44 | sean-k-mooney | perhaps we should add a hacking chekc | |
| 16:29:04 | stephenfin | and missed the fact that it was configured with side_effect | |
| 16:29:17 | sean-k-mooney | ah ok | |
| 16:29:23 | sean-k-mooney | that is harder to catch | |
| 16:29:53 | stephenfin | it was particularly annoying since normally when I see the error I was seeing, it's because I've mocked something twice by accident | |
| 16:30:08 | stephenfin | so I was looking exclusively for that, but the ID of the mock objects were the same in multiple places (i.e. it wasn't that) | |
| 16:30:11 | stephenfin | anyway | |
| 16:44:18 | opendevreview | Merged openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 16:52:52 | opendevreview | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.89 - os-volume_attachments https://review.opendev.org/c/openstack/python-novaclient/+/805022 | |
| 16:53:51 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 16:53:51 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 16:56:04 | lyarwood | melwitt: https://review.opendev.org/c/openstack/nova/+/800634 - Would you mind taking a look at this and the stack under it this week if you get time? | |
| 17:33:33 | gmann | lyarwood: as we are renaming 'id' field too can you quickly append the spec also before we merge the code https://review.opendev.org/c/openstack/nova-specs/+/794799 | |
| 17:34:05 | gmann | I am hoping no issue to update the spec now. gibi ? | |
| 17:37:27 | sean-k-mooney | gmann:the spec is already approved and this would be a minor change so i think that is ok | |
| 17:38:04 | gmann | sean-k-mooney: yeah, it is just to update documentation for what we agreed during implementation | |
| 18:02:54 | opendevreview | Merged openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | |
| 18:13:25 | opendevreview | Merged openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 18:13:34 | opendevreview | Merged openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 18:38:55 | opendevreview | Merged openstack/nova master: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/804303 | |
| 19:02:14 | sean-k-mooney | melwitt: i have some nits in https://review.opendev.org/c/openstack/placement/+/679441 | |
| 19:03:21 | sean-k-mooney | the -1 is because of https://review.opendev.org/c/openstack/placement/+/679441/25/api-ref/source/parameters.yaml#210 the regex allows 0-9 also https://review.opendev.org/c/openstack/placement/+/679441/25/placement/schemas/common.py#23 | |
| 19:04:06 | sean-k-mooney | im not sure if that was intentional or not. i dont see why it would cause a problem but wanted to draw your attention to it | |
| 19:08:10 | melwitt | sean-k-mooney: k will look, thx for reviewing | |
| 19:08:20 | melwitt | lyarwood: yes sorry it slipped my mind yesterday 😣 | |
| 20:14:38 | melwitt | sean-k-mooney: replied | |
| 20:57:41 | opendevreview | Rodrigo Barbieri proposed openstack/nova stable/wallaby: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/805304 | |
| 20:58:14 | opendevreview | Merged openstack/nova master: api: Pass request to 'addresses' view builder https://review.opendev.org/c/openstack/nova/+/803753 | |
| 20:58:23 | opendevreview | Merged openstack/nova master: api: Remove unnecessary 'base_' prefix from schemas https://review.opendev.org/c/openstack/nova/+/803754 | |
| 20:58:33 | opendevreview | Merged openstack/nova master: tests: Sanity check some tests https://review.opendev.org/c/openstack/nova/+/803755 | |
| #openstack-nova - 2021-08-20 | |||
| 05:26:11 | opendevreview | Merged openstack/nova master: Accelerator smartnic SRIOV support https://review.opendev.org/c/openstack/nova/+/804320 | |
| 09:27:40 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 09:27:41 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 11:03:53 | opendevreview | Merged openstack/nova master: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/804285 | |
| 11:04:00 | opendevreview | Merged openstack/nova master: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/804229 | |
| 11:04:09 | opendevreview | Merged openstack/nova master: Add functional regression test for bug 1853009 https://review.opendev.org/c/openstack/nova/+/695012 | |
| 11:10:07 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 12:05:19 | opendevreview | Merged openstack/nova master: Clear rebalanced compute nodes from resource tracker https://review.opendev.org/c/openstack/nova/+/695187 | |
| 12:05:26 | opendevreview | Merged openstack/nova master: Invalidate provider tree when compute node disappears https://review.opendev.org/c/openstack/nova/+/695188 | |
| 12:30:26 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Move _migrate_stub into LibvirtMigrationMixin https://review.opendev.org/c/openstack/nova/+/804232 | |
| 12:30:27 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Remove unused legacy block_device_info format https://review.opendev.org/c/openstack/nova/+/804286 | |
| 12:36:09 | opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/766043 | |
| 12:43:34 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Update attachment_id spec to include implementation changes https://review.opendev.org/c/openstack/nova-specs/+/805374 | |
| 13:00:58 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | |
| 13:01:24 | lyarwood | gah gate failure | |
| 13:34:18 | lyarwood | and I have zero idea why things locked up in the failing test, tgif++ | |
| 14:01:22 | opendevreview | Lee Yarwood proposed openstack/nova master: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/695189 | |
| 14:01:22 | opendevreview | Lee Yarwood proposed openstack/nova master: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/694802 | |
| 14:11:33 | grami[m] | Hi all, I'm trying to understand the function of hw:cpu_socket if I set this to 2 will it force the vcpus to split between socket or numa? | |
| 14:14:56 | grami[m] | After doing some tests with pinned CPU I noticed that it defaults to trying to place all pcpus on a single numa and is forced to apply hw:numa_nodes = 2 | |
| 14:16:12 | lyarwood | stephenfin: https://review.opendev.org/c/openstack/nova/+/766043 mind hitting that again if you have bandwidth | |
| 15:23:59 | opendevreview | Merged openstack/nova master: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/804230 | |
| 15:24:06 | opendevreview | Merged openstack/nova master: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/804298 | |
| 15:24:21 | opendevreview | Merged openstack/nova master: fixtures: Add legacy APIs to cinder fixture https://review.opendev.org/c/openstack/nova/+/805195 | |
| 15:24:41 | opendevreview | Merged openstack/nova master: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/804299 | |
| 15:24:56 | opendevreview | Merged openstack/nova master: fup: Move OSBrickFixture into base.ServersTestBase https://review.opendev.org/c/openstack/nova/+/804231 | |
| 15:25:09 | opendevreview | Merged openstack/nova master: fup: Mock all unix connectors in os-brick fixture https://review.opendev.org/c/openstack/nova/+/804233 | |
| 15:25:39 | lyarwood | \o/ | |