| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-06 | |||
| 15:55:20 | bauzas | I prevented to rebase | |
| 15:55:38 | bauzas | so, PS_n-2 to PS should show the very few differences | |
| 15:56:39 | stephenfin | bauzas: Thanks. I'll start looking now but I will have to leave myself soon enough | |
| 15:56:56 | stephenfin | Worst case scenario, one of us can tweak it while you're away to get it over the line | |
| 15:56:56 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Exclude the 'use_db_reconnect' option https://review.opendev.org/c/openstack/nova/+/803778 | |
| 15:57:11 | stephenfin | gibi: ^ | |
| 15:57:50 | stephenfin | turns out I _could_ just modify what we were registering since I stopped registering the oslo.db opts in https://review.opendev.org/c/openstack/nova/+/799523/ | |
| 15:58:02 | bauzas | stephenfin: I was planning to end at 5pm | |
| 15:58:15 | bauzas | looks like I was on the wrong timezone when I said this | |
| 15:58:42 | stephenfin | bauzas: it's still only 9am in California ;) | |
| 15:59:03 | bauzas | perfect timing for starting my day again | |
| 15:59:21 | stephenfin | bauzas: Can you bang this ~50 line change in as the last thing before you leave? :D https://review.opendev.org/c/openstack/nova/+/799523/ | |
| 16:01:33 | bauzas | stephenfin: you eventually got my last approval before I leave, gibi you lose | |
| 16:01:42 | stephenfin | \o/ | |
| 16:01:44 | stephenfin | winner winner | |
| 16:01:53 | bauzas | this is like the olympics, money time | |
| 16:02:00 | stephenfin | enjoy your PTO o. | |
| 16:02:22 | bauzas | stephenfin: be sure I'll haunt you when I'm back even if you're not lurking this chan | |
| 16:02:51 | ade_lee | stephenfin, lyarwood hey -- I started to look at the failures in the fips ci job -- https://review.opendev.org/c/openstack/nova/+/790519 | |
| 16:03:49 | ade_lee | stephenfin, lyarwood looks like the bootfromvolume test is failing - and I think its because iscsid is not happy because its chap algorithm needs to be set to something other than md5 | |
| 16:04:05 | ade_lee | not sure how to do that in the test .. | |
| 16:05:24 | gibi | bauzas_away: enjoy, I will look at your mdev series still today | |
| 16:05:25 | stephenfin | ade_lee: The test that's failing is an integration test running on devstack VM, so you're going to need to modify some configuration via devstack or a plugin | |
| 16:05:55 | bauzas_away | gibi: thanks, appreciated | |
| 16:06:14 | bauzas_away | anyway, back on tuesday means 2 days of work before FF, that's totally doable to merge things | |
| 16:06:34 | ade_lee | stephenfin, lyarwood in barbican, we do special test stuff on devstack with a script at https://github.com/openstack/barbican/blob/master/devstack/lib/barbican for instance , but I don't see anything similar in nova | |
| 16:06:48 | gibi | bauzas_away: :D you are such an optimist :D | |
| 16:07:04 | ade_lee | though as this is something that will likely show up elsewhere - its prob best to look in devstack itself .. | |
| 16:07:08 | ade_lee | looking .. | |
| 16:08:54 | stephenfin | ade_lee: this isn't stuff I'm intimately familiar with, but we do some stuff as a post-run job. For example, you can see the stuff in roles/run-evacuate-hook which is run as part of the nova-live-migration job | |
| 16:09:26 | stephenfin | pre-run probably won't do though since that'll surely run before DevStack even gets started, though maybe that's okay... | |
| 16:10:13 | stephenfin | doing it in DevStack (hidden behind a config option) or via a DevStack plugin would certainly be easier I suspect | |
| 16:11:38 | ade_lee | stephenfin, yeah and more useful as this will undoubtedly show up in cinder fips tests amongst others | |
| 16:11:44 | stephenfin | yup | |
| 16:38:28 | gibi | I'm dropping off for a week of vacation | |
| 16:38:33 | gibi | back on 16th of Aug | |
| 16:39:06 | gibi_pto | o/ | |
| 16:39:24 | stephenfin | o/ | |
| 16:39:25 | opendevreview | Stephen Finucane proposed openstack/nova master: mypy: Follow-up for I4a9c1ee486beda070ee0a4a9734a7ec9e2629a67 https://review.opendev.org/c/openstack/nova/+/803787 | |
| 16:39:25 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170 | |
| 16:57:06 | opendevreview | Merged openstack/nova master: db: Move main DB migrations https://review.opendev.org/c/openstack/nova/+/799519 | |
| 17:31:44 | gmann | gibi_pto: have good vacation. | |
| 17:32:42 | gmann | stephenfin: reviewed this hostname series, I think we need to leave the legacy extensions prefix things for non-related APIs and do only for hostname field https://review.opendev.org/c/openstack/nova/+/778550 | |
| 17:33:02 | gmann | left comment in https://review.opendev.org/c/openstack/nova/+/803756/1 | |
| 18:34:01 | opendevreview | Ade Lee proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | |
| 20:39:30 | opendevreview | Merged openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | |
| #openstack-nova - 2021-08-07 | |||
| 10:37:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add functional reproducer for bug-1939193 https://review.opendev.org/c/openstack/nova/+/803821 | |
| 10:37:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle if placement in down during interface attach https://review.opendev.org/c/openstack/nova/+/803822 | |
| 15:05:23 | opendevreview | Merged openstack/nova master: Bump oslo.db to 10.0.0 https://review.opendev.org/c/openstack/nova/+/801610 | |
| 19:39:01 | opendevreview | Merged openstack/nova master: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/801285 | |
| 19:39:08 | opendevreview | Merged openstack/nova master: I2f9ad3df25306e070c8c3538bfed1212d6d8682f fup: add log https://review.opendev.org/c/openstack/nova/+/803001 | |
| #openstack-nova - 2021-08-08 | |||
| 13:55:27 | opendevreview | Merged openstack/nova master: db: Move 'sqlalchemy.types' up a directory https://review.opendev.org/c/openstack/nova/+/799520 | |
| 13:55:36 | opendevreview | Merged openstack/nova master: db: Remove constant aliases from 'nova.db.api' https://review.opendev.org/c/openstack/nova/+/799521 | |
| 13:56:41 | opendevreview | Merged openstack/nova master: db: Drop support for experimental concurrency https://review.opendev.org/c/openstack/nova/+/799522 | |
| #openstack-nova - 2021-08-09 | |||
| 09:07:07 | stephenfin | lyarwood: Any chance you could cast an eye over a little more of the DB series this week, in the absence of gibi and bauzas? It starts on this patch which _looks_ huge but was mostly an invocation of sed :) https://review.opendev.org/c/openstack/nova/+/799524/ | |
| 09:07:58 | lyarwood | yarp, was up most the night but II'll make a start once this coffee kicks in | |
| 09:08:03 | lyarwood | I'll* | |
| 09:38:38 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Amend configurable-instance-hostnames for more response changes https://review.opendev.org/c/openstack/nova-specs/+/803892 | |
| 09:49:10 | kashyap | stephenfin: Hey, when you get a min, maybe you can settle this dispute here: https://review.opendev.org/c/openstack/nova/+/798680/3/nova/virt/libvirt/config.py#2058 | |
| 09:51:15 | stephenfin | kashyap: I think you're correct. Those classes are used to build XML for new instances. I don't think we use it to parse anything for existing instances. | |
| 09:51:51 | kashyap | stephenfin: Exactly so; thank you very much. I was wondering if I was confusing myself | |
| 09:52:32 | stephenfin | unrelated: have we agreed on virtio? Doesn't that have impacts for Windows guests? | |
| 09:53:27 | kashyap | stephenfin: Right; I've discussed this at length w/ the QEMU graphics maint, and 'virtio' seems good for both | |
| 09:53:30 | kashyap | stephenfin: What more: | |
| 09:53:46 | kashyap | stephenfin: I got a Red Hat virt QE to test both Windows and Linux guests with 'cirrus' and do some live migration tests | |
| 09:54:15 | kashyap | (with 'cirrus', changed to 'virtio', i.e.) And the tests succeed. See my comment on PS 3 (Aug 04 4:27 PM) | |
| 09:54:21 | stephenfin | kashyap: What are your thoughts on whipping up a doc with the current and future default device models, the reasons for these choices, and the commands one can use to migrate existing instances from one to the other | |
| 09:54:45 | stephenfin | in lieu of a spec or anything else | |
| 09:55:15 | kashyap | stephenfin: "Device models" --> You're talking only of video, or others too? | |
| 09:55:22 | stephenfin | there's a lot of context embedded in various reviews, IRC convos and emails now. It would be good to get it all transcribed somewhere | |
| 09:55:40 | stephenfin | That depends. Are you personally just targeting video right now? | |
| 09:56:09 | kashyap | stephenfin: Yes, right now only 'video'. And yes, I fully agree: the context is across sources, and only those who're immersed in it can have a semblance of clarity. | |
| 09:56:19 | stephenfin | If so, yes, just video for now, but lets name the document generically (doc/source/user/libvirt-device-models.rst ?) so we can expand on it later | |
| 09:56:26 | stephenfin | presumably via lyarwood's efforts | |
| 09:56:27 | kashyap | stephenfin: I'm always up for docs such as what you describe. | |
| 09:57:00 | stephenfin | spot on. I'd be happy to review that. We can use it as a stand-in for a spec and point to it from other reviews | |
| 09:57:17 | stephenfin | Plus, we've decent docs afterwards | |
| 09:58:02 | kashyap | stephenfin: Yeah; I'll throw in a place-holder, so I that I won't forget it after PTO starting this Thu | |
| 09:58:31 | kashyap | stephenfin: Thanks, as always for your relentless care for thoughtful docs! :) | |
| 10:01:00 | kashyap | (Just to wrap-up the video model one temporarily: the move from 'cirrus' to 'virtio' is far less disruptive based on the tests we've done so far - due to the graceful fallback that 'virtio' provides in case there are guest drivers.) | |
| 10:01:57 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Revert "Amend configurable-instance-hostnames to include response changes" https://review.opendev.org/c/openstack/nova-specs/+/803895 | |
| 10:03:27 | stephenfin | gmann: I've proposed two competing spec amendments: one proposes removing all extension prefixes for various '/servers' and '/flavors' APIs, and the other proposes not removing any (so 'OS-EXT-SRV-ATTR:hostname' stays the same) | |
| 10:04:06 | stephenfin | gmann: The perfectionist in me would prefer the former. The realist says the latter might be wiser, at least for this microversion. | |
| 10:04:30 | stephenfin | gmann: https://review.opendev.org/c/openstack/nova-specs/+/803892 (remove all prefixes) https://review.opendev.org/c/openstack/nova-specs/+/803895 (remove no prefixes) | |
| 13:04:41 | slaweq | hi nova-stable-maint team, can You take a look at https://review.opendev.org/c/openstack/nova/+/791420 ? | |
| 13:05:07 | slaweq | it already have +2 from elodilles_pto but it needs second one :) | |
| 13:06:17 | lyarwood | ack will do | |
| 13:54:13 | gmann | stephenfin: ack, will check and comment, thanks | |
| 14:04:18 | lyarwood | stephenfin: https://zuul.opendev.org/t/openstack/build/6cedd9d4547c4f608553ace4701d4709 - did you see that docs failure on your https://review.opendev.org/c/openstack/nova/+/799523/ change btw? | |
| 14:21:37 | stephenfin | lyarwood: No, I did not | |
| 14:32:04 | stephenfin | lyarwood: Sigh, that failed 8 times in a row. I missed it because there were quite a few random failures elsewhere and I got lazy and stopped checking the logs :-( | |
| 14:32:18 | stephenfin | lyarwood: The issue is that this change should not be here but rather in the next patch in the series https://review.opendev.org/c/openstack/nova/+/799523/1/etc/nova/nova-config-generator.conf | |
| 14:33:00 | stephenfin | afraid so | |
| 14:33:07 | lyarwood | RIP the gate | |
| 14:33:21 | lyarwood | but cool at least it's fixed then | |
| 14:33:22 | stephenfin | Much maligned but ultimately missed | |
| 14:34:02 | lyarwood | the series looks good overall btw, I went through to the end but wanted to look at a few things in more detail before voting either way | |
| 14:34:30 | lyarwood | mostly with the automatic migrations at the end tbh | |
| 14:35:23 | stephenfin | anything else obvious you want fixed before I push this rebase? | |
| 14:35:40 | lyarwood | nothing at the moment no | |