| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-06 | |||
| 15:36:46 | gibi | stephenfin: thanks a lot. I'm still chewing on on your db series. | |
| 15:37:07 | gibi | stephenfin: sure the nova-manage part is the least important and it still misses some test coverage | |
| 15:37:34 | gibi | stephenfin: so you are out next week, will you be back still before the FF? | |
| 15:37:47 | stephenfin | nope, I'm here next week but I'm starting my move the new team | |
| 15:37:50 | gibi | zigo: have you tried to restart libvirtd ? | |
| 15:38:00 | gibi | stephenfin: ohh, then I mixed it | |
| 15:38:11 | gibi | stephenfin: I will be out next week :/ | |
| 15:38:14 | stephenfin | I was supposed to be away but things came up | |
| 15:38:25 | stephenfin | I'll still be around for the rest of the cycle but in a reduced capacity | |
| 15:38:52 | stephenfin | so keep reviewing what I've already reviewed and rebasing my own patches, but no new work | |
| 15:38:56 | gibi | stephenfin: OK, I might corner you with some re-review for the packet rate series if needed and you wil see if you have time or not | |
| 15:39:05 | stephenfin | yup, sounds good :) | |
| 15:39:17 | stephenfin | there are two patches with TODOs left that I can see still | |
| 15:39:34 | gibi | zigo: it feels like it is some internal incosistency inside libvirtd | |
| 15:40:02 | gibi | stephenfin: yeah, the ones that needs the neutron counterpart to define the name of the extension | |
| 15:43:23 | gibi | stephenfin: the naming of api_db_api import made me chuckle :) that name well summarizes why naming is one of the hardest thing in programming | |
| 15:43:35 | stephenfin | Yeah :-( | |
| 15:43:49 | gibi | it is sooo historical | |
| 15:43:53 | stephenfin | I tried many alternatives and kept coming back to that | |
| 15:44:08 | gibi | it is not a fault of the current series at all | |
| 15:44:28 | gibi | the current series just distilled it to a well visible name | |
| 15:45:00 | stephenfin | I did considered removing the main DB's 'api' module and folding it in to nova.objects like we did for the API DB, but that was even more work in an already bloated series | |
| 15:45:01 | stephenfin | so... | |
| 15:46:13 | gibi | that api is huge so yeah | |
| 15:48:52 | gibi | it is impressive that you could push through this amount of refactoring in nova | |
| 15:54:12 | opendevreview | Sylvain Bauza proposed openstack/nova master: Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 15:54:13 | opendevreview | Sylvain Bauza proposed openstack/nova master: Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 15:54:13 | opendevreview | Sylvain Bauza proposed openstack/nova master: Provide and use other RCs for mdevs if needed https://review.opendev.org/c/openstack/nova/+/803233 | |
| 15:54:14 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: Cleanup GPU vs. mdev wording https://review.opendev.org/c/openstack/nova/+/803379 | |
| 15:54:35 | bauzas | stephenfin: gibi: last round before I leave : change of the option value to be CUSTOM_ something | |
| 15:55:08 | bauzas | gibi: sorry if I may ask you to review just before you leave, but the changes are femtonits | |
| 15:55:20 | bauzas | I prevented to rebase | |
| 15:55:38 | bauzas | so, PS_n-2 to PS should show the very few differences | |
| 15:56:39 | stephenfin | bauzas: Thanks. I'll start looking now but I will have to leave myself soon enough | |
| 15:56:56 | stephenfin | Worst case scenario, one of us can tweak it while you're away to get it over the line | |
| 15:56:56 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Exclude the 'use_db_reconnect' option https://review.opendev.org/c/openstack/nova/+/803778 | |
| 15:57:11 | stephenfin | gibi: ^ | |
| 15:57:50 | stephenfin | turns out I _could_ just modify what we were registering since I stopped registering the oslo.db opts in https://review.opendev.org/c/openstack/nova/+/799523/ | |
| 15:58:02 | bauzas | stephenfin: I was planning to end at 5pm | |
| 15:58:15 | bauzas | looks like I was on the wrong timezone when I said this | |
| 15:58:42 | stephenfin | bauzas: it's still only 9am in California ;) | |
| 15:59:03 | bauzas | perfect timing for starting my day again | |
| 15:59:21 | stephenfin | bauzas: Can you bang this ~50 line change in as the last thing before you leave? :D https://review.opendev.org/c/openstack/nova/+/799523/ | |
| 16:01:33 | bauzas | stephenfin: you eventually got my last approval before I leave, gibi you lose | |
| 16:01:42 | stephenfin | \o/ | |
| 16:01:44 | stephenfin | winner winner | |
| 16:01:53 | bauzas | this is like the olympics, money time | |
| 16:02:00 | stephenfin | enjoy your PTO o. | |
| 16:02:22 | bauzas | stephenfin: be sure I'll haunt you when I'm back even if you're not lurking this chan | |
| 16:02:51 | ade_lee | stephenfin, lyarwood hey -- I started to look at the failures in the fips ci job -- https://review.opendev.org/c/openstack/nova/+/790519 | |
| 16:03:49 | ade_lee | stephenfin, lyarwood looks like the bootfromvolume test is failing - and I think its because iscsid is not happy because its chap algorithm needs to be set to something other than md5 | |
| 16:04:05 | ade_lee | not sure how to do that in the test .. | |
| 16:05:24 | gibi | bauzas_away: enjoy, I will look at your mdev series still today | |
| 16:05:25 | stephenfin | ade_lee: The test that's failing is an integration test running on devstack VM, so you're going to need to modify some configuration via devstack or a plugin | |
| 16:05:55 | bauzas_away | gibi: thanks, appreciated | |
| 16:06:14 | bauzas_away | anyway, back on tuesday means 2 days of work before FF, that's totally doable to merge things | |
| 16:06:34 | ade_lee | stephenfin, lyarwood in barbican, we do special test stuff on devstack with a script at https://github.com/openstack/barbican/blob/master/devstack/lib/barbican for instance , but I don't see anything similar in nova | |
| 16:06:48 | gibi | bauzas_away: :D you are such an optimist :D | |
| 16:07:04 | ade_lee | though as this is something that will likely show up elsewhere - its prob best to look in devstack itself .. | |
| 16:07:08 | ade_lee | looking .. | |
| 16:08:54 | stephenfin | ade_lee: this isn't stuff I'm intimately familiar with, but we do some stuff as a post-run job. For example, you can see the stuff in roles/run-evacuate-hook which is run as part of the nova-live-migration job | |
| 16:09:26 | stephenfin | pre-run probably won't do though since that'll surely run before DevStack even gets started, though maybe that's okay... | |
| 16:10:13 | stephenfin | doing it in DevStack (hidden behind a config option) or via a DevStack plugin would certainly be easier I suspect | |
| 16:11:38 | ade_lee | stephenfin, yeah and more useful as this will undoubtedly show up in cinder fips tests amongst others | |
| 16:11:44 | stephenfin | yup | |
| 16:38:28 | gibi | I'm dropping off for a week of vacation | |
| 16:38:33 | gibi | back on 16th of Aug | |
| 16:39:06 | gibi_pto | o/ | |
| 16:39:24 | stephenfin | o/ | |
| 16:39:25 | opendevreview | Stephen Finucane proposed openstack/nova master: mypy: Follow-up for I4a9c1ee486beda070ee0a4a9734a7ec9e2629a67 https://review.opendev.org/c/openstack/nova/+/803787 | |
| 16:39:25 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170 | |
| 16:57:06 | opendevreview | Merged openstack/nova master: db: Move main DB migrations https://review.opendev.org/c/openstack/nova/+/799519 | |
| 17:31:44 | gmann | gibi_pto: have good vacation. | |
| 17:32:42 | gmann | stephenfin: reviewed this hostname series, I think we need to leave the legacy extensions prefix things for non-related APIs and do only for hostname field https://review.opendev.org/c/openstack/nova/+/778550 | |
| 17:33:02 | gmann | left comment in https://review.opendev.org/c/openstack/nova/+/803756/1 | |
| 18:34:01 | opendevreview | Ade Lee proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | |
| 20:39:30 | opendevreview | Merged openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | |
| #openstack-nova - 2021-08-07 | |||
| 10:37:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add functional reproducer for bug-1939193 https://review.opendev.org/c/openstack/nova/+/803821 | |
| 10:37:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle if placement in down during interface attach https://review.opendev.org/c/openstack/nova/+/803822 | |
| 15:05:23 | opendevreview | Merged openstack/nova master: Bump oslo.db to 10.0.0 https://review.opendev.org/c/openstack/nova/+/801610 | |
| 19:39:01 | opendevreview | Merged openstack/nova master: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/801285 | |
| 19:39:08 | opendevreview | Merged openstack/nova master: I2f9ad3df25306e070c8c3538bfed1212d6d8682f fup: add log https://review.opendev.org/c/openstack/nova/+/803001 | |
| #openstack-nova - 2021-08-08 | |||
| 13:55:27 | opendevreview | Merged openstack/nova master: db: Move 'sqlalchemy.types' up a directory https://review.opendev.org/c/openstack/nova/+/799520 | |
| 13:55:36 | opendevreview | Merged openstack/nova master: db: Remove constant aliases from 'nova.db.api' https://review.opendev.org/c/openstack/nova/+/799521 | |
| 13:56:41 | opendevreview | Merged openstack/nova master: db: Drop support for experimental concurrency https://review.opendev.org/c/openstack/nova/+/799522 | |
| #openstack-nova - 2021-08-09 | |||
| 09:07:07 | stephenfin | lyarwood: Any chance you could cast an eye over a little more of the DB series this week, in the absence of gibi and bauzas? It starts on this patch which _looks_ huge but was mostly an invocation of sed :) https://review.opendev.org/c/openstack/nova/+/799524/ | |
| 09:07:58 | lyarwood | yarp, was up most the night but II'll make a start once this coffee kicks in | |
| 09:08:03 | lyarwood | I'll* | |
| 09:38:38 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Amend configurable-instance-hostnames for more response changes https://review.opendev.org/c/openstack/nova-specs/+/803892 | |
| 09:49:10 | kashyap | stephenfin: Hey, when you get a min, maybe you can settle this dispute here: https://review.opendev.org/c/openstack/nova/+/798680/3/nova/virt/libvirt/config.py#2058 | |
| 09:51:15 | stephenfin | kashyap: I think you're correct. Those classes are used to build XML for new instances. I don't think we use it to parse anything for existing instances. | |
| 09:51:51 | kashyap | stephenfin: Exactly so; thank you very much. I was wondering if I was confusing myself | |
| 09:52:32 | stephenfin | unrelated: have we agreed on virtio? Doesn't that have impacts for Windows guests? | |
| 09:53:27 | kashyap | stephenfin: Right; I've discussed this at length w/ the QEMU graphics maint, and 'virtio' seems good for both | |
| 09:53:30 | kashyap | stephenfin: What more: | |
| 09:53:46 | kashyap | stephenfin: I got a Red Hat virt QE to test both Windows and Linux guests with 'cirrus' and do some live migration tests | |
| 09:54:15 | kashyap | (with 'cirrus', changed to 'virtio', i.e.) And the tests succeed. See my comment on PS 3 (Aug 04 4:27 PM) | |
| 09:54:21 | stephenfin | kashyap: What are your thoughts on whipping up a doc with the current and future default device models, the reasons for these choices, and the commands one can use to migrate existing instances from one to the other | |
| 09:54:45 | stephenfin | in lieu of a spec or anything else | |
| 09:55:15 | kashyap | stephenfin: "Device models" --> You're talking only of video, or others too? | |