| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-23 | |||
| 18:14:00 | sean-k-mooney | the policy rule is | |
| 18:14:23 | sean-k-mooney | but here we are changing the behavior of the RuleDefault class | |
| 18:14:53 | sean-k-mooney | the fact a project policy rule is deprecated does not mean the RuleDefault class usage is deprecated | |
| 18:15:18 | sean-k-mooney | https://review.opendev.org/c/openstack/oslo.policy/+/801929 is a new oslo.polify feature | |
| 18:15:26 | sean-k-mooney | which is a breaking change | |
| 18:15:59 | sean-k-mooney | so this need a oslo.policy major viersion bump since its not a additive change | |
| 18:16:09 | gmann | yes, major version bump | |
| 18:16:24 | sean-k-mooney | you can make it an addtivie chagne rather simply though | |
| 18:16:40 | sean-k-mooney | add a new parmater to the contructor of RuleDefault | |
| 18:16:59 | gmann | we did that in past via warning, not I am proposing to do a breaking change and remove the old ay | |
| 18:17:06 | gmann | *now I | |
| 18:17:21 | sean-k-mooney | right i am saying that is not a valid stragy | |
| 18:17:37 | gmann | humm, so keep supporting old way always? | |
| 18:17:44 | gmann | and keep warnings also? | |
| 18:18:02 | sean-k-mooney | no you need to wait until all or most of your users have adapted to the new api | |
| 18:18:07 | gmann | we introduced warning becasue we want usage to mvoe to new way right | |
| 18:18:22 | sean-k-mooney | when was the warnign intoduced | |
| 18:18:24 | gmann | sean-k-mooney: I did https://review.opendev.org/q/topic:%22fix-oslo-policy-warnings%22+(status:open%20OR%20status:merged) | |
| 18:18:43 | gmann | http://lists.openstack.org/pipermail/openstack-discuss/2021-July/023646.html | |
| 18:18:46 | sean-k-mooney | basically i dont think you shoudl do this type of change late in the cycle | |
| 18:18:48 | gmann | ^^ has all the details | |
| 18:19:11 | gmann | we cannot do in this cycle, we have to wait for next cycle due to dependencies | |
| 18:19:16 | sean-k-mooney | i guess the issue is just the unit tests | |
| 18:19:24 | sean-k-mooney | can you show me where in nova we are importign placment | |
| 18:19:35 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 18:19:39 | gmann | https://github.com/openstack/nova/blob/master/nova/tests/functional/fixtures.py#L17 | |
| 18:19:48 | gmann | sean-k-mooney: ^^ | |
| 18:19:55 | sean-k-mooney | placement is not in our test requirements | |
| 18:20:01 | sean-k-mooney | im trying to figure out where it is listed | |
| 18:20:32 | sean-k-mooney | here https://github.com/openstack/nova/blob/master/tox.ini#L97 | |
| 18:21:17 | gmann | yes | |
| 18:21:44 | sean-k-mooney | we should not be importing the fixtuer the way we currently are | |
| 18:22:34 | sean-k-mooney | ... ok | |
| 18:22:44 | sean-k-mooney | that explians it we still have not create placment-lib | |
| 18:23:19 | sean-k-mooney | gmann: we were ment to move the fixture and other common code in a placement-lib repo cycle or two ago | |
| 18:23:23 | sean-k-mooney | looks like that never happened | |
| 18:23:45 | gmann | yeah | |
| 18:24:01 | sean-k-mooney | it was to aovid a direct import of placment so we could release the lib ahead of the main release and avoid this | |
| 18:25:29 | sean-k-mooney | this is kind of tricky | |
| 18:26:03 | sean-k-mooney | the best way to adress this would be to pin the oslo.plolicy version in nova func test until after placment is released | |
| 18:27:38 | sean-k-mooney | which i think we could do with oslo.policy<=${last version without error} here https://github.com/openstack/nova/blob/master/tox.ini#L96 | |
| 18:28:18 | gmann | we should not actually, and keep testing with latest oslo otherwise we can get more surprise. | |
| 18:28:47 | gmann | either moving placement fixture to lib side or do like current way 'wait for 1 cycle in oslo side' | |
| 18:28:54 | sean-k-mooney | well the other way is to deploy placment form master | |
| 18:28:59 | sean-k-mooney | on master | |
| 18:29:05 | gmann | yeah that too work | |
| 18:29:55 | sean-k-mooney | we coudl replace openstack-placement>=1.0.0 with -e git+https://opendev.org/openstack/placement.git@master#egg=placement | |
| 18:31:37 | sean-k-mooney | ok lets pick this up next weeks and see if thre is a way forward | |
| 18:35:21 | gmann | actually we should keep testing with released placement and if we want we can do with master version also so that we test both way. | |
| 18:36:35 | gmann | for oslo, I feel (from other usage also with pypi released version) is to wait for next cycle. This cycle I fixed almost all the usage in once they are released with oslo version supporting both way then 2, in next cycle remvoe old style in oslo | |
| 18:36:57 | gmann | that is best way to introduced the breaking change or major version bumo | |
| 18:36:59 | gmann | bump | |
| 18:37:22 | gmann | doing both in one cycle can break or mixup the things | |
| 19:17:48 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 19:59:49 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 20:12:22 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 20:22:37 | opendevreview | Merged openstack/placement master: Add support for RP re-parenting and orphaning https://review.opendev.org/c/openstack/placement/+/784020 | |
| 20:35:36 | opendevreview | melanie witt proposed openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170 | |
| 20:35:43 | opendevreview | melanie witt proposed openstack/placement master: Microversion 1.38: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | |
| 20:35:47 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 20:36:18 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 20:52:33 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 21:11:12 | opendevreview | Samuel proposed openstack/nova master: Add REST and compute APIs to migrate instances between projects https://review.opendev.org/c/openstack/nova/+/801377 | |
| 21:53:05 | opendevreview | melanie witt proposed openstack/nova master: DNM testing https://review.opendev.org/c/openstack/nova/+/802133 | |
| 21:57:18 | opendevreview | melanie witt proposed openstack/nova master: DNM testing https://review.opendev.org/c/openstack/nova/+/802133 | |
| 23:02:19 | opendevreview | melanie witt proposed openstack/nova master: DNM testing https://review.opendev.org/c/openstack/nova/+/802133 | |
| #openstack-nova - 2021-07-24 | |||
| 08:04:08 | gibi | gmann: fyi, I will be off next week. I'm just skimmed the discussion about the placement - oslo.policy change. | |
| 08:05:59 | gibi | gmann: I'm OK to change nova to test with master placement in funct test | |
| 08:07:18 | gibi | the placement-lib idea is pretty old and given the lack of developers on placement side I would not try to do such big change | |
| 08:08:33 | gibi | if we switch from pypi to placement master in nova func test, does that solve your dependency issue towards oslo.policy in Xena? | |
| #openstack-nova - 2021-07-25 | |||
| 00:32:12 | opendevreview | melanie witt proposed openstack/nova master: DNM testing https://review.opendev.org/c/openstack/nova/+/802133 | |
| 04:11:00 | opendevreview | Merged openstack/nova master: objects: Fix VIFMigrateData.supports_os_vif_delegation setter https://review.opendev.org/c/openstack/nova/+/797142 | |
| 10:40:22 | opendevreview | Merged openstack/nova master: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/798145 | |
| #openstack-nova - 2021-07-26 | |||
| 01:48:34 | opendevreview | chengsheng proposed openstack/nova master: libvirt: Use improved guest CPU config APIs https://review.opendev.org/c/openstack/nova/+/762330 | |
| 02:44:52 | opendevreview | Qiu Fossen proposed openstack/nova master: Allow migrating PMEM's data https://review.opendev.org/c/openstack/nova/+/802225 | |
| 06:43:42 | opendevreview | Felix Huettner proposed openstack/nova master: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/801990 | |
| 08:28:22 | opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/802236 | |
| 08:32:01 | opendevreview | Stephen Finucane proposed openstack/nova stable/victoria: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/802237 | |
| 08:35:05 | opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: Fix error that cannot overwrite policy rule for 'forced_host' https://review.opendev.org/c/openstack/nova/+/802238 | |
| 08:35:06 | opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/802239 | |
| 08:37:19 | opendevreview | Stephen Finucane proposed openstack/nova stable/train: Fix error that cannot overwrite policy rule for 'forced_host' https://review.opendev.org/c/openstack/nova/+/802240 | |
| 08:37:20 | opendevreview | Stephen Finucane proposed openstack/nova stable/train: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/802241 | |
| 08:52:01 | lyarwood | https://zuul.opendev.org/t/openstack/builds?project=openstack%2Fnova&branch=master&pipeline=gate&result=failure - me takes a look at these failures | |
| 09:12:37 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | |
| 09:17:26 | lyarwood | bauzas: would you mind hitting this series to land the changes to the cherry-pick script on stable? https://review.opendev.org/q/Id3e4452883f6a3cf44ff58b39ded82e882e28c23 | |
| 09:23:49 | bauzas | lyarwood: I can take a look | |
| 09:23:55 | lyarwood | many thanks | |
| 10:56:31 | sean-k-mooney | the pdf docs jobs might be broken https://zuul.opendev.org/t/openstack/build/e58c187bc90f43c8a2bb189a54c6175d/log/sphinx-build-pdf.log | |
| 10:57:12 | sean-k-mooney | LaTeX Error: File `tgtermes.sty' not found. | |
| 10:59:07 | sean-k-mooney | we might need texlive-latex-extra | |
| 11:28:58 | sean-k-mooney | ok the missing file is in tex-gyre | |
| 11:38:30 | sean-k-mooney | i think https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/802296 will fix the docs jobs | |
| 14:41:47 | opendevreview | Lee Yarwood proposed openstack/nova master: WIP compute: Do not mark disabled but down services as in maintenance https://review.opendev.org/c/openstack/nova/+/802317 | |
| 14:47:07 | kashyap | stephenfin: Am I right in recalling that to deprecate disk-bus for floopy devices also require data migrations to remove DB entries using the old values, yeah? | |
| 14:48:04 | stephenfin | I don't think so. I think you'll need operators to do that manually via a nova-manage command (which lyarwood is working on) | |
| 14:48:17 | stephenfin | Not sure what we'll do about updating BDMs though | |
| 14:49:26 | kashyap | Hmm, this feels invasive to do the deprecation for these - I see that no one has done such a thing so far | |
| 14:50:10 | kashyap | I feel tempted to just nuking it is far more effective than all these subtle deprecations and in turn testing, etc. The very few floppy users, if they're there at all, will have to adjust a little | |
| 14:50:33 | kashyap | From the data I've seen from OSP deployments, not a single floppy in guest XMLs I see. | |
| 15:09:48 | melwitt | lyarwood: could you look at https://review.opendev.org/c/openstack/nova/+/791805 (and its backports eventually) if you get a chance? these backports have to merge before a security advisory can be issued | |