| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-22 | |||
| 11:45:22 | stephenfin | oh, wait, yeah | |
| 11:45:28 | stephenfin | hmm, probably not actually | |
| 11:45:33 | gibi | stephenfin: re sphinx: OK, then I stop fighting with sphinx :) | |
| 11:46:13 | stephenfin | sean-k-mooney: actually no, it's still there https://opendev.org/x/vmware-nsx/src/branch/master/vmware_nsx/extensions/vnicindex.py | |
| 11:46:30 | stephenfin | whether it actually works is a different thing of course | |
| 11:47:56 | gibi | stephenfin: I'm +2 on the QoS extension removal | |
| 11:48:06 | stephenfin | hurrah | |
| 11:48:13 | stephenfin | thanks gibi++ | |
| 11:48:57 | gibi | stephenfin: I'm fixing your comments in the pps series I hope I can push it today | |
| 11:49:19 | gibi | moving around the func test was a nice exercise :) | |
| 11:50:19 | stephenfin | yeah, it felt like the right thing to do | |
| 11:51:05 | gibi | yepp, it is much better now. and pycharm is glad not to reparse the whole test_servers.py when I edit something in the func tests | |
| 11:51:29 | stephenfin | fair to say that 5kloc+ files are a thing best avoided where possible. 5kloc+ *test* files are 100% worth avoiding :) | |
| 11:51:32 | stephenfin | \o/ | |
| 11:52:32 | gibi | I hope not just me but jetbrains using the nova codebase to performance test pycharm :D | |
| 11:53:05 | stephenfin | there a few projects that could benefit from using nova as a test bed | |
| 11:53:17 | gibi | :D | |
| 11:53:35 | stephenfin | gitea for one | |
| 11:54:06 | gibi | we should promote that as a goal of nova :D being big and complicated python codebase for "you" to test your python tooling on | |
| 11:54:09 | stephenfin | don't know if you clicked through the links on the nsx-mh removal patch but it basically crashed my browser | |
| 11:54:34 | stephenfin | GitHub (smartly) refuses to render large files by default | |
| 11:54:36 | stephenfin | lol | |
| 11:55:06 | gibi | mine is not crashed (yet) | |
| 12:12:43 | opendevreview | Stephen Finucane proposed openstack/nova master: tox: Encode specific Python versions https://review.opendev.org/c/openstack/nova/+/797054 | |
| 12:39:54 | sean-k-mooney | anyone ohter then stephenfin have time to reivew an os-vif patch https://review.opendev.org/c/openstack/os-vif/+/798055 | |
| 12:54:19 | gibi | sean-k-mooney: done | |
| 12:56:01 | gibi | incoming... | |
| 12:56:15 | sean-k-mooney | thanks im finsihing up some testing downstream this week ill be working on some other os-vif patches next week and ill start with a followup for the nits | |
| 12:56:36 | sean-k-mooney | pps series? | |
| 12:56:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | |
| 12:56:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | |
| 12:56:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | |
| 12:56:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | |
| 12:56:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port resource request tests https://review.opendev.org/c/openstack/nova/+/801815 | |
| 12:58:20 | gibi | sean-k-mooney: yepp, pps :D | |
| 13:00:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | |
| 13:00:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | |
| 13:04:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | |
| 13:05:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | |
| 13:05:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | |
| 13:05:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | |
| 13:09:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor asserts in qos tests https://review.opendev.org/c/openstack/nova/+/798930 | |
| 13:10:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | |
| 13:12:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port data https://review.opendev.org/c/openstack/nova/+/800085 | |
| 13:13:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 13:14:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | |
| 13:16:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | |
| 13:17:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 13:18:10 | bauzas | stephenfin: awesome ! thanks for the FUP <3 | |
| 13:18:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 13:22:58 | gibi | and I f*ck up the rebase at some point and lost a patch in the series :/ | |
| 13:26:34 | sean-k-mooney | hopefully you have it localy | |
| 13:27:49 | gibi | git reflog has it | |
| 13:28:15 | gibi | I basically merged two subseqent commit together | |
| 13:28:20 | gibi | in the series | |
| 13:28:23 | gibi | during the rebase | |
| 13:38:31 | gibi | I hate that git does not warn against commit --amend when during interactive rebase it stops at the commit both because it marked as edit and becuase it has a merge conflict | |
| 13:39:02 | belmoreira | Hello everyone... I have a question regarding DBs... but also related with nova :) | |
| 13:39:07 | sean-k-mooney | well thats becasue you can do commit --amend for valid reasons | |
| 13:39:15 | sean-k-mooney | with an interactive rebase | |
| 13:39:20 | sean-k-mooney | but yes i have done that too | |
| 13:39:30 | gibi | sean-k-mooney: yeah, but not during a conflict resolution I guess | |
| 13:39:32 | sean-k-mooney | belmoreira: nova does have them | |
| 13:39:59 | sean-k-mooney | gibi: i have used it where i was not finsihed with the full resolution | |
| 13:40:07 | belmoreira | sean-k-mooney :) | |
| 13:40:09 | sean-k-mooney | then came back | |
| 13:40:16 | belmoreira | We will need to move some nova DBs from mysql 5.7.x to 8.x. Our DB team was testing this DB migration and a character convertion is required (utf8mb3 -> utf8mb4) | |
| 13:40:46 | belmoreira | Apparently utf8 in mysql 8.x uses 4 bytes instead of 3 bytes (like previously) | |
| 13:40:55 | sean-k-mooney | belmoreira: nova currently does not supeciric any charicterset or coalation type in our schema | |
| 13:41:23 | sean-k-mooney | belmoreira: utf8 in gereal uses between 1 an 4 bytes depending on the charater | |
| 13:41:51 | belmoreira | sean-k-mooney right | |
| 13:42:17 | belmoreira | my concern is that they reported that (silent) changes of data types can happen, for example from TEXT to MEDIUMTEXT to allow the column to accommodate the original data using 4bytes for each character instead of 3. For similar reasons we could also potentially hit the innodb index key max size... | |
| 13:43:06 | belmoreira | Is there something that you are aware? Or this should be safe for Nova | |
| 13:44:01 | sean-k-mooney | i think nova largely should not care but im not sure. | |
| 13:44:19 | sean-k-mooney | nova likely should jsut use utf_8_bin | |
| 13:44:24 | sean-k-mooney | at some point | |
| 13:45:00 | sean-k-mooney | https://en.wikipedia.org/wiki/UTF-8#MySQL_utf8mb3 | |
| 13:46:55 | belmoreira | thanks sean-k-mooney | |
| 13:47:59 | sean-k-mooney | we do use mediumetext in somplaces | |
| 13:48:40 | sean-k-mooney | in general nova does not allow you to change the column data types form what we have in the schema | |
| 13:48:53 | sean-k-mooney | btu the encoding i dont think will break anything | |
| 13:49:09 | sean-k-mooney | belmoreira: are they plannign to actully modify the types in the tables | |
| 13:50:13 | sean-k-mooney | we generally are allowing sqlalchmy to mange the filed types | |
| 13:50:24 | belmoreira | I'm afraid to just discover some of these changes in prod. Anyway I will try to test it as much as possible and I will let you know if I discover something | |
| 13:51:01 | belmoreira | sean-k-mooney no they will not explicitly change the schema but they say it can happen when moving to utf8mb4 | |
| 13:51:34 | sean-k-mooney | well text files unlike nvarcars are not actully stored in the db correct | |
| 13:51:39 | belmoreira | I'm learning about all of this utf8 encoding :) | |
| 13:51:40 | sean-k-mooney | they are stored as sepereate files | |
| 13:51:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | |
| 13:51:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 13:52:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | |
| 13:52:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | |
| 13:52:29 | sean-k-mooney | we use string https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L256 when we wnat fixed lenght nvarchar columns | |
| 13:53:21 | belmoreira | I think the best is to do the conversion of a test DB and I will go manually through the schema. Maybe at the end there is nothing about this | |
| 13:54:16 | sean-k-mooney | ya | |
| 13:55:45 | sean-k-mooney | but ya just confirm that text filds are stored off table https://www.navicat.com/en/company/aboutus/blog/1308-choosing-between-varchar-and-text-in-mysql | |
| 13:55:55 | sean-k-mooney | belmoreira: where the issue might happen | |
| 13:56:02 | sean-k-mooney | would be for user-data | |
| 13:56:22 | sean-k-mooney | text field cans sture up to 64k fo data | |
| 13:57:00 | belmoreira | sean-k-mooney thanks a lot. I will let you know if something comes up | |