| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-22 | |||
| 01:34:42 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 01:40:41 | melwitt | gibi: finally I have an update for consumer types https://review.opendev.org/c/openstack/placement/+/679441 sorry for the long delay | |
| 07:15:34 | opendevreview | Merged openstack/nova-specs master: Move placement specs to placement repo https://review.opendev.org/c/openstack/nova-specs/+/800775 | |
| 07:20:21 | gibi | melwitt: OK, I've added it to my queue | |
| 07:21:59 | gibi | melwitt: I have the RP re-parenting patch ready too https://review.opendev.org/c/openstack/placement/+/784020 | |
| 07:22:05 | gibi | if you have time | |
| 08:10:57 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | |
| 09:12:57 | stephenfin | lyarwood: Could you review a few outstanding docs changes for me today? https://review.opendev.org/c/openstack/nova/+/782410/1 | |
| 09:13:12 | lyarwood | stephenfin: sure thing | |
| 09:13:29 | stephenfin | Thanks. I addressed your comments in that one specifically too, gibi ^ | |
| 09:13:48 | gibi | stephenfin: ack | |
| 09:19:38 | stephenfin | bauzas: In case you didn't see it, I addressed your issues on https://review.opendev.org/c/openstack/nova/+/798145 with a follow-up https://review.opendev.org/c/openstack/nova/+/801523 | |
| 09:19:50 | bauzas | stephenfin: ok, will look | |
| 09:19:54 | bauzas | and thanks | |
| 09:25:40 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 09:26:04 | lyarwood | https://github.com/openstack/nova/blob/3545356ae3a719442833cb8c3c911408d4bd3c15/nova/conductor/manager.py#L166-L184 - This is likely a stupid idea but why aren't we logging anything here as breadcrumbs for RPC timeouts etc? | |
| 09:26:26 | lyarwood | Have an example downstream of a bdm.save() timing out on the compute and I've got no way of seeing what n-cond was doing AFAICT | |
| 09:28:17 | lyarwood | I guess any breadcrumbs need to land in the actual object methods being exercised | |
| 09:29:34 | sean-k-mooney | ya i dont know really | |
| 09:29:45 | sean-k-mooney | i guess one question would be where | |
| 09:30:03 | sean-k-mooney | as in in what log would they end up | |
| 09:30:16 | sean-k-mooney | the api/conductor wont know where it actuly got too | |
| 09:30:59 | lyarwood | it should end up in n-cond right? | |
| 09:31:47 | lyarwood | almost need a TRACE log level below DEBUG for stuff like this | |
| 09:34:37 | gibi | stephenfin: what should I do to enable ':oslo.config:option:' directive in the api-guide doc build? I've added 'oslo_config.sphinxext' extension to the config but it fails with https://paste.opendev.org/show/807644/ | |
| 09:40:43 | lyarwood | nvm another n-cond log is full of `Too many heartbeats missed` errors from oslo.msg | |
| 10:10:51 | lyarwood | really wish gerrit had a `move the unified diff to the middle of your giant ass screen` option | |
| 10:12:50 | stephenfin | gibi: You'd need to render the config options somewhere like we do here https://raw.githubusercontent.com/openstack/nova/master/doc/source/configuration/config.rst | |
| 10:13:02 | stephenfin | (the '.. show-options::' directive) | |
| 10:13:36 | stephenfin | which we probably don't want to do. We could build something that relies on intersphinx to link back to the main docs but that doesn't exist yet | |
| 10:43:33 | opendevreview | Stephen Finucane proposed openstack/nova master: neutron: Remove references to dead 'qos-queue' extension https://review.opendev.org/c/openstack/nova/+/754448 | |
| 10:44:43 | stephenfin | gibi: turns out that extension was used by the VMWare NSX neutron plugin, but they dropped it about two years ago. Have updated the commit message to state as much ^ | |
| 11:35:35 | sean-k-mooney | stephenfin: nice find | |
| 11:36:39 | sean-k-mooney | stephenfin: im kind of surpised we have any third party exstions reference in nova | |
| 11:37:06 | sean-k-mooney | at least on the common code. i would have expect those constance to live in teh vmware dirver | |
| 11:37:43 | sean-k-mooney | do we know if vnic-index is used still | |
| 11:44:37 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Final cleanups https://review.opendev.org/c/openstack/nova/+/800484 | |
| 11:45:03 | stephenfin | sean-k-mooney: vnic-index? | |
| 11:45:22 | stephenfin | oh, wait, yeah | |
| 11:45:28 | stephenfin | hmm, probably not actually | |
| 11:45:33 | gibi | stephenfin: re sphinx: OK, then I stop fighting with sphinx :) | |
| 11:46:13 | stephenfin | sean-k-mooney: actually no, it's still there https://opendev.org/x/vmware-nsx/src/branch/master/vmware_nsx/extensions/vnicindex.py | |
| 11:46:30 | stephenfin | whether it actually works is a different thing of course | |
| 11:47:56 | gibi | stephenfin: I'm +2 on the QoS extension removal | |
| 11:48:06 | stephenfin | hurrah | |
| 11:48:13 | stephenfin | thanks gibi++ | |
| 11:48:57 | gibi | stephenfin: I'm fixing your comments in the pps series I hope I can push it today | |
| 11:49:19 | gibi | moving around the func test was a nice exercise :) | |
| 11:50:19 | stephenfin | yeah, it felt like the right thing to do | |
| 11:51:05 | gibi | yepp, it is much better now. and pycharm is glad not to reparse the whole test_servers.py when I edit something in the func tests | |
| 11:51:29 | stephenfin | fair to say that 5kloc+ files are a thing best avoided where possible. 5kloc+ *test* files are 100% worth avoiding :) | |
| 11:51:32 | stephenfin | \o/ | |
| 11:52:32 | gibi | I hope not just me but jetbrains using the nova codebase to performance test pycharm :D | |
| 11:53:05 | stephenfin | there a few projects that could benefit from using nova as a test bed | |
| 11:53:17 | gibi | :D | |
| 11:53:35 | stephenfin | gitea for one | |
| 11:54:06 | gibi | we should promote that as a goal of nova :D being big and complicated python codebase for "you" to test your python tooling on | |
| 11:54:09 | stephenfin | don't know if you clicked through the links on the nsx-mh removal patch but it basically crashed my browser | |
| 11:54:34 | stephenfin | GitHub (smartly) refuses to render large files by default | |
| 11:54:36 | stephenfin | lol | |
| 11:55:06 | gibi | mine is not crashed (yet) | |
| 12:12:43 | opendevreview | Stephen Finucane proposed openstack/nova master: tox: Encode specific Python versions https://review.opendev.org/c/openstack/nova/+/797054 | |
| 12:39:54 | sean-k-mooney | anyone ohter then stephenfin have time to reivew an os-vif patch https://review.opendev.org/c/openstack/os-vif/+/798055 | |
| 12:54:19 | gibi | sean-k-mooney: done | |
| 12:56:01 | gibi | incoming... | |
| 12:56:15 | sean-k-mooney | thanks im finsihing up some testing downstream this week ill be working on some other os-vif patches next week and ill start with a followup for the nits | |
| 12:56:36 | sean-k-mooney | pps series? | |
| 12:56:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | |
| 12:56:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | |
| 12:56:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | |
| 12:56:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | |
| 12:56:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port resource request tests https://review.opendev.org/c/openstack/nova/+/801815 | |
| 12:58:20 | gibi | sean-k-mooney: yepp, pps :D | |
| 13:00:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | |
| 13:00:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | |
| 13:04:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | |
| 13:05:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | |
| 13:05:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | |
| 13:05:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | |
| 13:09:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor asserts in qos tests https://review.opendev.org/c/openstack/nova/+/798930 | |
| 13:10:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | |
| 13:12:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port data https://review.opendev.org/c/openstack/nova/+/800085 | |
| 13:13:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 13:14:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | |
| 13:16:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | |
| 13:17:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 13:18:10 | bauzas | stephenfin: awesome ! thanks for the FUP <3 | |
| 13:18:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 13:22:58 | gibi | and I f*ck up the rebase at some point and lost a patch in the series :/ | |
| 13:26:34 | sean-k-mooney | hopefully you have it localy | |
| 13:27:49 | gibi | git reflog has it | |
| 13:28:15 | gibi | I basically merged two subseqent commit together | |
| 13:28:20 | gibi | in the series | |
| 13:28:23 | gibi | during the rebase | |
| 13:38:31 | gibi | I hate that git does not warn against commit --amend when during interactive rebase it stops at the commit both because it marked as edit and becuase it has a merge conflict | |
| 13:39:02 | belmoreira | Hello everyone... I have a question regarding DBs... but also related with nova :) | |
| 13:39:07 | sean-k-mooney | well thats becasue you can do commit --amend for valid reasons | |
| 13:39:15 | sean-k-mooney | with an interactive rebase | |
| 13:39:20 | sean-k-mooney | but yes i have done that too | |
| 13:39:30 | gibi | sean-k-mooney: yeah, but not during a conflict resolution I guess | |